From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49990C072A2 for ; Fri, 17 Nov 2023 13:42:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0EBA280018; Fri, 17 Nov 2023 08:42:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C977A280008; Fri, 17 Nov 2023 08:42:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B120F280018; Fri, 17 Nov 2023 08:42:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9B8EB280008 for ; Fri, 17 Nov 2023 08:42:33 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70C45140619 for ; Fri, 17 Nov 2023 13:42:33 +0000 (UTC) X-FDA: 81467560986.06.F8301C9 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf11.hostedemail.com (Postfix) with ESMTP id 227394001A for ; Fri, 17 Nov 2023 13:42:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=AjzGQnSi; spf=pass (imf11.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700228550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SiGMv/vnZ4v12NU81A3GF+oSLQQzlvJbOlPSS0J1KlE=; b=KsrMoE+IGbvw7/zhG5vh5ShGLyY2rWBF0S2+ket/J0DkZ6+rqO/MmrsXHdcL0BqeTu1Twj d/6qKG47ML7M1Z3C7K65EG0lPRvCfAqunaPlGOCQiU6euAbTjRrQ7bSgK54NwJdMPBCPLM LlHv8+qzQjY2LTbgB+jKUdLf3529WvM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=AjzGQnSi; spf=pass (imf11.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700228550; a=rsa-sha256; cv=none; b=ZaqoxQzS1LxxMuApspEqOYE47Q+/+VFMknnXyU/lrr+Ygv3sTMHz7b26F92Zrb2WFvAvRs s2LOwF0sSjqeF7pHfwM6gUcL96kI0v5+a4orVwCMdpB9oWutSRz9zcbUoo9aKyEs8RrOqo hjAV+UOloKvg5hF/RtkdGCVh3ZXQauE= Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AHDRKgO027838; Fri, 17 Nov 2023 13:42:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=SiGMv/vnZ4v12NU81A3GF+oSLQQzlvJbOlPSS0J1KlE=; b=AjzGQnSiUAFwXEKZExGJLqX7sdTCuv19TaI3NbRJs+zBPsmNvWCj8sLECVnVfW0j16qt 8aQvUAUk35USTWcCh/Ql+5GqqzNTR6ecapx54ZUj/IaVw5iq7ngmzGLrTIdcVoAjLrFl bOK4WQGseEQLaLk+yOFBHNoHVhaEMBI696/bgQrBWnz/dbA4tNQ7Qj8OAiz4fRH6kZ7B xCmq3UeOrWFi4iY1fwbKW7tO6+6VSneVwyF41v2q2qjegBrg0G3FxVf9yzvjlhSCHnJB cUti6iiM+BbyAPEeIWgTvaTDh6MdTjhEjak7Evfyas6dvfC+z7CEZAok57HuYKk/zNbe DA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ue92qgjhs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:42:26 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AHDRftW028593; Fri, 17 Nov 2023 13:42:25 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ue92qgjgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:42:25 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AHD3wsa018347; Fri, 17 Nov 2023 13:42:24 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uamayxesd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:42:24 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AHDgLwf61604120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Nov 2023 13:42:21 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 446F62004E; Fri, 17 Nov 2023 13:42:21 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70F5F2004B; Fri, 17 Nov 2023 13:42:20 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.27.169]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 17 Nov 2023 13:42:20 +0000 (GMT) Date: Fri, 17 Nov 2023 14:42:18 +0100 From: Sumanth Korikkar To: David Hildenbrand Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: Re: [PATCH 1/8] mm/memory_hotplug: fix memory hotplug locking order Message-ID: References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-2-sumanthk@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dyw7Xo6KqsR6c8oDGkKQ_1p0Sp4qmHkP X-Proofpoint-ORIG-GUID: 2gXwp31rvRshSCG8Q2JJYzbXbTqd8ycy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-17_12,2023-11-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=33 priorityscore=1501 bulkscore=0 impostorscore=0 mlxscore=33 phishscore=0 mlxlogscore=31 clxscore=1015 spamscore=33 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311170102 X-Rspamd-Queue-Id: 227394001A X-Rspam-User: X-Stat-Signature: 3aa6syqxxzmpnk8n6xr7r5hrgcssdc1g X-Rspamd-Server: rspam01 X-HE-Tag: 1700228549-817364 X-HE-Meta: U2FsdGVkX1/h7znsTjWMPDaohhaOJBQ5OTTOjsvShQvYkEIGNiQhCOS4/Gwp9PEIzvkHtCvA/UexBNhKFKkonBLuqg+8OqWypTMHA31Ajd/6YPQFp+JJxrtNOBhmO5Gpu9jimoPbRCe+humJLCRZyS174Ogl5zZb/ohafFNDjUCunWh88kwCo/Ih/KKOK29sBieZM9El3Ea/pKjPJXLeWPLhzUM/3QtVolsmA/GYUmf9HsGcCXewMXoTimo8jyxUoOneRr1byoljYrOq+TzyTm6YzP/+DIYlSERh/Ie8vCBBzJP0zHEVApp6CFtFC2j1opsw1JCxOf8vAWwEEySnIb5rahWc10HmhuFSD8zmD7r/p6h56b+SdIMNlbO3F1F+4jGaIXpIxUiOdA2IW7LK+G87ecwOiJpo1W3hTcGVlsJ0+bduFnPri3zh8dsUYpoOXH+hxpFBWt1Ur3BMiMsYmYlhLTPjdZoS0v/8T2Y5HEcTaIsWdSgPOXSbafB+oKFmm1XGCYbNPBVlNb5nma7Wu5pRowP2+1OfEYqYe4DFXKFSUU0gJo69LihuhHEM3xaa3dPPrmnbmigOmCb5Klq/1C7duhNFFMlUCHn1Jssl4+STQ9Ruu9F+TODdeyTaqn+FeBurTa922WK3p/mnHEb/bPSSfhH15L/YWcNIpWERwPyR+yVBs+f0O65OP8Dg91o5koTvmWVw4RKMVH6XNYsUTebveDuG4oFAAYNzP57oNhaaQywu2WxTRm+IGoKA+bXZ1MCVO7qB77gKVCkhOe0I1iaELMyGoGHRGNsi16eFu/biJ/7BNX6HJ69Nbfmnx8YWvoNkHwW38xzPaPEsYEIZqHjg9jZ4sQvnRr8rjLMyLlJl5RlsaMKrjePelR9HEkmOlBQ58J3LILg9YPp7ZXrR5LhgT5GKnB8HVDbaHEtlzs1jl0fPydHgtD5n2aS7rwfAXm+8wl/FMFn/gXOrOSN AcPytMSr rvxHXmqQ9S3nc8TCI83Rbofra5WAwdj+6wSAZcFs+xhE9VtwyaF/5FGzi1VKIPU58heabTDR96l9Uc+9QTyr+ydyvUuj8lR1ZWlZgQ5HMWWe7/IKAhcy0arHZqSAYJYm2uDHUsApzy7kj+fmwUBP4h/zphSc/Yp/5JFK0LzXwvcZaoru7UR4l/S+wSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 07:40:34PM +0100, David Hildenbrand wrote: > Good point; can you similarly add comments to these two functions that they > need that lock in write mode? Ok, will add it. Thanks