From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1D0C197A0 for ; Thu, 16 Nov 2023 20:04:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81AF16B0497; Thu, 16 Nov 2023 15:04:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CB716B0499; Thu, 16 Nov 2023 15:04:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66C3A6B049A; Thu, 16 Nov 2023 15:04:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 55BDC6B0497 for ; Thu, 16 Nov 2023 15:04:14 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 297F4B6018 for ; Thu, 16 Nov 2023 20:04:14 +0000 (UTC) X-FDA: 81464894028.04.10DB87D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 085FF180018 for ; Thu, 16 Nov 2023 20:04:11 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GuEyVXrQ; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700165052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+4XQ4i8Y5DNwJiAj9ly/ReOTlxs9KYLdEh1NBejN2C4=; b=NQY0hCA9RjFOaeMzvbvuM3vKV2tdfrV+5hGL+5TkEDOPAQhFQRMJmZ1KrnQabxP3gIEZbe Gn0GAcM+Jc9gyC3CWtHQU5Muj5FuxPjRQBcRK28ldhvzvB7uvxY9tOfbOnViT3oZiJUWDA Hy82/hNyCv2PyjjeRdgcjOFjHROE39g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700165052; a=rsa-sha256; cv=none; b=BdvEmXrDmW0Aik6UkH+k+sw3nTvPSuPwOyD4whNVXmlYWfHz6qPXXElYgqcOO0xZfmUOlW Uxij4DZNdgLKbI1yjQk6k2P7OEWcphJdjZgiH/gAxWUzj3M5bC0Z1edMZGzV+xbFRAJE5J Fb+FshBhYUC1oIfxJiEEm0Av78CM7NM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GuEyVXrQ; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700165051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+4XQ4i8Y5DNwJiAj9ly/ReOTlxs9KYLdEh1NBejN2C4=; b=GuEyVXrQuHVCQugwq+bPWiZUzUzD+RGg+iwWln9O5RNlrVAx9VI2tVPxxW2vILm25KYwh5 auWurIE7Rit4j8MjTMztQYtA4vjAItvwH6Yhfbj7t+ARRQSStA/AgJIn6ZXahF5Xhu/9kM ViOfi6tY0zRD4x0RDg4L9t/EXSXGoBY= Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-3aZBCSAMP4ia9dKbqEQcnw-1; Thu, 16 Nov 2023 15:04:09 -0500 X-MC-Unique: 3aZBCSAMP4ia9dKbqEQcnw-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-1ef39189888so290149fac.1 for ; Thu, 16 Nov 2023 12:04:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700165048; x=1700769848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+4XQ4i8Y5DNwJiAj9ly/ReOTlxs9KYLdEh1NBejN2C4=; b=vLa7bqrtLeP858WeidNEoKAtOY69sk37BBG4fY8Ux9WRl9ctI6vzFpkAOTt58gXeaB BAL3b5Q4mGRVfZ8SdD4J9vv3QicUhlnjDN5QFiN+IlWU+kt5Ss38GNo5QJx5hYKEii3S JxozgsJt4DzlT0bIpQ12NQK8jQAQJZBydBxg+lxfbUgPHBc1b+6EDcC9O0dw5XXfQNgX 5PDUk4tvKBU/+7K9DeL82cgNLEk+GTjKkHnIa/g4arL1hvYZkwEYIVRaW4nRdzHkoPfD brAxni+N6iN6naH0UvOjItRvhomUPduQBo2D9Apuy/pCl4QfRi73DoAMcwUBEUkUoNKJ V8rQ== X-Gm-Message-State: AOJu0YxhyHGSdZbmJEaCEqd2sD/uchWWPhXGLQC/cdDudJJogZl6RCbo cUreBMmRUotWwgf0lHnSaahHLOPwB4eMQsckPrNTkXW/R8hupQlVOvEJCasTAyg4dlwVRHjIFaR rSQa4fjT8EKU= X-Received: by 2002:a05:6870:2301:b0:1ea:7463:1b8f with SMTP id w1-20020a056870230100b001ea74631b8fmr10381847oao.0.1700165048052; Thu, 16 Nov 2023 12:04:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDPS7+wKj9qqDek4+rigv0rYOE1IH7oReMKMjyyoPNCSs/XVBtexRivZXLqhWKUZiqpeXWhA== X-Received: by 2002:a05:6870:2301:b0:1ea:7463:1b8f with SMTP id w1-20020a056870230100b001ea74631b8fmr10381812oao.0.1700165047537; Thu, 16 Nov 2023 12:04:07 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id j17-20020ac86651000000b0041b3deef647sm33619qtp.8.2023.11.16.12.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 12:04:06 -0800 (PST) Date: Thu, 16 Nov 2023 15:04:04 -0500 From: Peter Xu To: David Hildenbrand Cc: Andrew Morton , syzbot , Muhammad Usama Anjum , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, wangkefeng.wang@huawei.com Subject: Re: [syzbot] [mm?] WARNING in unmap_page_range (2) Message-ID: References: <000000000000b0e576060a30ee3b@google.com> <20231115140006.cc7de06f89b1f885f4583af0@linux-foundation.org> <6308590a-d958-4ecc-a478-ba088cf7984d@redhat.com> MIME-Version: 1.0 In-Reply-To: <6308590a-d958-4ecc-a478-ba088cf7984d@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 085FF180018 X-Rspam-User: X-Stat-Signature: b46o88fnfp4x3ogz4ee6y1iqnxcyw7zg X-Rspamd-Server: rspam03 X-HE-Tag: 1700165051-585430 X-HE-Meta: U2FsdGVkX18IaLc8AzsWlyUGsYN1NFW/Xj0+7maaPLcnyLa9FO4YuAqUKz7Elz0HhdFu9xTy7eZ3ZzM5yNMqS5OHpO+nVFz+LpEaU5pobnpyUTFkD1oeeV+qu6CM3pYIy1W2o7tgVmjloswUSGb1Mb2KSBM5wCTSiU3X17el4bLiTPycl8KozKEZ+61J4+s9btAk934K1GcgshrzMv0w/dWQBfc6q+c+CvaHqRgQkWEzZN5qQYl3dN5tRJN956PxxCd9Mw71r3QSEJGsikVtniVUqQpZ2UtH+SLxz8Udi6hknW/xWglBWP4E7YXM/itQ3cBamUic3UmtfacNLLyURtI6EwVlmWBPIpryps3k/bV/xkdprF9xduUiIiZDsORntplPbQ2xy19uRXNN2rZFGPIj7o/N1ybba1IgHk0ph8cJnbab07cr0DOuiuZMimWvP+mkVldy+STm8eqJ0MlRoH8WgAXdAL4mdxIgiaibiR8eB351Be0aIawwPGETjY+/0tK8T75p5U+qcALG5BqOoVPq1YgjhnICySQuhxG98QQcDg3EUfV133t/Uc/woOlFFtKpFR6WksRpiaYE4Z5EErEX2QBr92QMDg+o+lZx9+JnZ0tfZ5IxrbWpZjz/Og1/5/QZW1Zpj5qX6oVBBAHjsGPVFvIMJpmHyGdUICfuWV4OWYdmyKXxwdnArvHDXADBEEc5inEG0Qzz5dea58ALZSfp5kp2tThYQBXfVoRjf0li0cSO01muyZSPVxZMcycWNDMu+rBj608LV9Y/B+3L/MRYDwXOXXZNjbeff7ln/Q4KoKJB88uPp3uSXs3+WF0/DRK0Ia/4icUMQGG7hguKQVscp95oOVyg/3KYn/FLxipNtzVTbpMxyUAfUoEoChxTXf6KhHjpKPfzDxqm+/EuOwwllTYLFx+HAV/ulvhWL+ksx2KjcmNqxqpJ4aft7UbW/QnaqU5TkULUGhQBpdG N2asVG3c /8j6P/jDOGvXNzO0IdR19URUe/v6mkKP37tp0STAfVMtu86DntWT5LFYbpCSbbVwQsNJUMihnAqPCSIOmbCHjAFluF11iEvbYsar8uwXNQL/8infMg4ZGtJQ3Gregoj3yR9W73fEe4UVS2jwKbQ7kr1fFOuiWoRDeX4DtA1OcV8FJVE01A8PwVDcMPlm3jmE06II6PsN1KXizWQSCduyFtR68j4lCQMOG8FIUElNgP4eUKLn7dE7mhNeBya+QxgDBLXAWiZbv5iQZy0Dq1eHfIu9I/lNQ41vJbjuHjnbtYGz0i8mPWpmgK4f2YB5yaK959xi5nXFvY8qIy+LDpc5+P9mgHCzK+UdxFknM7cbxF0B6qxjEc+FCDmJ4bsqmbIquNj+O+nYy7ONferOb7kHeWTyDWU8qX7VILjaiYZveT+UemX9FwYHiymGrnIc+2YZvE17XfnJ26rZAo9H8Obp8L9w3hzRKBFrBsPJTtxZlGJasQ3bM+BsupBmhSoRALL0RcO2hljfe7AeGIeg6E371Vu4eB8/XmgTmyDEHi1bV17aCavI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 07:13:44PM +0100, David Hildenbrand wrote: > > It should be fine, as: > > > > static void make_uffd_wp_pte(struct vm_area_struct *vma, > > unsigned long addr, pte_t *pte) > > { > > pte_t ptent = ptep_get(pte); > > > > #ifndef CONFIG_USERFAULTFD_ > > > > if (pte_present(ptent)) { > > pte_t old_pte; > > > > old_pte = ptep_modify_prot_start(vma, addr, pte); > > ptent = pte_mkuffd_wp(ptent); > > ptep_modify_prot_commit(vma, addr, pte, old_pte, ptent); > > } else if (is_swap_pte(ptent)) { > > ptent = pte_swp_mkuffd_wp(ptent); > > set_pte_at(vma->vm_mm, addr, pte, ptent); > > } else { <----------------- this must be pte_none() already > > set_pte_at(vma->vm_mm, addr, pte, > > make_pte_marker(PTE_MARKER_UFFD_WP)); > > } > > } > > Indeed! Is pte_swp_mkuffd_wp() reasonable for pte markers? I rememebr that > we don't support multiple markers yet, so it might be good enough. Not really that reasonable, but nothing harmful either that I see so far; the current code handles any pte marker without caring any of those hint bits. I can also reproduce this syzbot error easily with !UFFD config on x86. Let me send the patchset to fix current known issues first. Thanks, -- Peter Xu