From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B24C48BFA for ; Wed, 15 Nov 2023 14:20:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59C9D6B0365; Wed, 15 Nov 2023 09:20:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54C0E6B0366; Wed, 15 Nov 2023 09:20:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43B0C6B0367; Wed, 15 Nov 2023 09:20:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3485B6B0365 for ; Wed, 15 Nov 2023 09:20:03 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 070B8A0A8A for ; Wed, 15 Nov 2023 14:20:03 +0000 (UTC) X-FDA: 81460397886.17.A917C68 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 3D9CA14001D for ; Wed, 15 Nov 2023 14:20:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700058001; a=rsa-sha256; cv=none; b=ojWaz5v5SRmN5lBXsp54ExZrlndKu50BB6IKG9/+5ClO22bog6uknd4FyYsyFmaeYGu434 p57b+b0JLFQb53xyBGesh5ADA79B//FnXvqG0fdKe4eitBaGedrCEtSjGEljmL3OnoCHah 4N0gnRMFARZq4JbiMCJ5ifgeBJqXLf4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700058001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlqvDXZsMW71Nr6Fuamenh+8QkMJUaEmrVK8mZ8UP10=; b=PEue0qwxKBmSGyyPq+JzuPWD9+PRoHhnlgrMS6EqCcccn4Fy31iAHPW+skmkauw8+6ngrJ x5t+VBpTdgboIFsvj4qSMckXQreAhi1KC1rgZJG+aBdGGYthRe/FFuK1n69uexRVNiPOLU CAD9Imypu3yjnV0pvEzmDoBF/HUra2E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 3E684B81884; Wed, 15 Nov 2023 14:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B709C433C7; Wed, 15 Nov 2023 14:19:56 +0000 (UTC) Date: Wed, 15 Nov 2023 14:19:53 +0000 From: Catalin Marinas To: Liu Shixin Cc: Geert Uytterhoeven , Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linux-Renesas Subject: Re: [PATCH 2/2] mm/kmemleak: move set_track_prepare() outside raw_spinlocks Message-ID: References: <20231115082138.2649870-1-liushixin2@huawei.com> <20231115082138.2649870-3-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231115082138.2649870-3-liushixin2@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3D9CA14001D X-Stat-Signature: qexp5e64bi7y5u9niri4mzz8k6wkobcd X-HE-Tag: 1700058001-168593 X-HE-Meta: U2FsdGVkX1+2OLOAc4Bt41LRyB8ZfiGywELe4L+UD9Zh6+K3nggxtJMACdYbOMREJSftjMUojK/7TM6V+U8BRK2aNfqsyUDfRGJN2OccEq9lypLe5xw9e4ZOqFopMILIe8S21W1gGT6O1S1QpfyPYxywlRvNiFk9sg3Ih39JJbhvbUQV5a6EaRf8ymzXxeqPYjUT8HqkEqRljv4N3QQE8rFZhzAFp06r+7/dv2CVQ+SMi5Bke4tRxM1zzEDa3jEMQrhDNdAMFEIyS0mspE4nawvjz/ApvvVVPApNV7zqQjUrvmoxS58oI7npkppCWt7bP55ORfCeTuc7q+duZIW39HzvV5K+uhH8f0BvkB4vMQ+0ufhD8UhGDlCg9cM/PH4QZMF+bersLLorOkAGwKhnZY8eS6o0WBsj6hQuHC782XCbVGEQjrke86bjRyBOhcRNEZfNhh15P6xMVAE5NISjG66ihppm/nPxNTasQDKfHNqsbHwyNO0m6WGFLZgvmmfOGNoc3UdihDaD5Li3ZlquEw1wtp7kcCozF2CuG0kaUamGXrGM2Dsa4nxTbJLuNjvFzPFUe3L5SbC3fqN1wUbS6XvbGqQNi1q63TH5Tn6ET4De7lgjeQUyohMSOVVRXaY6AcBIT0FIts1KxPntH4N6eXcdfjigwHPWb6l7EzBlJ6pGlHFAnWMrOEzWjn8JDbBOwC9zg3tkInhWbhpaoD8ro4SYmCCq/toxad2moWH5LrnSxt/qeZ7pvpAsobyfJCbluK3qr8jFtKWVl1J3jXkmlYGL/h+36K2w5qGGgEWSHtMh4nN7zsmfQFntuBADRuYUZTplbtBs5jVbwCg2nZhcwaypTEQkZNIqsj7VXE4EYLFPQSEKA1hhY//6nXGlpV5eAWq61qoe0sm7fURUxdGExeBF7tvrK8ExjCXRtO0FgQFvbfaxkS08YjhaCUdJcBlVMzBe2UoEqb1b6R4Tzlr 0WWbOceX cCnusBq/acKKaGjfWtiycF8q8VVUrbRJOM4GUFTzeeWDzS9vH3zPyQsnvjuZglNnQF68JgK+LwhWX5j9QNCprAetMg0yp954TyZ4yIE06Q7lsk6Wm8KFvMXKbD2xFnpqtQxdHovKKm1mAtRdaIm8HuE+oBdKwADYeN0qwZttdKUhpFNrAqn2RNj9NjfWzXwP1w3XI9xR9IKJUX7BJp6Lj0BiNBKtpFwvw9C6juQaL8NeUJ1EbRdx6tVqkUprNrZPe/dVSKdlThf1vPJp7zhBcXwCRDCEeWSRakV/6XhM9/4HjlEog8xtMOXdq74flpHG/ctiwoyQRMSvsv28ArNA1A911Sf1+IcNvC97seykQW+Bq6Zav0+OP4Cr3UM9zs7P61fqfYjFYRACCZT53YjNST12TZ0R7bGjUXNJeTA6LDfntxsmNdO1Sg6sUAc2VH8dRjBiPw8/UIHHq4vV9XhlvCxpQaOQ0YkCXKWa4RKtCf9DYsv1msLri+ZMR+7UbfwMsiYO9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 15, 2023 at 04:21:38PM +0800, Liu Shixin wrote: > set_track_prepare() will call __alloc_pages() which attempt to acquire > zone->lock(spinlocks), so move it outside object->lock(raw_spinlocks) > because it's not right to acquire spinlocks while holding raw_spinlocks > in RT mode. > > Signed-off-by: Liu Shixin Acked-by: Catalin Marinas Thanks for the quick fixes. -- Catalin