From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B057C48BD7 for ; Wed, 15 Nov 2023 13:45:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C71E6B035C; Wed, 15 Nov 2023 08:45:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 078BA6B035D; Wed, 15 Nov 2023 08:45:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5A3E6B035E; Wed, 15 Nov 2023 08:45:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D644C6B035C for ; Wed, 15 Nov 2023 08:45:38 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AECE0140A5D for ; Wed, 15 Nov 2023 13:45:38 +0000 (UTC) X-FDA: 81460311156.16.616C2C0 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf13.hostedemail.com (Postfix) with ESMTP id 2F1CF2001B for ; Wed, 15 Nov 2023 13:45:34 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=sW+hooDw; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700055935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RSS3oeqeS/CiWB6NMhIbg0WsBhrLrZytHWzGCO6Y3wo=; b=K+SjY3+7aTa4uIbk86cclj1UVxymbMcLY76/JTmK2J4CrpyzvOOK1nygWJjps3fCufbsMy IBNq8aHZEfrlMmFdUO3HvqM4uNRDz6jxAoqn7x0Bl7IEpEhdH5PTUxWu31tnYO1mvaLbYT cWdOrThSwQ99+hBkGYSnHHYZPRil3Mk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=sW+hooDw; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700055935; a=rsa-sha256; cv=none; b=txcXR9c/179FyezU50w4/nuYBXTji7oyVDDfGOJ0wNInx15x3cwGMbXtoB8bRL2NInZ7qZ CAuoWLhN8Db3tZzqn4KuLvWVilwWnD6e4zrnoFA70Pp6lmQNF6WGxhV3c/hItD/nQbmOb8 iOUZeAaYY57unQCGj25AmHPMSme+gLo= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFDWMmc008780; Wed, 15 Nov 2023 13:45:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=RSS3oeqeS/CiWB6NMhIbg0WsBhrLrZytHWzGCO6Y3wo=; b=sW+hooDwL5v5ywyUDjZdEht0MNktRiimGTSk7FVlhyxYg4QDGYw5Sw03xbKgsyWGtg6i +zIvE3DY4xAnX5RDJQTzztTKK4x6c/vT0pOXC/DmP2NbnO/UrrJqw4xMN5Pj0jzj4VFt y1fgL28AfFamJXbEvqMO5ZBOQo1G+4nuPQYuVKaR5wq1F9iFKsBAog81UZvhpOnxpP84 nqPgMkus6KNnLHfFwcjWCHb+cXEJ415cFz8U9iKSMMPSwBijnN+8QQUciZ+VsSbm4q7a mfkUq/wj7+koMnCw3qE65IstBe0Nim10XBVi0zlZ9mk0gsYOn+e6HdLe3fmDznMI+o4I gA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ucxy3racv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 13:45:30 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AFDixir019140; Wed, 15 Nov 2023 13:45:29 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ucxy3rabt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 13:45:29 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFDY4jD032564; Wed, 15 Nov 2023 13:45:28 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uakxsyuj2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 13:45:28 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AFDjQiW18612744 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Nov 2023 13:45:26 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E3F422004B; Wed, 15 Nov 2023 13:45:25 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1357920040; Wed, 15 Nov 2023 13:45:25 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.69.220]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 15 Nov 2023 13:45:24 +0000 (GMT) Date: Wed, 15 Nov 2023 14:45:23 +0100 From: Sumanth Korikkar To: David Hildenbrand Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML , Vishal Verma Subject: Re: [PATCH 2/8] mm/memory_hotplug: fix error handling in add_memory_resource() Message-ID: References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-3-sumanthk@linux.ibm.com> <6c545504-e1a7-435b-aad9-b045247d6945@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c545504-e1a7-435b-aad9-b045247d6945@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: dJVnrod4qTpVw3t4wCNh1TAkyvCTIqzK X-Proofpoint-GUID: rGx_9bQQcJXlDzFlXlD6dgQwQdzf0Nwy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-15_13,2023-11-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1011 bulkscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 mlxlogscore=421 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311150106 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2F1CF2001B X-Stat-Signature: idmzui8mko786x4foyt5x7tn9obgfps3 X-HE-Tag: 1700055934-92690 X-HE-Meta: U2FsdGVkX1+br/9CfpZvTvA0QY19s0M5cKebOrUMYPn4GhJOsDxZqe0QHZvJEz6mO4Fsg8fnOxO/ZNog5xbWOToATlNAfE6aszVkmLwHj++IjSeE8pTZhthsw6Zd9uV3H4xwxo4JhM42eNHtHkv07kPohtgXel+vS86vcpvHRjM7LpR91aUfb2WYKK4mp1hZdLclk20efM3SI2PAdpN94iIIerg7owiWsclfSLI7fwrKUCuljyBx9N6SdafF3FZ9UlXJQjufRC6PcIg48Wy+et0C6oTGhA5K6Cp6KDcjvG9Y/rvydFDRPsBsPpk/ZN/tC9k0/5F1qfpsLv7stY/tmUzpDNLPyQRjDpL8h11wtHafKqVZfAKahGM+9XLv/uikbhCuPvayodZswc5LHsADK+Wyk/W5xhIj3o1pNWIPYdcQ66XVpJGYq1tpEKXM5PvnTNsdVGb7/pzHVxCOxrhq8SjDTxEOuso/BX14uJ9tb3QE5WieXK2eZFso3auYebRkmLpYjOgDj7w+n1tpuyKMq3hkE/O0Wq6SzybHY0srDWDwJKeU568ti3N8nlzqV8aaz12pQbZ1Q7X1U+yp59k2PKgKll802y4Qn8pNZLG+YzvHqakeicU2JHT4PXpEZe+cJl0kEL4ZRGXZvX3oCob+UgGKRF97Q9PNY1vWA+A+4l4fq2zheksvkrxIXe/j3ver0bsBt4TcpVxZGDsohjf+DJLTIyPVI9IS0xdsemUSkX8VlAbFzgipytOvNXgI4sLvO+cHysq8PYunlXWNvEvtMGq7rVYz9poX8lOx33pgUdAKjjzMTj4QvnnnVf8IMNjRxPuuZBKRzabCYwVDp0OWfuWXpuLmV15cFBAXCSHFix5aM4XhIh1EHYVW0eWPz9Qzti123ThCtA5wthndGuxokMo4pkzIyvm8AE1MCH/G6DfUJWBx6kuKSJrvK4Cfg3ljx0MM2hCSTV6AnlRACMa A7qnyVsw Kwi+8tOBVyEPX7rJFEfNkJqzCJdcu05xx/C5rYRsxYxnWsYIYmuBgKOsQ/pS0k8rxWkg3KID7PewJooD7ftUwGLLqt3eAaLlY0/oFQ3LOvmVUZ0gO4Y7Lg368yJgqMquQJW0LQCoR7PuehXRP+uZMIpXazmlyNTo1XTHZoDZWlSDOr5VIPeiZUWhiqBsZ5vFJhIDEhogCjtoB3uqp33TCWSX/QBHqt7DALtVyeEMICbxh/YPE5FVvuEQnaEjgd1F//EtzOlwWAXEv/1I4ujDdLmT+s6UmAchdJ8FJqIodNVkI3Cjd22CxM3LSAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 14, 2023 at 07:36:20PM +0100, David Hildenbrand wrote: > On 14.11.23 19:02, Sumanth Korikkar wrote: > > In add_memory_resource(), creation of memory block devices occurs after > > successful call to arch_add_memory(). However, creation of memory block > > devices could fail. In that case, arch_remove_memory() is called to > > perform necessary cleanup. > > > > Currently with or without altmap support, arch_remove_memory() is always > > passed with altmap set to NULL during error handling. This leads to > > freeing of struct pages using free_pages(), eventhough the allocation > > might have been performed with altmap support via > > altmap_alloc_block_buf(). > > > > Fix the error handling by passing altmap in arch_remove_memory(). This > > ensures the following: > > * When altmap is disabled, deallocation of the struct pages array occurs > > via free_pages(). > > * When altmap is enabled, deallocation occurs via vmem_altmap_free(). > > > > Fixes: db051a0dac13 ("mm/memory_hotplug: create memory block devices after arch_add_memory()") > > That's the wrong commit. We didn't support memmap-on-memory back then. > > Likely it should be: > > Fixes: a08a2ae34613 ("mm,memory_hotplug: allocate memmap from the added > memory range") > Ok, I will change it accordingly Thanks ... > > Indeed; this will conflict with Vishals patches, ccing him. > > -- > Cheers, > > David / dhildenb >