From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2178C4332F for ; Wed, 15 Nov 2023 01:42:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 229A96B02E5; Tue, 14 Nov 2023 20:42:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D9B16B0320; Tue, 14 Nov 2023 20:42:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A1D66B0322; Tue, 14 Nov 2023 20:42:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF9AB6B02E5 for ; Tue, 14 Nov 2023 20:42:28 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C377E120483 for ; Wed, 15 Nov 2023 01:42:28 +0000 (UTC) X-FDA: 81458488776.24.3E7A517 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by imf03.hostedemail.com (Postfix) with ESMTP id E735420007 for ; Wed, 15 Nov 2023 01:42:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=softfail (imf03.hostedemail.com: 62.142.5.81 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700012547; a=rsa-sha256; cv=none; b=rIpX/5fjA+7tBZNP0+xKorcVnaD5o8n3JIIEP6UuYVyPIy5wwuCjSRQvIZ0CpAl+vSrY+0 weWFFJUO7FP6ZaG9cJLPSJThs1uYXDlnAMAnVDmWIXqOPUI1/UewOEQ3EZom94y3MZFhS1 3pVJjICf0YL6ME5vWIvKg4AivMYHN84= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=softfail (imf03.hostedemail.com: 62.142.5.81 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700012547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n9Nz9jEHwxLveQHGyNNxk1A4SLdZ122D/9FjQCjRsus=; b=brXs7ooIv+4z176zF2FioH0uf2JEQnws92FY+3fGcy9jDCgdbMuFHlSpv/cjd3cqV0bVjd j/+LIwyoZ30Cuf5/bDRUQfDgWiu828i0G8RCu7e4DiIB5NbIGB6A8WluxuKusO120lGG9n X9JgfDuwpwiya/saJ4b9Yh0qg/hbcPY= Received: from localhost (88-113-24-34.elisa-laajakaista.fi [88.113.24.34]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 38a819f9-8358-11ee-b3cf-005056bd6ce9; Wed, 15 Nov 2023 03:42:24 +0200 (EET) From: andy.shevchenko@gmail.com Date: Wed, 15 Nov 2023 03:42:22 +0200 To: Naresh Kamboju Cc: Linus Walleij , Bartosz Golaszewski , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Anders Roxell , Linux-Next Mailing List , open list , lkft-triage@lists.linaro.org, "open list:KERNEL SELFTEST FRAMEWORK" , linux-mm , Arnd Bergmann , Shuah Khan , Andrew Morton , Pengfei Xu , yi1.lai@intel.com, Andy Shevchenko , Dan Carpenter Subject: Re: selftests: gpio: crash on arm64 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E735420007 X-Stat-Signature: qwatobr34fmexn91b57wfeyjmcfrpbnn X-HE-Tag: 1700012546-356107 X-HE-Meta: U2FsdGVkX19BJ8mHNkrAJBVKA5sssApE/1OcakH06FFWkobbQKiLSLFJ6RR6b4i8z0LIPFF9vZBwE6XwmhWxJA8vTgOqxQj8R1dQQzvilhmW3NWvPcHBarPhZIhfIUg03zSvRvnqJose5O/BsYTtTvjQzV5Yxl9AHnWOExgLaGSRTuvo5uIGtSfsZozz2jEh6U9CF0giWCTm6z6EVY6HcYQ6Fn7Rdu26D4EXVW1w8eOqojEacZblbHDjT8s6p0J7mI/X4ujh2oWab4NJ/4JLvJo0m8FBtGhlSsVaKzRXL89ZXh/DBprLcQxDqxwqFOydi8s1NpNNk2CRvdmQsEVpTtw1Vog86MYc6t5HPtwHjLEyM4PO0S+Mk8F/DxOXzR+g+TH3231Mlo+XMrCOoR4cFHzveX4ZKfnzbZp9ZgEnc83OuAWNt8HjrGLvDJhTUJUmWvARdgLFvrBvwh5BVjQ8LhF0GMy19zSGDUupiYcvnzjYf6bdO+sNVggwzUs2ye2kfwUfq0s1Slcl1O3kWqXmt1EWHnoEXAsbbA2G7xMn5zngTUEDoNtn5AXKiZDwwuXgb9/uwGD418olPzE3OfUTPWnVvLfyO3CzxXMyc+h4TygkMhfICv5xmsmOqtLDg4gvc4pFM9l7EBInyVXKM0gkR8zoZHU6lBtXeXwauFtmsRbASAmXCv3MLlG1XMXoBwktm28Os1KRcZrVuh7X2XAqsDWjrE9GLMyod4blLf4+iehjWImEH1cjltbkiFQc9D9aDu1CGyB7FRykWqbQ37nyyz8C+DRBGYlK5RUr/p9FYxyNLUF2CxSKklKD1ZSpzEmTK3cKfm5XFRCyp9mYgOOg5YT8DBRpjTngChSKTb80FBnYwWwPU8xU4cQ3IkfPmeXZno3j2+YKC9t5f0ugSTvdpt2mPDZ0Jj+t1tMC8YMDfYMszolPt6hjqD8J9vCh07lvUv3scuOfK3bRrrKh3PZ crnZXnSs lclRMOkYSvMyucnK2jrtb5AQ4+cNBnO7Az9mdaRSLb1v5aT6o7aZ+NJhp8EPwbvn5hXBEZGThpAkVNT1FcPUlK4pKX3+EoRXPbpfFlSkgVgreSjVrz5FqGUmBbE/S8DUhAt0UnkX4/T6Gq8H/LvpehUJDGoKsmSXdCqJXvNgsHb9oP2nBmKxGwtZ0wHF+JSNX9pGXOWqUgH5EJeU7kKNPrG5W+Yfxy5mpsKsfCgirEDw8OP/fg4l9xTFbdd31ubbiji5G3JwSz9mGO38Yk+o8FHPlHIUJ2MU+p9jpdRdFWU+uj2+T2U1pDpSl5VMrq93+/hShvI7RHbL2NTDcVoaLmZTQMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Tue, Nov 07, 2023 at 07:21:32PM +0530, Naresh Kamboju kirjoitti: > On Tue, 20 Jun 2023 at 22:11, Andy Shevchenko > wrote: > > On Tue, Apr 11, 2023 at 10:57:28AM +0200, Linus Walleij wrote: > > > On Mon, Apr 10, 2023 at 11:16 AM Naresh Kamboju > > > wrote: ... > > > Add a pr_info() devm_gpio_chip_release() in drivers/gpio/gpiolib-devres.c > > > and see if the callback is even called. I think this could be the > > > problem: if that isn't cleaned up, there will be dangling references. > > > > Side note: Since we have devres tracepoints, your patch seems an overkill :-) > > Just enable devres tracepoints and filter out by the function name. I believe > > that should work. > > Since I have been tracking open issues on the stable-rc kernel, > The reported problem on stable-rc linux.6.3.y has been solved > on the stable-rc linux.6.6.y branch. > > Thanks for fixing this reported issue. > > Upstream links about this fix and discussion, I'm a bit lost. Is the [3] fixed? Is the fix the below mentioned commit? > Commit daecca4b8433 > gpiolib: Do not alter GPIO chip fwnode member > > [1] https://lore.kernel.org/linux-gpio/20230703142308.5772-4-andriy.shevchenko@linux.intel.com/ > [2] https://lore.kernel.org/linux-gpio/CAMRc=MfFEBSeJ78NO7XeuzAMJ0KezEPAYWsWnFXXaRyQPAf3dA@mail.gmail.com/ > [3] https://lore.kernel.org/linux-gpio/CA+G9fYv94gx8+-JMzbmQaue3q3y6QdBmsGUCdD-26X5XavL3Ag@mail.gmail.com/ -- With Best Regards, Andy Shevchenko