From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA94C4332F for ; Tue, 14 Nov 2023 17:29:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E346B02C6; Tue, 14 Nov 2023 12:29:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EDF46B02F6; Tue, 14 Nov 2023 12:29:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DC786B02F8; Tue, 14 Nov 2023 12:29:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 39FF66B02C6 for ; Tue, 14 Nov 2023 12:29:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 10BB6120B97 for ; Tue, 14 Nov 2023 17:29:19 +0000 (UTC) X-FDA: 81457246038.12.8F7BDF1 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf01.hostedemail.com (Postfix) with ESMTP id 1BD4140004 for ; Tue, 14 Nov 2023 17:29:16 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="vJGGfk/r"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699982957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ySI9j0LkhlNiSU7jNvFKoWPS1ihC2MUZj7Oi2BBGEM=; b=NVX+6za8Sl1yUQeMmujYZz5bToY8AywNfnQNtxudbC28SuWneBAP2Vay87+Zj8Y7E3fgG1 G7cPUX7t+C4Fyy0JRr1yiYWMfMrBG0/ouIZrkZg81xB0QtXRiTsjiu2JZ6X20cU2JRZ4Pc yldL0nqthdULZ0IxUJqdvpUTcMHfDz8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="vJGGfk/r"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699982957; a=rsa-sha256; cv=none; b=tUZ2O0S2lsNHtBApc9vHomqwOtiBfQfidSnjXIuC/csMraoVCIofibqDKIGBQeoR7UPzqR 1tgo3iKW7HPCFZw9EvpyJNTNBgNkIbEKZhFDhZ6Pu9ie0m6dE9rdPYHw7kv6tEa2E3/L33 EGJR7+vg9K/4Yy/7aCQYQLwi8IVP94Q= Date: Tue, 14 Nov 2023 09:29:00 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1699982954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2ySI9j0LkhlNiSU7jNvFKoWPS1ihC2MUZj7Oi2BBGEM=; b=vJGGfk/rm28tLfjQ+0Xx+A1CYI3f9aFGDPlKuclzXIeejsdioY2hLOZJVB7QIIMb64CKT3 4ZJhLmkIXDaDirMYrsFpYRPZVTP8+Eps2hXBXsm2gm5kJLrM8evkcNqvngGwhqTp30yA13 dgh83jGgQ4/hPPq8Z2vuWX0RonrPkWw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Matthew Wilcox Cc: Christoph Lameter , linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: cgroups: warning for metadata allocation with GFP_NOFAIL (was Re: folio_alloc_buffers() doing allocations > order 1 with GFP_NOFAIL) Message-ID: References: <6b42243e-f197-600a-5d22-56bd728a5ad8@gentwo.org> <8f6d3d89-3632-01a8-80b8-6a788a4ba7a8@linux.com> <4f48d681-376e-100d-01fa-b22d15e8a534@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 1BD4140004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: z1p5awc9yzzwcwz8ntjsm3f8yegqmgsc X-HE-Tag: 1699982956-309911 X-HE-Meta: U2FsdGVkX186giQJTUm/v5FrBzfuNA5xpWgYquebZpglUQO1QxoZIn23qOAkWOuzgXTZSx/mu/mc4aqzCTHW35udbmgM/c9qsh3Rm/28TAmURtr2DUmgB+zF0hpUEdJIfXmLPb3+P5kpUjH2jXhljZMsTYbb7KmdvfpqR/Ux7Y8kF3YQH3urZCvqNwlBtidn7jQ7MbRqUMurSlNnBTUV4hJnNOZkVOiThqY0OU4cmga4ckcu01/RLndSnfgVTWmvX3tuA9/7KE/4C7vXiTo6NlCD+8LKclOQwb9BMXQ/EL0Zk3ae9AlbYF88Wz+SwPFDHi5RN7CMqtPv7gRHCyeEZ1tiuv1tv1SWZJZ936n8pxDxvG6OPR63OtjXf7HbNXE24gq+h3PHXCtYlSH69sM/Ge3ImRdw2JqF76PwrVRrFerH2c1htY2aXM+7QrSJ+dEGIAnfg4ol8s/fph4KWM1jVtNpqEvw/qO+s0xS9mKptb7Y6gpQukK5iNKSaJkFue6wujW85Bk1Y2KG+ht+YYKGdyahoO786hSDLWEe0fXcq/j93HZ9Xsxpvf6lEd++6JB2taVC/ZyBAzlrb9kLFkO26ZHO/sthpJ3TQVZTcPnzh/OgtbJ89V2oXmR9Ot4dzZGXSo+9SByhgBLwURE1LAzaVC6A7a6NinYq97eN8yJ+uTjjQoUHK0z8U1fhhZjFk6LiPPLJSoeO4/oD+YOdGUbcwOXwO66Ah3QOlMR93qgMzvwcPHwwdjritNDXIw8bNdBCr3dSnMRBjTGmedKv68l5K6r7nbMxr9hAeo/lzTYhXGtaNrppEy7icSVENgRzMJtNwy3T7jz1m+yLKq2kijN21z/dUNbZ5qgen/H/9e0PDzRPbIqh6ssNHtGx4ZW13rUWhHkHMdj9NNVu6qSIuh4zvQ69R63cjfPXgh3ArswvgBwVlI53u+XvxRxhrGfEvwx11qkL/pRURDmyCtkstCS WjFhpO72 2Z4v7Ea9DjqUv8ce/TYcNij+ofDm1wIBntmtked/zoOzZ+dUrOGutDH+OWXg/sPLUYzgowGPbN2Igsk+hhh644yamd66RqSvX0zDneJl4Ql+fEoUVk2TBUQv8WOHQLRY4A6SWpWANckgVDX6S9KiQh1QXP5zYFjmLWCbcLYp5CdL39rPEflsPS1UHaCrWOi7RwpSa153rC7obpBM91CO1VH3VJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 10:48:39PM +0000, Matthew Wilcox wrote: > On Mon, Nov 13, 2023 at 11:48:57AM -0800, Christoph Lameter wrote: > > On Fri, 10 Nov 2023, Matthew Wilcox wrote: > > > > > > Maybe Christoph is playing with min_slab_order or something, so we're > > > > getting 8 pages per slab. That's still only 2496 bytes. Why are we > > > > calling into the large kmalloc path? What's really going on here? > > > > > > Christoph? > > > > Sorry I thought I already answered that. > > > > This was a boot with slub_min_order=5 that was inadvertently left in from a > > performance test. > > Ah. So do you think we need to fix this? I'd leave the fix, so that we don't have to look into this "problem" next time. But I'm not inclined to work on a proper fix: fixing the slab accounting for this non-trivial setup. Maybe we should add a note into a doc saying that raising slub_min_order might affect the slab accounting precision?