From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E78C4332F for ; Tue, 14 Nov 2023 17:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBF6F6B02FD; Tue, 14 Nov 2023 12:01:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D493C6B02FF; Tue, 14 Nov 2023 12:01:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEA2A6B0300; Tue, 14 Nov 2023 12:01:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A7B2B6B02FD for ; Tue, 14 Nov 2023 12:01:40 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 714BFB5777 for ; Tue, 14 Nov 2023 17:01:40 +0000 (UTC) X-FDA: 81457176360.14.9C2723A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 25417C00C9 for ; Tue, 14 Nov 2023 17:01:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Vymp8y4N; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699981277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pp5MU1mHRjsqLkYt40/eJ62sb2ubZSHcqYSme/SFRAA=; b=7R2cKbtmMANF8yOnGAHBuyD+7xBzDoeR21VZ2p65xJhHUQnhWMyJdNAgJVolusugr6Xe6x g5phqQ2CauLWBipprZUlbbvMOl1NNZwzmXyzj0ovLDHVSb6mbpwbCv6jj0WI9QRK3JavOo +LrWAks0S1JLCegnHF7cLPShI1O1H0U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699981277; a=rsa-sha256; cv=none; b=MnbxE1D3s25IDeESqNuPEwYbkL2SdXZ1iPHT094qEFr0LdpSUNZWPLvEPzpdp/okmWCZ5m p5qAHYVfD1cwKLJWCJqQjlpzejcq6fN7HIaxelf2yM5LwCULQwYTwzqGHlQ0Xz4EVp9Zv+ aThDzzGjsO+czv/CoveiTWewO22Qddw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Vymp8y4N; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4E1B720466; Tue, 14 Nov 2023 17:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1699981274; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pp5MU1mHRjsqLkYt40/eJ62sb2ubZSHcqYSme/SFRAA=; b=Vymp8y4Np6RqKAUi4obDcB2t1u06UfNJq6yFum9ob2d3yda1xJJIZ4eNApAbtaokGGZN1t httMG8yhPmIA1hjxQ68V6+WkIV9rkPYueMR2yUzOffG1gi6RST9Il1nIzWxofc49KEO6l7 oMU3b6ciIU2QAH8IVRv/MS1pqDMpkuQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2362513416; Tue, 14 Nov 2023 17:01:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id P9GsBdqnU2XYAwAAMHmgww (envelope-from ); Tue, 14 Nov 2023 17:01:14 +0000 Date: Tue, 14 Nov 2023 18:01:13 +0100 From: Michal Hocko To: Gregory Price Cc: "tj@kernel.org" , John Groves , Gregory Price , "linux-kernel@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , "linux-doc@vger.kernel.org" , "ying.huang@intel.com" , "akpm@linux-foundation.org" , "lizefan.x@bytedance.com" , "hannes@cmpxchg.org" , "corbet@lwn.net" , "roman.gushchin@linux.dev" , "shakeelb@google.com" , "muchun.song@linux.dev" , "jgroves@micron.com" Subject: Re: [RFC PATCH v4 0/3] memcg weighted interleave mempolicy control Message-ID: References: <20231109002517.106829-1-gregory.price@memverge.com> <0100018bb64636ef-9daaf0c0-813c-4209-94e4-96ba6854f554-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 25417C00C9 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: j3fik9cm9q5okww3h9147rzbe85ei7hy X-HE-Tag: 1699981276-529606 X-HE-Meta: U2FsdGVkX19hgURmq7JvO56rjv4po9WJidBNtOt1KBEHN+dIH3sjqFoKD9zVEdqXBNx/px8Ydoqko0pl5jNgFJXK5l/neAFuJMSJiZ8MLPJha9NSZAVIJ6mb+90VvUJk5V10elulbhSPt0MZ2F8i18L7w7Cfmpedxs8z0zzhwvN/ckZL9zovVX5ww/wu/j4pcmMEnQn/LkxbcMhHrqYlxzUlVyOkzR8u+4J/IrpP/Il/1hCo3rxPFLnJF2d4Q3kJBaGv+igvZB8D+klnoFpYkqw8W4q6QKJL6++BuW1CBPVL9DVv1nuaCPyE+EFjxWfhzC3Od9h+pZJZzonpx5uiBbaJ05f9aI30aJx/MCoAdm7DVj2GVP0+Gpzwp0fbOE2yd9ITT/bE+SHEgdg9W/j78q1IABzs0uvgrop0WScYzeSfZ/Z4LP0wmo7FTUZffS/d5if37u1oTkSI6YbahceR0CTI5o2j92tm+gm0rumdflT5DpQajEibE9PfaoLOL4XIrD6TPGTXOuewQn/lwnZ/9rRgSVVfkg9ylM5awiia/RFq+QHfTw+DbyYJLrROsO6fchUjm9gqHXhE7A6lV59zRgU/Q2Q3i7eNLng8URJpY96DurECWP9ZLs9dWvMKRj32lirwcZLvzfIPXGp6baNP0bjUbtvrzq/IWTDhgSbeNsJYmkaCeviH511ihyPhLJLMiII2Nxp7tRRL4F5/dkhL4Sz34rgWxOLSAyo1daeWdretbmmRy6/9uQqcTU3BQoWatQhsxgAPC7wK0TWYi5JA431IO0Gc4ojNPtITZBHQ0UKP+foWs+iOROUjj9z6wxiZaLn8mz8qSz8yH5LLQgZx+Hw4i9VT7R0ozg02eMGJbaLGKirpqlNLDisKdmFEDGDcsQ7SXyI5VoTg8hL/nxebYQzfOvOleCb2FzhmI+qn/S+hPZuTYwT2s3saWNSOOsYx6OVD4FYjpy1B0NTUuGl B2s2V91A w1ioNHQWxsjw7oCB8hGpoe/lpEP0RD1GRf7kRu5oE4drn3yQ5XcJoGNtKlJ4Ct5Cg2zUNJCqESVsRV0dBZASHQh23nDx5Qk2QM7414iBKMSx14Xf+ftot0yDbdWxzFrf1Vmthix/glI8Q+jabqY+0KCDc29CeHQNQGbh1JzwVGv1yLHz9UJ9sKqnMnrkCJOAPPl3/qlLCBFk5XFWxJxC4G+t91iK6EKYtH2n2S6umUm7F8zFWwQlgAHfMmB0vNmFOkfMkENP7kKJRMW/yKnN/eEbK0cOx1b5K2Wh8qseA1N71YCVfGwNY8r8e6eQ5BHDTOuTS3ySbh3RchP0cK13BqMWpwp+rl4VWgtKEKBHZzJhiSHg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 14-11-23 10:50:51, Gregory Price wrote: > On Tue, Nov 14, 2023 at 10:43:13AM +0100, Michal Hocko wrote: [...] > > That being said, I still believe that a cgroup based interface is a much > > better choice over a global one. Cpusets seem to be a good fit as the > > controller does control memory placement wrt NUMA interfaces. > > I think cpusets is a non-starter due to the global spinlock required when > reading informaiton from it: > > https://elixir.bootlin.com/linux/latest/source/kernel/cgroup/cpuset.c#L391 Right, our current cpuset implementation indeed requires callback lock from the page allocator. But that is an implementation detail. I do not remember bug reports about the lock being a bottle neck though. If anything cpusets lock optimizations would be win also for users who do not want to use weighted interleave interface. -- Michal Hocko SUSE Labs