From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A88EC4167D for ; Tue, 14 Nov 2023 11:14:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE7BA6B02BB; Tue, 14 Nov 2023 06:14:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A97A26B02C0; Tue, 14 Nov 2023 06:14:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938186B02C1; Tue, 14 Nov 2023 06:14:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 83DFA6B02BB for ; Tue, 14 Nov 2023 06:14:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 54CD31609B6 for ; Tue, 14 Nov 2023 11:14:42 +0000 (UTC) X-FDA: 81456302004.07.9FBFD33 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf12.hostedemail.com (Postfix) with ESMTP id 5B6C640014 for ; Tue, 14 Nov 2023 11:14:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=mFbVnbw1; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699960479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XDqzWLx2K+JvK/ZPpwmsrJYyQOBFyyUyoFsG3is7Iq8=; b=NviGtREnKpIrty+twX+yBtUh1uUtSaa6wU2nwdgibWDj5r0Kuu1CTrGFj1NqjPUzlnlnRO vj56tO41yyVjUC+hazPgAr1tQQtBVD+7HdW/2sEi/fJX/u4ItQm7pLsp7RaODGM6/FgmQM 4caFJXqDWETmQDaaEmA3CIPP8LHIMYM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699960479; a=rsa-sha256; cv=none; b=2W3E8jZKFQBj7MdqHIg4OGn6A7KBVy8xIi8fNLKGFJK/wGFaGmc+H73gpjbwYA8grSVvye wbmIId8V4aMumex0ET6MPTswhX7jgeCH9hofHyg9iQ0JL5UUprCZxw4p2xzB/J0R/y2XyJ lYrq75plVpOXo0vD57dMpkr7ndhB5bE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=mFbVnbw1; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 134DD21898; Tue, 14 Nov 2023 11:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1699960477; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XDqzWLx2K+JvK/ZPpwmsrJYyQOBFyyUyoFsG3is7Iq8=; b=mFbVnbw19yBLSGNX3rYmkMYGhAiCndHWSWr7B5HTniuoNjZSaTzjaKQqYG4c1XCEVXFCS0 vjAkEPCobTE0w89xorZjRJk6yNd9lc2/TtQASS++HnibQxY0g6sRgGsU9eCfFS0h3+sMmP Af7AEkldSerwYs4dAk0WuFYxiiodvNM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D79A813460; Tue, 14 Nov 2023 11:14:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sEGsMZxWU2UERQAAMHmgww (envelope-from ); Tue, 14 Nov 2023 11:14:36 +0000 Date: Tue, 14 Nov 2023 12:14:36 +0100 From: Michal Hocko To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Shakeel Butt , Muchun Song , Kees Cook , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 04/20] mm/memcontrol: remove CONFIG_SLAB #ifdef guards Message-ID: References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-26-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-26-vbabka@suse.cz> X-Stat-Signature: qgyagodd9dnb5zyz8yrx5jsqd7f43eoe X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5B6C640014 X-Rspam-User: X-HE-Tag: 1699960479-442481 X-HE-Meta: U2FsdGVkX18j9Gol5ANr2NZVl5GCJK5QtIKbkKnzhY2ULPijzIsxuR2nyHPeRpoFB9du2w+EabdyO4dqkWwzQU+txM+VpfNnVF33QH5Lagltg3vc3M5qRHzcxrqEw2tbqLlHNNdxGxi/yOMmg8kwte9A3EjtMB+Hla9L9CyxNRx6i0028XBH8nBeC85kNsAYn90RF40MqmBaYXVSqhk5EeUGAojqlUA+87QyhkGUcrOSDtG1GSAKNNVcoOHchzKXdqY4IAbFVDklPoAd4CrsW7E4IDBZuZLq1fQpn8jIwgEUH2I7vNViCXlcEHSAN1szFAVDYOVsNcmwSzCI/hZ3t6u3MePBLpRbOnwM/sufLD5qfHoe3fUIocUj2X7j/wRwgncnRvRLo1bo/o1miIKrRsr5s1u+1Z5xfxckbOzeskULsIAbL74vmuBJecSaFmU2ST5IQXzf2YxGJs26hxVMs48PinkM8QmLYHDqLAiYA5wcaM/eTs35fpTLlmnonbDLP9qsHDEB2nas0t6vduy+ZEqbXFqewRzm+yA3Sf77qQiz1MI/ctA2sRax9192CaEHGjj4kuqK3IeCJOeNDM7ew3nUNF7RPvKx3utcWm+TaDLzuYwfBSzdXqmESAKHcpg+fWuE4mM2fJQbkewhXR8z12MWwXQDEOmbUXBI69y+II6mKH+RV26IVYFvhuL9SiI6AQlmK24wVmE2KFYKcpAxuIPZyWsF/O1EYzsbFaahnUseF+6gX0W+uNSUNdOvjeK1RYlLChSZprJynXgtej3gLLsOb5GgYcxqZtRfzGWmCZ6mMa1tR58KxjjevBIpqlxIoW4XPPFB8qphCwd3asdzsVvlgNToLSjmrsCpIw0yEcHEQ9Ji9u+P+MUcuPTGBY71HuHL8xFHuzT8mHN/otmsZ2H4npkGt6eePi8FrM+Xi/FKDsVaKzrlQYhOWR6ZQjcCvR59E20cYLNZVuEddp5 jd5BSMtu 1GkQCm6AgEdSXdO4E93n70N1u4HdVK0gJCSdmZ3KXOehW4PYO/SHAopOljAX1qFn55tVEHVOxIi9P2SRx27acm3iC+0rTYh22irAZUdW3SS/nsI2Fhil0nBLKVK+oSHBJ4NdrzXC9UgkE/3ojSPZJhwbpFDf1IsH+T2KXRybYYR3Tf+9x/Ckx9GYOeJsIXT0VxPzUQ0PaXNNLyQmAkv1GkEysHepKHYZH1JfbT7x+7FzAyPqeGh34736qo6G+NcbyUnZlcbnUx6bVdMHEVdH8lD0T5XZZjgudrU9+AA96S45Eu2FpT40UcwajlSwFzC2t7hTcJkdpRg/rnNzMupWDgGQU2gIDNhT5K/ABczsR0HQmd1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 13-11-23 20:13:45, Vlastimil Babka wrote: > With SLAB removed, these are never true anymore so we can clean up. > > Signed-off-by: Vlastimil Babka Acked-by: Michal Hocko > --- > mm/memcontrol.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 774bd6e21e27..947fb50eba31 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5149,7 +5149,7 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, > return ret; > } > > -#if defined(CONFIG_MEMCG_KMEM) && (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)) > +#if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_SLUB_DEBUG) > static int mem_cgroup_slab_show(struct seq_file *m, void *p) > { > /* > @@ -5258,8 +5258,7 @@ static struct cftype mem_cgroup_legacy_files[] = { > .write = mem_cgroup_reset, > .read_u64 = mem_cgroup_read_u64, > }, > -#if defined(CONFIG_MEMCG_KMEM) && \ > - (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)) > +#if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_SLUB_DEBUG) > { > .name = "kmem.slabinfo", > .seq_show = mem_cgroup_slab_show, > -- > 2.42.1 -- Michal Hocko SUSE Labs