From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41964C4332F for ; Mon, 13 Nov 2023 19:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2DC86B025C; Mon, 13 Nov 2023 14:32:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDE826B0299; Mon, 13 Nov 2023 14:32:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA6736B029A; Mon, 13 Nov 2023 14:32:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AAFF66B025C for ; Mon, 13 Nov 2023 14:32:02 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 751E21209A1 for ; Mon, 13 Nov 2023 19:32:02 +0000 (UTC) X-FDA: 81453926484.08.3DF0993 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by imf25.hostedemail.com (Postfix) with ESMTP id 8117AA0019 for ; Mon, 13 Nov 2023 19:32:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gz7NGmG8; spf=pass (imf25.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699903920; a=rsa-sha256; cv=none; b=A+17I4P4iaGxoZH3czoN6hg0deVkqQJ3fYTFNc/XZFAWxtqU/4k4EOuxoiK+5ckBVj+Q3i sMj5m2bL0IF9JxFKi/Y7bn1Iz1SQqm20SRH6Zqs0W9tahGpXKlsP+5N4PqwTxELxwwMwVD eNSdb4ZKJ15BQRS6/X8nRweqoJDEmeM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gz7NGmG8; spf=pass (imf25.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699903920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hotpoRzPNg0gMmGSMdKIMSIWB7Z31+HA7sTVFI0oz60=; b=OX8CJPOf7bQ+wrEpSKwh42ryTmosKAyHSRyrmT9FNLEdpw1qErmwKxXcPJYquJm6ZWnFO2 1TImYTtLhpbs0ML0OHJjwovj7FWqC92eJ7vuVxDUaMF0e41LooIOqoExRbGaTH3J4kGzc9 eXawwkG6bh9Dp8AdZJ0AgFZi/Bj4DQs= Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-6ce291b5df9so3080533a34.2 for ; Mon, 13 Nov 2023 11:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699903919; x=1700508719; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hotpoRzPNg0gMmGSMdKIMSIWB7Z31+HA7sTVFI0oz60=; b=gz7NGmG8BFQkJjmWvDmMyhJeYxVnFAKbIGirOEDzGGBLa5/Xn3eP1j1ml4IoOsdZL+ O7nlS69lXezUSAoNoUVv5I2ZAqbffXE6IhyvkqgcQ7oEQ7fy4m2UpNCr6e+TkmmvLowN RPGCZwJltckcB23wqPPKIyJQasGVNhFrEXkQngs/u3vxPG6UuJ5YQe4fUdzO1DQ1QuH/ vogMRESbjLq721N2jPKcLViA7MKmI1o+7Vr9HY0ecU26oe/uzaiXwXX1C04NyH4DWULf oDNQ1BdqPTotSqxrGjRI1bKiW/Xp1wR6vPoTfBCIdwFqn2r7ylh55ZBkO6qprC/gpvFT 3sXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699903919; x=1700508719; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hotpoRzPNg0gMmGSMdKIMSIWB7Z31+HA7sTVFI0oz60=; b=Kx3MWduIg/wyNvVZD64mQDe1Bs5/nJZA5dM+02YR+IKOXr8/iaBGG18rKBun7Wvn0L 52Rw3ltoal5g5lGhOvpAZGvFGYy41TXi+L+1xt503gcsye8H3hDcuz3mZac9LnEBC+Ac sfGEyoYoBBziw74VFh8Fjeekw9QLUF44s+/7Nu8D59eo8paZJA5iKUj9NmyDCd6bmmAn g3LWAYwGSJQrhH/Vq80fD0L77GJQtmw/sCul9apVRFXLkAIyID2JvUyC1oyyd2i2ToW6 TMSTHT40dYN06EyCmWRGGUUi5gA+AZTeytyRsCALZGi/2xs0Ri/W8RvzGvXD1SVUcrNX kKWA== X-Gm-Message-State: AOJu0YyYXKvZKc1XMJ5G6LLChJFC5Qz1ZUoQ5Dn4Kx0Gj4sAUXuzJSnd 1Il/jVhmCa/DSXbRxoFMLIo= X-Google-Smtp-Source: AGHT+IGceLoBZqM2PHMkJ5D/TxmMnFCd1Me4IF4Mq7jbX23K2p+xb+PtiIJoWTkSj3XxDyJXWH85AQ== X-Received: by 2002:a05:6870:ed98:b0:1ea:3746:b7d6 with SMTP id fz24-20020a056870ed9800b001ea3746b7d6mr10147561oab.28.1699903919676; Mon, 13 Nov 2023 11:31:59 -0800 (PST) Received: from fedora ([2600:1700:2f7d:1800::46]) by smtp.gmail.com with ESMTPSA id m21-20020a056870a41500b001d4d8efa7f9sm1112892oal.4.2023.11.13.11.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 11:31:59 -0800 (PST) Date: Mon, 13 Nov 2023 11:31:54 -0800 From: Vishal Moola To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand , Sidhartha Kumar Subject: Re: [PATCH v2 3/6] mm: memory: rename page_copy_prealloc() to folio_prealloc() Message-ID: References: <20231113152222.3495908-1-wangkefeng.wang@huawei.com> <20231113152222.3495908-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113152222.3495908-4-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8117AA0019 X-Stat-Signature: ereb1ig3qnt9wzi31u1dg3ynjgtoch7f X-Rspam-User: X-HE-Tag: 1699903920-814379 X-HE-Meta: U2FsdGVkX1/YPije1RjHtCJxifVzTEkyE+XyIfbrzXQWs7+EzoyTOIRUA2hvIt8FlI9ZDCuY5J4e/mIhVmsnUbQT4f9EbDoTawqiGDi187FNB5WdT0WA1Btgnq37Ga+qrLF3kraZyubrfEkMYS5Wu/O3nTQpGRIE5EhyuBfUlhh2j7QzR/lHOrb0SM3efs8VsMYM5ucd6qM89IctG5mBC2erUTZC/TG9o28Pq0TvTSHPEiK6Tis8hFwx/bGJAHG/X8b8wAYCmDhDWuWTLKn0i5xcDgaI8oaqrnjbfLab/F7aSVHZHwruWJwRlEsdnsJ10G7ewDtgeNsAZiiGu3Zh+VAeKi8UtxjsQmrAWWCrmNsFhHzQkBPShLoAWWjsUfcblWNtp80mnZKTN71ETkXmZU3Kqs3AKtXnFMA4yiK1oqYVkozf+Agai02JCOJuXolk3Txn5Gh9N84Yk45MYZDpdIeHatMquGWQ3Wymzq+eaonlZOgTMtGNc6nROAl90LDZ6FKZSw/UoVzfgjTWe5Z9uZWBlLzWWK8ffCp31sGZvf0D9MqC+kWehcQsTQeObBLxFu9+N05obrxX7LsH/xMseMtmrTqZJuoYWTWbfjA8Dh90jLOq1SiLKhxlYml+DKE8CJQ2q1QHtGHsPuWv2IfqJNw0b8s4WJBVx15UcnYxudMaB43Owxk3vSOltGIIR1ra1GP8vSJrVrkQjf3QhDYA+Gmj5BYXRf9alIRHga+9QxWQlkGy7ls0IZ8U5TLDjVwN+ccF3bJkIRYfTwE7GaJcw8T2EtKokM0SsFcLo+tEaBj0XoIKEhjHl4OS4MgvGPY3UJUD9UuwqqyZij6g2PLJZLePzZewatCD37FZ+9t55tAjWSguO1eAMCRdErkMsVOJqyIba6oz+U1BKtkDwySIfkVRphvM+gOB5NbV8xzh9crAWncCCa4gpffaXxyVW8mfYm5+5LQRF/B6rIAGMBd 6/jIvIal 6+kXmjFscD5VaLO9VX1NduXZNAm5jtMikj5guG/LY+M0Jyks7LsbqqxL67SH19YwNaoofyn1+UBNZRF74xvxzC1QUqGmSJm/kMZEu33b7cZ5DFrK/mf0kjoWl4skflBemRjBoVB0a5RaodpDSiv89vZAqWl5+bHDtIVMBH1fbETcOKLio3lNHKh9fK3PkiuQp5wj3Xod8iLCndJFtskd+s+R4aDgaK45TUgPxHuwZ2V+6+lCP1YCXKzv0hzfJmAnvbYDZXxlFVfhSuqaLt62Vekoyz49880mQV559XtEl0VEIeuskPSr2mqQs35Yygtawdvy6Hmf1qrNo8D4kWMW0Cn8SavysSkoYl4WdJX0kqKKKBN9NJk296qgV/eln0asofnfcAX8DmnSaxJqwDG0KeNKHSzmVh/qGWXQBt1q9SasuBLTToPJVpF5PQYfqdMGE68l35SfyL9sH2E7YNiLheBiveBsQs13LBosPxzxC4dQGGd9K+0kY6VszLMeoAxGMuIo3iwTvAf0++kse/IbrAM4zX+gkmtKiddNFyQ89uqSdh/w0STDm1DzIpiXGLXKe0ye2aFF6LYbqE5I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 11:22:19PM +0800, Kefeng Wang wrote: > Let's rename page_copy_prealloc() to folio_prealloc(), which could > be reused in more functons, as it maybe zero the new page, pass a > new need_zero to it, and call the vma_alloc_zeroed_movable_folio() > if need_zero is true. Reviewed-by: Vishal Moola (Oracle) > Reviewed-by: Sidhartha Kumar > Signed-off-by: Kefeng Wang > --- > mm/memory.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 379354b35891..d85df1c59f52 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -992,12 +992,17 @@ copy_present_pte(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > return 0; > } > > -static inline struct folio *page_copy_prealloc(struct mm_struct *src_mm, > - struct vm_area_struct *vma, unsigned long addr) > +static inline struct folio *folio_prealloc(struct mm_struct *src_mm, > + struct vm_area_struct *vma, unsigned long addr, bool need_zero) > { > struct folio *new_folio; > > - new_folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, addr, false); > + if (need_zero) > + new_folio = vma_alloc_zeroed_movable_folio(vma, addr); > + else > + new_folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, > + addr, false); > + > if (!new_folio) > return NULL; > > @@ -1129,7 +1134,7 @@ copy_pte_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > } else if (ret == -EBUSY) { > goto out; > } else if (ret == -EAGAIN) { > - prealloc = page_copy_prealloc(src_mm, src_vma, addr); > + prealloc = folio_prealloc(src_mm, src_vma, addr, false); > if (!prealloc) > return -ENOMEM; > } else if (ret) { > -- > 2.27.0