From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1F9C4332F for ; Mon, 13 Nov 2023 19:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B318B6B0195; Mon, 13 Nov 2023 14:30:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE1A96B025C; Mon, 13 Nov 2023 14:30:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A9666B0297; Mon, 13 Nov 2023 14:30:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B1366B0195 for ; Mon, 13 Nov 2023 14:30:58 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3998880953 for ; Mon, 13 Nov 2023 19:30:58 +0000 (UTC) X-FDA: 81453923796.21.5F620D5 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf05.hostedemail.com (Postfix) with ESMTP id 6047610000C for ; Mon, 13 Nov 2023 19:30:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g957ZNJa; spf=pass (imf05.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699903856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NtsDd0lIOvoRQSEHQSqxkag10z8/tuV0tSNv0afMBPQ=; b=qXnSXZG9qlZzutbzaxkvQXlYp4jll4/aQpeMyyjbQO5YpVb3tO1WJXDEaNO0WxXv6rFeqQ 6pYyIsr+QkIO+1CVQy/ACo/0xlTzWnizkeeh1SXCER84XdefZ+qwk4JdZk2OgJGCwMar3k 6PbCxpIDf2Bix4O3vweFLk2ZqmlKJlg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g957ZNJa; spf=pass (imf05.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699903856; a=rsa-sha256; cv=none; b=2LpGv53UbVzt+iCGD1ghtynQ0rd/psKcytRFFzcicqZDUqbjSkp0glLUaDjqMLe0K2Pu1D X8IojhwNbLpJjWlSLyxcrQsH2gMypv2iDtr81kop9RFLXad2FK/ZBSF2TjW6l/WHDAAajd b1/M1++lJWBHcy+YmKvL7SbW6z/OKRo= Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3b3e13fc1f7so2951959b6e.0 for ; Mon, 13 Nov 2023 11:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699903855; x=1700508655; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NtsDd0lIOvoRQSEHQSqxkag10z8/tuV0tSNv0afMBPQ=; b=g957ZNJaGt1riBx/3PTkQMyjkLd/G+KfidIFhlPGYLp5v0wwlVlUkKojB3pbZV3fH7 jtdeg/nvKS0zkzmRsOxCZ9vREy5fEyrpYD1uGB0iPCP0LXUT+a3ryfxTTPTtbhuNCItt mIwOdewKBIwDyM7W27zmzKovP4TTgQtpmMDOO3Sdtu+1K96sjhGOFqV8/fKV+apSawIg oG02ca0Gvq1kyTcGPZhrBfpfssoAZ8v4ZOIKDhYVD9jgHiODG/nP1d+/WFdZ3jFH44qf myXD418G+aa6LZ2anS0wu2/f9hyc/HF6XmuYEvXOVxVp2WlrLWrCor6w6KRxzeYMOW2O uBwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699903855; x=1700508655; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NtsDd0lIOvoRQSEHQSqxkag10z8/tuV0tSNv0afMBPQ=; b=KFHubeWVI/eeX5SODigbmMbdRhaJrKILZwvpY+2Giv4+vViKzEqBrVVViGsaJY6tyk z0Um7hidAycUCrmkS7WOv1nJxcK8FJ/PhTr54e6dqjMI4A4Dlzk8gh/KlG2UPd3V0RPO nuvGZszv0RM7Xf4YwRw8+qFFIiZ7VOqDbNzC6Oe+VPXJUBTqacG/FlhIZSXNYR1/rFRN RwV2BIHSgGWB41Ju9NttK1wGfBQpkTAb/pSQuNTpHgz/345ggMdTbkLdfqncqmfnd8fl 6CEGTZGcnwxUp1lMTMPgCpWruQKisS61DNywQ7YxGA78b3W4lafdIxxKXqsNcpX45/k4 jb1g== X-Gm-Message-State: AOJu0YzlzMcmdIb7HHnRN4TilEwzx/HX+apf9jhL7yGgzFzsQyOjZoqn VeViciAXJeVN4z6hHuTdcdx9M6mhveo= X-Google-Smtp-Source: AGHT+IFblfdl9cev2v5CX0G/uLny8IBr2/VTvhViSAocpgEIDfS3dgJCm+QxC29VaJvatU0xlvT0fw== X-Received: by 2002:a05:6808:1585:b0:3a7:26fd:b229 with SMTP id t5-20020a056808158500b003a726fdb229mr12006278oiw.48.1699903855475; Mon, 13 Nov 2023 11:30:55 -0800 (PST) Received: from fedora ([2600:1700:2f7d:1800::46]) by smtp.gmail.com with ESMTPSA id n21-20020a05680803b500b003a78d196acasm887092oie.32.2023.11.13.11.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 11:30:55 -0800 (PST) Date: Mon, 13 Nov 2023 11:30:50 -0800 From: Vishal Moola To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand , Sidhartha Kumar Subject: Re: [PATCH v2 2/6] mm: memory: use a folio in validate_page_before_insert() Message-ID: References: <20231113152222.3495908-1-wangkefeng.wang@huawei.com> <20231113152222.3495908-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113152222.3495908-3-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 6047610000C X-Rspam-User: X-Stat-Signature: 4c6jogbi8h4aq8oa36ib9cdcmd99c8mf X-Rspamd-Server: rspam01 X-HE-Tag: 1699903856-555343 X-HE-Meta: U2FsdGVkX1/jdhC33cbCMKjMFFAk6E443bkd1i7pY8Yz6ox0u/Op70Gh7vMI0cDTbTEWIioCtoFQIlOT0Hn8uIxL5F3nvut42W1RBRhoqbPQ9SuqfPurKLERuCt/62xRXBxdSbOENQEu/VaLvu9x9JH9oZidp9Tqm2kaEfhN9XlUo6l9OQJI2kPC7KIMmHWJ0YmI1/JcQHG9IRoN3UWpGfxrecWloWPDVMA1dAT14V4K7xiOAWnmQgDFsZLpmqP5sMK0VMVtPShXqpWHbXj0mPQnJGziwlw49avU89lVAug4GNqrY9BAbc5eEKxu+lJtyJmy+E83pGLpzHxSOckCQPu1HU2SVrYa1gGmd82LXp8O7YxT7EVtb2Bi7uvpz40cFquYwEK169l8mQJ/9BXYPkfShm1DcLmAJpyIcJj7+4tlCp2HYQOdMhdVEuuQfsBJrZALOHpbR7hdtn68XZNXaPD0a9U7TXXtLg5dkwP+vaFsIkTDyUKZVLiaohYIR9BxGSW/tyZeMtCQuJVc1YpR1QIUojL1rHOppMEhMF0shMfBrs0sNRMmInJtW3zbWLg+3z9Y3UXSMYnlR1DdjrTZxTNzyFjukfAQ4sXTkgrmhcQZYl3SS+d+8pV2H5kggHdrwTGysaYt86M4VWcSdo++fBHTiHw9HCV5R8UVEx3sEOIvt/BTs5w/BwXGnmrA20zvvHm6FGUcyeGCTOm1j953d8I678mrxLXLw2kwPRekeBkqP1jmpzQg/dX1EWjnPjVneEVkSFFpo2hPkgwRpylBjUP1YJqhaO1N1SW5Htk7hKw4LXOZb+Uox18JyxVyiEmi4op9xmgJr+uPFU4RsGB7i8GMFQ3Za1RIdurAXLPte8XrcQ5J9qTrkE2QdVKMq5nOO9fJWYfV7NWHFT9kHcReIfX2xC7KICKcI4TeZjGXwh+CLGaPbF2SnrFFdKJOl23JsE9A3YNfWe+n4+w9b1h Ev65IaGl t2nEr6JUQipnpe6zxOBBW9Y/iPbVqVxuA6evAum9qJ5fr+BpmpKpXQgYXJXXggQ236F5zuWm3/OFsrE52vMYtDSNlbZCXmlWHWgd1I6FQS8BKyi+sxPvTgKyMIGvm9RHeMyyp0WvP62QFEt8ItZwBudnsEyL3W/3E4atV7OXfF+UhXL3iOl/kMAT3rOIQ1XWhgDgImLIfT3hKp9i5R+VZLT0QTFy2tPqMVzFmoBB3WSmPNmBmxlA8vPudDWOo4QSMX9AUP7HH0yIMK3/QgOLMjsEnlJP/0Ta5Y/d5LEf+kvTeKlERgclNSjpUNEo0d2LabTcgiR5t2PdBHlha63+NjcOYLpa9rJgFl5kgck9O0APZ2MeynGUQHheCkpIR3x1oGtyOYgYJR+3uYdPmV3aHdYy555bdoPp44iHiL1xmbEGUuR+9AxoZ5Ocj0LvDXcq5vZ2IoTiibPBpvPMUBhM/hIj1XOfZyX1r5eno65jKPg17tWkQ2UHnmIeRm6fDiIQ/j2G6IvQasNjCQx6PbiPGeZ4AEKupS/+/pDbFWRFjT9y90Z3nKs73ti3Rrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 11:22:18PM +0800, Kefeng Wang wrote: > Use a folio in validate_page_before_insert() to save two > compound_head() calls. > Reviewed-by: Vishal Moola (Oracle) > Reviewed-by: Sidhartha Kumar > Signed-off-by: Kefeng Wang > --- > mm/memory.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index c32954e16b28..379354b35891 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1841,9 +1841,12 @@ pte_t *__get_locked_pte(struct mm_struct *mm, unsigned long addr, > > static int validate_page_before_insert(struct page *page) > { > - if (PageAnon(page) || PageSlab(page) || page_has_type(page)) > + struct folio *folio = page_folio(page); > + > + if (folio_test_anon(folio) || folio_test_slab(folio) || > + page_has_type(page)) > return -EINVAL; > - flush_dcache_page(page); > + flush_dcache_folio(folio); > return 0; > } > > -- > 2.27.0