From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5694EC4332F for ; Mon, 13 Nov 2023 01:36:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0D746B01A9; Sun, 12 Nov 2023 20:36:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBDE56B01AB; Sun, 12 Nov 2023 20:36:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAC6F6B01AE; Sun, 12 Nov 2023 20:36:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D1436B01A9 for ; Sun, 12 Nov 2023 20:36:13 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7422D1A060D for ; Mon, 13 Nov 2023 01:36:13 +0000 (UTC) X-FDA: 81451215426.07.3A61382 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 8E94E1C0018 for ; Mon, 13 Nov 2023 01:36:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eWirk8Ei; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699839371; a=rsa-sha256; cv=none; b=0uGdM4syFzUANcK3RgtKzCnQ6C3TuAozZJfNwe+NRIXs7QYeeVI1LIFhpf7Do50Z9h5Ddz J/tDtMGhzN1VCQ/VDEcCu43sjMB7Nqja5s/0d6eZKtooXNjNTovCR2gVAK6Se34db5hM8F c46CuKNSLsqHv5O21OOjcnvS8IKpSfA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eWirk8Ei; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699839371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+D7ccdqm6TDj+4rVpt2CUxxkfNoxynYNLh9SSF9Rt2I=; b=sqbr+kLkJT2JUC2T/I28sB+u+AQxlJHwiE30Ns7EqBY2t4ZzasbT1+ERVLyiVuijE55Oiy J+rSvl5zeTAB4EuGooiXWV+uZ2gKlY8mWZcCz27MRkC7bMilfxFDsgHP5QRgth9oVzRtlj 6Lvq7VbrL/gVHQvISZn+y1g235Gy7Nk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=+D7ccdqm6TDj+4rVpt2CUxxkfNoxynYNLh9SSF9Rt2I=; b=eWirk8EiFe1xHnPFFvKh+zUsUa yDQQNme9s61dDuMh2O7ZtUG7gNUG2DNWl+/wdQKDyuIqBHAjBQbkXdFNaB2PsAUwSvgnJ0Y+sUHUj 9rY5A7pU/9zK+I53VWBZc1utkhTffnw+0PZMPfuqAWieIzkimwvhNXgUqgbl65o7jG8I80O/BlJ+X QlRoqWW9lTNxbfKwiaJ5JG6vzz+8L5mU9DmRFilQu1gAjXmtDGqiFP5Qkn7odNdeFaIjjw/RMgRSv xosZp3XvMPqARxv8mWbdNV89uz1sHvKYr4F0KyK2gJO+XsllEueD318mHATe3Ek3ww6QgNalhqKzd wLwkgBAg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r2Lrz-00BNan-3y; Mon, 13 Nov 2023 01:36:07 +0000 Date: Mon, 13 Nov 2023 01:36:07 +0000 From: Matthew Wilcox To: zhiguojiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , opensource.kernel@vivo.com Subject: Re: [PATCH v2 1/1] mm: ALLOC_HIGHATOMIC flag allocation issue Message-ID: References: <20231109073133.792-1-justinjiang@vivo.com> <20231109073133.792-2-justinjiang@vivo.com> <20231109094954.dd4b2a5b1f5dfcc9a721edba@linux-foundation.org> <4911abfc-081f-4d3f-aa15-73c617a81c36@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4911abfc-081f-4d3f-aa15-73c617a81c36@vivo.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8E94E1C0018 X-Stat-Signature: fexh3kiipg8eccuu338wk3hzzx9j6bkt X-HE-Tag: 1699839371-164752 X-HE-Meta: U2FsdGVkX19qOUTZcvNw2EyFhZJmRflTR5UCXeGKkeGMpCQRu6teOiT9ySjqSUPHnXtsuX4lR1TIuHCEt8mERe9kffpKNS9Fv5Tk2cqOqsiaCB02M2fF+joLKHIwpkYEjaGNB2doC4bBWQ5U0pDPJC0zih0otDCsmqOIsJoE9F5L+dnmOWbw20nmiXbGcrFJ+MJzwaTmOCa8T7Ppyj2+6+3xsFZfqE9bZzGpLMhwlt7LQw9yo8ZBfnwwnjKBZKQ3c8XBTkoeFtjU/Z7taGRM94jy4GKd4HDl77FxH1RUBJxX75Q2bHrNT7zGI2tF4gmUHJYJGd/1jRyMxL4hW3BPlgYSzukkvcF3AGWGvoIcIkLkqdPg4wxO4vtpogAyiNLn7gYQwNN4i8XpMMWppiEmAvf6d8WU1tuxR0Ok9m72shF8pJTOsXxgPqfBJCL36Q7BUesKR6FoF+U/abHIJCPtawyMH9UI7n3owLPtA6gAtOTb3wT177yWIC+oOP9QbeLKrVYcnGOq0OHdfPqNB/74LZ8YVxno7v5o55T/l0fChnKevxbHQiJmSKMYWUZWJyB2cb4+FLxVdibItpTpRFCjQ1P751FnBfXPNAs1dbpBCqq4FDa16jHmFQgzzCRkRN9ucbG6pco81hjmpeYrh34adCtdQaui52Yvy3fK+/CJxbcPhAoXY/q2M2IUn+lDoX5mm6FID7Ur1kGYvdG1mWG92xk3HgpaRn+VzO2/ERPqF/JcnFlAauNqZDSY+M/jjPEA6wj4a5CGOAbFsiyDJzT89TJ2QhigIXZfKd5CG4AZTZV1kKPixGMTxxd1wefTVjMbqNbM3kGPWQ6Se65zIPt/ceamJm11GmHioFJhaWdUuYyI2vye+kza+9ec7D0+UwyhX4CmB7jzSM3L0Xr+dgkJSWD3Mx37hLssck9HuCf7+6WCGNAi00MZ7RyrmOfmBf4ENrXpc/YHfPeEAkzvCLw dPAyF27U xqLfTJM9PkEksFtKEFhY8j3cgjW025jucdwzy+ziWoU+d8XrAYN66lEWNUcm1m8NCBUGuqL4fqNQv4BElG8rMO2TSCbqLq7t826/xZoOSiN5RyuW4uLWcRUKaGH4uPCVYH4q7MFfrv21C9bkeB6jqzOypyjH3HD5aJNPBMnlPDxs4mSvOfwyEWRefanCthpOxf7pc4aw2qOgiRhZ9rIJ92h4UmkDQyKQed4SL4TgK8ulrF0TsNIgbdJHHTAf+NgZY8hNCrlKvX6nNw762XeLwV79i22QVaCuy3Xr0p/YI4t+RsCs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 09:04:49AM +0800, zhiguojiang wrote: > > > 在 2023/11/11 14:25, Matthew Wilcox 写道: > > On Thu, Nov 09, 2023 at 09:49:54AM -0800, Andrew Morton wrote: > > > On Thu, 9 Nov 2023 15:31:33 +0800 Zhiguo Jiang wrote: > > > > > > > Add a new bool* argument to pass return flag instead of *alloc_flags > > > > and add the related comments. > > > Please retain (and update) the changelog with each version of a patch. > > > > > > For reviewers (please), here's the v1 changelog: > > This patch isn't diffed against the current tree. It can't be reviewed. > patch v1: > https://lore.kernel.org/all/20231108065408.1861-1-justinjiang@vivo.com/ > patch v2: > https://lore.kernel.org/all/20231109073133.792-2-justinjiang@vivo.com/ > patch v3: > https://lore.kernel.org/all/20231110020840.1031-1-justinjiang@vivo.com/ None of those are diffed against the current tree. You need to send a patch that applies cleanly to either linux-next or current Linus head. Not a patch on top of an earlier version of your patch.