From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE40C624B4 for ; Thu, 23 Nov 2023 15:27:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C61F36B06CA; Thu, 23 Nov 2023 10:27:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C10286B06CB; Thu, 23 Nov 2023 10:27:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD84D6B06CC; Thu, 23 Nov 2023 10:27:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9A6796B06CA for ; Thu, 23 Nov 2023 10:27:24 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 56A66140ECA for ; Thu, 23 Nov 2023 15:27:24 +0000 (UTC) X-FDA: 81489598008.10.24D0DF9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 543A4C001F for ; Thu, 23 Nov 2023 15:27:21 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BsBh6eBR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700753241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5h6+cWGrz23YrwqeZDYI017fAYOSZdJb9rWkUmkd9M8=; b=PFNQYaY/ad8hPJQplRZDD0hwXr0nWz6x95ZoKROSs+EGdbZvpZku6fVD8ikvmCJHQj7/o7 CAXtfprzv0S9ipWD7PEyE0ebL0ayj9ZCUldF7xsEWwQpI1DaB4QEhl2He/wEjP1tez7RnJ fh752G4Rawdsrjvp6ajiMiEFeMeogcw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BsBh6eBR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700753241; a=rsa-sha256; cv=none; b=xuMsTvU1WNhXIrMu8bclo+/8bvtNrlrmvpl9RXJcResHgHw3KRUgZgpzc3UHC2iqsfX2Up XSmeUiG1FQxFcYDkQGu1A+tZjbgeqySQKCFxR0Vl6jRn1p+48gPgvpykWFE+PkTaKCNpnG rotVkp+/lT6s+P5bGvA0bKm/1iLlf/c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700753240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5h6+cWGrz23YrwqeZDYI017fAYOSZdJb9rWkUmkd9M8=; b=BsBh6eBRghYRUxL332LiSHgcF1iwoUgOhJtaEPDhEtxUsIfjFCsQE+ewZFI4Ji007Ai3L6 DmtYzdi84T3Mtpis8bHtT4xJ3if2SJ7yHVi8cw55xJhnVGE7eEiumlDn4d50wkMW2klvto lwlyD/1v2+KwHBNfCMpgzkPxYXe72EM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-JRh7B5A9O62-w7ZWekoDRg-1; Thu, 23 Nov 2023 10:27:19 -0500 X-MC-Unique: JRh7B5A9O62-w7ZWekoDRg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-67a05428cceso1841256d6.0 for ; Thu, 23 Nov 2023 07:27:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700753239; x=1701358039; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5h6+cWGrz23YrwqeZDYI017fAYOSZdJb9rWkUmkd9M8=; b=ri/key/FuNEFVlbhqY00hYnbIclDnP7wpiY6cFEFO5spS2Jh/5Gki3gWoo/Qsgf0ie TGuNZfNVI+2mwx0BMw6sUDiziAcXKcQCK0ow+3jCKF23EX9U7qowv6B9b8KOfW+odjQ5 lZaGcKflOGnCCHILM+70gixuk4kowGfVP2PjZn6Z/lp0FgcJPDySh85VJk9pFkZsmbep M/IQsw1L9gipK14I952ZV281tZPnHl8rBe6ykQmu6cYGXaJAlfXdZXVthbiFqKluf7/V eCuO8aqmuJjeaqs55/UWSFceGkzcwEVsXSk41MqT/IEV1t1azFJodEcBoYe3pBM9h6uu XwGg== X-Gm-Message-State: AOJu0YxL/4FSaMI1t14BfzH6pxn8Uv+/ukfjVGFsBZlhA+FhS2KgCBJF w7jZ0Yr7xuDC//t4s5lupsqMvx43z2IfHTZAH38yYeK6hNnsui5lL3hJFjbaICLDBb2YZVEZLFq xvonC6n7KTkI= X-Received: by 2002:a0c:cd84:0:b0:679:e920:8cd8 with SMTP id v4-20020a0ccd84000000b00679e9208cd8mr5882100qvm.5.1700753238793; Thu, 23 Nov 2023 07:27:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkvNKZEqH2ak52nhp8X2gBafkO8yc53zv/hP53yhnuHDSS+q0WRPYSzaBGEY3q9PwqUY/POA== X-Received: by 2002:a0c:cd84:0:b0:679:e920:8cd8 with SMTP id v4-20020a0ccd84000000b00679e9208cd8mr5882075qvm.5.1700753238487; Thu, 23 Nov 2023 07:27:18 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id w24-20020a05620a149800b0077d587e5589sm531883qkj.27.2023.11.23.07.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 07:27:18 -0800 (PST) Date: Thu, 23 Nov 2023 10:27:15 -0500 From: Peter Xu To: Mike Rapoport Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 03/12] mm: Export HPAGE_PXD_* macros even if !THP Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-4-peterx@redhat.com> <20231123095304.GD636165@kernel.org> MIME-Version: 1.0 In-Reply-To: <20231123095304.GD636165@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 543A4C001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zkhekdwrtg4c4nmker6dtoeabf8d3jnp X-HE-Tag: 1700753241-977116 X-HE-Meta: U2FsdGVkX18Pf4PQk4eNa8lLer2lkohhahA65isyDX79FdG2GYL/DlpyQnOF4SWCyXd42e1KRLIOsbfS6n9ikJG+Eb2JLMRiToFOFTEXFVbn3R9YAi5o39OaKBQCGw3745SP66aCYZlSVwhzx0pRyNm1kfLMuUtREClOONGh2On7dGACrd4jPfzAYG/dvFrGdIjyuxJIB87D73Zji6ZN/M4uIivEBax0mv9Q9XSirJPhfmI6Revzt8IhgMFH7GFQSWv0tacqTnYfvlKvlpWmhN9TW41pY8RFBvGXGUwo/M9H6vwcCnZNQwboXJk/m+1jkxvEuVP142nQbep/WsIiaJIuJZeictyZsNRv2lFyhyqaFqq7wge3LN7XGrUXOosxR5D4ofjlwJTJf6yho69I0kAkXLXMrH1n+xYZCPFWFoYoeQR0sK7/JDJ220CxrJiWpw+/KI9HOKv0XaSTXe3PwjN0Ds9+O042HpSFkktOguMULue1tqnlYVkp/BV0Siez7w4liO1rlrXJaDekN52l27fjrrQvzizDSZX6DnKg80z5NcBdYrFKDDd+o4TfIDOAuS0y6xHRtZv9oh6x8F77WnXxlAdyEdBw0CCqoMExEKfoEZfIdIBgmdBR63EjAsbs/VjGEayTB85ShhYbOR1ZtA39KcNqFjzOy1klicHgOh/UIqQhwycwwTh/wIbUuuK4AR+ANYpInkdq9e33Dp/WvLGv+R70UMFFw9p/lqpwM87rFRI95qXyCdBHOnutjdgkeOrNhcD+WBTUSqbUG12tSMp61soV11ibuSD3nmDWYU2senE93Oam6thV4zjTeoQMoAAD0YCQP1tSEX80rWTTZBRXRS8QQJIaPo5EqH+9A8SLeV0BdJyWDWg61FImQ0Pjvqldi7PZw7R8WTtbU9BUOicJiZ1eyLsuYgaNELaLROyfVgny+T/sY84t2d4ORr3oDiZRBXQrqBN/1NmHeg0 E9VVBTTI h+rWQK8kudymq7FilUrGvbizAJ8W7MJkmKs79OXgUgcWZDbpty9PoGygHD3lRMChQMKyBwL/cRVRaqfl0MRQRYSaFw/i/vPhE+7+qZvhOBJpwu0ZjAHGemaa6wGXS0HO5gLkIZ1rNY5GA1Y0Rnwps+zToxEGnc5C5syfz3+b6tMZ/AmTSkBgh5Mb/GIrXdNVPe/VIuzNzNPOHmqD/UnCp+X++pjcgXT3haWe3YTpATBQFda7BxO22sicGKnGLWWwIE4E5ZO8fk516zNNCr1DX/S6KCHap4SeLcQsSeoouS5ktfCkPl+BvvCHMIBu6XCTxhX48Heh1ReYUdDTSaD3PV7Lf/OKMkTtDuF2pXkCj4C0O8rCFKGD4uOJz7zhgvmrDo60JV5eE5XbC4ghmIkbDlW6GVlIJoe/PTPWKSUp42Fg3qvHQcx5JRg0DQi5xycDIKzTUEHynAgMgDPY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 11:53:04AM +0200, Mike Rapoport wrote: > On Wed, Nov 22, 2023 at 11:23:57PM -0800, Christoph Hellwig wrote: > > No way to export macros :) > > > > I'd say define, but other might have better ideas. > > Make HPAGE_PXD_* macros visible even if !THP Sounds good, thanks both! Besides, I do plan to introduce a new macro in the next version to mean "THP || HUGETLB", so as to put PxD code segments into it and not compile when unnecessary (!THP && !HUGETLB). Currently what I had is: config PGTABLE_HAS_HUGE_LEAVES def_bool TRANSPARENT_HUGEPAGE || HUGETLB_PAGE I didn't use something like CONFIG_HUGE_PAGE because it's too close to HUGETLB_PAGE, even if generic and short enough. Please speak if there's any early comments on that, either the name or the format. For example, I can also define it in e.g. mm/internal.h, instead of a config entry. -- Peter Xu