From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D43CC5AD4C for ; Thu, 23 Nov 2023 12:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 098E76B0652; Thu, 23 Nov 2023 07:30:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 049996B0658; Thu, 23 Nov 2023 07:30:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7AF36B0659; Thu, 23 Nov 2023 07:30:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D90956B0652 for ; Thu, 23 Nov 2023 07:30:09 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A76F240DD8 for ; Thu, 23 Nov 2023 12:30:09 +0000 (UTC) X-FDA: 81489151338.27.08295CE Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf06.hostedemail.com (Postfix) with ESMTP id EB5E9180020 for ; Thu, 23 Nov 2023 12:30:05 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700742608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PaLyQKRyisx7xEIR1MhiUnEwsqH9lOlX1GcoNnRavdo=; b=zO2QRLGFKeE6jjd1cnTmQA8CBDKXN0PoCd9yDc7caswks4V/tVwdlte/nUpFuZvfqzm6ra XKD7K6P0UA13zeq06er4B7Mz76/hDYW4RcW6KZwZ6Vhw54oGt2uN59rxBmbv2cJcR6ykMU Ex88jDeWKIYSeay+UPpjQpJqxQbcspI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700742608; a=rsa-sha256; cv=none; b=Iexotd0AqU9iGDAwdw/Lir+jRJUKzlzvANEA64ZgFSUziBJ/5aImWMSubPJpnjam2t6ssJ 01vuz8SyMkI2pi7tsJAOUpS4vMXlXvpzCbbq2E2WltAmgp2Mv5b/NplvaDmwUT295fEqDH QojY0mAFbadmWbP8oiK6NFQw0AXJMog= Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1r68qC-0000v8-00; Thu, 23 Nov 2023 13:29:56 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id D8DBEC0136; Thu, 23 Nov 2023 13:29:31 +0100 (CET) Date: Thu, 23 Nov 2023 13:29:31 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: Serge Semin , Arnd Bergmann , Andrew Morton , Mike Rapoport , Matthew Wilcox , Tiezhu Yang , Huacai Chen , Yinglu Yang , Alexey Malahov , Aleksandar Rikalo , Aleksandar Rikalo , Dragan Mladjenovic , Chao-ying Fu , Marc Zyngier , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Message-ID: References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-2-fancer.lancer@gmail.com> <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> X-Rspamd-Queue-Id: EB5E9180020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: hxkrfcst6pd8z3gozzunb47cnhzz3jhm X-HE-Tag: 1700742605-538254 X-HE-Meta: U2FsdGVkX19Yzf9Cm22wcc4YnQIqCzlbHIGDyuXYe3Cl8L51oUJBhV7Vid7CX7BDwy1MXTI4dBBfYnl2EpY1aQA/M4UafY/2D8m6hoXO0BTgd6x8LT74UoNYq4Ftvoug+Q93zfMGS3tQzLDR5Novl5C2pVMpd9hgBYw3cxtWVsvc8ZFtfXbA7tsN0cwn9H9lLzrkU1GD07+DrRbreNEVDaj/m/IGPtdsrIPwaFMC7tWaQfsdhkiCvOhFLmZpAnrjYtCXyFoauLo0QPdUGDb9CTxLmVt05hTE3YRAVPieUID1C7HJepvr05MTF7B6ec/1l3fBabYeKEdYh/E8SGIApBSDBj0IWi019clJGyfTNn8wJaDv4xiglRbbbALvthV5zbzTlUhyDjH2pPvyuCneFs3Kr9Dby1TMX350uqCgUcRtPa/U93Jb5VanIunBM6ij9pChud/Bz9IUQeVUUBsxlGcK4a9KPLFFPZ0h/RNWg2u0WAlnfJgp/giLTAIHvslwxKEHHA3OuXMUeOUBYoTToE9qIK/QHgQy4mN91ANj0VMXm8IVJ/ooZReLdB5VxNyNRjAp0ofO2TMNthnF6MMXAc/Sp2YM1RHnrXhCr1iPBPVUx+tMXdCTdOmk+skznnzTXx4y74toOZwLi3vxh9Sr8Hks0FblhdDWs96KqnQwZf3kZa9fto0SA6tIr8oJbpTpLJB+U5X5V59m8wWz899L0/u6LyLNd4q60iDqekCm0hLRIbDIWQUIE562w368UWoyZI4f9EXZDEPqMRCp0NXRrJNqd4T8kPTL55ZcS0IpGLe4OSLra3AjtRE/5zCVPWLg3yRURENxVOpfDQxyaDSLpmZAFMYUFza0oeKCJ3xsItUzXTymZJ+CewmP/MlGSVUmQAGT+FzrVizfZS4p9WTg6ZhL4ZXZQb6WkXMGdSJYF12DNnrmPxz2WeQdQgCiwzKEALkr8Kfx1tw4gs/WWz2 p7i1HEJ4 pbuHi2eKPafV7qpv+tO0cdkfH520V+6U3DcGKderCVqlKjpk+DXIdYBIYGovTYGdHtslQRi+DWnjsj0d9R3d/lbqVJNU87SuYtI3u3Yfnrlul+GkubOSkaENzK1sYrexnFx5+8rcPIrXOQlA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 12:13:11PM +0000, Jiaxun Yang wrote: > > Ok. Thanks for the heads up. I'll fix the patch to be using ioremap() > > in v2. ioremap_uc() is just an macro-alias of ioremap() on MIPS. > > Perhaps we need to fix ioremap_cache so it can give a KSEG1 address? KSEG0 ? > AFAIK for Loongson DMI is located at cached memory so using ioremap_uc > blindly will cause inconsistency. why ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]