From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFAEC61D97 for ; Thu, 23 Nov 2023 16:19:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B5436B04FB; Thu, 23 Nov 2023 11:19:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 365406B04FD; Thu, 23 Nov 2023 11:19:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 254D56B04FE; Thu, 23 Nov 2023 11:19:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 14B536B04FB for ; Thu, 23 Nov 2023 11:19:43 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BF3F281745 for ; Thu, 23 Nov 2023 16:19:42 +0000 (UTC) X-FDA: 81489729804.06.9779C1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id BBD768001C for ; Thu, 23 Nov 2023 16:19:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W2MMQ9qa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700756380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NCbhRTsSQmLGeB2Y6SZ9GGd5iZSLx7qmMRIcRmE96BM=; b=j9uvyOgDiIWx5SS8soN7Yzqj7JZLzSfPyr5dxRIwgOFyl9xnca+wzyUNikpQzI386e3bR9 C8K4aGzbaVVU52Y7r2cO8pP3/EZzc/mnV1VdSWx2Q3TNX1jTM4TLMHjUxW9UZag6PVcdRo HFbn6iC7u0CG3Q159E/Pn8yE/7X34f0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W2MMQ9qa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700756380; a=rsa-sha256; cv=none; b=KYtkspzjOcAPTbJVkzsss2zlK7dYY62kBNy/a5EcT6L5psUzUPrZZx8z72IQEtnNGtzPm3 4igrWQhaAwcLOa8NcyvyIMtqEn81TCZvFarOJ01UcmDBB67W67uPJw4Jp0dqx8p/dEUV6H ptn1miLWeWHVrV86SDuYGLeoonr275A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700756380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NCbhRTsSQmLGeB2Y6SZ9GGd5iZSLx7qmMRIcRmE96BM=; b=W2MMQ9qaSSJGPDgBqGgN/lPwJug7CxCNOeg/5xxpaYxNN+uIPcdmd/cJOpPQashxDgCd10 77/nmJCzhu7SilMDvp7tTbLnNpjdbBsj1KutxxVS/iRTscCeVKRzDcgYygJ40s+8LtU/L2 sZqodRqu1/ViEkYHgXbJG/Rsn2gaOWU= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-lg9AceZvM6STUUtizRcg_A-1; Thu, 23 Nov 2023 11:19:36 -0500 X-MC-Unique: lg9AceZvM6STUUtizRcg_A-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3b83fc8349fso235764b6e.1 for ; Thu, 23 Nov 2023 08:19:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700756376; x=1701361176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NCbhRTsSQmLGeB2Y6SZ9GGd5iZSLx7qmMRIcRmE96BM=; b=rtJ/7pb4O1VYPGx3kqVx2BBCXDbo1Sa6/znFcrrR+/dXxv2Ezp56fxjdwWlcJ7gDc5 tfPW/sLMquF5vc8HZQuFZ0KMF6ckzdpWcLCbW6H+jnKaOqBQoHZwnxgwjYkASfqTt8b9 j9nQ90dRO30I6dQYUfnq+Y7yjfwKQI0K5tsvsB/BWaXfTEayVXs8g3eH4ICHr5Wow3Uw bFzoS5YiMuM7k8zRHrlQL8j+Me2z3n0pCrM9dkH/cpZ7XjICzxcxiot66G+FAxMQbM/O ephfp53RNcjh+WfN5EQr6Gf9XKkxn5jb0Ny4YTxZjNZhLgGe0aVyfJ50gQIqH1swZtQg k/fA== X-Gm-Message-State: AOJu0Yzvhz1WHhtCyF9J5t0U8j9AjOFgtBCaB6xjBnsiWkM4fBXYBonH e/pDWNiAVVOxPhFBy10cWMw36Fl5UwjCE2i9hmVW/LNF3pHoMRU2PjHaszY+6zkxaSh8DVXNxwH gyzQFrfx3RW4= X-Received: by 2002:a05:6808:118:b0:3b6:db1b:67b7 with SMTP id b24-20020a056808011800b003b6db1b67b7mr6471449oie.4.1700756375986; Thu, 23 Nov 2023 08:19:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHj341cAFbifzZn8hSKDGTqGwnVrVI9eN5MqbERDrXNX/6P/dAhTG4BNFEHbeWMfhYLK5o0iQ== X-Received: by 2002:a05:6808:118:b0:3b6:db1b:67b7 with SMTP id b24-20020a056808011800b003b6db1b67b7mr6471427oie.4.1700756375756; Thu, 23 Nov 2023 08:19:35 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id e11-20020a0cf34b000000b0065b22afe53csm618347qvm.94.2023.11.23.08.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:19:35 -0800 (PST) Date: Thu, 23 Nov 2023 11:19:32 -0500 From: Peter Xu To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 09/12] mm/gup: Handle huge pud for follow_pud_mask() Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-10-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: BBD768001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ckzkyxq6f55xqw64ndjsa3jrhyaaeyfa X-HE-Tag: 1700756380-101870 X-HE-Meta: U2FsdGVkX19rscHrX64oIOZvBHfTTQVB5LMX1MRPwJcuwDCDvYrSbDg4IORovtXY3dYuqmyuvVpr+hKxVCtdwdTsJgM2N1ahFdBlf0jp07C6Or84xBZFTrDl/lqmmPC9oW8sisyWM+wkVxa1JSTy2qNLpsnAniMQZk2vuG/otvF+aGUpFRRRcKEj63CUPZ1OdLxqGE6h7za+ljYCkM5VQ9hIDJoFldjXeRMqUPxiVFmjU0HCVxmoOufo2ZZiajJ1iewcsDTrR4n1hXCVGd4OMti1/POA1gLJJDbHPM7q3cn4nGjGnrj7KUHH2wYApmUQaAVd3J4NuZDh+o3ywlFyIfgEFXNB3zCTDtuQz2kpZZXhmLYE4zaahR0CyhNxOgiwbW7+fwTM1uCZsDaL3f7Wh8qSWkmeq+CCYLJn68TQ/GRGzrg1hdD3EFJDxJ59WGsejRsZS0BhWsUeStIGcvXlG5M3IK+dCoUFa9TGgKf6Hb7zGF4Uf6qMYHt7Uvh2JGrI4adTSVhQsMG+bmwJGJw41LlN73pnlXhI/gU1bewLP7jL2/EjvGiOMDE7vTjzcHmlQIPyDp2VjKbg5/jnKesYf9Yiv2G5h1C5JQ/wlG026J1V0OWM0DwYoub6QS24rE3pX3E1OG1XziROtNlKRqJiFjHnveBwOHi+KUNoEW4Vyod8rKrw0/z1ba9Xn/u/RnyFiaHpEfweiKy+jEqQykl/xh54r+28+NFLCl2W98UQGgTV7/tJI4hEjrF73aPYB2k+yy2r0ck0D+8MIg0+xkTCNguXzJoVH9QY1HTZzwe7BQko1X/sSyiKGaXlCtHPvh/vhSlGcBecRomqP/G1sRca4hFj6IpBXEZAEYmmM9X3RWr4LpKKWW8ndFOZNItiE660G1Tjzca500qJYgwYErTqpG6XRC5vDvc3uwS3bXyr4/wa4/qUgq2bNYs9HSCrOoLgPuyuGuMcRfTAQq1bU+F mM8DHVdI yo4hFof1pFB3PB2CRVyvtMo1odrGwvi1IlPRUovLlqhNRBUPpJDIMVnL5djO0KW4R0PUqkjD+iN5rH1oIRYALMGH8j6L+Z+szmiIVZ5QjMQPnut0fp8IrRLZ2eW5qu8InJty2//EiYkocp3tyA8UsLbE6bOy09WUcfyQj3LO4AgdGXztGW7hSb3Lhd3s0fGnCGP8gjFwkmnYFKArzjDwtwLM+7iaF3/90lRDjrPZ7+1073YJLu/Bl78d1XHWzVJo8ZM3VIz8obxgMmIj/+K7sJk3noHV5+0fTj4QknssPF0pO9TwE16nDYJIDpnEUaRmCaFwjwZ0uffRy3rlIAbGf16mGcXfqkR0kPJVDeXMomMEnF0ePaeZVCSbwmzsVSzGBBXpna5h3CYehz7L6hzR/eWDiEaS5oWxAGsU3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 11:28:31PM -0800, Christoph Hellwig wrote: > > We need to export "struct follow_page_context" along the way, so that > > huge_memory.c can understand it. > > Again, thankfully not actually exported, just made global. In the new version that shouldn't be needed, because I just noticed huge_memory.c is only compiled with THP=on. Logically it may start to make sense at some point to have thp.c for THP=on, and huge_memory.c for THP || HUGETLB. But I'd rather leave that done separately even if so.. In short, for this one, I'll drop that in the commit message, as I'll leave "struct follow_page_context" alone. > > > @@ -751,24 +746,25 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, > > unsigned int flags, > > struct follow_page_context *ctx) > > { > > - pud_t *pud; > > + pud_t *pudp, pud; > > This adding of pud while useful seems mostly unrelated and clutter > the patch up quite a bit. If you have to respin this anyway it might > be worth to split it out into a little prep patch. I can do this. I'll also try to do the same for the rest patches, if applicable. Thanks, -- Peter Xu