From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E32C61D97 for ; Thu, 23 Nov 2023 16:18:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33F866B04F9; Thu, 23 Nov 2023 11:18:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C8646B04FA; Thu, 23 Nov 2023 11:18:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1906D6B04FB; Thu, 23 Nov 2023 11:18:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 07A4C6B04F9 for ; Thu, 23 Nov 2023 11:18:34 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C24F51605EC for ; Thu, 23 Nov 2023 16:18:33 +0000 (UTC) X-FDA: 81489726906.07.4DC9578 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 2F6BA4000B for ; Thu, 23 Nov 2023 16:18:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DTzQfIto; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700756312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NNXxUTG8R40OhSLEVqBzS0dsS0Q8Pyvv4LmU/l+X8xE=; b=p3l/EsReIc14V5Gqp0z+ny2XzPzn34XzMZl/mwmnD6kVQTo5v9Ea/fYl7/HLFbiuL6cHzI i/dtElV5SD+cFZUSYCeVU4af5Xr0X9Xa/Ut4fEFo35Y+Dr99gdMXZc5J+CrE6Ej6FLNGjs kp8kZ55iDGRJOxb9pKjYa3B7pDFEoF4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DTzQfIto; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700756312; a=rsa-sha256; cv=none; b=vuR3T8JabzOAoIxdzEHiiF05z6nZsVJZXiBlIDeG0igPJkg5mBk0jIAMonQuyr7PNlLmaR omlJZ/CSdMr93b2a9RIlVpVIZvB6fJloss1prEW3aRnkjlbEBpO28Wa4gQaXl4BaT8XKeS u1B2JIziBRH6tthpNuY6VgkRtk9evhk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NNXxUTG8R40OhSLEVqBzS0dsS0Q8Pyvv4LmU/l+X8xE=; b=DTzQfItoUoWrSdgivicSkvfHbk LuUFl8J3TpwDSmzjNwoL7SR5i10AH+GQj/0ABB152Vd0/Xu4FU6jZjLoHCq9b25WXyeQ+lcX8PtZs Ksqha9OpHt+USc2a2yA70A5n1LBpfihkLr+YDZLR95g3xb28rMij4zqgYDCFLA2ws3Fp2ND6WOB31 1rXaEUOY4NEI05mQyt8E+qAhw+qNs5k8YmJDN5dZ6w6J69cMAKRZIv8nIwHp2849WSKCOgzKK4bPv knCoYeilABV/xwstcKYlvqnD3EIKKmFEMEguPr2EyT3tnpjHAdBgUyoyRI0rA5a1GTg6zQ9U4op+c gJ/9F1rw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r6CP6-007hXJ-21; Thu, 23 Nov 2023 16:18:12 +0000 Date: Thu, 23 Nov 2023 16:18:12 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Ryan Roberts , Andrew Morton , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory Message-ID: References: <20231122162950.3854897-1-ryan.roberts@arm.com> <7f76ee6c-f0e6-443b-bcff-3637895dec66@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f76ee6c-f0e6-443b-bcff-3637895dec66@redhat.com> X-Rspamd-Queue-Id: 2F6BA4000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: d4kr1jzzsoipts9dgewwftnwmnejtowi X-HE-Tag: 1700756309-838223 X-HE-Meta: U2FsdGVkX19RlBGF3Wy1EXL9KppY3bjAVkip71E8GBuGAGoC3lJ2DCA+9hGsAYvdDrc+loosZ+gb+49EntJ3pI6acqYlPgGZj3U0N7OREJcEkYsjC4LhSo0egPm8JiP2KHi6uKdq/+/93vn24oLA7joNYLZXrsPu+2hPvxT3KWlQofahSFrId78/n4Zh/aOTjMmE8ShH7op5vxDUYBaiXZ4vfEv70XfF5AMCrgNIC5GolvXQYmkmbAF4QXc+PnxFatRbOYTkkxC4W6l6jufgbKAx9387mcSNHM2zk/SAi2ewZtSHxpl1gAx6YKUt6sq6SQnMMdGXJ1auamv3SG0imWnwSGSOGfLTmT+fg/vgVhG6ohpRTBXKA6bk+EG6Pu/eUELMDjUy8udNWAjPyYWMklxCtEXDYDl12IxzmL6bE92DVNkIZhDuOoA+ZWuTVRMy22d7/a4Ufg44JhPCy/B37Jq39aSX1LaTi5XVy9i+tRtJXNwJIIMoOuqVVBVJCgtSIbtcQbR3BeCMYWBv5C1O10W6gV56CMReWsntPeiNPtPNlhVk2gojRoAU2Uz5yo9io/saksd/LxPv2HWtaDLEBo7TSQFJgui4bSPfoJu7ckieqFPWIwwskQuJMidgDrZOdLaLBzb5w20J4u8z9x+ffd8Q1uOxaVGfMGparOa3HjAXHo2EkJ4LY+JmPN8zIdIoAJYBwTJ80yZkqNJWnLNd5DYcj55CdWeFdmF5zHEPArF79cUIFprk5M4En9YCtFfNwk7EpX1Zg52rvxodYP3gfVTS36fG+oMBbPZaQZLGWBhr3i+O7aZiBtSzcGTXSaxmgGWlbkVlVu+ZQMX8BEBa9Z+it0pYE4JuhzKUyhtl2WasEWjr4Lc3x70zuduvAsKy4lQa8JpLiqbr38Iit1eBKxGJebcwWjgyhFiiLDzxYpYz97R3wqkU4mz9dUitBGo3rgG8wkk5hKxPfGba1TB ViSHzgge 9RBNd/PsQmsoJ87FBWHLd/sKWFE5KZEC4fPtwGMIBYGAJgA1EQTdBU9y7UjCCpMcRjFWYCVgqDL4oIsX4sn2tpgMGTy/63VXKG5lHQpWUAP+XStQgl5HGBAl9p1Y0mjqFGUV1TTTgafdt59C/xZ+phKORpqI3EpEW4dlkvrMZ9YeeKSkzguz8IGup7ptlWAc2EJ1wqcyY+7kMpwSv1SPlgT5qC0SdEgIlYLofg1wtT7MuRqwlMW0vD2KFX2+86oKIVlEqxngVwp0P1q0QaFsS2iXwAqY1wpVuCTUwlDN8Oa4pyKQtKoNS3OIM7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 05:05:37PM +0100, David Hildenbrand wrote: > On 23.11.23 16:59, Matthew Wilcox wrote: > > On Wed, Nov 22, 2023 at 04:29:40PM +0000, Ryan Roberts wrote: > > > Note: I'm resending this at Andrew's suggestion due to having originally sent > > > it during LPC. I'm hoping its in a position where the feedback is minor enough > > > that I can rework in time for v6.8, but so far haven't had any. > > > > > > Hi All, > > > > > > This is v7 of a series to implement small-sized THP for anonymous memory > > > (previously called "large anonymous folios"). The objective of this is to > > > > I'm still against small-sized THP. We've now got people asking whether > > the THP counters should be updated when dealing with large folios that > > are smaller than PMD sized. It's sowing confusion, and we should go > > back to large anon folios as a name. > > > > I disagree. > > https://lore.kernel.org/all/65dbdf2a-9281-a3c3-b7e3-a79c5b60b357@redhat.com/ And yet: https://lore.kernel.org/linux-mm/20231106193315.GB3661273@cmpxchg.org/ "This is a small THP so we don't account it as a THP, we only account normal THPs as THPs" is a bizarre position to take. Not to mention that saying a foo is a small huge baz is just bizarre. Am I a small giant? Or just a large human?