From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3ACCC5AD4C for ; Thu, 23 Nov 2023 16:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D1C78D0056; Thu, 23 Nov 2023 11:08:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3815B8D0002; Thu, 23 Nov 2023 11:08:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 249B68D0056; Thu, 23 Nov 2023 11:08:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 16DC08D0002 for ; Thu, 23 Nov 2023 11:08:05 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E6F5F1CAF39 for ; Thu, 23 Nov 2023 16:08:04 +0000 (UTC) X-FDA: 81489700488.02.082CEC5 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 176D680028 for ; Thu, 23 Nov 2023 16:08:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700755683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zCEDM5pQwQXkXHjdw5D9hDKa8sxMuafN+HhnCX1OVNQ=; b=L94A7Z6tfdlCXcVrLFFw0/tO+16YzJ6BFemZWHO8Z1ILhqdD2Bx9oT57L9csJvVBrh9cSB VHEn4P8w1cB41eYKh2F3zIY7eeS7Toux0MkZkrnCMjEORk7XHJ4bjfZC/2h7Tki4Z+qwjv ngmhkzJrOK13aLvjzjuRqpG70Uc0kmY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700755683; a=rsa-sha256; cv=none; b=OI6VaVFMOqz+NLQpB9B2a6+9D6V/gbuQTwgKNa0r79F3Ap03fUJq7Ryu2LtjK+id8nrneO mP9lqozSz+gur0rD5x3+kH6Dkzp0XJyV755sY7tdtLhIFWyeC9lr2KzhIqy3TFcarre0mq UpqCRM61lBqhyGGrqBgdefQoIaqUWFs= Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1r6CF3-0002rO-00; Thu, 23 Nov 2023 17:07:49 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id C04F6C0136; Thu, 23 Nov 2023 17:07:10 +0100 (CET) Date: Thu, 23 Nov 2023 17:07:10 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: Serge Semin , Arnd Bergmann , Andrew Morton , Mike Rapoport , Matthew Wilcox , Tiezhu Yang , Huacai Chen , Yinglu Yang , Alexey Malahov , Aleksandar Rikalo , Aleksandar Rikalo , Dragan Mladjenovic , Chao-ying Fu , Marc Zyngier , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Message-ID: References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-2-fancer.lancer@gmail.com> <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 176D680028 X-Stat-Signature: bexq7x9yoyh3fa983c9uh494orzxw868 X-HE-Tag: 1700755680-899445 X-HE-Meta: U2FsdGVkX197WoxtOWD7u4uS5A1rImCQlAMNcuY2fR6H94+RIH+nK4ytlzoYe4obNBwzHbeWqXvUDhMaPJMUArRBvgIyUaIZK+YvE6BnQoSLv7gIIfdq56QLOYX+l1cCEijIxXp27/+FLcUWoE4jpg9Bfjri5V257f6iYX0zfGql0HQmLvOL2u+NaDV2J+ygg3/JODsylrDjMPXhUC2QGXBz/D2FRJKc6j0htJ4ZhnTfAplMaeTd+2SVpB3l+ZBp7rnaLjC9V3PVfHD2fA5S92J6Y/PBOoVWP9+8JhKPcLRGfB5E5bhoaxmxQXEdU+daYDfzD+grQXf1YYzeyymJLN9QnFAIt9YBpgN0yHM5FbHDKvif6nDBROIVyDXCudtM3OE1ghz2FE3yrmTU5dnPgEkEA85dbRsz95eDyvl2OCkmT7eaomoht/ci1WGWaWceP+oM15L9DMJb7T8FOZTSuV/QeHozAnI4pUKd43oqCE5wbh9Svs8t92iezrSHjFYldSp9J5b7JP/gYSWdI5Yx1SW88deSQKTi84LZ+jL7g4gRtOJrQWwe3Oy2D0V5nIqquCbtWc2hNm1+S+uaGEucjtpgXLwkIOxbkf3fkPGRuDny3rq/CRarTwjbfzDl3mbjlIPHetWSbiE0PFV4pX8fLV5IED/GnBON+sOVw5lXwV5W2b8ecnmMxWDWwmQI7GyWx3pH3SsvHUTNrzGiTS2czXMEGXq5+Yzxd9HUcidE6Z+N6EaGdjgRI/epVe9jswih7N4yPT1DhwWyImuMOEUTV8EdmwejHdiMLZxGFEDWkRci0opHk0zS4PZT3dXjemRyJqNeKQ+G0DHF4UERFzk0eLd1IgC20iVh0NihkdXOePlYGjJbHKSONQKy4l5+GHJwXxwtMKU2QIVeIMqlyDPasl6MS8QTSO6YajjpHOU8QNYKH+WKPK9SY4e/OiiYeYp9xV5LezNUY9lqZqbko/I xt8Y0e+S 5rVzpsZPymLLFk1rmmlJBtF4syBYrYpRDu+OXwLp6R8dwviUMdEf8B55ReEkumjriKUUx12K8AKsRZdYDuAdEN7TsjkN0fA2h3QuKj2lBeH/cAOyhQK3x9T/vmxsYzKBxfnk26IYmFM3dCKg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 03:07:09PM +0000, Jiaxun Yang wrote: > > > 在2023年11月23日十一月 下午12:29，Thomas Bogendoerfer写道： > > On Thu, Nov 23, 2023 at 12:13:11PM +0000, Jiaxun Yang wrote: > >> > Ok. Thanks for the heads up. I'll fix the patch to be using ioremap() > >> > in v2. ioremap_uc() is just an macro-alias of ioremap() on MIPS. > >> > >> Perhaps we need to fix ioremap_cache so it can give a KSEG1 address? > > > > KSEG0 ? > > Ah yes it's KSEG0. the problem with all 32bit unmapped segments is their limitations in size. But there is always room to try to use unmapped and fall back to mapped, if it doesn't work. But I doubt anybody is going to implement that. > >> AFAIK for Loongson DMI is located at cached memory so using ioremap_uc > >> blindly will cause inconsistency. > > > > why ? > > Firmware sometimes does not flush those tables from cache back to memory. > For Loongson systems (as well as most MTI systems) cache is enabled by > firmware. kernel flushes all caches on startup, so there shouldn't be a problem. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]