From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426E6C5AD4C for ; Thu, 23 Nov 2023 16:05:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB9AA8D0055; Thu, 23 Nov 2023 11:05:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6B058D0002; Thu, 23 Nov 2023 11:05:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C31878D0055; Thu, 23 Nov 2023 11:05:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B1F8F8D0002 for ; Thu, 23 Nov 2023 11:05:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6CD8AA1656 for ; Thu, 23 Nov 2023 16:05:52 +0000 (UTC) X-FDA: 81489694944.12.F6486BC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E32CB14002D for ; Thu, 23 Nov 2023 16:05:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V2GD2jLv; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700755550; a=rsa-sha256; cv=none; b=In4LkMpNQ6M/vN5EkHOPdnTRAlbYMVCeESYx3d2XCuzrmEmXWgTveoQlp7d+zTPsYUmS9H EzwOHpzGxQvTj1oGmewNaEq5DXHqeGLbgU+c69r5NQ9RiqNUK6mv4tgPtvb7ldv4AzGE9V tqFioegoC3sPq5Kqwf+FYSf87cS14OE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V2GD2jLv; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700755550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PBfkuN+8kqgz4YwTIPKlrUbx6SBXFOUPuEOnMG73eBs=; b=ehvQLNIRhI1uW9qcsWdr7omwnJYYslKISoJJsQyDQnZnlnsja/dSJUZQISf5kGxKLta97q rfPJgGYpPEBl+hw3vCLIVMUec4lc0jVARiJwM9Sws8tlrbp43PgqxxJiCCreE3ZKew4qkF Bjy3IrhEu6Y3zDxJ61WkAmMGYCysKBM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700755549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PBfkuN+8kqgz4YwTIPKlrUbx6SBXFOUPuEOnMG73eBs=; b=V2GD2jLvDBj61SfsXK6ggJFxpCeWtoaFjM1/YWy5z3VihsN2ThCNpVR/qVqgj9ZJn15qY8 IETYrBb5fA5aejE6M1wPJWpjupT9sQjsILfzzwlM9SiREiwSMkvND/5uZJ2LS6jbVXqfpD hmPWdvAhsvsNQ1wTmNwHA6KVEp4UnbQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-0WluiR4QMpCZyKeR6BvxnA-1; Thu, 23 Nov 2023 11:05:46 -0500 X-MC-Unique: 0WluiR4QMpCZyKeR6BvxnA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-67a05428cceso1915346d6.0 for ; Thu, 23 Nov 2023 08:05:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700755545; x=1701360345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PBfkuN+8kqgz4YwTIPKlrUbx6SBXFOUPuEOnMG73eBs=; b=xC9lWTHPRZ8okX1zzVc2LFXqqwRQ5c7QzgQq4kSgMykxljofdXimt4wjCURS52HLt0 NH6ht1ZZNHFDRCpNdo1lX2vmzYS1vxveKdJ2ssdMbKvS8bPw6wYLcIAVbvcnzj3OGMYy lnkTxQLUIgUePK6O9up22J/dvjvp7pPpVjrutPhuYioDeXN0HvVhQxiPEmv8d3qhWAy9 VFqiup9PY7bRR6AUj3tFOfKO74MlKVv6iLu5Ca4ii3N7RD2vkw41KV+nTSeGdd6RYsHa FQKb1QXmurXqp15u7KlUZZ+NN3pv1hQ0pXFNxcxGEeB0DZMqSCSl9a+SYtniFqyondW6 HNgA== X-Gm-Message-State: AOJu0Yw3S24zmpKXMLV0Cn3sTirAwdNht9NWBIpF+Yr35+EsEhBluLOe 3axqtliOQK2xNMOzGTgjVrbdHSnDiCdMx/QwUeX+Ev+1tumx22G9jO1UPD2WUl0LgphLo2r/H0D jLOOLKJNUkkg= X-Received: by 2002:a05:6214:7f0:b0:67a:826:df8c with SMTP id bp16-20020a05621407f000b0067a0826df8cmr1824361qvb.3.1700755545591; Thu, 23 Nov 2023 08:05:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHceTZsgETgD6TUpriE8C2r98sh9PhkcjYZSjxDYN1lGZlX731umsxtmk6Pc/7HD1TdP38mzQ== X-Received: by 2002:a05:6214:7f0:b0:67a:826:df8c with SMTP id bp16-20020a05621407f000b0067a0826df8cmr1824326qvb.3.1700755545264; Thu, 23 Nov 2023 08:05:45 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id n11-20020ad444ab000000b0067a08bba0bbsm519516qvt.0.2023.11.23.08.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:05:45 -0800 (PST) Date: Thu, 23 Nov 2023 11:05:42 -0500 From: Peter Xu To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 01/12] mm/hugetlb: Export hugetlbfs_pagecache_present() Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E32CB14002D X-Stat-Signature: 4m65wm5oyznxoay7tmkrif6r4oi69jkt X-Rspam-User: X-HE-Tag: 1700755549-374107 X-HE-Meta: U2FsdGVkX1/zGIabgLzmMAUvMLppm7XJnrti1iHP75jtEEWmK4z3D5ug8Z3Q/MwIXKlgKNatKxjoES1bOC4He6HLG2J9MIdj031zy0bZsa1oV2BR1prKqJ7NK2bH45yt8zIiNVZIEjIC8bM6VamsdsysmWVykTxI1z68UR/yyt8p83qNISAod4GlMFBN8HGzMP9X706LQ49BoKn141++fbQtAE7IO23xE/pkDvfgn0RjTeqFhl5FBuKTNiF0w0+jDqrpifzNj6vytql0CyBEkdXZj0HqoHbLF0xeA1DWWHP+IQOAtm3F1RrkkHLo+llloqGdSsHoHQMdhquplckbtzRReXZJchwjEZT0yfYfPHYpfIMvibdR0j2RjCoWJ0m02szHDLCY/eM2k8ZBZOn7x+I0UsiKq49nJtlwfAXN1ZVM+uuerKzVeMcUMvzrXfGkm/cAJP0MOywidsLoVfy//Kc59WVcDHzIN/YEpZmjmfStUbY7Tx/NDd8gKhe8+sxF4DEARTbtwODWDK1BbOqoGiV4uS+duyoA+9+qTa6TEQHSAmnxU/BxiLAL9DrDCCsYWDJI4T/Ac7Pzh0rWK3dnSRaJzaB70bkaH++v3dUkrDftk6zCox/tsUZt0YwBz0dSmF5Qpx1LqRtchkLY8cXFy3hNz37zXBRxQ6wG5t9KUdoqbALohnJV0Sj8d/IoMVs7uuOZ9/z3UdcR0iVuLcAbwW23uME4AxPTajVnUFYIWjiFa7vwvGx/jaUIC093GQ/n6Scs8Y2C+ZEC4gCEL5cO89s7h74IaiTBF6hMv2Ss9SfEZy7hvsxaOFv+UKVn+CulbCTiBeNBbvI/GKIzLDDiH9S/7GRxxRkXnx9GaOJvwfwDzTtmsdz+t5u/HE+FWhkBNwnpepByEgwFRigqpYz/UxAAg/DCKWiIx0nnFOyfRdwnKnmhlf6XPz+r7QUmkTAK1JdsEvkX2KrqQaomMyk TyriwiDB cZYgjI68wsVOBJQ/2k4/6+cnz7Cw48spxQQo2JVfQ8Xv+3WYJMQptHip4HvOkW7zJqm6t9m82NdjQE3vz0X0A1fgGCK7eHxVGZvvt4DX1+KtgYuY5huMqqBitapZs+hOcTg285rcU0QTLRAalMgoum/d08NFzR6Ix4Rut8cBRvxdtK2gNU9Z7ZKz78kld28Nwdsl4zWXLFNuuoAvcxZf5H7Ag/WpHEU1Ev6wMhhUQ7I7Tlgscg/zpCOyOgW4o1kvUfNIwBUWKCEvqR8uZ0kiWyCJEXX0ffOVasu+PqPLqhFFNU8PiSEHQ8o55zoR7WH8EyO1l43/8l8MpqjQtqsEU5LpPXKFg1svSrLYSqmTwN7yG8/89TqLUUB9CiSKEUG0bhYu3+TA2bSOPtrIQE5nWRWsbEpWuuLJF5XiYKEkubboIOoNNg21n81dh2UL3y32SaYwr1cBMMK6SzRvi+y/GovCxISjnyFYqMiBEzfmNM7oeTj8gEKjna17fRZL2f9lGFeK5Y2UyosoRMBE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 11:23:07PM -0800, Christoph Hellwig wrote: > You're (thankfully) not actually exporting anything, so please > don't claim that in the subject. Ah, I'll rename the subject to "mm/hugetlb: Declare hugetlbfs_pagecache_present() non-static". > > > pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, > > unsigned long addr, pud_t *pud); > > +bool hugetlbfs_pagecache_present(struct hstate *h, > > + struct vm_area_struct *vma, > > + unsigned long address); > > Can you just follow the much more readable two tab indent of the > function above? > > > -static bool hugetlbfs_pagecache_present(struct hstate *h, > > - struct vm_area_struct *vma, unsigned long address) > > +bool hugetlbfs_pagecache_present(struct hstate *h, > > + struct vm_area_struct *vma, unsigned long address) > > Same here. The new indentation not only is less readable but also > creates a pointlessly overlong line. I can easily follow what you suggest for this single patch, but afaict the kernel doesn't document that in the style guide. https://www.kernel.org/doc/html/v4.10/process/coding-style.html#functions And the reality is at least across mm codes it's used in a mixture of ways, even more than these two major forms of indentations. To be explicit, I think 2-tab is Vim's default, while this patch follows Emacs's c-mode default. It means if this patch indents wrongly, probably 99% of Emacs users are doomed. :( Before we have a clear and thorough rule over this, shall we just allow either sane indent to still be accepted? Or maybe there's some rule that I have missed? Personally I actually prefer Emacs's indentations to align with left bracket, but that's just subjective so doesn't count. Thanks, -- Peter Xu