From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DF9C61D85 for ; Thu, 23 Nov 2023 07:23:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970F16B065F; Thu, 23 Nov 2023 02:23:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 920BB6B0660; Thu, 23 Nov 2023 02:23:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 810346B0661; Thu, 23 Nov 2023 02:23:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 67FF56B065F for ; Thu, 23 Nov 2023 02:23:13 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46F9EA0C5A for ; Thu, 23 Nov 2023 07:23:13 +0000 (UTC) X-FDA: 81488377866.07.CC99F52 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id 93333180011 for ; Thu, 23 Nov 2023 07:23:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=pDZax++h; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e4PsA32ksarbTD7FwELk4DnKSQW5zZP32H8oKCdWKrM=; b=shoCGCW48euR9d3SUAkBW00UjY6vUi//gzAL+Iol9AjcH6EYpIi1HRHKoeulyXVmI/BtLI pKWaXIUpll19cOvk8faOZ7aP8H5nkzbAytWK8UKb159XE5cZmFtVCAvh0BMaVzPQ516KML Mmc0dhIONmfv6bAkZLX1rbAp04sUGsc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=pDZax++h; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724191; a=rsa-sha256; cv=none; b=iV6NJOz7uwvCuYBsoM9YIDut1RmJizssiul2RqFnXSQ6QBQq/lGG1HhX0rdQOHn11I7rNB rgqMMEk9+bNk5ZJbNnCdC546JT/63ZAdZzi/BOezWcOEtjNUCG7qrOjPdHfAd8KPURf8ag JUBxZZW2u8qizIRLilgslCZjrl8T6bc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e4PsA32ksarbTD7FwELk4DnKSQW5zZP32H8oKCdWKrM=; b=pDZax++hGn2oV7FeSHRMOIMDez PdAkuhzOZ7Ps3CEUik8v/nResbjuMDIrqHSjjWmlrzx/g7Da7k7sFjOROK+u+x3fuLR/gg8D/xr7t ps1Gxsl25FufRHCafTHyC959uluCLFssTDbonxtTH4eccPW1J4u9034b0xCfuMadBCWDLLsrVnFTR CuLi8ZUmQi/0FGPLY9nnLyQ4Pmx1BgiKE8Z8olpLxpsPzTxA4VaQE6+sUImHjvWOEvtWTXgSTnKAL LqfyOteHizswnpt+nAYQSsLjiIob/Hfu+HhKcijO7nT8I4MBCUPlB0ZXZUX/QMeaH+cUem8M0zWvh IHctsZkg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r643H-00417G-2N; Thu, 23 Nov 2023 07:23:07 +0000 Date: Wed, 22 Nov 2023 23:23:07 -0800 From: Christoph Hellwig To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 01/12] mm/hugetlb: Export hugetlbfs_pagecache_present() Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-2-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116012908.392077-2-peterx@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 93333180011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: q81cxhjqc6wz3181pbtoakd3uiuqkekp X-HE-Tag: 1700724191-224189 X-HE-Meta: U2FsdGVkX1+JDBiebq/CXPXeyKiML2FkPBJAyj9BMSMvTxVnh5cGiiQTfCtYdJ3wmXO2FP+2vmtZnMPhHVpRPLH6FW6OkSnWZOcr4X5wurtSajDF+/YkoOVMrDVH0/0Y6WZ9eKuDWOIaqrumu7IoC7P8R/4gkkwlyo6/AMIVCnI2gdnUDFtvEOWoFKBFl15OiqCIXRP8yEJXOcLzEwxi52JgQhhqt//ddptff8hMF9LddQyW9utAqJB8zNzSDmWL5RVIf4CjzweDO3SRgmL4VmkYu9WDKzCZAiL8xwdozVkEINgDiVgkK3uBCT2YPZ4+2tN0sSMFNIcmJl30YKpmFys7tImfin9JsOoVZXZQpk02m8NIlLNSue6o1k0Jbu1Q1hQc0B0k/KiUM8ueVwik2tdYxQ7iALGIbqyPxr1y2njRcpEZ30nyuGBtKvH5L4d1Ub/YHBwdFvRyB0OcTyvkXeGUq34LTlLvIYnFtnPTTYtxSuDaHizj2Twbwg0lPg2xpGjnO8gmEZU47P/Hvx1/TbmutAVnNc6heBXXSuxOBOJeDpWoVIB4xN9aQIu9WuePoeZxvH3/kyWkfBgsy1InXCpyNACLUNvj1HhNvHiclW1t7dgk/hZXcWTJG4FPSt9lY/veBggjgnHYGLAU7BbeS/KAn+REpnGEm+C4EZsk3K/rPp5w+DLvDkCjuvvvUVtLVrZr0w3Pw/YlIJ5X8VZq8rmxUAGssq2mAW8AKtf4FiqdPKPzHPbIUvBkS5Ujky0uMCzBiwaKvGIX4/q5twSb7xqVR6D9fSpwwouzcEK4ljZ7vI0/fPU2bxgi/yxTb+vnSmSPgPVWdE8PKUGEVZ0o/yCxEwTfZBbFtmMcAnJGl7oZOHR4X9uEropwSYRRaU8Pi5zdWX77KGF2zGzq5dpdKVx/2LL0Q39/yJgzj7uPLR+8gYwz1FEnPDB14dBlr78vNVM+NEGya5GNXd1kgmF tSO8+m6m aBM0quDwA6jKUjsuILCrkjKc55x4nr+0wwV78K4JYq3oyGF8RUwWX1yx2Oa4CnnXCiGq3B3a0jTI6PN7bspRaeQBrPAeeMZtkp8g7ydcH7RTOBFOP+dk9cHBTUW6JM6OaQm2LIC7of8AK22j9JLG05c7aJjoPKxqJfZ0yd9lGZ+WKHb3/PmdJJKpHtXRrPGEroMw0SBAwilfP8f7pTW9upiJ6mGav85JEnCqrkDFp+C+THEk1t3v/U5nw7WXiuQdvzuCqxAS3qfNzgqo3h57oII/GYneV2mcvTNt+u3SkG0zvf6RgTc+XPb+cWCFr+NZvEHoTWsNM4H/yLs5ekPwQNr3e/FJyBNf3mV4ME5if2tTfxG2xCWm1hHddKJZXovfaGCDVQDlm4uRaBMPWt0pYRf6iOGa8TiV8UC6sm0dN578LeQP0rXH8br6RsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: You're (thankfully) not actually exporting anything, so please don't claim that in the subject. > pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, > unsigned long addr, pud_t *pud); > +bool hugetlbfs_pagecache_present(struct hstate *h, > + struct vm_area_struct *vma, > + unsigned long address); Can you just follow the much more readable two tab indent of the function above? > -static bool hugetlbfs_pagecache_present(struct hstate *h, > - struct vm_area_struct *vma, unsigned long address) > +bool hugetlbfs_pagecache_present(struct hstate *h, > + struct vm_area_struct *vma, unsigned long address) Same here. The new indentation not only is less readable but also creates a pointlessly overlong line.