From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BC7C61D85 for ; Thu, 23 Nov 2023 07:26:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E336B0667; Thu, 23 Nov 2023 02:26:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DEF46B0668; Thu, 23 Nov 2023 02:26:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CDAE6B0669; Thu, 23 Nov 2023 02:26:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2CC456B0667 for ; Thu, 23 Nov 2023 02:26:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F2828C0D5F for ; Thu, 23 Nov 2023 07:26:18 +0000 (UTC) X-FDA: 81488385636.15.E214DF0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 55E8B40003 for ; Thu, 23 Nov 2023 07:26:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1D4CBpbx; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ucNIMLdxUFVbCLp9HspFVrXSn5iGqL5LxFwAG/1uGD4=; b=E1W45Mc8/7MjQfdDeKo1LcN4uxMwhZ9CcnDliC9PZtD6yWDAYb2GTwKMfuvvCrSQsyhDuV zF/vSeXQqrWd1cjJVnalFHZddKFRGPgeTG+8jQRowcjkXOOYthgDloMy0uYuBGPMJ2BEY1 ekyS/lGSAh8CtNkCOIUJIJcD9VwG7c0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1D4CBpbx; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724377; a=rsa-sha256; cv=none; b=nnin3kWq3JeJltt61VdA/6EVMlUdUJlrHE/xLBhDUQ6UeZtkkjo5mqu72v0fxd1rFb9Tee CMifzMn16sxMr6lyolZU/6ubjoYmIA5dUMmY0ZCM/b5D2D0GzgkuM+YARHBzNGDdByogBY jbX3fMZfsso9uSt8PbBTMra1KhhyRJA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ucNIMLdxUFVbCLp9HspFVrXSn5iGqL5LxFwAG/1uGD4=; b=1D4CBpbxv4d4JTuoMceC6cwKDs 5DUJ6R7EohJ1LkucUf4xdCoIpt3HtGoW9BwAH5gcRCGgcYs2mVS3JZJjbwBIZXf6ooVUlMr4Z3EoS VrXnD8Sp6/2bj0iW5C7byD8EQToZezqi/rCfhNEJF6NJdTKAi8WQTQT0LMTORjRmKxHszexdeailm USOIIwdBL9MwC88RG7BI2rTEk39p74ILrXMku8ZBq4Xw8ygwf/kFaG9uJNpDeYfk6/75rsaJhkqxo IHYn9UlE0tQ89kRS4ux3sHAnKrqJB1pD4aBzCMT0hQH/r1/SwHzZFwLHHNdolYJo0R9L2UjwpepNQ U+hjNp3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r646I-00422X-10; Thu, 23 Nov 2023 07:26:14 +0000 Date: Wed, 22 Nov 2023 23:26:14 -0800 From: Christoph Hellwig To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 08/12] mm/gup: Handle hugetlb for no_page_table() Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-9-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116012908.392077-9-peterx@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 55E8B40003 X-Stat-Signature: y5xbkzb4ij1a8f6hbq8oj6dhcxmzf9d1 X-Rspam-User: X-HE-Tag: 1700724377-737412 X-HE-Meta: U2FsdGVkX1/bnYh0w3GvOnsGxKjagpGp0fWAgNFU2BAoQT5kFcuOKpzDV9OdYXXKqCL8nFAPhiAHpVj1faFU88VDN6acTbCPNX+Zww9z0s7fp6BtYck7bq/9V2l9ePoRDkWpnAmYq/jZTbNNykdxRw6D46PDVf9V/0Jq3P2UK7RGGoH7DeJ4bgCl/hsmbos/6I9zOpYxof1lkeHqATpUPX5pBKI8Y5bEN4rZi0vuQCLXQVD9PZX7eV9bhXie8UGq3md6z/03IpVPOO4egM99WpPCOB1uj/txhXgIkidwxj4JjzEc/ITs41cAcoLsQtPwyq4byNStX5kH77b+eIqoa5/JKITzUAZMxI0xFtufnypmYNmPvI5KU0jvnNrkYGKf/nfOeSFiNv+TqDKUcTV1rZJPFF/ZHmB1jvUgj+S+liWdb9xFvNTjsupPRIPAFBVcp6n4AQAsilN4s0LU19+ZiagFfJC2ysTLzrlGaeDonRJXe6Rvew4AyzMG9j3E1BFqMk1euG35u1CsOLc731MGbKT92DjH671Whv9dQ+Qyg/KfhDNVH5m25Ud7pXQeLUmUZb9JmVTunxfTQ3MBmeP2dbJunxSMpYgUeRsnB8YxPoQWHaQZlQCBi1Avaceo6dgAGhvPvkB+qE5pxpe36zMVZMAhl1JEjr1DHxgoWxgNs4AfuRbzBO/WI8kn2qqo6TASUjfCehhKiKZuQYUSh5Pq/49pYJvzcKnPqQcyZcnzY2U0QQndbhCZo1MJMvBB44TlNMHvsaOwfgPBJ22h/zWzaSC1hnCzx56XfSH3p/LsfzwoeJZqMPQl1bgNmdVf+ZwOw6zZOIm3m8HXs4yk0tEYxxjnKkGKXRzNfLzC4OZI4a/3Ij7z6AhYuV+NeexsYXcwLR/xe1RbsUn8xhQOodtDzZECYW6j3rYVKJ9n+GsubwGzW1atVL+BVTkYLeSurFXG52FT8Vu8+S//mgSFBxE d6SM7meN pJfaU8UH3nm3e1TuHh/WfDVuo11JKO87jJIZcVpa4DYaCtFmqcOklHNJ7Yc6ayKLnoVdojjBp61zC3xKLo29W4ztHTe68wWzudgnqgiQvFRflf2gmvTmrkF/aTlBrKFnaCi7PlZUQAnQ0I0yVJl4i7CfOYn9PHwPUIlLVQDA7vFk2apUCAB0fmsJAGAhBWVkkUY4TNeE2uZR9M9YCe2CQJjUTQSWCGnd8zlXyie+mzf3pcX3f9DMQHvzFRKL/klvXBoY30f/+70UuBm8RGfQ71vtibFLjxr30kaaP8rA17MJd65m3iT+8SoaQuzVkfa6xe7oQGmJvXdVweBN6+n++SJQmlPXlM4qRVdBkeR1grPUaAWw2RuWN7yuum60ucTLn7y3HXXB/WzvUuBpd+f4k7NBZsFBlyFurfK6C2n0yRujrzl6rBIXjDAgjN9lPngKh/csvRirLstuE3CJDGT4ab2ubl7i5fVnuAp6f/B6aR/ddyn2Jq9xCYKLpqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > static struct page *no_page_table(struct vm_area_struct *vma, > - unsigned int flags) > + unsigned int flags, unsigned long address) More reformatting that makes the code less readable :( Oterwise looks good: Reviewed-by: Christoph Hellwig