From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C451BC5AD4C for ; Thu, 23 Nov 2023 07:24:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9E06B0661; Thu, 23 Nov 2023 02:24:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B0C56B0662; Thu, 23 Nov 2023 02:24:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0BA6B0663; Thu, 23 Nov 2023 02:24:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4BCF46B0661 for ; Thu, 23 Nov 2023 02:24:03 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2C0DEB6978 for ; Thu, 23 Nov 2023 07:24:03 +0000 (UTC) X-FDA: 81488379966.07.C663C88 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 7CED11A0003 for ; Thu, 23 Nov 2023 07:24:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2PfPu0Bg; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cH5KstrQ6X9Z2/rTKAQoqizmRcDpRe5h9xPsJQTg8Qo=; b=SuZEhHSbgz6Wfw8L5XCiUqNlV/ZX1BWmXGhVaW7zWuwDjhgieOY/de/twShRfXipAzP8a9 wuYa346/C5ZhbshSxAl3FLO0VJMB8n8j/r0Z5DjXDE9wUGfaRslkzC1WgHnmtCxUr1Licj va9fh5FSjKQsyw0ffwGJnxRCzR8GWNI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2PfPu0Bg; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724241; a=rsa-sha256; cv=none; b=FPLt4/wqCoh3EmHyHLCoQqdkI+fuZbuDKOW/HuCV4CYFQd42hBLlzq2Y045YXiyOZPrmKP q849ZWjKZsM1W/Kmx9jLNKzMv0ODeLp6MzLOOwJgj8E8G6plYm64ow0Yfpvd1eTZ28xQdK mvUBkfXUa2fQkHn7OLzrkgss5ou3y8Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cH5KstrQ6X9Z2/rTKAQoqizmRcDpRe5h9xPsJQTg8Qo=; b=2PfPu0Bg1MlvogYjoOdQsxlJtf uOEfFygoHfw4sHk1rfBCN38h305SgXrphdFMv1eqyFLFRpRwUigUwJmIJ5gnMNn8Cl7H6KVH3GASL r0Q4wannJjnYKow60Eb3LJRm0AnMDgC6uH9Hf53EG/qhz/C0QWIbz5eFeIiWUtoKoUm5n9a3xSz60 cKU9vWmgasDn8YaWiYV283xZeUzdWEpPBsu7t58HCHdLfR7BXAARNzc8fwP7CwrEfBJmSbmLsDe5z A9JPrjVyliBsJ4PfWTMYToml7aMxSYJfgCQHvx2rGQCH+WnR5Z6a4DWKpbFhT/lgOJwg8+ptZRMrg 7bxwjhWA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r6445-0041QU-1j; Thu, 23 Nov 2023 07:23:57 +0000 Date: Wed, 22 Nov 2023 23:23:57 -0800 From: Christoph Hellwig To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 03/12] mm: Export HPAGE_PXD_* macros even if !THP Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-4-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116012908.392077-4-peterx@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 7CED11A0003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: uo5hpf7fezkrr3y1ia99gcxgfp5kaqzw X-HE-Tag: 1700724241-632541 X-HE-Meta: U2FsdGVkX19mICpUy6wwNJjiFUUjphIDyF9MRjkYfxSdbrrvFWHiqrK34zRPoNx/ORLIZNHyoBhtpe13tcVtoAvjsxq0yYXr9hW5Evqrh9s0jv8R6aymbdqiN53rJDQvmWvqYsaUWgUNGOhKLAQk89t3i1Swia5Ww0T5+hNY6dXWLnxjXYfTPveeZmxP+nqbURGuM3IXoA3100jQg0PAH7iENVaj4qZco6ayuL2f3+TE2rUuJfpOgSYYc91Xi7h9od/8DXqjGZZ4QeMyrHbgdxTzK62Qy3jJ4i5+hqQqc3TxZJBIq191py06j/cUSe8Q3w2XFXV6axjFfolUGQPSHDD3yJkRDlKbz7ZxpfMFPgDXMZlCZu+elYiramYvrmNN/U/SaADcUriUBiWbhuQy+840mF3tkh7mHtt+oTW5HLamh4FSglySIYoyZxmS9Z/+9CLXzuIehWlKcfMkcFMl8597/KJShoMM2+SElVRCV7iwRnnyMhTA2tNvKfwp5zzkrUPLNd8EtZQc0Zx2aQbqlmhOuqKrMic7jJQCEFEOf8QNpiC7FYeGp5dXvoUjCS2IIo7ZI32xGNZGQJivYmexhm1aJNpHhBj+3M4qdRG7NEZbeRIqw5rMTcXGcSLxfiZJIP7MhbWwWBH/3o4su+3Rv55dk4lv/hBO8v3A9NKsK0hdqcI+uoBVy82NqQglwdqNcCnBGIE4s1Yi2hoRIQ2CFligWe4b0E2CCjxeZbWsbyXQZN2Wrk7sNAMxqPUe/WCt0Jim4CGfeF9xspUcfWdJW6u5FV2Aw8vkaTU+GJtwEmE3k1U71Y5oa/URpRAVSH7kTXzag+1pKDHDe3kTbXpJK2xR3jQrtUa6pThxcKvRzdFkiYf6VB5vGsgY1kE5L4AbVsgbxuoePwAKhxT5aQCcVLEuk3PIVmmwCSo5mf90WQCTa4DkHKTXMOQ5VxG1VqkxFY+9yj5ntNtK9esSt5C c2EZ9+n+ 3UmNDYjn380OHWX6z6F1v5NhhWJqXtJsLByTmd3341veDGSj6m4NZ6PpvSMBqltmBxiiEl83UAaGhNkDOTUz97Z64NXTYnHuBqwh6+kRNqBAQbHJ6G/hdJsKcPjSA95i61tZK/LETTrNt8ePdDgUDyT/wluI+qR624OeluInZyROJvtheHrpfuefLHzx8oImlVB+clvJ4PMgZ5i2rcLAv60C3eSQRheW63jlwFJZ2ZK2OLbtvKzIF1l1BF660pwqje/PyQ81xG7FuP4TFrQrna+Zwe3seIJyxRRpZL0NzY+27ImFlHlqhHgm3BnlOVCHcfxcZMVyJ1mR1JUI9eTksxFU7s6HH02gnK1Wl2+Kq0eWeO7mPjw2Dua7syju3oKQAF54PO0xCPBviK5ABL8XSd8I7f5DGePEviuabI9xKAOYjX6+OxC3Pg7+XOeL50xnrphvD/2k3iyv+hAgn4uBAxvNLncOjBxIXaTq2BBdulPLBHwxba5bQQ1A+V2Ikxb1PnH3fENU7p/21nFRdDxbrQ1jgNVe7JS1NToBe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: No way to export macros :) I'd say define, but other might have better ideas. Otherwise looks good: Reviewed-by: Christoph Hellwig