From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC331C5AD4C for ; Thu, 23 Nov 2023 07:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15FF36B0669; Thu, 23 Nov 2023 02:28:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 110946B066A; Thu, 23 Nov 2023 02:28:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F40C56B066B; Thu, 23 Nov 2023 02:28:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DF9CD6B0669 for ; Thu, 23 Nov 2023 02:28:35 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AC9E1C10AF for ; Thu, 23 Nov 2023 07:28:35 +0000 (UTC) X-FDA: 81488391390.18.71E30A4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 185311C000B for ; Thu, 23 Nov 2023 07:28:33 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HGn9w41H; spf=none (imf20.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cFIZx1yogxTLlZGRvld5KeeBDD9lT1xUio7I+xCLOyU=; b=E2UoHCv/8Xm8B5EeOu97jzks3MeQLIWL+SenvFULDdr1xCYE9lTKbOYrDD5uFFeyxdoG46 68nEvgGlQJ/XlDuf/ulBc9S399GWDtd0jIEmcbQuncW9HYD0yWQrtcF0VBOypRuWMISKhv U6toLRooJkNVkMdX6fS0zaNZ9Usj674= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724514; a=rsa-sha256; cv=none; b=GCM4pfBNavzPAGP9hVIQFwEachI4hKqY/UjMiEwRhE6IpAE69LeQ3RKidHWhd/HAWh1jfl RR3zI71TnFtnfHhEK96OiPXV2CL4mwrrG+V4/8eJVsih1uJnsceSKZYDm0AVsa1lQpusA9 fXADnw52NgEwRoH0Sc+YrgnH+pBmz1g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HGn9w41H; spf=none (imf20.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cFIZx1yogxTLlZGRvld5KeeBDD9lT1xUio7I+xCLOyU=; b=HGn9w41HrtRpenjpgTwuLAegI6 XIG0w7jdu0ZjPjA50rnWjFlSrNtpbnWBwNAv8EY4b2qvqCe9MC1/0SHjwRBHnvkgWI2HYP7om3Ex+ OmkmxRqaxLOzO1gTDA/LZEfpucHPdqy62+SQFQZTAs6R79wcvhTauyGD+OkxIx96R92nAqse9/tvc 25sSai1Z8cX30vfR+DFAfCqW76EwOQJHAAtfP8QQRvVMrQ14lJJr46uyE4PwhtQNiQupZYAF/0vvK GAnWrqUv1KmKtHQjpPrylCqMaWB4D0AZyc6iyTwxsoX8HKWxT5DoAa0rU/j4CwP9rLx1lczhI36IL nlqpw0kw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r648V-0042Sy-0z; Thu, 23 Nov 2023 07:28:31 +0000 Date: Wed, 22 Nov 2023 23:28:31 -0800 From: Christoph Hellwig To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 09/12] mm/gup: Handle huge pud for follow_pud_mask() Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-10-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116012908.392077-10-peterx@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 185311C000B X-Rspam-User: X-Stat-Signature: mn7cwtwksotyjeobg89w9hh6kinmsksk X-Rspamd-Server: rspam03 X-HE-Tag: 1700724513-750130 X-HE-Meta: U2FsdGVkX1/fvJY6DO8e583S64TwQ5PP4IN2fQLMFQ9Ljby/L4aE5+b+URPEQf31h0SaZ3p493STZR0xa8K/J9JPLlWoR6hzvLY489oHHzpghjwPs7t7zbs4Ziu/XoqC9MW6HPFAVdtswKdA6fJCee+RQQFUYUBHQRXGiaS6Ia95sknHk9d8GTY+HA9opuNcXpqMoqX9w6CciB4e7d7p30CYyxCnqwkZk6UZatXY8tsLLo/ayWEYXHhspNkRGCYnhkNEdYZAtkkKNqI5Fl0MLiNRNvzWD6/0EV50r/cpwZr8cQ9rsKK2USiyfXsohn0pqnvEcPV6cEQS9MdmKbPImttinSOq3D7TH96RX34HXeV9NQfgtIgugoZ/A452AO/oDyZLtNH50L47zteD/iPjNlYq3BE2FOXn3UsIoL+AiqbSfB4UolVWFVzavkXOEt40jtRtzo1HOZ8Rx4YnX/92C5r2OaKx/0nuqBuIiCK8XAwD+Ch3i5IDoxySnunkMCGhJzRbp3uYNARbg/VzT1m5pgfyZPeqkjo/3BmxI3vbFX3E37VDR8PIbE9ushBVriUuDIh29F2bSI8P1wcc1WUEBog0rNFCEgmKRXO72tOOKq8/FIwtk4I8qhNoxV0b1MwRJzord5lBZ0VmATiI3/i1Z7/AZrkxOvQtm+2C/gz5BHFO6on96qxcZtAmrWa0WRXWgZsx8KvId1qoJrUXfezGx+0DNsvOw/Ju2Ebmy98qx8Kao41QxrcXwPhEiT+uzJVtYQiMvyeho735gkzwVJI0xmAMe/O7xPdCrun3T6NQ+N6JzGAsQnaZ7jqx47thW42vvzECvFVYI3aID8Jea4QG71sTCdSUKPHYO+KJJKC8cH67EwBx+/WgwUXaExKBs7A/G3Y+uGfXJpEcZfludMYhnf3aOyTuFR8PxJdlhjsiOx3LgCiFY8gX+ewU8mM4Cd+onrhSwRsjfiQBtQmspmA sWCTQ0nq KtELVjaNhI5jep7Hf7aHZIRrvQPuuKl4xG4OkyP7SiBgNjf67rGkfzKibQ44VmOIMpzi7YBfZnOICNb6T0VjmYS1bYUNAmOFrVrVNwWWehBhBoQ/Q3E++Czn3B6hLTfRRKRCNksOloVi0+4Zt9bXKvotljQGFWs6UgS4I8y9Z4MvM5GfmIebxncaznJKOE8F8nJRzfJksy0dSkGU4Nh+wPi3QT4lGW2YTRuovflig7O3mg/ZnKxXrQIqUBYNvUpjB++41tuuYryOjvDChDC6s9XXQoOWqsjltcceCZimmPgPlpTtN/Lw70BAaJ4TBOhmkIyVd9hjsUwOILmdrMjdYO5wVhm+gEJocExbhIzDtr96AxItph2jL3VORw8xuTyT6lUWhMS9GikezqH+ALnq4dF3sE9soBW/BpFXrwyfTUFThXqqP/sv4OjvU7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > We need to export "struct follow_page_context" along the way, so that > huge_memory.c can understand it. Again, thankfully not actually exported, just made global. > @@ -751,24 +746,25 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, > unsigned int flags, > struct follow_page_context *ctx) > { > - pud_t *pud; > + pud_t *pudp, pud; This adding of pud while useful seems mostly unrelated and clutter the patch up quite a bit. If you have to respin this anyway it might be worth to split it out into a little prep patch.