From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C9F7C5AD4C for ; Thu, 23 Nov 2023 07:32:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E1B66B063D; Thu, 23 Nov 2023 02:32:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 890946B064D; Thu, 23 Nov 2023 02:32:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70F6C6B064E; Thu, 23 Nov 2023 02:32:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5B14F6B063D for ; Thu, 23 Nov 2023 02:32:38 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 392F5B69C9 for ; Thu, 23 Nov 2023 07:32:38 +0000 (UTC) X-FDA: 81488401596.30.72C1017 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 92668140003 for ; Thu, 23 Nov 2023 07:32:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1SKOsh9G; spf=none (imf23.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700724756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d7S/FKalzXE2uJiN7XbTBuXkMpogj8oWwgyCfRleg4Y=; b=kFvCSTL2rXSJV9VD+TXuGOM/LhKXUNACWDCeQa8I6n5N/hdzNU2el23ys2IAWxxlqaIsbY EqxyAePIq5BhKIKZspJLxGfMKOJUb9doFplU2W1pf5FhfTuzfAoS81w+9+m6mAThbJB7IH sJtzYTpgQHSb5GF7Pv+fPf7WP3+Rlis= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700724756; a=rsa-sha256; cv=none; b=Xt+2Qo1OlzTVJSFY7sI41NbMvkS/TNgtTGAUtv5bcKu3vBl8Er4qkJy731XkoSuUHjIa9E 18bDmdETvkOSRYFPiidyS63JhEJkd+fhcYRtwbJGQ24zEwXR0WqIEt37eWISwk4q/ZxZ8Y bVjg9p93sic4iiQv0FHPfYeRxGjJDL8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1SKOsh9G; spf=none (imf23.hostedemail.com: domain of BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+979ba4c0e07575382778+7396+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d7S/FKalzXE2uJiN7XbTBuXkMpogj8oWwgyCfRleg4Y=; b=1SKOsh9GVU8iqvK6R1fOs0sh2s CZSBcnZ7pXUvGsWz+Fb4qq1jTzZWzObgWnxlffh3BMb6ZxMI2zWRJE660LVnqHzZu7+i9rFd0bTXL 4MCic54La6hsZw+eLdvJuCO9RPKQRPEnpGSMNGqGkYT+oDb/RIgvd96C2OzvhZya1aW4OlSZgfLUM k6+y+gbJgCZru0pSWsHcf/UnhuzCabugOeEJUNAchUOOBcXVaIgsZ9Tu/Jn0Sr16J5FJymlFmRr9s 2ClOaRjsxbEQ18DwIdODqOJmMA1gXC6hrdaA+bNVYdv9YrqW0hCU2uTQt7dGDjDNpYWzdYDU8wLlO wzGESUBw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r64C5-0042og-0b; Thu, 23 Nov 2023 07:32:13 +0000 Date: Wed, 22 Nov 2023 23:32:13 -0800 From: Christoph Hellwig To: Michael Kelley Cc: Christoph Hellwig , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "kirill.shutemov@linux.intel.com" , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "decui@microsoft.com" , "luto@kernel.org" , "peterz@infradead.org" , "akpm@linux-foundation.org" , "urezki@gmail.com" , "lstoakes@gmail.com" , "thomas.lendacky@amd.com" , "ardb@kernel.org" , "jroedel@suse.de" , "seanjc@google.com" , "rick.p.edgecombe@intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v2 3/8] x86/mm: Remove "static" from vmap_pages_range() Message-ID: References: <20231121212016.1154303-1-mhklinux@outlook.com> <20231121212016.1154303-4-mhklinux@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 92668140003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: y3nbfa9yhnzdb3ghsuqtoudujqx4wjzn X-HE-Tag: 1700724756-608438 X-HE-Meta: U2FsdGVkX1/qrGv6tGzlNt5o6xX4EBYEYzsqkFkYXOlELI3FXlkN9Dhq7bDeT565709UEw3xUptNNykaf/PKqeJw5f/VQrvlXqDFIiK9AdxJH55FNi/uavk7E+9kZz18fhlMmtZJVBpS00ZTwdA/P3Hi3q3C37XbQqVHwmhDpu5PGHv+kQgRgc3swn2QGHmmRziW+aRPkg9gqghq2Z0aYcY443Ka0eByy/AiYY4Re/msGylAumNsxjvUXFfTN9zt4qO+5NmQct6lz5m7MBW782J6QSlg/rDnhN32nw2vSnk051jy1R8K2jJyLJn6m3du2N824qdNW18dhwJV6IB8zZtUU8uIbgFTqgb4sWxZZbZz2GAeBrvIznt5+fnrzCLhBn8rmt4B0IVsakhfWATXBypr9ZJ6RStcW3cz7Asz97zRN9ILuA5egObYzQujgqictTZ8FgU82f9c3YuZHup8mezbafEcmGlGEQTz/38OPynACyYdBEYJ4DznvFYrMtKBEuoaAVd2rLZh2ee7Qx+xfENEIGzJvv/4hfunmby5aPFyNabv6S/1wuhfSj5pQsxKlrgC95oDfj54a9lchoSYBVc8xC41h/y0w2XYvMsGODVX60nMri9O6ETFjKXJ8bU85lRxMOEGNqMxPO1GTeH1NIwA5k1skPIL349iJgIoyqsZLF6NC3LoaiUg0/7spC/A4F00TgUxj8UuRAA+lktYVyNk33Jcd7VptK9gmjM9yeCMQPCHIFOxQqWdWlB0GnRKBdpWQFGdPsDnlP5CjQVL5At7f+/70yXUYP3ThMupEQyFh+6/QQmDOexF4FSOxI3Rz5fMLV8Rq4x12Ar876d/dlhh1beesxP2HW0JjQcDToT/idWqffLJoPzsCXaE8ChCY0acBWz90vkhyN9lVky/mZg3heUPkiQl+I0XLMkRtZpmukY9TXnwFwxVrcHmxS44iLiSNs1GBgFXiDwTXXN lv6Pq6tv 0pYNpiyBjlG6SsjYKSbs6o/4YmiQgfIoseetL7g0hKdp2lbCGFzHtLNJt8O+YVV1R8O8URqveDMY43MJteIWENTuDbZMgPWczML/5v4c5+hqO+PQckXuFcrJLyZzBqDt7xXRTiegRMyrt1EG7nYTqTL6aXrhT7KmHFqWvG1VgdrBjech4mUoJyzmwK5vf5GF1KDRcnQvUgaZsbkVaxIQvIYObTwQ1FwnNMsMQ8m9YMiMzfXik7Pxfp6xVyWttRJi12XyoxjY1qc9Pu1N3KlgKRRw3+cZMMwpLYHxEYAOpgrzJ2LzDPDGl+EFmJGGOVDpqmMI8g2GXClr01rv5CKrZpPNnEUBJm7psNVte2O5UeCWrVgPlu5at5umSbi/27GVDidwqB6Gtx3dCJiD+Iza7R2EeALHxxjfvJRaOmcswqb4hoSN4/ZoeT3b/MJbpOmGgINbdlZFyzyk2TnLGk484/dOLb+st4rxS+lS8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 12:24:49AM +0000, Michael Kelley wrote: > > I really do not want to expose vmap_pages_range. Please try to come up > > with a good way to encapsulate your map at a certain address primitive > > and implement it in vmalloc.c. > > To clarify, is your concern narrowly about vmap_pages_range() > specifically? The prime concern is that it took a lot of effort to make vmap_pages_range static and remove all the abuses. I absolutely object to undoing that.