From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A91C27C40 for ; Thu, 23 Nov 2023 00:26:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D3938D0005; Wed, 22 Nov 2023 19:26:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1844B8D0002; Wed, 22 Nov 2023 19:26:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF04E8D000C; Wed, 22 Nov 2023 19:26:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DD4098D0002 for ; Wed, 22 Nov 2023 19:26:08 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9209B161788 for ; Thu, 23 Nov 2023 00:26:08 +0000 (UTC) X-FDA: 81487326816.25.5119D59 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf28.hostedemail.com (Postfix) with ESMTP id 46B42C000D; Thu, 23 Nov 2023 00:26:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V9TwdeRG; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of zhenyuw@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=zhenyuw@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700699166; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MfeM5pDmGQkU41GtCe3qHTN9EQmixR/daGjlJECpUxY=; b=Sq5dGKDGGtbtRv0iiRavdZvqVZA0POQDRYvLvalqo8D8eK1yqMvTm9oZGI7ZtmDrMYuM4p 08SIGnH+frb4CeQSrSHDSLQxY2o5nsYDfHmfrcL4Kn4EjpJUplRxAoby5wqIxeP+hn0DCV WKfncQWqifXwiZoNL6dv3BGa9c6VL5g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V9TwdeRG; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of zhenyuw@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=zhenyuw@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700699166; a=rsa-sha256; cv=none; b=QAXTTV8To05c0uIRIxD1R7TQQ+llgKz7T0YVQTP9+gRrd9I8O1wmr7fFqzMpQpUOTaXABW 05QJ5iULWJ03vYVqbekuCuBfavHmCTbdiMBEzPz0uQJGRKaw/qQx/KUyFmnRUj3NOqqtSG oii9d+gGpYF4G8zB9rYVYTwjOamI+fo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700699165; x=1732235165; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=kMJqNQrPFkouBUmP1tIxtozSsYheDkR/LnL4F11wiis=; b=V9TwdeRGIyQC3s7DyWk4UYRiN7nlWjii1BMAWINlGPxxtsIlZuVzksJr C/Aml+Oix4A6Z6YXpiGKI+r+IQIry1oxlLabqAZfqfU4OdKz9WXPjR1nA 7Tqff0PM15Yl52VRG+qy1M1F5PJtO/9WrRj7O2utzsHtUoqRysTZzNCE8 S2FEvu2AfmcN+lnCRTVr/HFYO8M6J/NrXLNiFogMVJHu4MrTYo4D4206M d0hnVW+P8oc7WAF8MkopbGaRF3Ijug67f/powfX8M5XKwP3kvYnjy6OPS pJ25aYkXaGLGafVZnYw1nDZyUcs1kC/KzvSEiDQ6Xl5lp+6tbM05tlCem g==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="389323025" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="asc'?scan'208";a="389323025" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 16:26:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="716903060" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="asc'?scan'208";a="716903060" Received: from debian-skl.sh.intel.com (HELO debian-skl) ([10.239.160.45]) by orsmga003.jf.intel.com with ESMTP; 22 Nov 2023 16:25:45 -0800 Date: Thu, 23 Nov 2023 08:24:24 +0800 From: Zhenyu Wang To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, David Woodhouse , Paul Durrant , Oded Gabbay , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Leon Romanovsky , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Diana Craciun , Alex Williamson , Eric Auger , Fei Li , Benjamin LaHaise , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fpga@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-aio@kvack.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [PATCH v2 1/4] i915: make inject_virtual_interrupt() void Message-ID: Reply-To: Zhenyu Wang References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> <20231122-vfs-eventfd-signal-v2-1-bd549b14ce0c@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ehCOKC0wDaVXxQlM" Content-Disposition: inline In-Reply-To: <20231122-vfs-eventfd-signal-v2-1-bd549b14ce0c@kernel.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 46B42C000D X-Stat-Signature: n7eua91dajxaucex6em3pkifr5w1q66e X-Rspam-User: X-HE-Tag: 1700699165-75596 X-HE-Meta: U2FsdGVkX19tx3iujaocUiyP6QKAh5j5Y7cE5VsiYz1+12EnH84qL7QqwZewTOtkNMtOXqAihLhsTnyQyGKimRSgCzGG46qHO3iBqdjnbtjKvacyBAF8uPHM20nvcE1zxpx0lARbMGZlB4ngyHQxhzeMmWMjM9vZJI9DcRWEjieu94je91vDdoz2DYOsRpURkADi801bp9CywMQdy9PDSqOGr8Hixf3a1q87QYKpIEvYxcoPHRDXcl+HwiHWlMIvhHLdUWJ6n99UnrB90O9q1xjfpdhtx9UuWaKE2CJBXfj8HbZZse4aZkduc8EW1LKPwlZSSFhPNXRiZxBOZpCGQI2DLH9S/SPUHsFZ+UEgFF5fNi53rWGLcKJdroRMDoOk9AdgBH6FvTQ1gnZyVokBJchkaB3jp1cc0dzKDuOG28A8SD5YRXvim3vPWLeC0gtW0D4i6q9WYOY3wDWEFAVUl+rUxWrb2kPmHaH2hiLdPxj6IB/jOhn+4Cn5LjcB7sR7w/PZkjg9VGWcnHfvlK7mdFGwSRB8nKDBgVCk4OBUQJXVa7UtpDczwaJIPnUnZ8i0VdgHduCAGV7F9THbnItel2+oFJeZ6E1oz4LlQJzydi51LbBezlv8NP2/GZCqMzW8pvRAU7kO0zcElE7xZWtRkmJJ4MKBJlK1s4doWWxt3F696lltqOSXfI8dmSMw0EcS8Nj47vU/RjnbBGDp3P2MStmWOoJuofcosahNM90S/PkbmtWT5iub+wGoO6rzCsmqnA7eFMvCR2E3E9U/krOsIdFw3OY/gYyy7vapi3OsOi5lgSbBb0+asrBEAXtQrgyx6Dm+AF0HjN4dFgoetpbxbahTc738e+DcI2E6vWIyK9LOcOAIhsDpyJxG+w3pXjkkfDSK8ukrcmc6VRfgLmMbjgf+M2aExUatKrPT2cOaL5FvSiQCS5KolxJAYxDUcQ3tl//YWyQErxa523LAi6/ Vo6nWeMo B3tTM3NyT5lvGDPyCzcCrWIhYon6SnKNTEMiL3KYhcgKHA5SZxcj0e4j7axg76+dId5uWUqqoipkj7JRQfvaKTliV/ugDTJjumNSf1PBkZ6ryhge431VrEBb1Y6lqorRf7I5Qa0RZrr71cciktPnfRbiV23q4eJb55Gb3ahYMAmlu7c/pFAFtNGOGqLLmbMrsnSCkpM+S5ysjcrfblePDcrsRIMU8tB55AcHgYSzyg6EG0je3DgION5uWcORZty3VhAwQvV/hphe4XEjpV44ZrhSweGAN4005yYrmKEks0oc4fzhFRKDFUIrhBXMy2uSTSUD5K5iOhUgUNWn3djxCquYs65I2A1ThzhVlaadFafDRULGO67gbzthC6VOHNAkBZUMy2Eq+nqL8S/UuVgkUKPMON3OoPWrrdIlfS94WjqSojSmHX2EzHcdgN8eduAslfn3je8J5J/RlarA3ou+GdC5RUiIMfZ+vlTvnem0i9AQC9+sWXGK5y9YTDmmxvnkj5jIBnrckD4/08lU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --ehCOKC0wDaVXxQlM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023.11.22 13:48:22 +0100, Christian Brauner wrote: > The single caller of inject_virtual_interrupt() ignores the return value > anyway. This allows us to simplify eventfd_signal() in follow-up > patches. >=20 > Signed-off-by: Christian Brauner > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/= gvt/interrupt.c > index de3f5903d1a7..9665876b4b13 100644 > --- a/drivers/gpu/drm/i915/gvt/interrupt.c > +++ b/drivers/gpu/drm/i915/gvt/interrupt.c > @@ -422,7 +422,7 @@ static void init_irq_map(struct intel_gvt_irq *irq) > #define MSI_CAP_DATA(offset) (offset + 8) > #define MSI_CAP_EN 0x1 > =20 > -static int inject_virtual_interrupt(struct intel_vgpu *vgpu) > +static void inject_virtual_interrupt(struct intel_vgpu *vgpu) > { > unsigned long offset =3D vgpu->gvt->device_info.msi_cap_offset; > u16 control, data; > @@ -434,10 +434,10 @@ static int inject_virtual_interrupt(struct intel_vg= pu *vgpu) > =20 > /* Do not generate MSI if MSIEN is disabled */ > if (!(control & MSI_CAP_EN)) > - return 0; > + return; > =20 > if (WARN(control & GENMASK(15, 1), "only support one MSI format\n")) > - return -EINVAL; > + return; > =20 > trace_inject_msi(vgpu->id, addr, data); > =20 > @@ -451,10 +451,10 @@ static int inject_virtual_interrupt(struct intel_vg= pu *vgpu) > * returned and don't inject interrupt into guest. > */ > if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status)) > - return -ESRCH; > - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) !=3D 1) > - return -EFAULT; > - return 0; > + return; > + if (!vgpu->msi_trigger) > + return; > + eventfd_signal(vgpu->msi_trigger, 1); > } I think it's a little simpler to write as if (vgpu->msi_trigger) eventfd_signal(vgpu->msi_trigger, 1); Looks fine with me. Reviewed-by: Zhenyu Wang Thanks! > =20 > static void propagate_event(struct intel_gvt_irq *irq, >=20 > --=20 > 2.42.0 >=20 --ehCOKC0wDaVXxQlM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCZV6bswAKCRCxBBozTXgY JySHAJ4qE2jv0i0ZauQv+Bv/bGwHt0ZrbACeJadIIL6gQC6kmoICLhyqplCwOeo= =1+t0 -----END PGP SIGNATURE----- --ehCOKC0wDaVXxQlM--