From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD18C61D9C for ; Wed, 22 Nov 2023 14:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EE026B01A7; Wed, 22 Nov 2023 09:51:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73B906B01A6; Wed, 22 Nov 2023 09:51:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43FDE6B01A7; Wed, 22 Nov 2023 09:51:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 242316B01A5 for ; Wed, 22 Nov 2023 09:51:45 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E87F21A0C25 for ; Wed, 22 Nov 2023 14:51:44 +0000 (UTC) X-FDA: 81485879328.04.42B817F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf17.hostedemail.com (Postfix) with ESMTP id 598EF4001F; Wed, 22 Nov 2023 14:51:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eNAtmNsc; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 198.175.65.9) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700664702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=26nxW9uboXsY9UEUg+2QdjIf5aqgHitBlGGseDfd54Q=; b=wIkCzHxXyhRhi69VhGkBuIGIPUdop8t0igpw/1M446bGdXEqXNX7lS8KTVyBAC7P1WZicM z3e3CZNkKfFOBMtr43rD5FZN44jwE2OR4raky/CHDcyoonzLfhgiFqe3t3ThTf8rXymryW FZUVGGSmJVWJ4UAxwuJNrz5Sl7SYP8A= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eNAtmNsc; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 198.175.65.9) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700664702; a=rsa-sha256; cv=none; b=zAsz7jbdXAnVbgH2KksiL73UNQ4ilcvWTwgcaxJYP1LXrmiI+/k4J3ZUTZ+Zi5QHVGM4bi 1DC5femEhIgBl9Fn3hhCY9bjBxirtLAs1At/qfxlquHs9jzsGdQPDIyz9DYjvUMpj46MKI eGKW7O4aw9+xUjx8RIS+LSkuXwoko9s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700664702; x=1732200702; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3Lp3IDM3ar4jYOzHbknAigUjAPfa74EA/HlhJuCNIfU=; b=eNAtmNscaJTe8CMwrAV3+nxQdYIaonSHUjF6TnitWnAvqu606iHshhON ZbMYeSIeiXODrpFSob0rqVYuBl/BGgfUTW1m5+cO9BjUG3lEgBlXn0y1Q FFiNCaZ+Dpw7efnJbC3raelwu99x6wbI26gGJP03xdrNGGzAWBQeECZfB tj/bgA2hMWJc/RwEQ5KOm8zWhQIbx5V5fMlQljLONMNFMC8fvMk2GEJ0I 54MHG0gs8EWsTuu4isd4c/a682gGgwfiND61fbRvwSy7RKL3Q7liShSna oig3HXu7fIcfm7eF21EF2MelarU5DOi4oEjJauZZxgZ967GWxtepBQ1TZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="10729207" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="10729207" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 06:51:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="14944713" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orviesa001.jf.intel.com with ESMTP; 22 Nov 2023 06:51:20 -0800 Date: Wed, 22 Nov 2023 22:49:27 +0800 From: Xu Yilun To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, David Woodhouse , Paul Durrant , Oded Gabbay , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Leon Romanovsky , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Diana Craciun , Alex Williamson , Eric Auger , Fei Li , Benjamin LaHaise , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fpga@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-aio@kvack.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal() Message-ID: References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> <20231122-vfs-eventfd-signal-v2-2-bd549b14ce0c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122-vfs-eventfd-signal-v2-2-bd549b14ce0c@kernel.org> X-Rspamd-Queue-Id: 598EF4001F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: myjwzxf9zq87uux9yea3qb4cjarsfkzg X-HE-Tag: 1700664701-181014 X-HE-Meta: U2FsdGVkX1+zDz/dTJXqM+rJGdgMoPqGuPEQku42HYecVm0a1SDQ1T2Q/lR/C+KS7+kbFM13pUM0MXUMET8BQpn3tSr83Y5bYAv2yif1FxNhzFsBin8oRkktwX0gNKN9gbjInhDe6dluY2xgGFsSnry3jWaHiymSnrF+z/c1iFGaJFdEctYsxP1ZKWSD5+LG5/cXh78nevAHeZUeGFXc20IM7z5z1ldcox2uFVzufa3rXP1cUh+SEl5c4QrP44Cu201QYHI3Qv+orbZ28jJkbS94gTvFsRinghFIza39Fh3xII9rw12KoxVMlIwgD5wu37OWugpzouaJJi4K1Uwj90DG5akO7cd1GJ4wl55lBPo6FfWz9PVPuo6epQ4pWgSggfiWcIlYsSLcjBqdmUOEZjyCyZDqLP9wVFOG+/FI1NQvlb6IROky/BVw891mdnRjOAVPzXFyL8AcXDH4MzOeRT7nrDboVn3Er/HAqQIiUoETsywwIhZqPxJMqoFhyF598GRZdp8bGV83uY3bCvCwyGcPiWZ8Pbsv6VdiCkxm0RhU0dnoFA1d+WUrD2+cHn6+FIE3HdoO5zDcSRGr9+Wez/YrpWSulwt+YmxPzzmyZlGNFQJ+61J2/MFGENy3wD5ZkLSR15U3F8R+eoqQc4FlMNaG7BeoZaapDVJAyztWDCgbRBr2DUZrVtgI19gOsr+jdLa4zHFy9KNUIzKZzU0Oy5P4WK23c9aFASuqYm/fvDI37BjFoLngO/XOSl38ihNmoWubXMgdFEdx2rY6DhchjckaMZBEOfhLwCcYWEfIOdunfpytKbaj6ImlTvfIvK5+iuXGcxQmvqBkhI/FkaRJuDPAo16rtyGSY1nQZxRGmqZnLijScMHXLclqxMY3e1X1IjUbN9ZAFqSOY9MhY+gcJAG+W7gfZZ+3rVAF7KRNJao5igfU/vMF0ugaYeE4/RZcqX59qm7/bKHKaE3I1TL 1KKlNPFH 9IIUrYL85gPYag79tkFppwFal31Xq/wCFfdrLayX9+2j+Ha0dDCC8YQ37/9qTi4ajPr0tsIDu3e5jRfDyiYJZ70jxmlZyd6HAskufRrTTXolqbFu0HDYZJ5J+/V3cZ/w26DOr+g/bPfwhJwjbcu8t8cps1B5DvOfiEccB0bD5xhR8TnbPanoeXlj8cq1aosMwSrKFUJoZwVE7ZPQRfBX47AZO/ReKAniIe99rjuMAcAj+/uTkSCWXfsFgbysZU455MWgLrrFoX8PBPt8WuauqKt/+jg3XERArcj6t7RDM7f7QsVmdn6TwtVCkmcnUe2Z/0uuVxLynbdSb/zuNSnEcavsKXzKxHhG5cObs3NlEe/TmStk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 01:48:23PM +0100, Christian Brauner wrote: > Ever since the evenfd type was introduced back in 2007 in commit > e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() > function only ever passed 1 as a value for @n. There's no point in > keeping that additional argument. > > Signed-off-by: Christian Brauner > --- > arch/x86/kvm/hyperv.c | 2 +- > arch/x86/kvm/xen.c | 2 +- > drivers/accel/habanalabs/common/device.c | 2 +- > drivers/fpga/dfl.c | 2 +- > drivers/gpu/drm/drm_syncobj.c | 6 +++--- > drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- > drivers/infiniband/hw/mlx5/devx.c | 2 +- > drivers/misc/ocxl/file.c | 2 +- > drivers/s390/cio/vfio_ccw_chp.c | 2 +- > drivers/s390/cio/vfio_ccw_drv.c | 4 ++-- > drivers/s390/cio/vfio_ccw_ops.c | 6 +++--- > drivers/s390/crypto/vfio_ap_ops.c | 2 +- > drivers/usb/gadget/function/f_fs.c | 4 ++-- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 +++--- > drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 2 +- > drivers/vfio/pci/vfio_pci_core.c | 6 +++--- > drivers/vfio/pci/vfio_pci_intrs.c | 12 ++++++------ > drivers/vfio/platform/vfio_platform_irq.c | 4 ++-- > drivers/vhost/vdpa.c | 4 ++-- > drivers/vhost/vhost.c | 10 +++++----- > drivers/vhost/vhost.h | 2 +- > drivers/virt/acrn/ioeventfd.c | 2 +- > drivers/xen/privcmd.c | 2 +- > fs/aio.c | 2 +- > fs/eventfd.c | 9 +++------ > include/linux/eventfd.h | 4 ++-- > mm/memcontrol.c | 10 +++++----- > mm/vmpressure.c | 2 +- > samples/vfio-mdev/mtty.c | 4 ++-- > virt/kvm/eventfd.c | 4 ++-- > 30 files changed, 60 insertions(+), 63 deletions(-) > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index dd7a783d53b5..e73f88050f08 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -1872,7 +1872,7 @@ static irqreturn_t dfl_irq_handler(int irq, void *arg) > { > struct eventfd_ctx *trigger = arg; > > - eventfd_signal(trigger, 1); > + eventfd_signal(trigger); For FPGA part, Acked-by: Xu Yilun > return IRQ_HANDLED; > }