From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752EEC072A2 for ; Wed, 22 Nov 2023 06:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F230A6B0564; Wed, 22 Nov 2023 01:20:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAAFF6B0565; Wed, 22 Nov 2023 01:20:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C5D6B0566; Wed, 22 Nov 2023 01:20:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C18276B0564 for ; Wed, 22 Nov 2023 01:20:57 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9E8A8A040C for ; Wed, 22 Nov 2023 06:20:57 +0000 (UTC) X-FDA: 81484592154.28.16CAADE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 7F822100002 for ; Wed, 22 Nov 2023 06:20:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OynjtmZQ; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700634055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/cYE10pQhZn9hOp+ZMW+N4doTFUbECzoIMfshVyvGDY=; b=AG49BT9UwNpQBEPNH3LJcvwj3lF9Z970FzPiRJWOEemdjd+PlSoJMpMGNGbEG/d0U0JEcA TJOXhzMGWcgqLtZjTxPdR2H8KDol10jGMbpXZnnv15J3wzeQy86scrfxVaG2XOs70nqU30 ljByfTZtjpSgWw7Z5ewQ+rmS7WfgM4k= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OynjtmZQ; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700634055; a=rsa-sha256; cv=none; b=yp+0Sdk0dqL5xB5x+qoUPrlxUmLfEm2d5k/qGG8bVuoXgLRwFvcQ/ZMUmiG81/VruVCknN vH8ZMqo1TlW4GDK9VF/BtG44H6zc4g7kJ0PceR/mORcKts4EJZXfyG8MhRBbS0E3xwKArf 4pnXsgx9UR9bj88F5LoL6tOWDgSMtvU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/cYE10pQhZn9hOp+ZMW+N4doTFUbECzoIMfshVyvGDY=; b=OynjtmZQLAej8/FNfkpV0sngDh /Lsty0gmyOn/1alVikEVLx5fJAD1nqbUAbWZS6lizITR4UhWgH6+rmZrpxro0hDsonvov1dvlm4BW LFfwQRDr2qjGHAAi9ktYO8wJdLhy6/CyjrORHXifUxdfMBf2TeXm5vKplX+HzR3oteydJO6EtPxVy uE0ApIN7gBV7W0J2Z6bRa7cDd06HyXP8QHpwmHzv6OVqP87w58/H5eMJkepsZ6tVuxzAuLd3nR2ZT 8xjq1aqT2zxRSroI6eo763NLPHcKOWGSmcnObBpKWlVVM3hn8n3Hd5h3Mhd7N6ozl+mtVQCIOhjFL k+6M33lA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r5gbO-006HGc-AG; Wed, 22 Nov 2023 06:20:46 +0000 Date: Wed, 22 Nov 2023 06:20:46 +0000 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , opensource.kernel@vivo.com Subject: Re: [PATCH v3] mm: ALLOC_HIGHATOMIC flag allocation issue Message-ID: References: <20231122013925.1507-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122013925.1507-1-justinjiang@vivo.com> X-Rspamd-Queue-Id: 7F822100002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hmxjgo53q4fxey7gz7tunk744mzjr9ru X-HE-Tag: 1700634054-757374 X-HE-Meta: U2FsdGVkX19UNodAILQTFDcWx1mhkcZqEKYcZqzWQNiOnhRxkVaD+sgHrYUoR0QpOqf7+CFlit3CGcDAxgnP9AiccfNhF33bz0D1sgmbfD74xBy69gjJP+wF5wqv1rYyDmPQ5tuSl+oHXO+7BoQ3oLYXkup3q86S6R0iYMbfFmSdqRii9b+X0ZQkyBk8nbrlhhsqjFSt5mL2/0K99EdVx+DMeK6RDJr7u7VV7zluJOF3mLPgtnKuY4W0AWMsRpjZ9hvw/6Nc4rW226P2NCkoJNsjywCnlLzDcGcNu3BHIv6qdbPBq2Pcq2fwX7pivK6rTZBXvMdRXgdDII3GT5G9p9gcMp//O6MRHbS8yljNSDSqkUVFb66CTRALSgVGttwOiK3/JA16q2YCndWxXBbLtE6WSciOtY+kDTFjHxjlozkaSB1jyUSuhJmtYSpxhj3VsFbGgs9ZgOEZExER1Tr7zyMADtW2AyymCBvE3aKuJeMAVcIotigWRIQz5hHlIHyGwij9jzbaZRGGcMPp6G/chWl8Z3Jm70cKNYslfo3dj3I3JSAW/G1KtCOh+srOhropM5fJ1RtjQ1rUwA0V+dvMqhg0uJ7YZEaQ5MugX0aLccaIuV4Z2bU12qmkdAEVjmZy9U/5SkG6gaOCAqzZJUonE+yKqbiCj8AGReA1+la7bWeJ58WhZo3R6uyLtdeoZp3ZIFZE7WqBrkPLbQD7c6tLlzlzZLFoeuxIaMQcp70P1pPD6bR4cJLsVbH8+IM9qYN0HcMVlpuOeApH6I6xd2ysFd2tY97W+8GYu0XyEU4EG10xP/B2N5As1MJfIeut7lWSGSYM7XQsgaEPXE3LZqeJUEvgIqfWVt5V7sXERbhZUe0NcKTqhL1cjivj3zjdkNxNNjqFB2PSX0Cf95eiJkiN/XYmN4VTd/dFV6+nBGLt1EHoEqJi2xy6cLUTuKMAJPAKnCYSORiEP7EnYyWqsTP qBH7hgrQ CGcZR2+B4U9xPzutHHSgsfcv2uTpdyFWtVs1LidWtGr4NtUkW+ECqdit+8l+puM1QokHmqZhXWl9zr0DfUGAOzykwSVm5CJpJHCle1qjVUcOLIDG5Rm8bjB+SdkNwQFmmc9juD0jl/ifygDA2iqw3rdyjeM61qUw6Im/k1z5TGqtKfCmMPcShEh/5Lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 09:39:25AM +0800, Zhiguo Jiang wrote: > Update base on the latest Linus' tree or Andrew's tree. > +++ b/mm/page_alloc.c > @@ -2851,9 +2851,9 @@ struct page *__rmqueue_pcplist(struct zone *zone, unsigned int order, > int alloced; > > /* > - * If pcplist is empty and alloc_flags is with ALLOC_HIGHATOMIC, > - * it should alloc from buddy highatomic migrate freelist firstly > - * to ensure quick and successful allocation. > + * If pcplist is empty and alloc_flags contains > + * ALLOC_HIGHATOMIC, alloc from buddy highatomic > + * freelist first. No, it's still based on your earlier patch, is it really so hard for you to read your patches before you send them?