From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29731C5AD4C for ; Thu, 23 Nov 2023 17:22:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 802DD6B0674; Thu, 23 Nov 2023 12:22:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B2EE6B0676; Thu, 23 Nov 2023 12:22:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62DE16B0677; Thu, 23 Nov 2023 12:22:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F06A6B0674 for ; Thu, 23 Nov 2023 12:22:19 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1A7A814188C for ; Thu, 23 Nov 2023 17:22:19 +0000 (UTC) X-FDA: 81489887598.13.9A93065 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id EF05320008 for ; Thu, 23 Nov 2023 17:22:16 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I8ZJ2h7A; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700760137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KcpnTT0f+98xbE3/g5MCgDaaep2Eqio0fEdLtHv5RPs=; b=QqVpuq683pgRlP+VLqNf5ffbjiXBgjdj16lfsOw8acEYbsNlFmmg0NiQS6ZR1alOkHxurP QYzmTzoNpM+3aEkaluLhYtLxEuvtEzW6h4dgeHmHAJUCv7WaCkFioOb3f0hCMIaHxDMVQP 3WkAPFHjLRRAf7iBT+UnMP/0Q7vG+e0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700760137; a=rsa-sha256; cv=none; b=5KrixQ3qn+WJMLwb2YADwV4VNvJ5czjALJ9FikWtI3sv4w26YQPoFUpGiI25XTDe84HISN s4E3mps04fH7rwHseY/61H8za5Okh8Qra1jiF5yLBCi5p5JM0tQTo+MI/10+hwAzTIBCpp x00KY8ZDxyUG0JqkOk7NsxoNRe+2XCc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I8ZJ2h7A; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700760136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KcpnTT0f+98xbE3/g5MCgDaaep2Eqio0fEdLtHv5RPs=; b=I8ZJ2h7AaT766iPN0geurxhX/0Yh+izuejW/FCC+aJu2yJntwYbkEXqSXRrM/gO5FWU6bf MMoiiCboQV59vlhm5BZlHs67ZYHbnsxB6/GEIEgTTYyC3VMY9YM/dL+0tjeETXT/TI9NH2 AxMIO5oRThPwwt9qiKzBZUwjSpvCoEo= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-E45eQbKDMHGirMGUYwz3IQ-1; Thu, 23 Nov 2023 12:22:14 -0500 X-MC-Unique: E45eQbKDMHGirMGUYwz3IQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6716c2696c7so1781746d6.1 for ; Thu, 23 Nov 2023 09:22:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700760134; x=1701364934; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KcpnTT0f+98xbE3/g5MCgDaaep2Eqio0fEdLtHv5RPs=; b=ufPzRGgqB1F9IGX1gCNipZnuIzvYwdIOuvuo/AUNHl9N7UWaPmMjfAMTcazi+x/4J+ mFRe4ECvtvSoXd5l+yqe4ZXRly/7HMdeA35BAqVbHSnvc8Q4j1sWWT83LWyaIHpgUwN3 jXZtHu1QNTJmE/A6YBt5l2Hpkw2Do3oZdUlJ2KnoMMzgjjshYBzXlWPH/E8z898XC2S6 TtuBMMVJQf3YnFKYyt21wcvohKMsWKVQlAcsDKOwaS7V/Lz3vCsqzBwqxyTF/Jw0gIPq 3vvuyCZ6WA/PgfaQeZj/yBB6hmvlOtuRAIXEo0np6JG20g/62NshaNu5k58mEOJ8n1TQ SouQ== X-Gm-Message-State: AOJu0YxRhAyI/NJkv7OTPZ/WTLIv6BkQcu9pW+iiZHsK63livF8iM/ko QGAFwSg61/Cw8JtZSBNRUchcqW/coQNBPC6XcYW+4vTVgbmI9ODSfJpyyXBicYFeW3O80SRYga8 tQkhLb+WCzz4= X-Received: by 2002:a05:6214:16cb:b0:66d:1178:8729 with SMTP id d11-20020a05621416cb00b0066d11788729mr210892qvz.0.1700760134479; Thu, 23 Nov 2023 09:22:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoctQeyyuLZxBsUdrKfoqF1pEVxywUQFLPrXNM10XRHBt/gv7otbSLqMQmESr9lBHxoHkzbA== X-Received: by 2002:a05:6214:16cb:b0:66d:1178:8729 with SMTP id d11-20020a05621416cb00b0066d11788729mr210872qvz.0.1700760134200; Thu, 23 Nov 2023 09:22:14 -0800 (PST) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id x5-20020a0ce785000000b0067a0b48a4f9sm451474qvn.66.2023.11.23.09.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:22:13 -0800 (PST) Date: Thu, 23 Nov 2023 12:22:11 -0500 From: Peter Xu To: Matthew Wilcox Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz , Ryan Roberts Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: nug1inxckbkxssdrzgakb6bxscapy56k X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EF05320008 X-Rspam-User: X-HE-Tag: 1700760136-523719 X-HE-Meta: U2FsdGVkX18fzLHW9atTTC7VgFkuj2q/Y/SEnp0R6DmFocDaqXEcpA2K6CAgPbL6Ro91HZFAzQv2JhynMLQb2FxbIv8bn9s0SQHBGzMoTWlutNr3lyux5j84TVvGR1+ND1+An6Hzdwyynjhsotw7Vd1zwwxQqoEFHelno/w1B2JiLbOgeloTErGLS6SXEVrsOO6wW7ZezBBUMyS/w8Fjcj7w5faOx4pbJKIx7ET83IVhY80/mpcSrgizfHMEDkEXW5CiiX3es0R5HkAdCSpEIoHfR6bg3n9mrNcamiPgEUuTJsFQYwbwp/fINrU6n9W8g8EctExLQGVnb/5ReK6IxNlUFgE5YJJj0a5x3X/ic7XS6ay7MfaP32mh7dZs9R+csX3UINGWe3V6winhsaMO6tR+cqgH/RFcvfGMh6UIFMELsxFtgSK064ei4r9rH2tIeq72pQNiltCISPvMidFlmd3Di2R2cEFwoqYKVQSXedadkSZJ5ckvnTiU6+SU0umUaeI04zb29XloiF57Oa9m8ReX92yY25IB4FQA5h9Qo9JvuQ1y7bZa32wf1gBGbTe/BEj7Mun5InoCgskWGHq5uv+rQJizwMr98ei6+W6l46nB2vBVcgYLpXOdODd5pNTgpjVgnL98fdH7CHiiAssfCzEaqIw/6dpHQSNNw57L8lLTQI/ktON9HfIPSvBAdz7K7wHDCLQ57HKzeu9lWA4pzCP72DzHN4/TpbE1zhni/08qmordHDAYlS8Dja2e/XCqxUmpF7BGE690ZeLmpTA+GddkGZsH80eEklNw+BFlvio8cjlvyvBKkUQi1Sg6Tc3tJyxm5/pVaYR/j6y1FgIYMg5velQ7w5c1zTLEJMOel+4gun5NvM7/KBdpnN2skVy6gucklxlfUiDw3dnfnHl/cywUWa8Ah1HMZPHVxASUtPpDNSCZqGCmti91dmD0E0eJWZ0X/KXivytbL5LsxtE ek3tp06g amsjRDAAyQ1mnIHQudhPz2SLjk2dftViJ+WurzmccEHwqB/bmvP/ShbY29WSrdoiH+ahv85Nu7r3vhM6m2V0wGSbkUH9kfNW6kJqs8NK8u1x87JkcAo39bv6UWNJFYWPguUBEjYMsAcJV4jHXQVNCcSFCyQahVeJFCcDSgZeHzFehlrH9PK6V0+a1gdUX2jQN/StY1hLOLkcUWm22mFuspx+UI85DQ5Aiy42EurbNDk8rMQ/ad7mv59Hpccc8Lt3SHdngWk6hNk6sIIbpgGYxOj9sVZWRg7VXAgyewzdRakZnpNbc/qRFZsaIG3GXaTvNVAowdqj3JkCkC4AdyYvKFr9vLW0lmSw9LJXsA3Ja9Xja6bi23kOY7nnEDHrUREypcblBT/f1ttYAZEFlvgKUPh6QP63AZW2x2xkI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 03:47:49PM +0000, Matthew Wilcox wrote: > It looks like ARM (in the person of Ryan) are going to add support for > something equivalent to hugepd. If it's about arm's cont_pte, then it looks ideal because this series didn't yet touch cont_pte, assuming it'll just work. From that aspect, his work may help mine, and no immediately collapsing either. There can be a slight performance difference which I need to measure for arm's cont_pte already for hugetlb, but I didn't worry much on that; quotting my commit message in the last patch: There may be a slight difference of how the loops run when processing GUP over a large hugetlb range on either ARM64 (e.g. CONT_PMD) or RISCV (mostly its Svnapot extension on 64K huge pages): each loop of __get_user_pages() will resolve one pgtable entry with the patch applied, rather than relying on the size of hugetlb hstate, the latter may cover multiple entries in one loop. However, the performance difference should hopefully not be a major concern, considering that GUP just yet got 57edfcfd3419 ("mm/gup: accelerate thp gup even for "pages != NULL""), and that's not part of a performance analysis but a side dish. If the performance will be a concern, we can consider handle CONT_PTE in follow_page(), for example. So IMHO it can be slightly different comparing to e.g. page fault, because each fault is still pretty slow as a whole if one fault for each small pte (of a large folio / cont_pte), while the loop in GUP is still relatively tight and short, comparing to a fault. I'd boldly guess more low hanging fruits out there for large folio outside GUP areas. In all cases, it'll be interesting to know if Ryan has worked on cont_pte support for gup on large folios, and whether there's any performance number to share. It's definitely good news to me because it means Ryan's work can also then benefit hugetlb if this series will be merged, I just don't know how much difference there will be. Thanks, -- Peter Xu