From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F916C4167B for ; Thu, 9 Nov 2023 14:06:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12F89440149; Thu, 9 Nov 2023 09:06:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B6948D0073; Thu, 9 Nov 2023 09:06:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9A5E440149; Thu, 9 Nov 2023 09:06:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D6EB28D0073 for ; Thu, 9 Nov 2023 09:06:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A879B120ABC for ; Thu, 9 Nov 2023 14:06:03 +0000 (UTC) X-FDA: 81438589806.20.54CFDE4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 755A74002B for ; Thu, 9 Nov 2023 14:06:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bxnQJM14; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699538760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/R3RSbCO/oRPxhx3RiVNx3CrxYoruIxF6lvTHy2TD3k=; b=XEzkp3afI2BwNvvCxwrHc1lA18lcp8UBX9Dq8OpgD1m2Vpq2+HdpDZmNMAjjCww5e42SlA eeq/5GlhTQdPZ7Bwe1GiCSZDcUEmyEYFozqIFPPJ1VgQEgbHZogzwnyixGcvIjo0rQaBOw OhqsWzG6/oDTZKbAimGuItpPY/XFXxU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bxnQJM14; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699538760; a=rsa-sha256; cv=none; b=onjfPWQhNc3tnODJkELTK0d1TW/gQAsnOJwVxeB4r8UrwNRBnkKFgxhSiSU8r9xjSiV77g o+X1ggnB//LGM/qrNCvCu3uSZmFBYqkWhtvUrR4mSPLa7NqD/su1EaQoH3ozGQZAtY/YGX i+asWhoIGE+DZMiUctBrRgcy7cN2UwQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/R3RSbCO/oRPxhx3RiVNx3CrxYoruIxF6lvTHy2TD3k=; b=bxnQJM14jc9o0SmLCxJIDDEv4L ldPRMuM9UXEyLkSG2XJJaSmHb9SLCJkBf8Bte7XYtweKd8tz8Pklta3mPmfHDY50y2wUBhhrw/UGj ZUhgjxgRjrlO5/9fEtPeoDIe/mA8TaAnXICAK5fIAAte62ArNyBkYUhsCigdwym0oUpWn2+ArW7nS 0lGvUS0qc8+uTnicl4zFFASJRo3DCUP1f//0xIoh4Xn3Z1AAmf+M/0bOiZiafn2nAMNXrkDcrVsaA Gfm3kFV4te2frXDmFje2i/xxlEnoy2rTnqOFyry+X6ik+MYjp98B8tIOdwNK8LYcq8cLqIDiggC8y Bc53b1iQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r15fC-007elN-3C; Thu, 09 Nov 2023 14:05:42 +0000 Date: Thu, 9 Nov 2023 14:05:42 +0000 From: Matthew Wilcox To: Jeff Xie Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chensong_2000@189.cn, xiehuan09@gmail.com Subject: Re: [RFC][PATCH 2/4] mm, slub: implement slub allocate post callback for page_owner Message-ID: References: <20231109032521.392217-1-jeff.xie@linux.dev> <20231109032521.392217-3-jeff.xie@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231109032521.392217-3-jeff.xie@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 755A74002B X-Stat-Signature: 1nhno1z89a3shyi96gdqaere59939af5 X-HE-Tag: 1699538760-342403 X-HE-Meta: U2FsdGVkX1/MBl0vBP0P3f4Tq6YDwg5/63MngC6b+eyGgDRRfHlJi+EOYrdTz5UPtGvKOmLoJfNCu2LXescIV3OZ6Cury08vorPEwl2o8TJrhBMuPzLTDhl3IFA0XpxEV6FHCLsyot5jbbBhHlL3WmKTvesE89xKWS8RVavOJjOwHxtV0nswJwOyhI14T7OBpPZGMo6Vq1Zc7f27loLRk7G+CWMM56RA1FFneMQiI/kB2PA5pF8iZ7GHjkGXk0UAoWyVri+hZGRVKeaezSx3OVX8CyrFNiNXGUtLI8iVpNpHH8am7YFKAxoElK/XqwwRy9+BsD/IgvrjTfhukMgd6iFvlH7oBsF7UebLNH54o1JmErSFXwBlxPTglpmvEtjvUBCczVfjK2jceEyaVZC4xnyOfK2U3waXOcdRDOYIRaAD8SdaGP+fuarbuhMcN45hgOFODHfBf83HUhP49c/7DKPEi0IzlM1f3X40j3QVzg6YCAvUBAm55uElqg9Q/Eidu8IuWXdmQHqLZYfkSa2QltLvoaWXq5MeLOkIt/T+1TsLu8ucHxINBkOipPOhO2Zu0jehtz1PKO074Ldf96GSrX4ptBFulMTGCFZV/Z/QFY/PfmcwKXnETHLxuBN1GxARDRKaveM+1NuMTrt6bxF9XJiFyJ/CATVBceSeF7ULvvDYXwYvho6GrFRlYFlT3GPxM4mZRQ5fEg2VyzsG8e/PDcvmhCx3DupWzujXtirrl+YiSTgxoI0wF6xQZf9/CLYZLdBEI6Y1IkO3HxZY6sNgsyn0Zvu6BS9UHX4bXNefV2hjhKDjVuBDTlPGFwMqqmLC7V2QjWdiY1pRBYRy2v+DRjMMtL3Jrqdn2nChDNGVci492vv55TytSJE4P64d7v+uNxSXm4yF44cGrwXTGiyTKQG33QPVw/62qx958vM4asqIdS2EZ3ktLYcX0qCmkFpRZKK+9ALRXjaiF+2+cIK /zhR9iiW gAm9ZcNyHd59dzJN1zWTkec5HQhwhSaIXt+jYOh2GVu/W2PIuAfjcwqQe3hKDuapidTA4/hpK5W9pGelLgvfGMYESEjwrVufSQyI2g2NvMmFZGsJ2ZfiyMYFu2ypJnoEzyViyz5kRixq6ID072lGdtxIzAP486bc1IzBb8gU9AsuIF+8kWiplrpQKA8YfnGH673qSM/YUKY5L7J6oRDO60YaOD0DWEQqF3xLMG/cuGN8UxiCu1HpagixeYU8WpubuWzk2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 09, 2023 at 11:25:19AM +0800, Jeff Xie wrote: > +#ifdef CONFIG_PAGE_OWNER > +static int slab_alloc_post_page_owner(struct folio *folio, struct task_struct *tsk, > + void *data, char *kbuf, size_t count) > +{ > + int ret; > + struct kmem_cache *kmem_cache = data; > + > + ret = scnprintf(kbuf, count, "SLAB_PAGE slab_name:%s\n", kmem_cache->name); > + > + return ret; > +} > +#endif Or we could do this typesafely ... struct slab *slab = folio_slab(folio); struct kmem_cache *kmem_cache = slab->slab_cache; ... and then there's no need to pass in a 'data' to the function.