From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C95C4332F for ; Wed, 8 Nov 2023 17:30:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 612068D00C0; Wed, 8 Nov 2023 12:30:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C2108D0073; Wed, 8 Nov 2023 12:30:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1468D00C0; Wed, 8 Nov 2023 12:30:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 39B188D0073 for ; Wed, 8 Nov 2023 12:30:06 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04820140BB1 for ; Wed, 8 Nov 2023 17:30:05 +0000 (UTC) X-FDA: 81435475212.30.5407B29 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id D70DC2001C for ; Wed, 8 Nov 2023 17:30:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZdarU8HT; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699464604; a=rsa-sha256; cv=none; b=LAmZSIk5r+A0sqzV6lnyx6er6vM9eF9MKT+Vw6gvVC3j8wdLpbZlZ5jCEJFmFQWDPP7zJ8 0mA6OtCmV9uo2p0OOsH1kj1f+JbRhnimmXP474sEPkz51RagmYdPjylE3sY8x8xGQ7U+gC jDaLbfk7CQ79+R8TINe0q396ViElyeY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZdarU8HT; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699464604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H2zkVEPvH7oBasEzfGl3kL2RvaYaBO1+1nf9sgaN5go=; b=qrJKie8UTJ5h5fXsDgVaCesC+s7QT7QorKcGfxv4nGncmjw8aASIydI6HCIB7i5GToCYIT 7oeEyOUxnvVL95oRRZrhGm+cNKFxHssXmtNR8Elceq6t2yJcpBxmlkD7/Q7XYqnE+riO8c UQdktzYjbs3TZR1cDQ3IMj1SRSPHzZE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=H2zkVEPvH7oBasEzfGl3kL2RvaYaBO1+1nf9sgaN5go=; b=ZdarU8HTLeI+3VXpHsmRAd6/EN 58u/kaSEFMl7acA7qNp5+a83pAUeQZnu/gYqsi1dl1uJ+xdsf7ZE2yEw0RVqilETPB2Ft0uRVdzFg bisNk7HFRWNZyleyr6LRtD+73q/QhXiY4NNCtrI8nE48GHWF1uplqHpBA9omugSeWoN9Wmh8gcBYk tM+65iEaEcIH+4F/E07cqzNkoxfP96zPdeNYBJkY5t0moIRSrY1yeLCyfAIu4xuh6WZGYj5uSwGVp iMMlc7BR56Oqsxa+TVwTJ5ULCe2+DMd4nvvjCkemvjxNU+CJ8Ub9acUANoWmzqWqdn65EEV2B6ABd R4XoZQPQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r0mND-002Guz-VU; Wed, 08 Nov 2023 17:29:52 +0000 Date: Wed, 8 Nov 2023 17:29:51 +0000 From: Matthew Wilcox To: Stefan Roesch Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v3] mm: Fix for negative counter: nr_file_hugepages Message-ID: References: <20231108171517.2436103-1-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108171517.2436103-1-shr@devkernel.io> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D70DC2001C X-Stat-Signature: omuxf3m6yr9cbzf9j5puu45wdbds7gs4 X-HE-Tag: 1699464603-346807 X-HE-Meta: U2FsdGVkX1+nt1uW0ad7vFsCtZnb4W20at8AhgXJBtQoI9YTuCYAxt0YbfWeQGn5s28yYpVEwuZn22Ldm2gfQLwGCdoGir1RTwPb2tC/Wq4dzpAB+vD4HDvm1AaBAADYZnmQwPb1H8V8WAd1KYaRDioMP2Ytb8XbL0LS1yy0OaFeBL5UOy9guB1kbfYJu+wHB44e+yHfjnvhzlgI8ipWFuOkjGV4EpwcnjeanwwLmzOXi3J1lrxHvEbh3rL8iTUtTaOIFkPQMYUkVWXKaVYA0UGKOXblgCbE7wnWkcNKjmwUHWbQQzGntangS3smEsXyRBjsJzNL2jnx39QuC5pm94CV2UPit8egk9/BgjmbSJy5M6x5rmWaYNL4I2AvCgH5EP2SjngK0DPfDb7tV8HBVShKd/CjDzuK0qiZFgNYPAdLi4K2gkEyJyXQt0aX6kd2uHgxX23GZ+WkNcLINdmATkGSh3aML2+up2zEeN383rw+eV7x0mrqDhhDNKLN+sNcRMxtzID1YeLGInpenoPongpTI5pAhLBYB4194Qu0j3MZBhiaxe+CzvOzisGRhN/axpkDqfTjVSfDZoRoCsBOegtf2jlkX+Uk/nrbhc96VihfXAPYoa2yyrDj1v6gC4nQ0esIwopx9CfovH7Jqrd6HjqdhAIoN9tojYBgH6gFPAyOtoSW/pjqDS4AzDKwxakVRv1RQO5h1WdM5EHNbihWHE1jD8nbz8UpP0iOu8HfwjfNRPLPVZBZ4ytbN8EECvrHun2TQ0nW7UZBFEob1It1d137KeK0g9WdgsMwqKztvyLiueuMb7W3aUn/hwNoOWY4tmLSuTQ/jUhBs0yokUkl9p76m8kiXoc7DZ50Xxh1C+Kt8Chibo1A6CHtuPMKNOPRaCWQoLwLS/tbmGuEIobUYYRO7KfYPRpcRMjArrWMzDH3/XzNPkF4EaCdkGoJZqZZ1HlvA3hCUYZ3zod3K31 2DnEAY8J vb5jb+5wnfJejIEehmD6cb85xtPzObMrUFltxWuUbkZK/PiZt3PvHEmw8FA/GnZct+EXdxi25StJJXHg9boOORvnb7orrlk3dYJvutMeT5gyzpNpgfwQAwxyJb8p6YWvbIvibyBOH/RVmy7wNo5zrQVUIQttJs2naZgYND73tvpINpFjQTPfxTscQhL4pVDB1J1a6W9c+0QtLU6iGb/TUR/MnZsNcOad+JX8creZuK+EYaEZZ8uOSfWc7ZikZGSxZtwGKVI8uRiBkX7b/9LMw9Wt+yVNCNrnQUnJZfg/HayU0nrD5V7PE4SJzllXgyDO1LRCS8hJqP58r3mt7F7EQ/I2hlYqlCYA5FIdMFFE9f4yITtEtBMEykWhQwmQF5uSpbz4r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 08, 2023 at 09:15:17AM -0800, Stefan Roesch wrote: > While qualifiying the 6.4 release, the following warning was detected in > messages: > > vmstat_refresh: nr_file_hugepages -15664 > > The warning is caused by the incorrect updating of the NR_FILE_THPS > counter in the function split_huge_page_to_list. The if case is checking > for folio_test_swapbacked, but the else case is missing the check for > folio_test_pmd_mappable. The other functions that manipulate the counter > like __filemap_add_folio and filemap_unaccount_folio have the > corresponding check. > > I have a test case, which reproduces the problem. It can be found here: > https://github.com/sroeschus/testcase/blob/main/vmstat_refresh/madv.c > > The test case reproduces on an XFS filesystem. Running the same test > case on a BTRFS filesystem does not reproduce the problem. > > AFAIK version 6.1 until 6.6 are affected by this problem. > > Signed-off-by: Stefan Roesch > Co-debugged-by: Johannes Weiner > Acked-by: Johannes Weiner > Cc: stable@vger.kernel.org Reviewed-by: Matthew Wilcox (Oracle)