From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D007DC4332F for ; Wed, 8 Nov 2023 10:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 646798001A; Wed, 8 Nov 2023 05:41:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F6B18D00AD; Wed, 8 Nov 2023 05:41:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E51A8001A; Wed, 8 Nov 2023 05:41:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 400018D00AD for ; Wed, 8 Nov 2023 05:41:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 16B541CB69A for ; Wed, 8 Nov 2023 10:41:14 +0000 (UTC) X-FDA: 81434444868.25.3892253 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id 6BFEC40014 for ; Wed, 8 Nov 2023 10:41:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699440072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hpoLA6rBX62IrFFvX7dElPCVumC1yZGF0K3t++YBd2Q=; b=GAWVy4ecGrgpRaljZha23jylCGTCR8QsVvL2rFiTNwEjkcUvzbtZAqdUi8FS5VvHYPD5Lo Y9bX3iEUXLwgazzIE2OOyV2DW91hkc8GZzEOQfTsYBelUPPSd8xIvaOsIXeuKUBZvTD+Ww Ya2vE7XosIuxBujtgrfUZSvI92xLCqM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699440072; a=rsa-sha256; cv=none; b=FgOqXllPCigXLU0elaft2kHYAMFqMJlS1PEv7CjLeFFHUGtxos+JwRHMQYYizwkj5BjC3O EiFpT5fKT4Tg9zz2jTrS8SLw/kUtDIM3Q+McNwtLydEBGI33vPyiFrJkL4pKnxvdAO13dy gTJlzoXp7bFz5e/ZsqFfd2wORG8DqvY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id DB1E3B81AD3; Wed, 8 Nov 2023 10:41:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5833AC433C8; Wed, 8 Nov 2023 10:41:09 +0000 (UTC) Date: Wed, 8 Nov 2023 10:41:06 +0000 From: Catalin Marinas To: Omkar Wagle Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MM: kmemleak: Removed coding style warnings and added a NULL check Message-ID: References: <20231108062756.8129-1-ov.wagle@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108062756.8129-1-ov.wagle@gmail.com> X-Rspamd-Queue-Id: 6BFEC40014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nxfyc17heb48ici5ujracykm4f54ygp1 X-HE-Tag: 1699440072-578397 X-HE-Meta: U2FsdGVkX19UZEXNbaSP1Zu0EX2kYrG60hP2zwe+mHM9ZESJYpxtHpt9m+6D6uImThPme2jRGrQuAWmCH9aZss+wKNiwzJ8vtaVmgZhjvl/CgTKhLkTu/A0QzLhi3AcjeXsvTS8VSNHEh+5wmXqVnoUXBmtoOmJEqFgXk7jyA3mke2rqFFMPK/+eLnTSHZsPOWuxnAU/YhrJ90LGSZp0GgGvZIh0r0OPIH0t0S8jlpEa7O6YeIzLkGYB6pRm8uH6ngJsrGtTIvq8YFY0AinXeceLFWElsvgFns5UVxJjD+iFREB3t5PwyYO1p9ycGNqVEcuRoMT39iuteXg0hN2ONvx7mQ+0YreP1zynzZBR07gzUqmycYQ9wJXihQIuDs8lWr6h7TVb87DeEHE0MOLBa4Bz6/c7uPW7//JJh1Ch2TAc6HXTIK9m9bhmO3RZVvwKY25gJsz5dhUlf3CSabxf95cgP19SXLuJl7+twp/qQyVkRRUZ8HjuWK0GGZhaDl7YW4XMCUq1+p/73MR0+pqBxdnkXFhUZbTnZfYQQlWXGSj6PqOzduETwQ4n0vaP5K2LmNGUevkvW03gaGdYYE2e0/CLUR9LvqCSz7AWw2jN+txtfLAS+f8qbR4nWn9GbfWBPvf8iiN3V4si7p2U+1czxrh2P620bxhRAzGAH6gB3u0Ol19oZqKAJQDoBZY1wRxx60n0t16JPq4A+jOCGRWVK0pfQS6tl4SbhSKNbvmpfbPOBwqhylbvmyxmOiu/M938LyUOSW/ec1iyhNyHBUftL0UtJjjz1WRkvUed0TksS4olRa3aTGhEPZTlJvoZW3YkF7NhtH7Zbu4gF6hyeA9knWVU8WVkcqk1iYYj5KC+XPCu1sc3HfvwtoKPY5l3KxU8wuSLFt+pVvnA8Pk9wXRT87C0lqNxUT5RuvN8Q6DUG9kNL32WnH6ick6C27ZVnBesFDLprdnd8N4ny6JzPox CXDigNqS yVpIfNNfMnHaKk7i1lJnnb1oPWXk21R4vN9GE7l3thoCpRv9dUTCHYvONMl7z46WZOUWV8UzmpPbijhIMKijRg4rNAor85mPMjr0qV0EOXEbslV5FTsbWjsxEL+KYmnF1Q7h+VljY24VkIIgKWAFzrH4lXtU4gCE3LOz0EdjKkd7DxsKM9zYdPaVbS/pLob4pbgT/eH/EHAbGONXf5vvl0K6fODIy+ihG7Rf89r7RlMzL1OtNM0V+IfwT8locg/FCHMHFu8D1Zc2Uqg8n9g23wCeBJ+OjiwkjR2imciyfwkPUOBvSkW4CYPJ4ygR1xV1s6c0IM12GfzhiYmnZkpbwIP6st87QLcpTTQXS7DwAgKEg1zuTEjaFPoKRMZEFtPOSr5hK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 10:27:56PM -0800, Omkar Wagle wrote: > @@ -406,10 +406,13 @@ static struct kmemleak_object *__lookup_object(unsigned long ptr, int alias, > unsigned long untagged_ptr = (unsigned long)kasan_reset_tag((void *)ptr); > > while (rb) { > - struct kmemleak_object *object; > + struct kmemleak_object *object = NULL; > unsigned long untagged_objp; > > object = rb_entry(rb, struct kmemleak_object, rb_node); > + if (!object) > + break; No need for this. rb_entry() is a container_of() and we already check that rb is not NULL. > @@ -1027,7 +1030,7 @@ static void object_no_scan(unsigned long ptr) > void __ref kmemleak_alloc(const void *ptr, size_t size, int min_count, > gfp_t gfp) > { > - pr_debug("%s(0x%px, %zu, %d)\n", __func__, ptr, size, min_count); > + pr_debug("%s(0x%p, %zu, %d)\n", __func__, ptr, size, min_count); That's for debugging, I'd rather keep the %px option. The same comment applies to all the other pr_debug() changes in this file. -- Catalin