From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541D6C4332F for ; Tue, 7 Nov 2023 19:35:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93CE96B015F; Tue, 7 Nov 2023 14:35:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED166B0160; Tue, 7 Nov 2023 14:35:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB6B6B0161; Tue, 7 Nov 2023 14:35:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6FB8A6B015F for ; Tue, 7 Nov 2023 14:35:52 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 45889C0B55 for ; Tue, 7 Nov 2023 19:35:52 +0000 (UTC) X-FDA: 81432163344.04.1D1A3E3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id A554220007 for ; Tue, 7 Nov 2023 19:35:49 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=I3TeLlCa; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699385749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RMzfASwureNH8zSRhEEH/Mxu6HknK4f+eaK1G9SLRAc=; b=kNlpMIK5ayV4zWJqOSmiG2GFfXqI63nK1FZ3DtWtDcU4m3bS0RxUqHpM6v7KPk6FB0hRxC pJnbXhaiC2whqyci6t0PVeBgfvk1x0kY/z/k6oZ1/dq542+tgfInI0lfrsQV8DHaU0I+4D QnHDyV/ROXS1e51LSdtDVbsYTFRLfLM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=I3TeLlCa; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699385749; a=rsa-sha256; cv=none; b=RRlVi8SzUdSoD2bAjs0iYaJysvcl3wBFGXJGVPqQYVjnpU3PDwYQVtI7dApe6hLkNHTJrj o4s7TVJW3QapHOE2nXGsgERmgBiMJj065BJQU3l7FwkUX5ctAp5U5ZXjon5RwkQe7Owo/6 kbzSmIq3Q7v6c9gs8oa1P4TUq8+f9XQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RMzfASwureNH8zSRhEEH/Mxu6HknK4f+eaK1G9SLRAc=; b=I3TeLlCaus6IkrVTGgwZHy8o2k bAB0PaSS3TAxVd81jvQdhVgm9k+Z/Ya5i5gNv713ULe03Vo+EK+tRXPJv2+KSthlk0ZjSlwf+YpJA FTiIj05R/wy8pkP0rYCupnMoxuCjEW937iD9tvlr1jeia7rxgV6PNhXtK8rcjQ4Df+RZ+fycAoWzW +Nq9/uEerZcBE2l0EgZjzNeuYonBHLvJssv2ssmBPoEWyehdl70glLATggwHk80hLYrdt5BltWpKe rNOBE7V1F9fm46+u6wGXBROSOP4TM2poPh+NT2Y3NewYCPR2asGjMDOe40yDUsWR7kOmS2CDzrXi0 hG6mMhfw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r0RrN-00E9U4-T7; Tue, 07 Nov 2023 19:35:37 +0000 Date: Tue, 7 Nov 2023 19:35:37 +0000 From: Matthew Wilcox To: Stefan Roesch Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mm: Fix for negative counter: nr_file_hugepages Message-ID: References: <20231107181805.4188397-1-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231107181805.4188397-1-shr@devkernel.io> X-Rspamd-Queue-Id: A554220007 X-Rspam-User: X-Stat-Signature: 9rc55itksk11f9ek6kff5pwwk848byx9 X-Rspamd-Server: rspam01 X-HE-Tag: 1699385749-271009 X-HE-Meta: U2FsdGVkX18IL9PoCDNhDIsQ8hcvKzuYnx+ql71+o4vCFYzkBVe+a9LH+Yr/XTCrgtbvRywfu/iyq/tj9YGJDTcTTXsBRAxj8mR7a8ZTUY0kSL8WGqykHmEj049V9EiKNMDqjDvb96BDu1FBQpTzFJqYstJJncXSPwl3y/nkX/K9La/nW7hZYLzTEgbuJeZq/arDOl3UjtU6NalB511DFz8d8RuVxsjXvxyj2f80156FcI4W1Cz63QB1dnCtDayX5YLq+MOTdXJ90b5KH4gj87EPLX2vnUxouFGbu6dpUfpK+H5prKg4P86zprgKjJ/TY80lO9o/u2/MpU25azAs3OOfvPpy+A1u6+fUJdvpMBket5hPvgsXEOz/3ZWxWmEX6xn9TL92md7gBrvzblsi9rGuQEo36BTAqEp4RedIo5DW/l6z+68I7dn3NyIBkQLczQJLrGiroKbBrfKWEQH6S5KIi4I1koVFzaKzwGQWK3ZIzjlBgrHb94PUwz7Yt0YAX6x0rXl8IFytTJH1plzP+QvmZ2amJHlAlHBMtG1LqVjQdwK/t2KHASc+ltzavzHXH5nxERKOGBQmiJKS7k+6shCLeOjDeDFEfR+eJkxbVFuk6osIzCI3sPZAIXS13skejrL1a9fbccQqzJLz/SQ24ue5HeoE7mKcTyBGWpnSab1JrXTHs2qjfb3hvlup7SJLASnQ+AMvd7JVq1xvYfPepmNAO9qsEeiWhvWUjxzkQmTcgrzhG/yiSAXjPQ8PWrdsIAq9FRxNZ5kQlj9NTiwOpsE/XTM+kWrpkGNnWOUiqXDquOKjRdOQZx8reXtjLRefaYFucDVLm1h2rD4R23M4lADjXLXlqe3emFR4XlIO9G1l7JcrluhfUUFWQuhjQkI7IGVig5z8i1ezy50kc4idgD7yd6MycQo+3YqDqvbfxf59yMZWfrqHu31VHMNtXVRZ5EyHYSCSJ9XpgNjomA/ awto6J76 J49wnYtiIMWi1NtRV6fxIT2mzcmVb7mt0odgt6aHQr05HAGMugWMXfWabr/xNba1JleRp1dIZPBLwdApHN3o55nRKppVbrxSEEzUIQxwD+XlKI9XWhP5AXLf+bLMq7Ddx7hlpko9wskxj+OiTUfZshdTUzCiK0ynIktu6QnsJwdoa+KG2LC+z8wlelA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000494, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 10:18:05AM -0800, Stefan Roesch wrote: > +++ b/mm/huge_memory.c > @@ -2740,7 +2740,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) > if (folio_test_swapbacked(folio)) { > __lruvec_stat_mod_folio(folio, NR_SHMEM_THPS, > -nr); > - } else { > + } else if (folio_test_pmd_mappable(folio)) { > __lruvec_stat_mod_folio(folio, NR_FILE_THPS, > -nr); > filemap_nr_thps_dec(mapping); As I said, we also need the folio_test_pmd_mappable() for swapbacked. Not because there's currently a problem, but because we don't leave landmines for other people to trip over in future!