From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953A4C4332F for ; Tue, 7 Nov 2023 14:24:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D92E8D003B; Tue, 7 Nov 2023 09:24:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 061478D0001; Tue, 7 Nov 2023 09:24:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E44388D003B; Tue, 7 Nov 2023 09:24:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CFBF28D0001 for ; Tue, 7 Nov 2023 09:24:35 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C3A91A0849 for ; Tue, 7 Nov 2023 14:24:35 +0000 (UTC) X-FDA: 81431378910.01.8310006 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 80FB21C001C for ; Tue, 7 Nov 2023 14:24:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oumPiU5j; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699367073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2nocopVJrZg5DkEAMHz/LkgkqbkKX5Z643rJ6AjI3Og=; b=V8jqJATUyJlZsfKjjtJbe65XMHiF90mfRlzXGHmeErStMA2rNL7mJfsawkTGdT1aMgF5ml F46mKKL4W7H+gbz1Zgjo3u6tsyWU0t4GVr+YyjMTCiw33LH5VzIbliEqgvJzSeejEf5bvK Rm03to9R3GWy1zQZRxk0YLBt5ycNLCI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oumPiU5j; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699367073; a=rsa-sha256; cv=none; b=b0FF8gQQ8GFCXs6Uy554AZBGn6AhB2jcX5RTKX4kNTNrRhAisCzMahsOmtQcDxBkc1KjK7 WdSTHRtSYSktqLicUFJ0ikXYRruiiRlRPxZRFXCQ4qt0uxiT9r6WS+bdn9qpr4MKn96JXJ bZNLf65FcDqsTdIuaLHbw63BFueX0Pw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2nocopVJrZg5DkEAMHz/LkgkqbkKX5Z643rJ6AjI3Og=; b=oumPiU5jlO53htmdUDzf0meBVJ AMxD++rMI0xVxAZxwDna+AoxCGNEFq/Afnm/sMNXDMIc9HFY+bqVLiNNuV4Gxq6j/wkw2W8tgB1v8 /bNuT3ge3rHgxtVaFG+v3UH/+uuo3aDRpYAuczCKhyPU3Aoih4Btu4xmSCALjTuj1lkraRxiirYV8 0h9LDPXB+FiTtyyjdDUnTZ23thodnmZpF+aw+z0Bo5qZSUIL37zshKXAReFwMA5B7yS0BYpUA3h2A SRih7jcUnSWNe7WSiM7gRBzvk4iC3i+TpQFqhJsMkCZcJpUN61TGP30Ucl+0LPx2AwhV+j8idsdsM Z8nlwAVQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r0N0A-00Ckwp-O5; Tue, 07 Nov 2023 14:24:22 +0000 Date: Tue, 7 Nov 2023 14:24:22 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand Subject: Re: [PATCH 1/6] mm: ksm: use more folio api in ksm_might_need_to_copy() Message-ID: References: <20231107135216.415926-1-wangkefeng.wang@huawei.com> <20231107135216.415926-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231107135216.415926-2-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 80FB21C001C X-Stat-Signature: e75prxxmxb5mfpc1t8o95acuwzsm5h5a X-HE-Tag: 1699367072-755261 X-HE-Meta: U2FsdGVkX19PcacVMkU7VgAU21tqfKQiE33Q/VZkXmB0dxfO+D1PUlEVUVY5CYBnSK3wXaLTLrPZ76IQaBRC6uS7bGdzh0hGMvX/FOrTB+JZ28uvJHwND6PfVKSO/qR0ZbQgt6yP9EVrW4pgA+svtX0e6Qv6Zs3SYtryn4IjxLrmcVTskxLH0XSNqMBFK2u5yf1lSy21OtrlMA+W0fwYDy5lXRRoD88SopuE6vEhk6zTw2NbsTJdXCXEJ3c1uWydNDsjLXjVKfcqXSfj40pUKnJJsGvV08Eov0SyGNPcGMQ4l+6oMRbz++vxo7XVVAzv9M7TM/YPrlKbTGxaZRT74XHN1kH0Ox+43zOjqMRJIch56l0w0MoTEHITS1V+64O9p3obeF6W4KSuOzW+p8ZFx6w2YX1G0H5NN0yNzjD7rpuvnF8PRImvlWQ94gHu5ODk4Hr9SpUzg5qQlRw6MAEidZvGrUwaoICllBvdsSdykjvZfN31XF05kOWMJ7cX/S1l/LxnXEvSBBIWRGRpemYY6pV/+FijoWsVZ+HOxJ9p1XN08jZqXjErQ+oQwZRfFIqCAH/xfoLe+SGc0y+8Wunl4DfKt7Kc+iv+lZT7TXKUe7SPec57ioMQHuSnWDTGXcwZ0yahkcMsMp6g3gSAgk6Ry2qN30I5dvzsOadsIrFuw/Hg2NdgjoWgtUBhzfAej7Gksvy4y/rI4dpBFvfQmLALZPfMvGXzNwuAVGEHzAWwmfs5LS40REJjLU8BnfhU2+ukJNRBe0Bv2ijKSSRUs6+fgAFERBheH9ZfDjCLzsMJKd7vhjBYNSQLfMUahRxdWcNK85DFStvbCrcUg/jZN0xSNJO7vCFemd35ukcg3ooRak4Uwai4mAtFRyx2mafq4Kvg6YAyv6trhqEAVDx7HCCkG2wh5080lBblbk5uxuCeKtMJmk6/IFYwU8WLdD9/+v/c/Qv1L1c+iydR8siYDPE 1WSAnjuV ufD7Ga4XrgQ2x2lGHplcczT3o2GDrbKSz5KBXsKrXMjNRAXVruXqp9/SGC2QJ4kKyH+LTpAiFjgAk/0LDEgyZy1L7R9r5QfDF8mZ5UD0D/R5Xv26tmfZxj+i09lGZ7PX9MLJ7lQVyGCgAI2hF6fnCAArF2kijx+vFGIF7AAS5IZR3rSAOuetzULK1iQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 09:52:11PM +0800, Kefeng Wang wrote: > struct page *ksm_might_need_to_copy(struct page *page, > - struct vm_area_struct *vma, unsigned long address) > + struct vm_area_struct *vma, unsigned long addr) > { > struct folio *folio = page_folio(page); > struct anon_vma *anon_vma = folio_anon_vma(folio); > - struct page *new_page; > + struct folio *new_folio; > > - if (PageKsm(page)) { > - if (page_stable_node(page) && > + if (folio_test_ksm(folio)) { > + if (folio_stable_node(folio) && > !(ksm_run & KSM_RUN_UNMERGE)) > return page; /* no need to copy it */ > } else if (!anon_vma) { > return page; /* no need to copy it */ > - } else if (page->index == linear_page_index(vma, address) && > + } else if (page->index == linear_page_index(vma, addr) && Hmm. page->index is going away. What should we do here instead? The rest of this looks good.