From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15F0C4332F for ; Mon, 6 Nov 2023 16:13:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FA178E000B; Mon, 6 Nov 2023 11:13:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AABB8E0001; Mon, 6 Nov 2023 11:13:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24B0E8E000B; Mon, 6 Nov 2023 11:13:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 13BBD8E0001 for ; Mon, 6 Nov 2023 11:13:06 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DFB758082C for ; Mon, 6 Nov 2023 16:13:05 +0000 (UTC) X-FDA: 81428023530.13.9AA4837 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf22.hostedemail.com (Postfix) with ESMTP id 14588C000D for ; Mon, 6 Nov 2023 16:13:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FS1wt1BP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of 3jxBJZQYKCAYykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3jxBJZQYKCAYykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699287184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=oiIMZCbsKdoiMOE3rfJl2pHIym1QqmAK8MOncOrmi8FKWQqL6IDxYyIoYR62fBs+Qs6DMh FcqHmoiAHEbt/XXePBHrS+1dQQh9FyBPo/qk/EeaIjpuuTDty7zk9Tx2u9UKmIUmo4ZHd9 e6WOIilAin/8l+1onJzcPgwm0uQy9dA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FS1wt1BP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of 3jxBJZQYKCAYykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3jxBJZQYKCAYykgtpimuumrk.iusrot03-ssq1giq.uxm@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699287184; a=rsa-sha256; cv=none; b=te8Gvb5dMS9Gu5q/ajwP+Il2v5IoAyiX4OKnxV8RA4lNeHzJWli5es4BVzDqcr6d/2VoHe 04fPJB76K3nADP05y0X/6ZvKIQ1KtLPt7KzsZ3Ej4JaMBmobrG28jKeKZSz0pihZYeD+Lc WttanUQoYH3VDKwHowzDEpURmJPLjw4= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5a7d261a84bso63746047b3.3 for ; Mon, 06 Nov 2023 08:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287183; x=1699891983; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=FS1wt1BPtbPW8laRZYJ4aj6YrXwApAdstncAb3r7IGYgsApsix5dTrwegC8t85lv2c pHlDajT2frd/GLN4GAeF2Qtd+L3RoAIvv/gAgJV2fwbWdN5WMlYowVPO39Vp5eCy6vFE 3r/ccHJG3OQYXUp8RXxV5dNOAvD++EfQ518f5sBng7IM9sIEWxzm/kkvOdawupj1dWUZ jmHOFJ5szT+JPMQekcq6/MZIly+CCYKHvQd1dZ2OqNQSDu/FME6gWy9+Ag09rC7mhQfB smqSIi0F0Fpx7Vj8i5mGR5Dh7xrXY0gmT77ww8nRkcm6o3heaM+phVwx/5te/tCd56OF kohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287183; x=1699891983; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=FJNBol1Y3lxb26dGK2crum4+kRmPNW+7R6GWSFjUOAkmStf1mOS2nC8CxWYR2VcNuK g+LB+FkYfQjj38v1QehV+mn1KGkeaBYL8pgiwX8H37xwSw8l+2FFZHzBznS/BzAQgnJ1 n5nMy4Uf756d4Y+SpkYLWvjW9xIVws07m5/ZBpyRjOv4NhKexKD+XprDHXABJgwNdfBN GLfU6A+S8aYgGcAcq3sCoHUy7fhr0Mo5wz0LDT1zncNA8n3Dg/VwsjQrkU28+v+ja/io YfSB7DkzQqZYkHJZJwpUMPWNjCglXE/QDAn/HX6hzcMCTBpD7UNG57owk01ZDBYR2vm0 Furg== X-Gm-Message-State: AOJu0YzPgX+9rcqVla6kFnaR4tgWOx63k8YfV/3lMWt7vTzm/IbiAD84 v5v+EgBAvH21Q4HzbKYxmXbAEmpQIUI= X-Google-Smtp-Source: AGHT+IEuz2kxbbqGFRlRrYjmJAAmCd5YL62xYCCumvx9nTcHzja2SicRUTSCOZ5GtJw0RknzXE1Az5YHDFw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d5d2:0:b0:5a7:ad67:b4b6 with SMTP id x201-20020a0dd5d2000000b005a7ad67b4b6mr228755ywd.2.1699287183068; Mon, 06 Nov 2023 08:13:03 -0800 (PST) Date: Mon, 6 Nov 2023 08:13:01 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 14588C000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nt9hk6ssejixjxyym9sudofd8q9we4nt X-HE-Tag: 1699287183-418044 X-HE-Meta: U2FsdGVkX1+abhl2N6zor4IYGSLE7Cng7gi5xQn0E5OcVyeRXw5S/pELdX4UThdixF4lH7OKVWOz4RDDV3Y0fAGvPXYPFk6WDojXo/9YkTbxxCotrvNp/HG8orY5uxK70t8nuUPRl1dGlfrcKwXxSKC0udHaSO/9NCZFfm2YbgrLPQxKHOYtHx/uNAB3NljGkGKl0sBbpUjeuKFYHPkl0C2+qOmBWDBSWltmfMWssG/UkJSDgjpv2JK9sp72MhOWCEx8rRiubvPSvgVfxr3OV5onNHQ2vHpUqhO28A6L3oG2v0wiOv+PY6tPZ5hRUNrev/i/BYFc1/pcuA2gd7LWqFqx3w4X1H2ihMAoxQ232vEh8IB5Q3oynxNcRwycqpeLW+cXy/a4paWQIK8hT2mUVLQEQ+5qChaL5p5tKxh+K8TOZTPYgQKzHfiE+aU0zOToHBdkgnoDXv86lDBRf2xfMLy+FXRne5k6ZZ4PHarYdmY/+nB8mQtVCnlWMMOvC2o5YzQ3KfqtWpRjfoFg4KkgnnKjaLEpRVY4/Dj48E4wf3CbAoOInTPcfTs8CV8fFT97CbBPNkge3CwN0IlNMuHotKT5TFJEld2GnhPh93bWlcuye6eW69R8Y26Mg7fpSUq3gCLUoKZX6q+MWlfg8ZtACUUdJn0LaAwEdoQdx8hX88jYONerLQy2aCkKJLmOyLZDiEhdwayC6oEZTRpn386LpD8saCpLSZEB4os38KUzHw4oTJuzecu27M6gQpW2dC0AxkOMXGK0++mL0BzbARyekGSuIICjZ2S45dQ3WMaKjW0OOSiks70ZTt/TQv8tt4No0k5Cs6bZG7SRG8l9YCWeUwR4yNEnqT2VuJ51lsX+AbpXjKzku/fiIryEc0UZ7J72b9MJ80pXHa078J0ABSFcvScSu4atzfrYQQsiHujNo/p+SNsxLRk72VGjaKfM1/MF5kcu5o2hsBmZBQePMFu bvp+AyPK LaHbTFT16HMFX+L4MfLi836NcU6FshyEBkd0X9QzbrdGXZ/x2bV7ZuH4qmUeu62zIwua+8sWCpRsJg8DscKHwXMo654rX5u+ULoHsSe5wnVG/KkGTlQcCSiRK1hCwnXAQ3LgUp4jbXZyhuOy2M1QNCVHQ/Q47pmeRQusgZWdaFTRn+ScbAbP5JYQ84apXUhH66eV822JFYqCffaR5TYcI6J8dy96AapumQXt4CQDD+du0kBbvTOkELuBQIGR17ZplF3ZWQlJkhTi67i1HV+2lBHf1v6xLCyYHKaEciBveHXjIhUEEO7WthsfuF0QevSUxXjfZ2ok3Uiwd7r8gEBQEZ9tWMUyp0NW1jVrQHB0wLF7BgodtCCPmAxPwECnh0aJdd1SjJzOAJSId31mzoZLvMkDKPnYxZKc9A3zepvivkP2GEctWr8ojWn98pmzTtU3ltp1RiDMRdBr7M9WG9t8q9/QPzsHP9tSGlHH3wVx8fv+iR0jtoH+7P6DYGcIedlvmQueyup0a+uhD8Emspdzp3+oVc8lXDVwr92C7bFQDXR8uuXLBfrHF2Oyw5PoIkUtNub5dF01XfAV5o+Ti39mU3f72LvFYtrZ+9QUYrC+SWvL7jB+Hs2kuDMCDsBbQtRh5x9LFE5xstqf1aYkjGiPv2WAnE5to6nbHgwNxnFXVjqefMDM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > +void vm_guest_mem_fallocate(struct kvm_vm *vm, uint64_t base, uint64_t= size, > > + bool punch_hole) > > +{ > > + const int mode =3D FALLOC_FL_KEEP_SIZE | (punch_hole ? FALLOC_F= L_PUNCH_HOLE : 0); > > + struct userspace_mem_region *region; > > + uint64_t end =3D base + size; > > + uint64_t gpa, len; > > + off_t fd_offset; > > + int ret; > > + > > + for (gpa =3D base; gpa < end; gpa +=3D len) { > > + uint64_t offset; > > + > > + region =3D userspace_mem_region_find(vm, gpa, gpa); > > + TEST_ASSERT(region && region->region.flags & KVM_MEM_GU= EST_MEMFD, > > + "Private memory region not found for GPA 0x= %lx", gpa); > > + > > + offset =3D (gpa - region->region.guest_phys_addr); >=20 > nit: why the parentheses? I simply forgot to remove them when I changed the function to support spann= ing multiple memslots, i.e. when the code went from this fd_offset =3D region->region.gmem_offset + (gpa - region->region.guest_phys_addr); to what you see above.