From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8FE4C4332F for ; Mon, 6 Nov 2023 19:06:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 566E76B027F; Mon, 6 Nov 2023 14:06:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 516556B0281; Mon, 6 Nov 2023 14:06:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 406096B0282; Mon, 6 Nov 2023 14:06:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3201D6B027F for ; Mon, 6 Nov 2023 14:06:25 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E3386808E4 for ; Mon, 6 Nov 2023 19:06:24 +0000 (UTC) X-FDA: 81428460288.20.CA4AEB0 Received: from mailo.com (msg-4.mailo.com [213.182.54.15]) by imf21.hostedemail.com (Postfix) with ESMTP id C67261C0025 for ; Mon, 6 Nov 2023 19:06:22 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=mailo.com header.s=mailo header.b=kRDUmg35; dmarc=pass (policy=none) header.from=mailo.com; spf=pass (imf21.hostedemail.com: domain of drv@mailo.com designates 213.182.54.15 as permitted sender) smtp.mailfrom=drv@mailo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699297583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pzVzu7Dwdig5Mo/00pVBUyLbnDBjl3/CZmR2am+Mu8o=; b=43eCtfyTv1HSwASFtAEjEsmmvA4BGG8QeDX5zMuzzHhAp9Zftcws96wgdz/34FtHE8x5Ac jgyWaAbGwy9wQwCP7UYxBV2pj9RHsTK8z5haBppO07WwLZlKjJWSyPNnCFlN484i+qdMpp BRxSlTx+d+DGUgOeHLexG87peJ/jOqw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=mailo.com header.s=mailo header.b=kRDUmg35; dmarc=pass (policy=none) header.from=mailo.com; spf=pass (imf21.hostedemail.com: domain of drv@mailo.com designates 213.182.54.15 as permitted sender) smtp.mailfrom=drv@mailo.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699297583; a=rsa-sha256; cv=none; b=Nd8veRzMeqrMsQZ4aNjIRNOLCSp6qw/rHveiVEl4FAKiHiUTEN2PyqVEiWeLTrMm+X5Qq3 gPAscxkC82vfM/bCwI3Zr81jpEKT2OYd5Y/2JNudTCJA48dIiJZCTgIaON/gYhVqRD22+v Ev3fe6MedTpG8w7FP9ECcAFdPo13x/o= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1699297562; bh=pzVzu7Dwdig5Mo/00pVBUyLbnDBjl3/CZmR2am+Mu8o=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=kRDUmg35yCD+ztLKkQP0yqOJ9ngRorV5sLLfHHqO6WMr7hECpArm3ukXSZRQgxXhM 5ByRylBptMWhkSVZsb/gGGXgS+UVh0s+jpt8z009pQrmY6J719RM4QYU8y+s2xxNkU z1q+Nclonvs1Azc4+StlxH31SD4YbCKMDh6prp1w= Received: by b221-5.in.mailobj.net [192.168.90.25] with ESMTP via ip-20.mailobj.net [213.182.54.20] Mon, 6 Nov 2023 20:06:02 +0100 (CET) X-EA-Auth: kusI/K9/2vFZbosj6opuFTlRppRhSIp15kRkBtBWy8fzX1PimYFwzRDoiBSGEgsIv0QosBXzI+09K53Li6tVmwhnDuFWAptn Date: Tue, 7 Nov 2023 00:35:55 +0530 From: Deepak R Varma To: Dan Carpenter Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: eliminate potential uninitialized variable warning Message-ID: References: <739e6aaf-a634-4e33-98a8-16546379ec9f@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <739e6aaf-a634-4e33-98a8-16546379ec9f@moroto.mountain> X-Rspam-User: X-Stat-Signature: er5bjrphok114i5dryfib55jwtrpqmxn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C67261C0025 X-HE-Tag: 1699297582-129122 X-HE-Meta: U2FsdGVkX18iNkmlqkekVf9Di8KqbNHue0OYl8fW36u2gYU2Dva6HRfzbVaZIQsRKz/xW4ela0Wqt66kWZOeSVRyhKxklLzH9TEtgsXw4a4amTsOjz9VxL7R/0nChnI5dq7GCg8ZtJKkylI3EKY+TVYAa7dWn4jBiO2IVdur1TByQcZgRoeHk6r0SdzYIB7FQgcggmqNNmFMRZ1ZsNOa+a8ZVb66cEnBQDJxtipg8Qg8mo/2TJePP0PqoDr13EAfZHAP8bflR3ovK/1DmWQz7q6aEdQCA0jMhcINVQeA9jwBTU5CnOFPL5WlSsVe62SWWno/H4uubL2EdvPwXBw5hGXVrpcse9FwbSnyZNd6dSwAjagClrS6OiwgxE6MNgUtRqohjlHd1FunmwH6K0vSjTKucW50/scSn5ZT0tFLOwYM6OOtT+ejQFBdS6WSvVAqnXwpZuiuXg8fZxvwfDalbI/iC1hdJH4J4CqQaEnREI3ZkR62gYqe8bX9o7wNFclqOx9UA2yAr+VHipVXkbY7XClPONsgQkKJAqJVCQDqPI0T2CbZN5UziBmHrV5giGsxc3O1wNMfdxSdWIVrJhVI3Iobgqs/i3JBY+ANux+v9RaUWUNWmEmjxAUw4/6MKSQR/SnLlrC8JB7iRutV1xf4IaigoD9A6xtplgK9zMWe47qhIPRYfAr0YpVX1BJuo1q3NyQ/SJBr1yjXFWvbvEoocomHTADbmHfToIL2xGzCp8PndVp1DM88Yp/qI5OMF6tDiukxu6Mt6QxBO7v1ksPkJLT+ZVQ8b5FoZl7iDOdXfcLHjoZbnU824KKyM45WzpF7U0OfGyMxZqWvQohGyU1/pdsmTCG4jZOnrzqMX74GCF18YvkEEnTUvfgI4iAORPQ8bxPHcVVYlIFRinxR0JNJ806TZrOjf4vtqP8axKLfvZbQ41o2k9WJ2M4USvqrY/jlOo1XGrKbDu/TazDEjVE zycWUL7k N9MQQStiIF5rbOhvUE+hCebyLLUDtiLW+ViqdpasuDqfcZsB+pSk3lKukoTzpxYbKyMhettexdt0wUxjxOFCG506Ph707nog1vkg0A01XGrwHHveHpIjqr8SJwaoBLAH8m7W/DxXNlXO8b9TXYyBEz6OV/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023 at 05:07:40PM +0300, Dan Carpenter wrote: > The "err" variable is not initialized if damon_target_has_pid(ctx) is > false and sys_target->regions->nr is zero. > > Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit") > Signed-off-by: Dan Carpenter Should this be a void function instead as the caller is not checking the return value. regards, deepak. > >