From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493CBC4332F for ; Mon, 6 Nov 2023 19:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4FF56B027F; Mon, 6 Nov 2023 14:00:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFFA56B0281; Mon, 6 Nov 2023 14:00:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEE5F6B0282; Mon, 6 Nov 2023 14:00:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AC1476B027F for ; Mon, 6 Nov 2023 14:00:28 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 594531A085D for ; Mon, 6 Nov 2023 19:00:28 +0000 (UTC) X-FDA: 81428445336.29.3DA6041 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 2DB59160002 for ; Mon, 6 Nov 2023 19:00:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iAUlm6oE; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699297225; a=rsa-sha256; cv=none; b=8XkJEn2BoSSlh6hOOa31+CCdF/y0tdDgg2+MYVeGoHy5Hz+1vO4GxJIPH/28JMJGeA/U3z XkfyvJ5l2LJ3tBwOfSRmdFsdAXs5gRH3i88we73nUjNqYYL1jbsKlCWyCkZclOpiXD6s4Z 2LFerEFDHQQsk72RU8j1pw0tQd7ATIo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iAUlm6oE; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699297225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S1v0S2JecaFdDuKteJQPQfqSbMeszz0DlIV0jVMrBEs=; b=BhAWSm2JoKHz5n0IUcR2ia+f+zCVXVwHYMHmp+PXvRbxnpeanVOApSd0eaweMd8DIwnI9v N60rT0bXOOfN6BUj90eSnPoS9ljceSqtlvULJuPUYIj9E2alPmIkWDAslmG+UKo92/q2du xcoGdchWqs8SNEGNRjOKOtVt74qrWOE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S1v0S2JecaFdDuKteJQPQfqSbMeszz0DlIV0jVMrBEs=; b=iAUlm6oERK7x44Sld/Wg5L+uUl NdFtvZIpve6t49PqXASj+HLAVbCkH/1V8oiMJXxmIgF5UaY4JmhLiROqZjH/wI8gT2Hkyinonpvhg SV1bFvn0KNo1lBi2heNS96mlIP+1LbsNWMkpOMk1MmQg4+IHpvfw6m3Wlvf5xU8T0upPE5CQtDhXw xSx038MlfmTDx0KLeioKVvgBdXIk/AF7T81tg+L7j8GSE1Lo+g3aiLn13n96ykvPPIx/OjQVZgG54 9BPCoY9SIoeM3pZskimmZtEqsenTTz+QFkzpddqwc5CbZ4zycHoOydwxMcKMAIjcy9N3ZrtSqzenT Zs7yNhlg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r04pH-007dUy-GT; Mon, 06 Nov 2023 18:59:55 +0000 Date: Mon, 6 Nov 2023 18:59:55 +0000 From: Matthew Wilcox To: Stefan Roesch Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1] mm: Fix for negative counter: nr_file_hugepages Message-ID: References: <20231106181918.1091043-1-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106181918.1091043-1-shr@devkernel.io> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2DB59160002 X-Stat-Signature: ktrgb4hd81dkb7634779q7g3okd861te X-HE-Tag: 1699297223-658123 X-HE-Meta: U2FsdGVkX1/FWOqDRly31oWSJVxs+EdNfb5oQjSlReDOct+z2cF0NwYX3W4YjmgOGgf/QRCTBXxb8Rq//OoJcfe32OklWNywotCfvQkD/kXY7IqgnWH49qWCoX5Uxh0AL2TCY7JItbxwOeoCaMaR4pQjb/SQEhkwXUP8iOe1JEJ/qrFc+4GlBfyu+FF5HJCaU0toriNTC3N+I2zmzVY/1Km4Zc0E/dp4oOayJ95j2zGMTOfGfGHyT59UtaH2epUSOyL6DUJOLJ10erDdTOtFzQ/emLqgmj3jYIW1ZkkenEnTs1BF7cdc5w/Z7lGEGb07OKA7MNKsEuq77EHPDZueQ1VvQvAmfJMqC7vGKIRg3rfYtWj5QwnFqrCsel7R9eaSJprTmgG64QQ67/XSC/RuoyUwfHIiuU8fGTM+rzDY7awZd0ieDZOi2WG6mXOYiQK+G0iagHOkywKFzeSZkoCrFxETRVHkgMQeMP79nTSw58ZFzB3zgpyuck0MflBHeEe3h30OFwO4M6n/HBCK0qrwsAaDChlXrJP5TtIYydGQqqn7XDyPSHyjD7/dg4kr0wDEMR4AJ4lU0xr5/CX3adUVZR0OQb8ZEVmOTfGWwiPeNQPgss02q8FMrkkzibAiAogBM9XY9b6fWY4mut0giff0bhg6iliBmeqrzsSh7bqqOUpKgevIj+Z/DFO0RZlkTXGG2N6/iyFFuyiQurp7FVoeh7rsKuxNyrMMhAEAAbHUOKBzDN0Thned15rKHg4QNia53nUpUKTxAVlytk/gj0o485qZEZDcBK8JcleEDaKenJmQt5DQX5VtRcl2WfvCYpUPdLAnXIe7BcVSlAdyI4FUpY1jR4qzfh7lxGynN9pH8kpkEpogMZPTe7i8Jig0x6FrHzXRgolfUcm9/KIRyjVjj/HL212yplmH8P451DrVRtVG07Pu4DryTpBKwOhVr96ZE4e9pZAOAW4zKGzWlBd Ihiiy5b7 8iXKEYN2TqpghyxDx2eo430fvHwbvEQCo4qIFX1BDe6i8smnmaD+VYkV8Wdmsdm8L+dfFSQioJMiwhSYutti+SXBKqUEI7qwZbvWG1RXev1JSpyShuR3fRyJDwTKrdzClRHZz9+P8tU1SSqJMrbEU3E9m7NXdr20PVg8Ck3tqAx25dsJXSckBTd/pKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023 at 10:19:18AM -0800, Stefan Roesch wrote: > +++ b/mm/huge_memory.c > @@ -2740,7 +2740,8 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) > if (folio_test_swapbacked(folio)) { > __lruvec_stat_mod_folio(folio, NR_SHMEM_THPS, > -nr); > - } else { > + } else if (folio_test_pmd_mappable(folio)) { > + > __lruvec_stat_mod_folio(folio, NR_FILE_THPS, > -nr); > filemap_nr_thps_dec(mapping); Good catch. Two things: 1. No blank line after the 'else if'. 2. We're leaving a bit of a landmine for shmem when it gets support for arbitrary folio sizes. Really all of this should be under a test_pmd_mappable.