From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D40C4332F for ; Mon, 6 Nov 2023 18:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 200946B027D; Mon, 6 Nov 2023 13:55:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7466B027E; Mon, 6 Nov 2023 13:55:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C71E6B027F; Mon, 6 Nov 2023 13:55:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F2B086B027D for ; Mon, 6 Nov 2023 13:55:07 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CDFDEC0531 for ; Mon, 6 Nov 2023 18:55:07 +0000 (UTC) X-FDA: 81428431854.23.9F47942 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf09.hostedemail.com (Postfix) with ESMTP id 0259714001C for ; Mon, 6 Nov 2023 18:55:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ifv5spS+; spf=pass (imf09.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699296906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vhLzSo2ZdsS1cNYMQVnH8qp5KlM4qInxdfA0/jF4QCI=; b=cKnz29m15dLlLpj1Kys1nkqMqVWzKYxZ/p8A/5S+somTnz3iRMafkES+JPmnvoqNG6406P EJRnX/9aaJUkwqNH0Rnubx+m3xezGYWfW66VQQKTaqBp0jXIN2FHyBGF3QFiXMEykAipf/ 1WVfXknfL99uRIzwzB+cbrS3W/kUqMI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699296906; a=rsa-sha256; cv=none; b=S0bEiJ9OeIvM5nhxyM6zKKsH20JOCey9yRh5tehmgt7y1ofRV8zhHBrYl/zE0KIoFMXw92 JrZPGW661Vp4+CSqNH0kAyQN9UqglHWGYJI9bOebFAZ0xWiLNPjcAHWdyyMrq54GzNv+8w al88CWvyP2Vha/er+ug1JyLfNMWoeLI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ifv5spS+; spf=pass (imf09.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-d9ca471cf3aso5052534276.2 for ; Mon, 06 Nov 2023 10:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699296905; x=1699901705; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=vhLzSo2ZdsS1cNYMQVnH8qp5KlM4qInxdfA0/jF4QCI=; b=ifv5spS+i3RoPW0+TKM06mAo0MpkO5dLe2vIzr+68EV8p50axpbSgr3AvqYSXzPz+L fvx+oLZtPzZ+OmICE1s3ECfab01gZ51MWS6NPT2tnPIMKd1ApPnEwcg7XxD/SztFXCw+ +HS8WRv/RgsQlZvqkzQgkzvRXtvJ/KUwTw52iaIQgqf/VIjmkMG7SjI+WBYetZi/CUgA 3ex/euHEBVBXhMmIIp3OmK8PS/X4+1SEm2qPvagQiZYra2ltHyGIO0WR27Ca/ftVye5C aZtQi0pd3dh61i5gQD8/ZOnEgDXmMghhjm3nCjLBFYaBiwl8/Yd3/A/0t6eB8Ps+GB+i 8hIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699296905; x=1699901705; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vhLzSo2ZdsS1cNYMQVnH8qp5KlM4qInxdfA0/jF4QCI=; b=kSnrPxZm7i4cftE7viHzS4cdgs75OfSdXoQ0dRuzedI2leXDVN9BoAS8PvHO8m11WE 0TqTvLGdxjrADwTpAbcyowAxHxpMluLGvj3Q6zROQfCLfJcfTNFK7cgcqX+Pb9Rb06wn u6gBzG84Yhn7zlg0Gft1Kk/L9JFt7m+jMULA6DPMoclyb684zdnjMoRrozIWtIr8B1gk PFCVQYQzxZnqC2fCRpPRC1L1iT4xHHczgyqXCmbtxIqLFsv07MZJzMlrbZf6PEL26UNh icxENU51cFX1JG9N0PjWUmGZMu2FWpPrn3YUYU+eI2pQ+zTfBOv6L9A1xfQKnAz/S/iK vHEg== X-Gm-Message-State: AOJu0Yy2uDCoeo0pZz8j5F125lXhpfDnZb7650i0NN2YRQXNgrfNT6uL d6lizY2ryDe8RE4b0evnCew= X-Google-Smtp-Source: AGHT+IEJ7Z/Zl9Si6wi3vI6C5MCyjuEizvr3x7s3+sIED3gUWfaO8DNl9Kxv0Pys3EFaVusnV304EA== X-Received: by 2002:a5b:d49:0:b0:d9a:6301:c82b with SMTP id f9-20020a5b0d49000000b00d9a6301c82bmr31039102ybr.13.1699296905021; Mon, 06 Nov 2023 10:55:05 -0800 (PST) Received: from debian ([50.205.20.42]) by smtp.gmail.com with ESMTPSA id w142-20020a25c794000000b00da0c49a588asm4300672ybe.8.2023.11.06.10.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 10:55:04 -0800 (PST) From: fan X-Google-Original-From: fan Date: Mon, 6 Nov 2023 10:54:38 -0800 To: Vishal Verma Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , Dan Williams , Dave Jiang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer Subject: Re: [PATCH v9 1/3] mm/memory_hotplug: replace an open-coded kmemdup() in add_memory_resource() Message-ID: References: <20231102-vv-kmem_memmap-v9-0-973d6b3a8f1a@intel.com> <20231102-vv-kmem_memmap-v9-1-973d6b3a8f1a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102-vv-kmem_memmap-v9-1-973d6b3a8f1a@intel.com> X-Stat-Signature: xoq7n4mkrz6d1gdc4ho1bzanx7fi3mt6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0259714001C X-Rspam-User: X-HE-Tag: 1699296905-415301 X-HE-Meta: U2FsdGVkX1+b7DX2Ih58ru4IGE3RvsxcAGH6SguHg+x5E6kWnoh9mcHft7pw12jTM+7DDG8cLM9jAQJOG+ygNR/D7EHRh3QrtOWDKpbRi++sBc6p9Ue7iDcZ+iL3r8yhPqAJTA83Z+Mv+qE1O4S5GvAVZINXUWiZzk7s+pxnCSGKRZFDo9yAp4s/zcZKKlKfbQRByVFgmOrcwlAKVHtGta+stxaTK6Jmz6sVkOUNQo2+e0ktJns81ZJ7+Hkla+RtW4hxn9T9CWL5lhhgTRAGzbX1/n4nHLXd178ni9Ml9+P2hukpVnV3n1uKX32rt3hvYGE3SDuuPSFkMLlFkaO47xnnFg5LM90OhFHAC6fIFSkitgyM8hRDQATp8e0BJlyAtW0PkDPcRYVB7psguaQAhC3RgrQw94CJCTCQHosNfDkQ0jP0z8wKVRp3V8QB6PUS6KHUAMfzVWqgniRoFPiOgfC9jJqYTU5YKGCXF75RCuIS/9D8hX0jfQZCa697rjTBMSU/PtAivARzm3pwaBLA3svLXG/wvLfJg0f/QMnprQp2vVzbPs/SRYu18+5DZPZxKEWYETehtYRLvx033jHYCWkMqE2shAhtGfVZ8RYjQfE0WZnuz1kupPrZvH5mLsIlxXcsr1rmuzm9aVbZnvL0fAvsaL0IlkosX1y9VL8TJYNGSK4tQx6swARODFXS7YMP3hsbVIMzA5ljRtkdx0BA6XpbAyKFmt9ZMGsYNi3d7wlBs1wN6R34dVQr8rN1PWYlavrzgxb/lgtIeMWCw5lfRxFGtbCmkAvR8JMVV3NQfPMU3oittUx/5Rm0p8sQ7wfnlaHsgzxDfqJsRzqqQTck0XCmJaokraja5rvDuPfRi8oNRn4+zF398bDrDsPfafHZqV8DGp3I20K+BxNO2EjNqKspcDEmKmqyPzeDYEjyDn2Pj3moSSO2dqLbZpI9TTERhsfdXAnZdSGSBJJ9rb8 y+ym/VBQ zzhm5RPBO5CDpHdLa5H0AuHhWsl+2b30N/q1xcJ0aelrjCUE/u+KoHZfwpjaTzMWH8sH8wcLMj6VB886akmagUd9KgvjPpbhJl2+pwFVgr+SDZOzs8i2JkRDXhGLfoc3CzB0TdgaNo+YBH5hQlQiQUeeh+7+3iZ4BToo7D2KlP7dC8hqIDnYKSLjlorXuwbjSjKjB4Jd36S1Mlj1XQFBO+7AFuZPg2OBUbcKd28l7ZgiF+TVn5NgHIMWObR3HbNbOHprghSa8pJF4UDf/hQ4YwgYNF3e9NBenQGzcZ+ljn/yZ4zXi4rAUOFfKuJNxc5LpVQgDsc3AMfVwhv/M4uhiwaCyQbIQ+FhC0yHTvQK4P6tJ6KR0PnMfDH8eQENxbHGHkazAZAKAWuHxi4Mci0Qlv0+FDoWvQJdHgPBnRvLm7+SNTbB2Zq7pEPof/AvoTXM3YGvxuRZEzdMuGSHxXnY8189/rl0LDbhxARlEm4lBhxs7vYjE5RWZm2c+dlnc7Jcb2Tza6Ig5UO15gq3B9OBjS+OHsvZCS/wSoPKbpkvUeE+VCd/1lcsKXtEAGTshQITkxjiD4jayW/OLGThnkZ+qHavIRdWCh25fljCh3sVtsMdFqgmmu40HkgN3lUHdO6zJTql9XcGuOFdNe3fwF7kzv+QWkzAhEVHBgVFIQkhv5d3v4pLb8LxMIwZ0wbTa0DNN1VEX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 02, 2023 at 12:27:13PM -0600, Vishal Verma wrote: > A review of the memmap_on_memory modifications to add_memory_resource() > revealed an instance of an open-coded kmemdup(). Replace it with > kmemdup(). > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Dan Williams > Reported-by: Dan Williams > Reviewed-by: David Hildenbrand > Signed-off-by: Vishal Verma > --- Reviewed-by: Fan Ni > mm/memory_hotplug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f8d3e7427e32..6be7de9efa55 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1439,11 +1439,11 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (mhp_flags & MHP_MEMMAP_ON_MEMORY) { > if (mhp_supports_memmap_on_memory(size)) { > mhp_altmap.free = memory_block_memmap_on_memory_pages(); > - params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); > + params.altmap = kmemdup(&mhp_altmap, > + sizeof(struct vmem_altmap), > + GFP_KERNEL); > if (!params.altmap) > goto error; > - > - memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); > } > /* fallback to not using altmap */ > } > > -- > 2.41.0 >