From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479EAC4167D for ; Sun, 5 Nov 2023 13:04:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1BB28D0007; Sun, 5 Nov 2023 08:04:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCBC38D0002; Sun, 5 Nov 2023 08:04:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B936C8D0007; Sun, 5 Nov 2023 08:04:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A9D5D8D0002 for ; Sun, 5 Nov 2023 08:04:44 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87E54A013B for ; Sun, 5 Nov 2023 13:04:44 +0000 (UTC) X-FDA: 81423920088.26.E8A819C Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by imf09.hostedemail.com (Postfix) with ESMTP id DB83B140012 for ; Sun, 5 Nov 2023 13:04:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=luiuFZ4C; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699189482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9SMBpTiewq9uum8pa+C7PlxeCu0pFD1zXCwEef5PLCk=; b=bHrq75cM2fcpULjng0KiYrGTH/22MhlWODWjAL2u1HbmvJRjxdoFuV6yIlksT4JGpgqiie vAoWyPt4Hnzc6CvuiiGfB7E2VCwxeHZ4YobyVjhJgLWVTGegZibxGeL38ZZAYNaQrIKhqR uTlUCSdnE0oyltiZI37bY+/hs1RHFZk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=luiuFZ4C; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699189482; a=rsa-sha256; cv=none; b=gwGxsDTrsKy38MHI4Ct0raoosK+radaWca434bXr6GeFMwKFV74ZwOnptNnV1znQZhCfj+ 6ckFj7LxJR5NH+Y8T/ASJo3lOl2ZnoRMbNTunAP6bPb7bsWJugqjPmm393HJldRXvvqMQS TqzQpxjx2aChiqjRw4JZMOCk/EoCtcw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699189481; x=1730725481; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mFE9c4kKSFVvQT9y1x5f+rwwI1//UOO/ul+Hvls5bPM=; b=luiuFZ4C34ioZ8qEi0FjhegFU8oLxs9xjJI0ZqSPZlVAJqksXjuHOPGq zFP4E1aWHLTglJSoEWBnnOPNXjyv5cR1Z4iQ18W+7lmve4DuYfjLc3lXN qiEWchOyAq7umFnaKStqMzfl/DvVldBT+R2CCH0Inz6IHlMIOnBbDNBnM WOhKBGCKOHlpiHYU1X5ZItHhuPMbeZ6x/mb8RLfKUbCddYJ3Kcfdq8+GW ANLaZ/PQEn95ijcmt85NWenE+wQpsMzqOUW00Y1rMFP19KwJ2/kCEPe1T 7cmPglRxXJ7Y31eN81K236x6omElW+TS6+oOQv65IIH/pSDp+vhpsj737 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10884"; a="388033727" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="388033727" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 05:04:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="10206430" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmviesa001.fm.intel.com with ESMTP; 05 Nov 2023 05:04:02 -0800 Date: Sun, 5 Nov 2023 21:02:32 +0800 From: Xu Yilun To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Subject: Re: [PATCH v13 20/35] KVM: x86/mmu: Handle page fault for private memory Message-ID: References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-21-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027182217.3615211-21-seanjc@google.com> X-Rspam-User: X-Stat-Signature: u1xrt7j78emu77hbgsbczk7xy5fmn6fx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DB83B140012 X-HE-Tag: 1699189481-221573 X-HE-Meta: U2FsdGVkX1952ezE8o1prc1/8rMMYjCpHgsCmTmnqEN/TMmPq1ovG6tuKGGDzm1jx+JSh2yjPb55Ux8SD9wd5Ww26guy1jw6fje7fEcLilumUyDIS3jxOUmKYjAlAqm99L76En2qHzZ/7p9gAL6jewZjKfHvdk2G6sn3rYxaH5ozg0WaFVV+ZfLIQzFgABHEqoPNMxUYHGIkPAYGyAjrSl4ixOX9dsbQ1XwaissOl1aJpatSXLNtwvyX175AhNwL++oS2bDEALxbQqRywITH9immbJMuYQUvbEThG3Mj+KPb/EduiKBXPXqFj4uh9Ez13x0jxOYbTOi7ZzjZEcZNn4WrvCqWQUexdTWH0R6VcZJvVf+u/2dQRJvlBP4IfCb7bC86f3iiJwRSsrk2h51iMhSSE2qP/r8fjD82h4t+b7YpaHxviuH4Ij4bnZ7ryvCxocpq1uJHhtir3qqhAy2tw1kFkhdh9u+kJYiXBrxq2BDIJaiUP3tXvgERVrEVYg2nvBJZKUUw++kSnD7Y1rpNwe7i8CQ0MkmBzYNGgWX3ggQGX0DNGMvFi3VI69mTH7pJqp7AgJQMx7h8FynlocSOJxEPR8UnLZubDtG35cKWbwjB2yjYPamq8rhS26vffxzJvDufR7AVv8r0nuA4tGnuGS5TGA5dOI2e4e0HGtzbKH09S+tMjytA5gfVESX1Hfc/5EQlISTejVkp9naxMg4GDpOnDx8MIuVSsQNjtKiU9xC2d/Cf/fLOzCbl6p4Ob4W3rLDA0OBK0ahWUmg88m8hX5bGWnH/C3QIkjCx4bFt2JCs/jUHQpDUs93fZ3Gr3ndkTK5YYi8Kkra1dZgAU4p/Dqh/BLL6IFvvTltHRZu18H30iUmLAmUiOq+hd2uG5HFnJb/Ktkj/FNbuo7Gcjukmiq36WBF2qEAtX+hR5xPX+NyFjgJyrmwwL5ommbvfQt0Mixf6vE9iwHmAW9FI2Q/ ovLfBzBg 87u5k2IxnRYAhmksuNsLfScwbEBvBcPOm0DrBUkpDxavPCYcidBoQj8SheBtmcJtykXAh2UXUfgWNJpCaQLYz5dFe+KrRLHRwSMHwT5k0JPp1dV5qo7xhXfHlnZK8+jxZdtQ2UgApIXflFJ7uuJaGCg5zZXQTv92hRrHkLbL0UyM/p4bd6k1GcqK8J5HxMwsZbdb6KkaZfINvHgh+Ou+Lc0PfWHV46gm1RQFsNQneBSv61FI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +static void kvm_mmu_prepare_memory_fault_exit(struct kvm_vcpu *vcpu, > + struct kvm_page_fault *fault) > +{ > + kvm_prepare_memory_fault_exit(vcpu, fault->gfn << PAGE_SHIFT, > + PAGE_SIZE, fault->write, fault->exec, > + fault->is_private); > +} > + > +static int kvm_faultin_pfn_private(struct kvm_vcpu *vcpu, > + struct kvm_page_fault *fault) > +{ > + int max_order, r; > + > + if (!kvm_slot_can_be_private(fault->slot)) { > + kvm_mmu_prepare_memory_fault_exit(vcpu, fault); > + return -EFAULT; > + } > + > + r = kvm_gmem_get_pfn(vcpu->kvm, fault->slot, fault->gfn, &fault->pfn, > + &max_order); > + if (r) { > + kvm_mmu_prepare_memory_fault_exit(vcpu, fault); > + return r; Why report KVM_EXIT_MEMORY_FAULT here? even with a ret != -EFAULT? This is different from the decription where KVM_EXIT_MEMORY_FAULT is introduced: KVM_EXIT_MEMORY_FAULT will be used to report memory faults that appear to be implicit conversions. To allow for future possibilities where KVM reports KVM_EXIT_MEMORY_FAULT and fills run->memory_fault on _any_ unresolved fault, KVM returns "-EFAULT" Thanks, Yilun > + } > + > + fault->max_level = min(kvm_max_level_for_order(max_order), > + fault->max_level); > + fault->map_writable = !(fault->slot->flags & KVM_MEM_READONLY); > + > + return RET_PF_CONTINUE; > +}