From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12FD0C4332F for ; Sat, 4 Nov 2023 13:59:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67B698D00D7; Sat, 4 Nov 2023 09:59:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62B2B8D000C; Sat, 4 Nov 2023 09:59:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F2CA8D00D7; Sat, 4 Nov 2023 09:59:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 404A28D000C for ; Sat, 4 Nov 2023 09:59:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1D9C0C03EB for ; Sat, 4 Nov 2023 13:59:14 +0000 (UTC) X-FDA: 81420428628.12.CB83B8C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 5F4921C0009 for ; Sat, 4 Nov 2023 13:59:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KG3xZ24g; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699106352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KbQX3TX3AsShLw2jPMJYpsyjzTazVTX8lprkxkrhw20=; b=MmghFYH3tVdHQjBwASRsU6T7uoLFr+j6sdOLJyk61Fqyq0hZ//wyT1uSQqFjsEFKdo1/b3 9wu5Ep3joVSzOokGwdlsnMJQjTEComituWuHvr94h+JSf19VgGSYZ2xn7AGMyCC8tDPDuo WhraBTI+jq7DvoXr66P73iuqyOt13DE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KG3xZ24g; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699106352; a=rsa-sha256; cv=none; b=2LmcmPEK4s48XSEBnuw3XimgCEVY7XxO+44FAx2nCIZLfF2T79F5MF2bndmTFrEkgIaWHP k405KM/1j1B7hsGKk2dlOpDfCvqm0AknC6hWzwdu3azvMg3EGXxJzqiuKNfDo+hUuPUFC+ +PKXYoPwJ4oOPJrQ0FefAilKi/Jwl/Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6A91DB80AD8; Sat, 4 Nov 2023 13:59:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1F88C433C7; Sat, 4 Nov 2023 13:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699106349; bh=ngBgbPjGe4VY0Szfr2ipMZungHmONQzt8eNm8Edd7KM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KG3xZ24g4Ms6FoAbNpBwwlbXSEpCSghDUU+fDRae+OdLWpsin4az0vCy6r8t0IynX Ms26ILWTYmmM/OqNh7nFgxdyD2K4CHSQBztulYHjiVwoF8yM2KZPtugp9o3XN5yFRj fNxuW7ALkEZ17/Ujy3nn+avLV3YOP0NQwLPLWuiT7ghkZY59qRXl6xmMPsogLhrTVP Wvj+grpXl/EASsVcR+TiRNBcwRuTo/8C7YafC7qdESsEbYISlQDH1QLGdSoHPhCQhH Ci67QLIMLP3AeN0hCKZo66ixY6JFtQwwRZ40Agr2GSrBJOe4P32sJzeGO/NJwwQwKd 6VRw2CIosBc4w== Date: Sat, 4 Nov 2023 07:59:06 -0600 From: Keith Busch To: Mikulas Patocka Cc: Marek Marczykowski-G'orecki , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Jan Kara , Vlastimil Babka , Andrew Morton , Matthew Wilcox , Michal Hocko , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , Mike Snitzer , dm-devel@lists.linux.dev, linux-mm@kvack.org Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 Message-ID: References: <3cb4133c-b6db-9187-a678-11ed8c9456e@redhat.com> <11a9886d-316c-edcd-d6da-24ad0b9a2b4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11a9886d-316c-edcd-d6da-24ad0b9a2b4@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5F4921C0009 X-Stat-Signature: ncetbx16ejttomtfj33uc66rerhahx4w X-Rspam-User: X-HE-Tag: 1699106352-931512 X-HE-Meta: U2FsdGVkX19GZfL68+sgINJ3r3LOB1mJm0Y+WGTprJN2JnEFaFjgVA6dA6oQpqo6EhQyOATIRDWrIrlvr3cfhG8gs621dqa9roKOtwAyeFdt+SXPC6AqTgqFVGO+yVilr1pLcuWQ1jxNXkeskWHZewvcPj5pAjpABb6m4gIBH63eJj1qCijWmXt/Ilq590yhwvGvbGxcRiJWkpecLmdja8jfo7BVateM1GFebog/zTfTGtdcfPlP7e4xEDfoYmNZko7OhP/gaBGEI+uQeWhb2zoWU24G+tD32AqgSmCtli1jky06inSQwH0K7Qbmtz3U5IedKjGMEVncjFnvs28p05prtrTl9LgTaj4uwc+iBHDcE1EXxXxs4AFvaLLrKv2S66RDDptzvUqQZ/z5Sbg0XJL5WvH8uWLrqW4zQLRNqJ37gdk6NapX2xvXCTyuzqxtY5/pwsh0Q3Q+52CJpM1w1YV/LmInLNHpb0NjcOzgklOFG1R75hDe2nd9/wvcrA2IQDUBMCVCrt0hx+h739zdLgiIk8H6KNKV0Eak2/AVI/ae449wqrAHEqgW4QuE63OV2jNJ7tr3RtA0gKhDn5+jBZz9UK6L2A2XvipyrzoPy76sGRI+DXLBawPfs5Zj01P/MxLFsePMcWevjJ71T1hHkI3l2QLqMClQ8iwpGeGRJ3SMLWuUmYnmJ4+7FPjTiJqSuHQkESb3Fz0flkashwiwyyFyp4D1rmu/4HCo+0zw8kzVq56PS0e0fWHXY5YLd0wjRtY+rqLXHx00eXPpOu5kq9v52Alx4RlGF1JILScX1F3R6wNO5h+rfc+WuCGMo4cEWxuNSkslWRqHDRejKVRieoEcRU8SBZjG/OyDmd5uPFtPsoKYCW+dQhrTgaJJdhs2d7/WDiGUfbuw0PHmVKDLmZunolPOmgWC4cV6r4PVxgGLc56scaMJlgj2Qlr0fr8+jz3zyMzlXAl6V25bR6k dSxZw7rs XBq99aRlK5jt6bW0VjVdgFRhxNECWBE+r3sN2J7SIGNtCCv4JCTRBouThQyBFp8yhr6+5+qePpNC3LhoZpVnTGoRkPiqMsURoPO6b92vr9WtgzhjFnUGV2CA3G0INMdlKkG3nzDElhbIhwFDuxugd7ickZes6eZf3VhsThrhdVmZ4DHMgf7rdBZvNe6RGkbrWACkbpL9AFub7aOcjarEIDaDLdK5ZARV2Fs+z8ugs4RmI6DCyiFvq4hPmha6nLZXL3CHBSlKw51JGVzyi+PGAmyXCyueq7LHslkGC+5ZPr0UVcFV/O/3Rc/aOfLJ4xlDKiKmK3bo/a1k0EmQZGxseUDNJQKUDl7wb9pgi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 04, 2023 at 10:27:32AM +0100, Mikulas Patocka wrote: > On Fri, 3 Nov 2023, Keith Busch wrote: > > On Fri, Nov 03, 2023 at 09:30:07PM +0100, Marek Marczykowski-G'orecki wrote: > > > On Fri, Nov 03, 2023 at 10:54:00AM -0600, Keith Busch wrote: > > > > On Fri, Nov 03, 2023 at 05:15:49PM +0100, Marek Marczykowski-G'orecki wrote: > > > > > On Thu, Nov 02, 2023 at 06:06:33PM +0100, Mikulas Patocka wrote: > > > > > > Then, try this patch (without "iommu=panic"), reproduce the deadlock and > > > > > > tell us which one of the "printk" statements is triggered during the > > > > > > deadlock. > > > > > > > > > > The "821" one - see below. > > > > > > > > Thanks for confirming! > > > > > > > > Could you try this patch? > > > > > > Besides min3() being unhappy about types, it works. > > > > Oops, should have changed the constant to "ul" instead of just "u". > > > > Anyway, the overall idea makes sense to me, but I don't know the swiotlb > > stuff well. > > > > Christoph, does that patch make sense? For reference: > > > > https://lore.kernel.org/linux-mm/ZUOr-vp0yRkLyvyi@kbusch-mbp.dhcp.thefacebook.com/T/#m8d34245e0eef43f8e9fe6cba6038d77ed2a93ad6 > > dma_opt_mapping_size returns "min(dma_max_mapping_size(dev), size)". So > you don't have to call dma_max_mapping_size explicitly, you can leave the > file drivers/nvme/host/pci.c as it is. Indeed. > What about the other block device drivers (AHCI, SCSI...)? Should there be > some generic framework that restricts max_hw_sectors according to > dma_opt_mapping_size? I think it's just like any other request_queue limits and the individual drivers have to set up these. Thinking on this again, this feels more like a max_segment_size limit rather than a max_hw_sectors.