From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D767EC4332F for ; Fri, 3 Nov 2023 22:42:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 045428D00CF; Fri, 3 Nov 2023 18:42:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10C18D000C; Fri, 3 Nov 2023 18:42:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB2718D00CF; Fri, 3 Nov 2023 18:42:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CC8528D000C for ; Fri, 3 Nov 2023 18:42:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A42F616138D for ; Fri, 3 Nov 2023 22:42:30 +0000 (UTC) X-FDA: 81418118460.05.E008AB1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 9563040004 for ; Fri, 3 Nov 2023 22:42:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qfmzVrQX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of kbusch@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699051349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RnklPu8n6YoPUITHj4CjGSsP4aHuY1l1r8GCmHYCASA=; b=AJc2c2Lcg4F1X/dX3UY9615YqAWi+SUl8jdT5OYkO+p2fL99NJ6L41Zj2NcKijGu2huiH8 PRnu6ceUW9aztSlLIsQ9AnEJEzNn6w7USE4uQgnVk9h9xxuOZxhupeuJApjorrQGwTNunn EUBrOfkimv0V+30oJiDGmg+bEzkPkFQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qfmzVrQX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of kbusch@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699051349; a=rsa-sha256; cv=none; b=XkIP/KWjuL4eLan1vn2iCd8KEjuCjAJz3BjWaY0o3SSnXcOqmv+lPh0rXfu8n4hCWECnuy NSroq8Zh/h5vfRK+NVrJUBYuZo4CTMFtu+r0eZUC4yzIih1zGGtmZB//ViZ/XTUQFyr4Zc cOTcQ9vcQ63sNVEze0pS2DECMKcC16s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6EDC2CE20DF; Fri, 3 Nov 2023 22:42:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96C91C433C8; Fri, 3 Nov 2023 22:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699051343; bh=M+ptlKAOA+sEX04/48lagPpY5EWZpkTUmUL2k+ef/pE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qfmzVrQXas81SSCB36xz6q8EtGP9twOOIhmsKM+uoZfMsW+0wM/d/2SasJdjn2WwE fl/yMQXNLZ0NuKwY/i9K7SiBWM+pukZzeYlx6ZpnS8SMfWzQnDrxKXtxqJ+kLhDfA7 sXk24jYSI/be0ykfa1mka/drdfyx724vCRMX/uaYshRasQkMCBroWscqqQv+X3HJ/R jyJacUYfBNZ0XqBztWabkaMXJr8qfcfcNxCJJ2Kxcstq0rnTNwgE2ArwLfNnbHRJet VOxYUE1gAB/nWF/jIy0KoHFAQVGPLJTenAKFF86kL4jbLv09qscuDGu8v7dQlZn83S WkSaQZTeGvgig== Date: Fri, 3 Nov 2023 16:42:20 -0600 From: Keith Busch To: Marek Marczykowski-G'orecki Cc: Mikulas Patocka , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Jan Kara , Vlastimil Babka , Andrew Morton , Matthew Wilcox , Michal Hocko , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , Mike Snitzer , dm-devel@lists.linux.dev, linux-mm@kvack.org Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 Message-ID: References: <8a35cdea-3a1a-e859-1f7c-55d1c864a48@redhat.com> <3cb4133c-b6db-9187-a678-11ed8c9456e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 3a6futjpa34ipekwyr9dhxht5kuifh1w X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9563040004 X-HE-Tag: 1699051348-988680 X-HE-Meta: U2FsdGVkX1+mlHU8YFxi4WkHvWUZ5KiSw53iC+aiYy1munb/qZWd/KV2lft5vqyMQ8dGm9+fehaTMb//EgiNfeUDQGrtN4USIHyiL+eWOszz3iZMFelTO/lgAVj4tQE3ufNg9SaLXkAe1jDcr52oQZfyOdMh/QqIf0U0gTKEB6prckX5ZeQdCMtBySEbAI2wsBf83zQwI89pQi3qFy5+KT+0W4deMUl1VAaz5sQYzW2WzYSMB6ppkJvNAQEuRejdi2Z4CyFKRY9Q9N4C5thTNrPaGjiLDU560kfS3Zyw2Wsjb4m7EHqoxHxMsAAeuwn19Y8+VFLWYm27bSEB6he8zOFpax1ZbNRkow2nNb6Q5Ayu7fzWy/8Iuj0I1c2047Cw/Aa7i+pL5RyGNerAMOWA41wnzGGWuC+CdJToOX0wsl4EOXgQxyz8Owh/930RwGAcf8AdRCP9s6J7CnVy0mBkh+Pie2dpjNE9Eit07gSxOEGWKWmQ81X4P8/nOQyAB+kjA6EpFVLKtq3D7JDXxcy3eJsKlNpICA6rtNT0EC2g/SZ0i6S7qj9tu/mDQfHeR+1mBhG/0zz5ifZfmiVlhFrwdtOhuo0PttY08Kk54/Zw9BrJbQTdUTd/c0lq19/A2lFLDpv2r4yUzq8lM4GbitQzY83MrpzibzPo+h4gWdWNzZ7FDpfzoGE7pq7FNizeOr3hUZIEcpqrcjH3Bwl5d30HZoQO26ujLZZFz2nxbzJ+P8ky63YdsNH9iYL++2N1hO2zwO1yoUhAe/HuY31RgPJ+ZtUoBEKGAVVR8/dNvKmgmBC3hQMu7nvLJORo+0xI8V2WAWfzFHpS85XclnONr9F9Q4jPrpfH+KhSbo71l/Vcol9+ZOHEG3Mi5Cx3kNDf7MKiw219BhE4cV7GDr38gmf4Uq+mS93qtlca/L011qTQN7a58m5nZksIMuIkK7i9RiR/2Q14i+Ej/ujujS93vth ZM8ayEmB sk4Cs2xrk8otPJOSn/W2Nrgj/V+NKwK67lymCSVg3DNvU0mdjRCiZmlVo/lRYCAx+S7YBp2tI0vPO0w/t4hO77aff3Ur6hGlLrJ3mHCEoMpHDMdhCW1SW+faIA4YJWhOZeW5CXWMkiGwAuGJM/0qMlaJm8Sxaz6uJb+d+TgWJ3+FlqsiYIeRBrjQTzQeazC5RxvTuyaiIra1fExKwD92c9OXFMXNhWY0S26k/FtLVPF62D7DcjfvqxNo2v/SkS3RFk0bwCGoRvLiKtbb3uu0qJKCWzG4vjO1rcqs/HixABfi1UE/sjgkDyjveWm/B2037kXhCLxuRHib4uUTeFC4/g1pooNz0w9IOVOeYWBtLc5IUmnNE8xf/wA070DU0RaD2/3oJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 09:30:07PM +0100, Marek Marczykowski-G'orecki wrote: > On Fri, Nov 03, 2023 at 10:54:00AM -0600, Keith Busch wrote: > > On Fri, Nov 03, 2023 at 05:15:49PM +0100, Marek Marczykowski-G'orecki wrote: > > > On Thu, Nov 02, 2023 at 06:06:33PM +0100, Mikulas Patocka wrote: > > > > Then, try this patch (without "iommu=panic"), reproduce the deadlock and > > > > tell us which one of the "printk" statements is triggered during the > > > > deadlock. > > > > > > The "821" one - see below. > > > > Thanks for confirming! > > > > Could you try this patch? > > Besides min3() being unhappy about types, it works. Oops, should have changed the constant to "ul" instead of just "u". Anyway, the overall idea makes sense to me, but I don't know the swiotlb stuff well. Christoph, does that patch make sense? For reference: https://lore.kernel.org/linux-mm/ZUOr-vp0yRkLyvyi@kbusch-mbp.dhcp.thefacebook.com/T/#m8d34245e0eef43f8e9fe6cba6038d77ed2a93ad6