From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33379C4167D for ; Fri, 3 Nov 2023 16:54:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BD908D00C6; Fri, 3 Nov 2023 12:54:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96DA38D000C; Fri, 3 Nov 2023 12:54:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 835158D00C6; Fri, 3 Nov 2023 12:54:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 73F738D000C for ; Fri, 3 Nov 2023 12:54:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 402BA810CA for ; Fri, 3 Nov 2023 16:54:08 +0000 (UTC) X-FDA: 81417240576.03.4942F31 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 8060140015 for ; Fri, 3 Nov 2023 16:54:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q8DCkJ14; spf=pass (imf17.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699030446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zc3d9f/Id7OYKFLc4pICDilyHuAY9hTtyrFUMNxMi0M=; b=uFjFEmg3zEwoXqaKb5m6B/AclpeLO2MPDdAy/Y38jj5ZNI8pSxtRULtPhbbT4dVyGYYhCW JRHEjXiLgfayAnDpPOjbMUFn6pVO8/wocC0xCYBocCYM3SgS7zy/AOfZZ82ZeXe5FxP2EP gsq9NgECAnwmPzA596g8eUBTB20vk1k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699030446; a=rsa-sha256; cv=none; b=4r9oyQlYbK/7/T5T5aPYLOdbRO7AbW7rP8ecsmc3Kurr+09lw/HA19ywzCfSE4EDTywoEe SxEJ5pA001E7hkfd2WBQuZ/adT0TDXWfwvYExEEFnAs9a4dEMTky5mtVXUPQwhtisWLIxj rRvu0IsfwYUpZdZ5QTig4GexxSoh67M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q8DCkJ14; spf=pass (imf17.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 83E9CB81EB5; Fri, 3 Nov 2023 16:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D24F5C433C9; Fri, 3 Nov 2023 16:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699030443; bh=03QJ3PTCv+FjBj9S/gwPR8AYKtrdfz+IgTjZitD7WdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q8DCkJ14x4w34x3tOqYXmmzrH6nPzt9hDkXcYILMc0TrCTMoTdEuBSnr5IkLwmiO4 MWQh8LzkG2oulV82QJ58BrAF2eens8GmnG9gD1nPx4s3Kqo0QMTlswul857GXPBx2z 6bPvSxA75lyF9BX1xYaNMLHFNULdewYizxlE1suD6FBl/wTmQ/R557SKvfu6H39aaU YebSBv9hHHEdpRvJpFVqULghgOsdnyuxyVGNjXhIyAaI0Sb4MSi77Vp+W4fua+qCub yqWlPcGYZYyzxOt2UuT7JajDm4SqRzOdihYAf8GAQo3Wj8u1bAzvCMnDqQl5qxxBPn 2J3yheVPauoPw== Date: Fri, 3 Nov 2023 10:54:00 -0600 From: Keith Busch To: Marek =?us-ascii?Q?Marczykowski-G'orecki?= Cc: Mikulas Patocka , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Jan Kara , Vlastimil Babka , Andrew Morton , Matthew Wilcox , Michal Hocko , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , Mike Snitzer , dm-devel@lists.linux.dev, linux-mm@kvack.org Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 Message-ID: References: <20231031140136.25bio5wajc5pmdtl@quack3> <8a35cdea-3a1a-e859-1f7c-55d1c864a48@redhat.com> <3cb4133c-b6db-9187-a678-11ed8c9456e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 8060140015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zbpgyxt9bksiros8urosu1kjzrsyqiz7 X-HE-Tag: 1699030446-186162 X-HE-Meta: U2FsdGVkX1+vYmDDnhhc7jrOy3CljBsNd4XKWNGGzRnC7ctCE0PelEZ923dA+AEeh0Br1O3KfRmNpNYBxmX9ll5ycdzT6NVNc+2zHqpxr+GKI4L5vLIN5G3riNlRdROOOKumGlF/ehb4r9akO31kzF0xgO16le9JgbJ/I98glHxF8O3+oK/fjr272vD26pw6e9ZhkEO8UtIKV+XDY0ul9S1ChLQezj5nE4lZVij1L74G2x69ck/McrVS8+MP3U3SeNOU+BWkSN9nN8n28+qQl8yBamfCa4roE1UhgoCfA7t20mDlWXpYXQdckX227pb0O0P0jXrfMNxHhtopwHqi2xHNuJeI17qpt+I0eSSpMmsr8kGubSbyKxHiG6d81OnzpI1rUAL5Y9SFAxfQyOoMpXItt4WjeoMVGRx1LcCIVvOfl6uGR5McHGrqvD8n2Ku7lZK2JO7JeULajV3GkfFC/EqTLEwsVZxve/kZ/W0avNpufKo0v5f0/KqroO0OCSzJ6ewXXLaCZLsLWmjuMMYM9CLDQtcTccCYIYbLIjetmfqDX6YJeCJBGIJMgrpMja5B38jwsWU5zKtyyBdK7S8FCqYwaA40ipck0J6JZE0iZW0LWsm7EoSJ2qnWcAZBStPbKvGuyncAjOZ20KGcZKHnAQ1gaMCSYSLy94IIDQiFN8474eVRMRpKnMuDcrI6Yeim/gmhEmdTE2322D+05hJW5X5OKotWNrKPjiQN11WdeYxCKSglHpQyBaQhNBfxw+19o6p6yC79sMnWwYGgiLTot0i2HSe1ORcP6ijgkVFpRm7RQ4++WAWUFf+1UKcX2scvbXrEGpPxZYJiL4YWVZ9Omob4KtjMPCwg/h7/Ydd8FHpIsVuRDmsSGrZCOPXcsWsWoy+rD6bfEDLb9ijWPFSsJlLosZbPURQrfUAPYM7QG+bo2H6fNN1tBksUHtytFr7awdppsLmyD0LhL6We0KI WxshFwqn zWejC3D/ag2ka8mBCB4UYp0SDutiGvTbTn6KNbdvRxEIUjKhB90nJnRZzu8jjZbg2Q72o6awq8O4nafn4UH9eSKk/LSwH+v73modWIf9ryai3DzZin0iJpelIqhLEtbyzgJgmaYmGCo6oTpD19drgeqkIbhadgAYNNbYTkfhnd6j07hdn/TlXbPvieqE8h0tjlz+46SUikNOirCxhyjGNM4E/MgnILQBipt8r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 05:15:49PM +0100, Marek Marczykowski-G'orecki wrote: > On Thu, Nov 02, 2023 at 06:06:33PM +0100, Mikulas Patocka wrote: > > Then, try this patch (without "iommu=panic"), reproduce the deadlock and > > tell us which one of the "printk" statements is triggered during the > > deadlock. > > The "821" one - see below. Thanks for confirming! Could you try this patch? --- diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 60a08dfe8d75f..348fd6c6702a5 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -41,7 +41,7 @@ * These can be higher, but we need to ensure that any command doesn't * require an sg allocation that needs more than a page of data. */ -#define NVME_MAX_KB_SZ 8192 +#define NVME_MAX_KB_SZ 8192u #define NVME_MAX_SEGS 128 #define NVME_MAX_NR_ALLOCATIONS 5 @@ -2957,8 +2957,9 @@ static struct nvme_dev *nvme_pci_alloc_dev(struct pci_dev *pdev, * Limit the max command size to prevent iod->sg allocations going * over a single page. */ - dev->ctrl.max_hw_sectors = min_t(u32, - NVME_MAX_KB_SZ << 1, dma_opt_mapping_size(&pdev->dev) >> 9); + dev->ctrl.max_hw_sectors = min3(NVME_MAX_KB_SZ << 1, + dma_opt_mapping_size(&pdev->dev) >> 9, + dma_max_mapping_size(&pdev->dev) >> 9); dev->ctrl.max_segments = NVME_MAX_SEGS; /* diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 946bd56f0ac53..0e6c6c25d154f 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -405,4 +405,5 @@ const struct dma_map_ops xen_swiotlb_dma_ops = { .get_sgtable = dma_common_get_sgtable, .alloc_pages = dma_common_alloc_pages, .free_pages = dma_common_free_pages, + .max_mapping_size = swiotlb_max_mapping_size, }; --