From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67860C4332F for ; Fri, 3 Nov 2023 16:26:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46D68D00C4; Fri, 3 Nov 2023 12:26:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F67C8D000C; Fri, 3 Nov 2023 12:26:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BEC18D00C4; Fri, 3 Nov 2023 12:26:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 791128D000C for ; Fri, 3 Nov 2023 12:26:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4294EC0173 for ; Fri, 3 Nov 2023 16:26:32 +0000 (UTC) X-FDA: 81417171024.27.4134555 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf13.hostedemail.com (Postfix) with ESMTP id 69F3D20011 for ; Fri, 3 Nov 2023 16:26:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aBBt23al; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699028789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6RxeQm4cmA2JrbAVa8HTs83GsMijucDFIF/Igdee3yE=; b=YCUyMGMr7tiaN5St5kZinL4rqK2geXPq+U1xVb5fXpLlPulRJUgOiYnG9N7OryL2afnZV4 oIZsiUEWXNBflcPE28OlGXcjEyfXNJajPX1XKKy34AV+k/32KbTfh4ujqAMZIdp/KxcGl1 zXBrH0lf+K50Rp/sbMtJd1Vm5todAyo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aBBt23al; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699028789; a=rsa-sha256; cv=none; b=jfL0Er7Cvq7eAqlQ2b/rBwkiWGu4d5qtRoj82r1OeYVfG0CzzaDXmkkU93shgDfrXdJCTg zR2xV3MUz7utz5AY47rSV++s3S4hN7Fim/1WERuTF/UPw5haO6E0dqmB1CkYaIgKgKPFG2 nUo9gKPaETe7hjVULl6feAvHL70OsSM= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1cc3bb4c307so23923815ad.0 for ; Fri, 03 Nov 2023 09:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699028788; x=1699633588; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=6RxeQm4cmA2JrbAVa8HTs83GsMijucDFIF/Igdee3yE=; b=aBBt23alQhIQeMFPw8TWwrr9tz+xRucEADfEeylrEmCUcv4i4a0jpcAWiKaqqRP4w6 D2Ennqnl0OOxcYmUqt2Q30067Vv7caFyelklWNqKN18PWCr/VAH7NLYhr69FkeO2aUBo dUovWmlcbLeFJjyW6lC1GLAMhtItNJcAVuS6lCp0ExWbTeuFCzj7iHWwbd/A/icUpVWE PqD2Rj6cI3fIt2LF90GrZOBcOhqc9VSK0pohTGvkBYB7O8TX9+oSzvyyQTDdZlcHr3sA ueB7L26XOHXwbkk4kq0YE4WPXaAonJ0O7F8f+G5zsDBqv/lCGfgKTph1vpswqRsYBevX ScBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699028788; x=1699633588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6RxeQm4cmA2JrbAVa8HTs83GsMijucDFIF/Igdee3yE=; b=JAAcu5VzGzPOzOD0wAKQ3eVPB6YJdqoXwAaHs64TcwcmSPFKmoDyAE5SQn5i7Q7ZaG uV1f4gjkNz0FuJRQD2iUFbaaDiZmyPqK7UCk4cyFC65UUoxzxdxQzJnpwx0SjXLfzbDG SfRuZfZAXzP11K5l2PwMxDVA0yL1sCsepTL6S7aLUs/y1sIsmizExauV3o1IYa4o8PtR GdQXArzPYUk7J7BbKYTDyaFshPJNdVghash2b3YJqWTTK/QSNNRqh0sd2oLdOkg9lVh+ Gr1XDcs884IHk8gSZZCsAEdAkHDIoCzmDhDKkqSwjr7PyKIMQ3ho9Je45RvCe2GhGIIp NYkw== X-Gm-Message-State: AOJu0Yy6BsqEkoKbQMu7PP/HN7pV619JROi4V1JyUmkbhX6/P02YLSba H5x+/rz2Yt4gWoN1bSMrhN4= X-Google-Smtp-Source: AGHT+IH+UfkDk1M09a11MgKdQ/HzVeEoAf8yilhUhOvIPnSu6kULsuDKgmMoS0l4cwRyk9qiS6Zxpw== X-Received: by 2002:a17:902:f551:b0:1cc:5b2a:2f33 with SMTP id h17-20020a170902f55100b001cc5b2a2f33mr14887406plf.43.1699028787560; Fri, 03 Nov 2023 09:26:27 -0700 (PDT) Received: from debian (c-71-202-158-162.hsd1.ca.comcast.net. [71.202.158.162]) by smtp.gmail.com with ESMTPSA id p22-20020a170902b09600b001b8a3e2c241sm1609244plr.14.2023.11.03.09.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 09:26:27 -0700 (PDT) From: fan X-Google-Original-From: fan Date: Fri, 3 Nov 2023 09:26:06 -0700 To: Vishal Verma Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , Dan Williams , Dave Jiang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer Subject: Re: [PATCH v8 1/3] mm/memory_hotplug: replace an open-coded kmemdup() in add_memory_resource() Message-ID: References: <20231101-vv-kmem_memmap-v8-0-5e4a83331388@intel.com> <20231101-vv-kmem_memmap-v8-1-5e4a83331388@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231101-vv-kmem_memmap-v8-1-5e4a83331388@intel.com> X-Rspamd-Queue-Id: 69F3D20011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5dzg718hdf87fk91mw97tjoipxr9o583 X-HE-Tag: 1699028789-131036 X-HE-Meta: U2FsdGVkX1+HAb4oHT2xqAl/fqvhc7F/YRGRZdXVjRCOK4whoRFyn6dP9yeXUinkUZ/rQOBYV6ZmW+KGlOMIbj37ezWivDwg0Ul7vO0GYPql5rBwDM4OZs1teBEAxEBXt6+wbneGHoXCqbyppk4ZhdgOJF2ipqIgwmh5IKvd1rO8ByR71BBZLuUGUmzI/RyDxRTjyjzpbv8bMc1Ybfx41PPqwGuDa+mT5sOlZpWV+4x9YKrIPtvnGPRdvQpr9MDrdesD0cdCUiISl6YhBHbzbnto/cEHrEAD3YEbPRtQF/iJPAaAuead73Xp/nxCj6joF6S16tR+kkTMYRbY5i5yc4xKleCxQIIp4IGGd5RYIgmTxnk2ZTwaFaDPjAtjHif+HLjk8//v9Z58scE/ghcOYKGuWZrtlsIVAviT2gHhqKU7o/RfxpyMqs+OrpEUoD4Buv41cIfLI0pPqDOQu1TA+VmQ9xNAlVk3jg+tLjofsujPkMiB0itjb799G/XYsbwTQJh2THG6pmiDzyvNWD8Cz2kW4ysJvEgxuJ0nEUUVOqviqMH1h0pdWAW97F31yiYCncucTEfkxeVvzqLCZYkyabXDGYLFWsBVVNzPzT3QTS09QHMHbOSaWSGeI9DzFuzK9v+Azdky+wMofqpZ4lLR4N5P3trtObHeSzs8MMsuL5K8jkhbRFsiYxd+7vw8XRkcH+rfyL7juO0cDiiin14fUDjddKrpxPZ1jg6KfMN6lcLeA3uCH8QOiNAANcGRq7xldu0VpRmU8/9niJi/JDX789PrVL0Cfqzg04E5ViMLXXrfoWIKLmvsDhTg1bwop9Kk/XKary3F+VLIJnUPOMgrMJBXCXvLn8As/SSnmcDFSmnxDOjs8/M962OZZb4/z0OMLQKWnXH4u23/AsaxyjUsq7EpQkpT/nBKi2Ln75uULZ61BFcqQd0KyYTsiAsG7Hm8Vid7TKKpn2F6OzlFdkp g8FCIx86 nIR9KguFrmeWTna4QnMUJiF/sml+JXBjwfPNKRCXerGgfSbp+2uf+IVvCJ1xzX4f9rAyxXIepDuGwYoCnESkf22BAeOkOOdTZ6xTuSwlSufHj/zvRgafgZ5c0NoiIIFC2z1xHPkF0bdo90QvchUCBkW7G8PNp33sI48lGhouN0jX7k1JpdN5zskgaD8rINPYpmh/A8rguC0RNuX6MJEkaXYS/ygLCkumbQJ3q3dk01wXxJvG1gaAYLZc8gpZWWpoT348zdPbmNR+4SPQk7f3cad+6gDITBSuxNxqW93BfgN4hmh6//vFwLCdFxLl5DZTrJ8J1BGkRnzrk1igdcdPp1ES/qIGAVzpt1NzYosRIEHo3aix8EMazood+0N+Swy0ZFJB6lVaTxBzB5EeyR/8POwPXtwkembQhJmC+o2ZO2AWlk+ujdMYqz2LmnRvEMhKeR6AUAO1L44U7VmCXfnxcFV4w1XU+ZbAOe1u4mkq/OF6mRGdo8S96SwuFjlU1tnxvk7Oj0QqVP5498TgtKaBZSU+ZIVVCkT/JgbovhkPP3IA6w8xsdLultuPBDy1XCcQXesn+fI7STuHym5jOzQOJXf0/LFi5y5jWvAPzRzgCsA5VZGk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 01, 2023 at 04:51:51PM -0600, Vishal Verma wrote: > A review of the memmap_on_memory modifications to add_memory_resource() > revealed an instance of an open-coded kmemdup(). Replace it with > kmemdup(). > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Dan Williams > Reported-by: Dan Williams > Reviewed-by: David Hildenbrand > Signed-off-by: Vishal Verma > --- Reviewed-by: Fan Ni > mm/memory_hotplug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f8d3e7427e32..6be7de9efa55 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1439,11 +1439,11 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (mhp_flags & MHP_MEMMAP_ON_MEMORY) { > if (mhp_supports_memmap_on_memory(size)) { > mhp_altmap.free = memory_block_memmap_on_memory_pages(); > - params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); > + params.altmap = kmemdup(&mhp_altmap, > + sizeof(struct vmem_altmap), > + GFP_KERNEL); > if (!params.altmap) > goto error; > - > - memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); > } > /* fallback to not using altmap */ > } > > -- > 2.41.0 >