From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11628C4332F for ; Wed, 1 Nov 2023 17:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7784D6B00DC; Wed, 1 Nov 2023 13:12:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 728216B00E3; Wed, 1 Nov 2023 13:12:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57A0A6B00E4; Wed, 1 Nov 2023 13:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 419ED6B00DC for ; Wed, 1 Nov 2023 13:12:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 09E45A091B for ; Wed, 1 Nov 2023 17:12:05 +0000 (UTC) X-FDA: 81410028210.22.B579B24 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf06.hostedemail.com (Postfix) with ESMTP id D2542180029 for ; Wed, 1 Nov 2023 17:12:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=GXE6E0Fq; dmarc=none; spf=pass (imf06.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698858723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4u+GdFNNu//8JGsibyj35ov0lclmoqfLk+qgIIXFPCc=; b=L/kSCozDgRoYtwsriRpzOjUiijRAM/g7Qgz3YsTFraVU76s8w+NF14h09Gr741C7N18GER 4KVyz9cQLcBe5HosBexrlSXMJJErLRbHjKHLNu9tO1RQ0P3X0srOh2s1dFeKAs3lUnZQR7 2RxMZ+h37padQb30hgKgRQEziuztGOc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=GXE6E0Fq; dmarc=none; spf=pass (imf06.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698858723; a=rsa-sha256; cv=none; b=7mDklFSm/zO47e3jLUGiqvfi+d956vm8dzcnh3LKqNIaxZcuKVcG8sU1bAgYygdUx+EjDr XhfNq50bqfEuOcoF9qW2kuUpuDFRbcldzv8ZUORh4RLYRrS2KM7gsD4/O0P4pYI080MhN8 Sg5kxcC1PgU8K+veMxgT0jiC6K2E4Jw= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1cc3bb4c307so29014525ad.0 for ; Wed, 01 Nov 2023 10:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1698858721; x=1699463521; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4u+GdFNNu//8JGsibyj35ov0lclmoqfLk+qgIIXFPCc=; b=GXE6E0Fqwds1dp9QuMNSQXYNA5KGgdVB+H/frwaDkV9VmFo2raaVSbn92159jbLKch qAh7oJxEL9MsiT2A2KvnF6aneOQPNWeRS1uQ0N9YYs88ZW6n3lhFMyA8xP9oh37cctu6 ae+coAAw4IujL0Vfs9r/RY+BPpPDiyhgJSv5CBlnY2gVA8tLoepJcrH8wBUTA4NFwXxq kGFKfFVEReKXjLhuHB+oCiEuoM6dJ4MtyabgP0QfybxGkp8GbCr/kwvd3vuk0RKpzdKW d1O7KIhKWTjZKXbZqrVMcipS4/npCxcwSXDB6Lmnj/oG5DvmNlkQ5c63qTE082eVxX4z 54uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698858721; x=1699463521; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4u+GdFNNu//8JGsibyj35ov0lclmoqfLk+qgIIXFPCc=; b=nKgeKiFCxw/HdN+RnnVgAQK2pcLpZHnybkxXAYJ7IvgaK2hyUepGcxjiX4C47jWO+I Yp58k44f0zlOnJLwIUnDdgAU8mn65fV8U2an3gx7IASbDxerq8IaRHqk0irompMjlYeM FjL4TAiniYZlGZDQBmy6NQkzkiTxpG1fyHyIpQP7XpGTT4xMG6KdLMTJNbq1HDkXp3XI pyy/XcUpDmW7lAL0SlaerMvG1IJ+82cgGdzBPYcTClfxE+qCG/MOPkw1WwkFEh76agYa GY3TCXziv/xcpPg00xFoyd9dExbjm/K1e2NeQXKuVs0gN5diBkbxfHDk9+57HX8Y+DEB sljA== X-Gm-Message-State: AOJu0YwOlg6MVoagRc/vY3QU5vCex5PQvB7YQHFWnMrFHNAYBgOv8G8C Hwx6opFWMsANwBpo8PT/qrWAnA== X-Google-Smtp-Source: AGHT+IHISivakRVRlaMe38Mj+JpFjsKq915Z21w7vxAfUns/0aLBngf23xTDcwdDRYV84Je5Bf6SUg== X-Received: by 2002:a17:902:fac3:b0:1cc:4eb1:edaa with SMTP id ld3-20020a170902fac300b001cc4eb1edaamr8022790plb.51.1698858721388; Wed, 01 Nov 2023 10:12:01 -0700 (PDT) Received: from ghost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id b6-20020a170902bd4600b001c74876f018sm1568650plx.18.2023.11.01.10.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 10:12:00 -0700 (PDT) Date: Wed, 1 Nov 2023 10:11:58 -0700 From: Charlie Jenkins To: Emil Renner Berthing Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andreas Schwab , Samuel Holland , Nelson Chu Subject: Re: [PATCH v8 2/3] riscv: Add remaining module relocations Message-ID: References: <20231031-module_relocations-v8-0-09b5b720c1fe@rivosinc.com> <20231031-module_relocations-v8-2-09b5b720c1fe@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D2542180029 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w6dc3toofgjb63d6zdjrqu6i71qcid58 X-HE-Tag: 1698858722-370103 X-HE-Meta: U2FsdGVkX181GBv6x+xL781rRn+DwslvDKFnvvQ6hoBJRNaSAzvRNrptvvwJivxDmIJVoT+yuKYX1EzhiEMrDB+nV/FzUVrNo6nIKRQ//+Q00zVZBUAf2f8RlYGYTbc7CKbO2jF6TIPRmMaIo+08PnzTZ1e5X5R5jLv0RT/R8MjGURlv9xl7iHg9YaLJf1CNZqO4KKJzlTxLJDxxj+c7NfgCMWrypNYm/KhuWTvvQ3n+fZIC0y1tg9FhRM00tvXyCf9lhUJGYIM+E2A79viliVo06DBMJt/3DVLmvz4oTl6BUhRfUr6gg7iPTfB9NAdEwTjl9TW5i06+pRJ0rLrHYVBcZn+IazvSMqqrfWdljsInPuc1yCYi/nnUIj7usIh7X3yF62YY7/bb/Zwarh56CzF2rkkLNPSK2ewxHlnB7A5GZWhiHpvdx95COZ0dOKEzCKBPlUkfKmsvNTJZiJBGGFQH6hRrwscpbBVWUE9Oi7G5QYeM49pbaY1IS2dPR28SspqIvXAVZfZupo4epBlCNK3o02k2dcKn+Grp4cSGfVann20aw5klh7mhZOFVLDFgNGoir4hRlxx8eULEJ0nT0JBKbbfb6R/WsPJaoTi1oicc/kvoInNS8LPSrqX4cyI0nDecplL0E0p3mx176Dpr02Tu7t9q0CxSmlZ93dsQJLMQRa50rVNgCekk3O3PE411fyRT5te/PrpxxJIbCrNvD4Zd84TQ62OBkUqb39C1JanQVfLcpDlb35XWQLOALZFwpOJm2PvPUtUkRjWathFqU3o1naYpbEIHIRTw7BJRexfV0vqFpF0LNbeBq7lg/e/dv7mjoWxhl+Ckmn0yZH6yhUw4Mn6rAOKRb7cfeGN8AvRyRnyFiYcvkQFLCGFMNHv4p3gYpiz3fXMatKLzKryM30/nY0WgAIqPhftIDlT2n6bi510iE43fugsnQYmuEK11X3h1IgL8RUraPppLZx3 1NtPaBvd B9ioNqthn6bt+PuRjSnt5P62FsJb5cGVg0jY/5D/02CC9vngacRtCT6Gq8hdRJTEomB/k785OvS3CgMpgn6lx3CeuW106CmHe08+c8BcPHh8z7+K8ewIUYB1+jT4vLo52qact128WWY+obEwa900vLaJp2T2uai9IPVXjI3o4V/mD69NXZpCZv/rTgEdQZvuawVz7yue6Y2j2wHE2IdNed4ACRtCAFIfPwDHDtT6M7htAaO64/bN2pT7g8TwWw+cLDfjUCDi100a6lmtSsAF2cT0rDjyQPz6AEN4WvMZsy868BO34MZptql4qSgZc9/01vFBxRCRolHAUk/o0k4uIqNU/lngcTXf7xzXDo6qKyjkCSNzI2AIYj9AKOxFhijSlawPv7VwrTpS78unVRnUiU7Api5TS2dVgPt8+5pZkkz3UPcQKHwrtJLnEbuALPiD2A1zKjWQ0uIFaM+wgAEffxYJ1Cc5DHDpBQQY3bCSsoGbdf1Wc9lT5rGCJYzQzJ45frs+LRSRQT1bbdBk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 01, 2023 at 03:44:30PM +0100, Emil Renner Berthing wrote: > Charlie Jenkins wrote: > > Add all final module relocations and add error logs explaining the ones > > that are not supported. Implement overflow checks for > > ADD/SUB/SET/ULEB128 relocations. > > > > Signed-off-by: Charlie Jenkins > > --- > > arch/riscv/include/uapi/asm/elf.h | 5 +- > > arch/riscv/kernel/module.c | 503 +++++++++++++++++++++++++++++++++++--- > > 2 files changed, 476 insertions(+), 32 deletions(-) > > > > diff --git a/arch/riscv/include/uapi/asm/elf.h b/arch/riscv/include/uapi/asm/elf.h > > index d696d6610231..11a71b8533d5 100644 > > --- a/arch/riscv/include/uapi/asm/elf.h > > +++ b/arch/riscv/include/uapi/asm/elf.h > > @@ -49,6 +49,7 @@ typedef union __riscv_fp_state elf_fpregset_t; > > #define R_RISCV_TLS_DTPREL64 9 > > #define R_RISCV_TLS_TPREL32 10 > > #define R_RISCV_TLS_TPREL64 11 > > +#define R_RISCV_IRELATIVE 58 > > > > /* Relocation types not used by the dynamic linker */ > > #define R_RISCV_BRANCH 16 > > @@ -81,7 +82,6 @@ typedef union __riscv_fp_state elf_fpregset_t; > > #define R_RISCV_ALIGN 43 > > #define R_RISCV_RVC_BRANCH 44 > > #define R_RISCV_RVC_JUMP 45 > > -#define R_RISCV_LUI 46 > > #define R_RISCV_GPREL_I 47 > > #define R_RISCV_GPREL_S 48 > > #define R_RISCV_TPREL_I 49 > > @@ -93,6 +93,9 @@ typedef union __riscv_fp_state elf_fpregset_t; > > #define R_RISCV_SET16 55 > > #define R_RISCV_SET32 56 > > #define R_RISCV_32_PCREL 57 > > +#define R_RISCV_PLT32 59 > > +#define R_RISCV_SET_ULEB128 60 > > +#define R_RISCV_SUB_ULEB128 61 > > > > > > #endif /* _UAPI_ASM_RISCV_ELF_H */ > > diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c > > index a9e94e939cb5..0f5d41eaa596 100644 > > --- a/arch/riscv/kernel/module.c > > +++ b/arch/riscv/kernel/module.c > > @@ -7,6 +7,9 @@ > > #include > > #include > > #include > > +#include > > +#include > > +#include > > #include > > #include > > #include > > @@ -14,6 +17,39 @@ > > #include > > #include > > > > +struct used_bucket { > > + struct list_head head; > > + struct hlist_head *bucket; > > +}; > > + > > +struct relocation_head { > > + struct hlist_node node; > > + struct list_head *rel_entry; > > + void *location; > > +}; > > + > > +struct relocation_entry { > > + struct list_head head; > > + Elf_Addr value; > > + unsigned int type; > > +}; > > + > > +struct relocation_handlers { > > + int (*reloc_handler)(struct module *me, void *location, Elf_Addr v); > > + bool accumulate_relocations; > > + int (*accumulate_handler)(struct module *me, void *location, > > + long buffer); > > +}; > > + > > +unsigned int initialize_relocation_hashtable(unsigned int num_relocations); > > +void process_accumulated_relocations(struct module *me); > > +int add_relocation_to_accumulate(struct module *me, int type, void *location, > > + unsigned int hashtable_bits, Elf_Addr v); > > + > > +struct hlist_head *relocation_hashtable; > > + > > +struct list_head used_buckets_list; > > + > > /* > > * The auipc+jalr instruction pair can reach any PC-relative offset > > * in the range [-2^31 - 2^11, 2^31 - 2^11) > > @@ -35,7 +71,7 @@ static int riscv_insn_rmw(void *location, u32 keep, u32 set) > > insn &= keep; > > insn |= set; > > > > - parcel[0] = cpu_to_le32(insn); > > + parcel[0] = cpu_to_le16(insn); > > parcel[1] = cpu_to_le16(insn >> 16); > > return 0; > > } > > @@ -43,8 +79,12 @@ static int riscv_insn_rmw(void *location, u32 keep, u32 set) > > static int riscv_insn_rvc_rmw(void *location, u16 keep, u16 set) > > { > > u16 *parcel = location; > > + u16 insn = le16_to_cpu(*parcel); > > > > - *parcel = cpu_to_le16((le16_to_cpu(*parcel) & keep) | set); > > + insn &= keep; > > + insn |= set; > > + > > + *parcel = cpu_to_le16(insn); > > return 0; > > } > > I think you meant to squash these two chunks into the previous patch. > > > > > @@ -269,6 +309,12 @@ static int apply_r_riscv_align_rela(struct module *me, void *location, > > return -EINVAL; > > } > > > > +static int apply_r_riscv_add8_rela(struct module *me, void *location, Elf_Addr v) > > +{ > > + *(u8 *)location += (u8)v; > > + return 0; > > +} > > + > > static int apply_r_riscv_add16_rela(struct module *me, void *location, > > Elf_Addr v) > > { > > @@ -290,6 +336,12 @@ static int apply_r_riscv_add64_rela(struct module *me, void *location, > > return 0; > > } > > > > +static int apply_r_riscv_sub8_rela(struct module *me, void *location, Elf_Addr v) > > +{ > > + *(u8 *)location -= (u8)v; > > + return 0; > > +} > > + > > static int apply_r_riscv_sub16_rela(struct module *me, void *location, > > Elf_Addr v) > > { > > @@ -311,33 +363,415 @@ static int apply_r_riscv_sub64_rela(struct module *me, void *location, > > return 0; > > } > > > > -static int (*reloc_handlers_rela[]) (struct module *me, void *location, > > - Elf_Addr v) = { > > - [R_RISCV_32] = apply_r_riscv_32_rela, > > - [R_RISCV_64] = apply_r_riscv_64_rela, > > - [R_RISCV_BRANCH] = apply_r_riscv_branch_rela, > > - [R_RISCV_JAL] = apply_r_riscv_jal_rela, > > - [R_RISCV_RVC_BRANCH] = apply_r_riscv_rvc_branch_rela, > > - [R_RISCV_RVC_JUMP] = apply_r_riscv_rvc_jump_rela, > > - [R_RISCV_PCREL_HI20] = apply_r_riscv_pcrel_hi20_rela, > > - [R_RISCV_PCREL_LO12_I] = apply_r_riscv_pcrel_lo12_i_rela, > > - [R_RISCV_PCREL_LO12_S] = apply_r_riscv_pcrel_lo12_s_rela, > > - [R_RISCV_HI20] = apply_r_riscv_hi20_rela, > > - [R_RISCV_LO12_I] = apply_r_riscv_lo12_i_rela, > > - [R_RISCV_LO12_S] = apply_r_riscv_lo12_s_rela, > > - [R_RISCV_GOT_HI20] = apply_r_riscv_got_hi20_rela, > > - [R_RISCV_CALL_PLT] = apply_r_riscv_call_plt_rela, > > - [R_RISCV_CALL] = apply_r_riscv_call_rela, > > - [R_RISCV_RELAX] = apply_r_riscv_relax_rela, > > - [R_RISCV_ALIGN] = apply_r_riscv_align_rela, > > - [R_RISCV_ADD16] = apply_r_riscv_add16_rela, > > - [R_RISCV_ADD32] = apply_r_riscv_add32_rela, > > - [R_RISCV_ADD64] = apply_r_riscv_add64_rela, > > - [R_RISCV_SUB16] = apply_r_riscv_sub16_rela, > > - [R_RISCV_SUB32] = apply_r_riscv_sub32_rela, > > - [R_RISCV_SUB64] = apply_r_riscv_sub64_rela, > > +static int dynamic_linking_not_supported(struct module *me, void *location, > > + Elf_Addr v) > > +{ > > + pr_err("%s: Dynamic linking not supported in kernel modules PC = %p\n", > > + me->name, location); > > + return -EINVAL; > > +} > > + > > +static int tls_not_supported(struct module *me, void *location, Elf_Addr v) > > +{ > > + pr_err("%s: Thread local storage not supported in kernel modules PC = %p\n", > > + me->name, location); > > + return -EINVAL; > > +} > > + > > +static int apply_r_riscv_sub6_rela(struct module *me, void *location, Elf_Addr v) > > +{ > > + u8 *byte = location; > > + u8 value = v; > > + > > + *byte = (*byte - (value & 0x3f)) & 0x3f; > > + return 0; > > +} > > + > > +static int apply_r_riscv_set6_rela(struct module *me, void *location, Elf_Addr v) > > +{ > > + u8 *byte = location; > > + u8 value = v; > > + > > + *byte = (*byte & 0xc0) | (value & 0x3f); > > + return 0; > > +} > > + > > +static int apply_r_riscv_set8_rela(struct module *me, void *location, Elf_Addr v) > > +{ > > + *(u8 *)location = (u8)v; > > + return 0; > > +} > > + > > +static int apply_r_riscv_set16_rela(struct module *me, void *location, > > + Elf_Addr v) > > +{ > > + *(u16 *)location = (u16)v; > > + return 0; > > +} > > + > > +static int apply_r_riscv_set32_rela(struct module *me, void *location, > > + Elf_Addr v) > > +{ > > + *(u32 *)location = (u32)v; > > + return 0; > > +} > > + > > +static int apply_r_riscv_32_pcrel_rela(struct module *me, void *location, > > + Elf_Addr v) > > +{ > > + *(u32 *)location = v - (unsigned long)location; > > nit: in other reviews i've been told to use uintptr_t when casting pointers to > an unsigned integer. > Okay will do. > > + return 0; > > +} > > + > > +static int apply_r_riscv_plt32_rela(struct module *me, void *location, > > + Elf_Addr v) > > +{ > > + ptrdiff_t offset = (void *)v - location; > > + > > + if (!riscv_insn_valid_32bit_offset(offset)) { > > + /* Only emit the plt entry if offset over 32-bit range */ > > + if (IS_ENABLED(CONFIG_MODULE_SECTIONS)) { > > + offset = (void *)module_emit_plt_entry(me, v) - location; > > + } else { > > + pr_err("%s: target %016llx can not be addressed by the 32-bit offset from PC = %p\n", > > + me->name, (long long)v, location); > > + return -EINVAL; > > + } > > + } > > + > > + *(u32 *)location = (u32)offset; > > + return 0; > > +} > > + > > +static int apply_r_riscv_set_uleb128(struct module *me, void *location, Elf_Addr v) > > +{ > > + *(long *)location = v; > > + return 0; > > +} > > + > > +static int apply_r_riscv_sub_uleb128(struct module *me, void *location, Elf_Addr v) > > +{ > > + *(long *)location -= v; > > + return 0; > > +} > > + > > +static int accumulation_not_supported(struct module *me, void *location, long buffer) > > +{ > > + pr_err("%s: Internal error. Only ADD/SUB/SET/ULEB128 should be accumulated.", me->name); > > + return -EINVAL; > > +} > > + > > +static int apply_6_bit_accumulation(struct module *me, void *location, long buffer) > > +{ > > + u8 *byte = location; > > + u8 value = buffer; > > + > > + if (buffer > 0x3f) { > > + pr_err("%s: value %ld out of range for 6-bit relocation.\n", > > + me->name, buffer); > > + return -EINVAL; > > + } > > + > > + *byte = (*byte & 0xc0) | (value & 0x3f); > > + return 0; > > +} > > + > > +static int apply_8_bit_accumulation(struct module *me, void *location, long buffer) > > +{ > > + if (buffer > U8_MAX) { > > + pr_err("%s: value %ld out of range for 8-bit relocation.\n", > > + me->name, buffer); > > + return -EINVAL; > > + } > > + *(u8 *)location = (u8)buffer; > > + return 0; > > +} > > + > > +static int apply_16_bit_accumulation(struct module *me, void *location, long buffer) > > +{ > > + if (buffer > U16_MAX) { > > + pr_err("%s: value %ld out of range for 16-bit relocation.\n", > > + me->name, buffer); > > + return -EINVAL; > > + } > > + *(u16 *)location = (u16)buffer; > > + return 0; > > +} > > + > > +static int apply_32_bit_accumulation(struct module *me, void *location, long buffer) > > +{ > > + if (buffer > U32_MAX) { > > + pr_err("%s: value %ld out of range for 32-bit relocation.\n", > > + me->name, buffer); > > + return -EINVAL; > > + } > > + *(u32 *)location = (u32)buffer; > > + return 0; > > +} > > + > > +static int apply_64_bit_accumulation(struct module *me, void *location, long buffer) > > +{ > > + *(u64 *)location = (u64)buffer; > > + return 0; > > +} > > + > > +static int apply_uleb128_accumulation(struct module *me, void *location, long buffer) > > +{ > > + /* > > + * ULEB128 is a variable length encoding. Encode the buffer into > > + * the ULEB128 data format. > > + */ > > + u8 *p = location; > > + > > + while (buffer != 0) { > > + u8 value = buffer & 0x7f; > > + > > + buffer >>= 7; > > + value |= (!!buffer) << 7; > > + > > + *p++ = value; > > + } > > + return 0; > > +} > > + > > +/* > > + * Relocations defined in the riscv-elf-psabi-doc. > > + * This handles static linking only. > > + */ > > +static struct relocation_handlers reloc_handlers[] = { > > I don't see anywhere this table is written to. Can we maybe make it const? > > > + [R_RISCV_32] = { apply_r_riscv_32_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_64] = { apply_r_riscv_64_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_RELATIVE] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_COPY] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_JUMP_SLOT] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_DTPMOD32] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_DTPMOD64] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_DTPREL32] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_DTPREL64] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_TPREL32] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_TPREL64] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + /* 12-15 undefined */ > > + [R_RISCV_BRANCH] = { apply_r_riscv_branch_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_JAL] = { apply_r_riscv_jal_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_CALL] = { apply_r_riscv_call_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_CALL_PLT] = { apply_r_riscv_call_plt_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_GOT_HI20] = { apply_r_riscv_got_hi20_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_GOT_HI20] = { tls_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TLS_GD_HI20] = { tls_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_PCREL_HI20] = { apply_r_riscv_pcrel_hi20_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_PCREL_LO12_I] = { apply_r_riscv_pcrel_lo12_i_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_PCREL_LO12_S] = { apply_r_riscv_pcrel_lo12_s_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_HI20] = { apply_r_riscv_hi20_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_LO12_I] = { apply_r_riscv_lo12_i_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_LO12_S] = { apply_r_riscv_lo12_s_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_TPREL_HI20] = { tls_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TPREL_LO12_I] = { tls_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TPREL_LO12_S] = { tls_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_TPREL_ADD] = { tls_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_ADD8] = { apply_r_riscv_add8_rela, true, > > + apply_8_bit_accumulation }, > > + [R_RISCV_ADD16] = { apply_r_riscv_add16_rela, true, > > + apply_16_bit_accumulation }, > > + [R_RISCV_ADD32] = { apply_r_riscv_add32_rela, true, > > + apply_32_bit_accumulation }, > > + [R_RISCV_ADD64] = { apply_r_riscv_add64_rela, true, > > + apply_64_bit_accumulation }, > > + [R_RISCV_SUB8] = { apply_r_riscv_sub8_rela, true, > > + apply_8_bit_accumulation }, > > + [R_RISCV_SUB16] = { apply_r_riscv_sub16_rela, true, > > + apply_16_bit_accumulation }, > > + [R_RISCV_SUB32] = { apply_r_riscv_sub32_rela, true, > > + apply_32_bit_accumulation }, > > + [R_RISCV_SUB64] = { apply_r_riscv_sub64_rela, true, > > + apply_64_bit_accumulation }, > > + /* 41-42 reserved for future standard use */ > > + [R_RISCV_ALIGN] = { apply_r_riscv_align_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_RVC_BRANCH] = { apply_r_riscv_rvc_branch_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_RVC_JUMP] = { apply_r_riscv_rvc_jump_rela, false, > > + accumulation_not_supported }, > > + /* 46-50 reserved for future standard use */ > > + [R_RISCV_RELAX] = { apply_r_riscv_relax_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_SUB6] = { apply_r_riscv_sub6_rela, true, > > + apply_6_bit_accumulation }, > > + [R_RISCV_SET6] = { apply_r_riscv_set6_rela, true, > > + apply_6_bit_accumulation }, > > + [R_RISCV_SET8] = { apply_r_riscv_set8_rela, true, > > + apply_8_bit_accumulation }, > > + [R_RISCV_SET16] = { apply_r_riscv_set16_rela, true, > > + apply_16_bit_accumulation }, > > + [R_RISCV_SET32] = { apply_r_riscv_set32_rela, true, > > + apply_32_bit_accumulation }, > > + [R_RISCV_32_PCREL] = { apply_r_riscv_32_pcrel_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_IRELATIVE] = { dynamic_linking_not_supported, false, > > + accumulation_not_supported }, > > + [R_RISCV_PLT32] = { apply_r_riscv_plt32_rela, false, > > + accumulation_not_supported }, > > + [R_RISCV_SET_ULEB128] = { apply_r_riscv_set_uleb128, true, > > + apply_uleb128_accumulation }, > > + [R_RISCV_SUB_ULEB128] = { apply_r_riscv_sub_uleb128, true, > > + apply_uleb128_accumulation }, > > + /* 62-191 reserved for future standard use */ > > + /* 192-255 nonstandard ABI extensions */ > > }; > > > > +void process_accumulated_relocations(struct module *me) > > +{ > > + /* > > + * Only ADD/SUB/SET/ULEB128 should end up here. > > + * > > + * Each bucket may have more than one relocation location. All > > + * relocations for a location are stored in a list in a bucket. > > + * > > + * Relocations are applied to a temp variable before being stored to the > > + * provided location to check for overflow. This also allows ULEB128 to > > + * properly decide how many entries are needed before storing to > > + * location. The final value is stored into location using the handler > > + * for the last relocation to an address. > > + * > > + * Three layers of indexing: > > + * - Each of the buckets in use > > + * - Groups of relocations in each bucket by location address > > + * - Each relocation entry for a location address > > + */ > > + struct used_bucket *bucket_iter; > > + struct relocation_head *rel_head_iter; > > + struct relocation_entry *rel_entry_iter; > > + int curr_type; > > + void *location; > > + long buffer; > > + > > + list_for_each_entry(bucket_iter, &used_buckets_list, head) { > > + hlist_for_each_entry(rel_head_iter, bucket_iter->bucket, node) { > > + buffer = 0; > > + location = rel_head_iter->location; > > + list_for_each_entry(rel_entry_iter, > > + rel_head_iter->rel_entry, head) { > > + curr_type = rel_entry_iter->type; > > + reloc_handlers[curr_type].reloc_handler( > > + me, &buffer, rel_entry_iter->value); > > + kfree(rel_entry_iter); > > + } > > + reloc_handlers[curr_type].accumulate_handler( > > + me, location, buffer); > > + kfree(rel_head_iter); > > + } > > + kfree(bucket_iter); > > + } > > + > > + kfree(relocation_hashtable); > > +} > > + > > +int add_relocation_to_accumulate(struct module *me, int type, void *location, > > + unsigned int hashtable_bits, Elf_Addr v) > > +{ > > + struct relocation_entry *entry; > > + struct relocation_head *rel_head; > > + struct hlist_head *current_head; > > + struct used_bucket *bucket; > > + unsigned long hash; > > + > > + entry = kmalloc(sizeof(*entry), GFP_KERNEL); > > + INIT_LIST_HEAD(&entry->head); > > + entry->type = type; > > + entry->value = v; > > + > > + hash = hash_min((unsigned long)location, hashtable_bits); > > uintptr_t > > > + > > + current_head = &relocation_hashtable[hash]; > > + > > + /* Find matching location (if any) */ > > + bool found = false; > > + struct relocation_head *rel_head_iter; > > + > > + hlist_for_each_entry(rel_head_iter, current_head, node) { > > + if (rel_head_iter->location == location) { > > + found = true; > > + rel_head = rel_head_iter; > > + break; > > + } > > + } > > + > > + if (!found) { > > + rel_head = kmalloc(sizeof(*rel_head), GFP_KERNEL); > > + rel_head->rel_entry = > > + kmalloc(sizeof(struct list_head), GFP_KERNEL); > > + INIT_LIST_HEAD(rel_head->rel_entry); > > + rel_head->location = location; > > + INIT_HLIST_NODE(&rel_head->node); > > + if (!current_head->first) { > > + bucket = > > + kmalloc(sizeof(struct used_bucket), GFP_KERNEL); > > + INIT_LIST_HEAD(&bucket->head); > > + bucket->bucket = current_head; > > + list_add(&bucket->head, &used_buckets_list); > > + } > > + hlist_add_head(&rel_head->node, current_head); > > + } > > + > > + /* Add relocation to head of discovered rel_head */ > > + list_add_tail(&entry->head, rel_head->rel_entry); > > + > > + return 0; > > +} > > + > > +unsigned int initialize_relocation_hashtable(unsigned int num_relocations) > > +{ > > + /* Can safely assume that bits is not greater than sizeof(long) */ > > + unsigned long hashtable_size = roundup_pow_of_two(num_relocations); > > + unsigned int hashtable_bits = ilog2(hashtable_size); > > + > > + /* > > + * Double size of hashtable if num_relocations * 1.25 is greater than > > + * hashtable_size. > > + */ > > + int should_double_size = ((num_relocations + (num_relocations >> 2)) > (hashtable_size)); > > + > > + hashtable_bits += should_double_size; > > + > > + hashtable_size <<= should_double_size; > > + > > + relocation_hashtable = kmalloc_array(hashtable_size, > > + sizeof(*relocation_hashtable), > > + GFP_KERNEL); > > + __hash_init(relocation_hashtable, hashtable_size); > > + > > + INIT_LIST_HEAD(&used_buckets_list); > > + > > + return hashtable_bits; > > +} > > + > > int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > > unsigned int symindex, unsigned int relsec, > > struct module *me) > > @@ -349,11 +783,13 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > > unsigned int i, type; > > Elf_Addr v; > > int res; > > + unsigned int num_relocations = sechdrs[relsec].sh_size / sizeof(*rel); > > + unsigned int hashtable_bits = initialize_relocation_hashtable(num_relocations); > > > > pr_debug("Applying relocate section %u to %u\n", relsec, > > sechdrs[relsec].sh_info); > > > > - for (i = 0; i < sechdrs[relsec].sh_size / sizeof(*rel); i++) { > > + for (i = 0; i < num_relocations; i++) { > > /* This is where to make the change */ > > location = (void *)sechdrs[sechdrs[relsec].sh_info].sh_addr > > + rel[i].r_offset; > > @@ -371,8 +807,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > > > > type = ELF_RISCV_R_TYPE(rel[i].r_info); > > > > - if (type < ARRAY_SIZE(reloc_handlers_rela)) > > - handler = reloc_handlers_rela[type]; > > + if (type < ARRAY_SIZE(reloc_handlers)) > > + handler = reloc_handlers[type].reloc_handler; > > else > > handler = NULL; > > > > @@ -428,11 +864,16 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > > } > > } > > > > - res = handler(me, location, v); > > + if (reloc_handlers[type].accumulate_relocations) > > As far as I can tell the table above has accumulate_relocations == false if and > only if .accumulate_handler == accumulation_not_supported. Could we maybe drop > the bool and just check for that? > > Are there situations where we might end up calling > accumulation_not_supported()? If not we could just let .accumulate_handler be > NULL where accumulation is not supported. Then the table could be initialised > with > > { reloc_handler }, // when accumulation is not supported and > { reloc_handler, accumulate_handler }, // when it is > > ..and the test above would just be > > if (reloc_handlers[type].accumulate_handler) > Yes it will always be the case that accumulate_relocations == false and it uses accumulation_not_supported. This suggestion will make the code much cleaner. - Charlie > > + res = add_relocation_to_accumulate(me, type, location, hashtable_bits, v); > > + else > > + res = handler(me, location, v); > > if (res) > > return res; > > } > > > > + process_accumulated_relocations(me); > > + > > return 0; > > } > > > > > > -- > > 2.34.1 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv