From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60096C4332F for ; Wed, 1 Nov 2023 15:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 335798D0049; Wed, 1 Nov 2023 11:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E52F8D0001; Wed, 1 Nov 2023 11:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AF218D0049; Wed, 1 Nov 2023 11:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0AD348D0001 for ; Wed, 1 Nov 2023 11:32:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D95F11CB0E5 for ; Wed, 1 Nov 2023 15:32:49 +0000 (UTC) X-FDA: 81409778058.22.D87D6E2 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf12.hostedemail.com (Postfix) with ESMTP id AC8A74002B for ; Wed, 1 Nov 2023 15:32:46 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Hh2+yA7d; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf12.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698852767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vcCEUkBWxVVVtdlOMG0APDLxA9A2FXAb3KHpbe9d4OQ=; b=A5FKPTxJUaNZBsZ6iC8P38ovv3jkdWPz0ciFs/ZK2gKNZ3DXatkTD8a4I3Kzs/qHZ4J0mU IoBGX8kDxMPA97Yxe539ogkafp8J1RxxEk5KgqxWyhyRUfgGnr7Qm6c49EMg7jGhWdyqhA 0GoPFAARUdftBrsRQovcoBWuL/1y8Sw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Hh2+yA7d; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf12.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698852767; a=rsa-sha256; cv=none; b=YJtXltgUW59f02l9WAMT2++0+e0OkP4qD8/sWx9DjmCJml6r61nA3xV6GzA6E6G8bqw8XT Rl/BU3gBmJTq/4JbaZj2EPjhTJoI2+LMbpDT8Fq4k27KeijZ0xV1oHJyngVadQ05pGrqPM qBvQOLm+5i/vv+zqzb7twuX8lVFN6WQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698852766; x=1730388766; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2nyEdm6cgXtLmEHT90SMnCtukFAW1r//JISNY6vr7Ro=; b=Hh2+yA7dApXkxpm461tWhaGeL0QnHh/xxTzl1cgASkMm6m1MJ0Wfrimw z+0muMdItn1PjNVy3RyFG+oSQTzvMRnYFq8Pvr8UPtVN3RBCBjDuy9WCp yhKZLrEV969e9Mt33MAFCadFRQyupG9mEIetvlwOzOQvI/Ewu2VJFhnle rirweOIHLnS+4eXZa1oBVHrDWkYnKidFzhkWDkKMhLFFwZW8tNHuAbLQz RiSzfZ0y5NP11xORnBv/8W4ytSPUTh460vH6vJgjYBmEwHmv0UVm3LdCh l8Jwf+NtMimvCWzhziamonMFqh9JR8VLN2FNEpDSmeLDADqpKSA7B+Mmk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="474758879" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="474758879" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 08:32:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="2207680" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmviesa002.fm.intel.com with ESMTP; 01 Nov 2023 08:32:35 -0700 Date: Wed, 1 Nov 2023 23:31:10 +0800 From: Xu Yilun To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Subject: Re: [PATCH v13 03/35] KVM: Use gfn instead of hva for mmu_notifier_retry Message-ID: References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-4-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027182217.3615211-4-seanjc@google.com> X-Rspamd-Queue-Id: AC8A74002B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: x5t8ud5ugg61igmejopg4bkbwiqt6ksj X-HE-Tag: 1698852766-115086 X-HE-Meta: U2FsdGVkX19E3VEj0laMHFtKWwo80Iqn3puWGDF4UFIwK/XI+0VBsAQvwodLYUUnIeF2ZZI5MGEriieOOzqphG/VH3MUbrP2Ah3P0MiNkt1zYkthNCzmd+esV3PycMAOSynt7cl6zBB1XWI18vFLBF+hhUTq435U/4MgwlSZGfTBrgzar56m9HkOtbsNVt8MDns/YbvCRfGQWs46ebCfxwXSENaCGY6h15zVOPdXFjPdhvZLaWkroFvjebZrItjpA03iRyfPlo3PpU0OADPkPz3rmYjo2PiTsLAd0AdV/iBXzKmOt1PtVI3eflkf0KOny2pC3eFSY7FQLclN6xbAYc3YcEIYduASd/svlXoGucCA3ks+sZe7hIQzfTBDyVypdkXz6v4NEbb7NeCFGiJWdnT1aSh3lMNhnhQPkeiPi7LTFkSJ2tRew5dXHJls+aTOBSIGU3ygzw9/87PfpLJXd14Nmr5fP492wcLW57aMuyeuxs0/afHqnzdhxerj+kwX/Rk8L4c7Aoqs7rFcxuakcPs7MySjTbhW+Txs6U6U9c2M8PVGBfmBirhWqwGi6nTAnJ+EHVZsM4mAZNZB45dZf2IqVTepDNdQfBrIVRwAyfCAGMm3MTI0e1khf39mmS+fuA0xyWgP8UWsJ7+Bv49rMzDvy5uxwHQ5P+XkOyrBaxn7D6rjS5xXptgrCemxXI8HuR5KAVVJ8awBQURONC4f0a3NSbrDNBdZavBYKOawXNk2hYGMTo6UP7D6gHrzRUVT2IQjf2iPRmuPmQXjBHJrUUqsVq8wdrDdPtt8w0OdQPpXSgUNdUnHsOh4pWRNN/8EuyvCiLlFgsE0G3nMo5mI2JKzbnLeEKr0Iv/s/Q4AwdEp5hLonOTTUa3WLsyJvuNDiheB63E1zLAwj1/PysOxUlk+K28R5b0JCMXg72KwRB/ORLkMoi+bEet78LBLDEIfCA1EXuwakazcsM72a3X HLmEodJA j1iqdDV+dC2/GK6/zlLHDdEG+g831ZA6dm7e8dSxTSqEppX46QbZhKvi3EULXgnPMPHMb3MU5MQ67VPPqcO8cQss8OQODpgp+OccEXg7XvTG0WpMl8pQzoPP77nXIlYjO542UoI8yDNFg+tjNR7EeSsw/gfqBTm/Oc4b8BWH0gfl4t4kFjGRacEmup/tENQXVEjccLLrB8wIj8QS3rYJA1uYgG3LDQCNy392Aqn9EQQ2o6xz7EkKHlRElDSfSNdaTQJyY4ndYOw4wxJSSHqtQ3iBfVRxwjh6bhG2wgomhEvO3htGqpEVdsk0Vkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 11:21:45AM -0700, Sean Christopherson wrote: > From: Chao Peng > > Currently in mmu_notifier invalidate path, hva range is recorded and > then checked against by mmu_notifier_retry_hva() in the page fault ^ should be mmu_invalidate_retry_hva(). Besides this, Reviewed-by: Xu Yilun Thanks