From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2014BC4167B for ; Tue, 31 Oct 2023 20:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FA7D8D0012; Tue, 31 Oct 2023 16:27:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA7B8D0003; Tue, 31 Oct 2023 16:27:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299EB8D0012; Tue, 31 Oct 2023 16:27:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1A2C68D0003 for ; Tue, 31 Oct 2023 16:27:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D881FA0B9E for ; Tue, 31 Oct 2023 20:27:28 +0000 (UTC) X-FDA: 81406891776.13.4331AFE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 462472000B for ; Tue, 31 Oct 2023 20:27:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wo9lFuiN; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698784046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J24EvlKL0HTV1heFD4NanY/502+VJ56TUzZ3rmsx9yE=; b=DPFE3y/ggOGZDn5j4HXlV8/8Cu9VmcPhkPtfg1HO/LFDbf84M9zDxMCWDHnBgJnVYRd5qv oSRD1KTyFDzuJBdvKUUXARFYPCNTyeA6DC8e2WPjvCJL6M4AvVF686sKlKqyRsLbaJ4uc/ 1iii05isQMivQFMgM7iJc+rWYF+vMjw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698784046; a=rsa-sha256; cv=none; b=T3A5FQuJCXkfPVxeLOcqefp2ZaOqmhnvvEXYRFC1C6aR0BLv0BaE4lZ1B2I5rRu1aQEswE GML0Xmh9YviLFuHbb5uYMIvjmelE9eiIxuPOGrSF4b9xZJPsRZpPKwcyVWi3EJ1fcr62EC BpUUhNptM/KbrcwSIBFCqQCX5iFHEks= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wo9lFuiN; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J24EvlKL0HTV1heFD4NanY/502+VJ56TUzZ3rmsx9yE=; b=Wo9lFuiN+tfkVPX49uRGez4hyH pG0l/rW81DbJuj66DwFPin39Dl56jTX5KQzu05WHnDAgpTYPL7hb7vfyD5fRtr51+9lElDrvYaMsD TGkDyBtHFZLpqwN5z6XEXObeg6bGTHCAQY3gjbyTWmCaSKKBLeKeKDIxTEhoh1RtNWwg7ZDxu62JQ yo/AXubuf0t85nkv+tFHGtZi3rt9aAVOs0Tk033CXvZB7Y8ZUuWczlhNhDoGKuXSJa9hFTMeEuIwO XeqfEXv05OSNVqpXmv1i69SfIWx55wA3BbBY+2XvdS79r6ggFJmb+ihfMqtewfqSnagfr90c1YiF8 J7371lqw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxvJy-00C5Ur-MW; Tue, 31 Oct 2023 20:26:42 +0000 Date: Tue, 31 Oct 2023 20:26:42 +0000 From: Matthew Wilcox To: Sourav Panda Cc: corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, weixugc@google.com Subject: Re: [PATCH v3 1/1] mm: report per-page metadata information Message-ID: References: <20231031174459.459480-1-souravpanda@google.com> <20231031174459.459480-2-souravpanda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231031174459.459480-2-souravpanda@google.com> X-Rspamd-Queue-Id: 462472000B X-Rspam-User: X-Stat-Signature: r8ud39qxj7an19msut4f1m5nm3j5wif6 X-Rspamd-Server: rspam03 X-HE-Tag: 1698784046-321866 X-HE-Meta: U2FsdGVkX19X07gSjqvAy2cDkpE8raguvqB25A4c9u+vwmSHphqJ7aUsYZBZEzBk5E+q+6foe4y2581mQbCBx1WQHQDtwt9B7YcO/WSCT293jex1F8eryGbZrxKFHYT+bV+BOHSy6wab7u4U1VY6vSwpCxntkzftCL650VpZigG21/X9YOrDrp3qvMEUoSh6dZWO/VbwnDXOAxv74rDkDhwnY6sMQWOt1fZzZtU/S+sxitXAU4RNAKHrZFfELh0ePAgWRkCWzGJ+sgVDU1fc4fqz/eXP/Xd2AxCfXd559MWilxOzDZ/NxDrN0HXHkGr+OR8i6zPxbdo8yeTSEYBTM0L8RbhY3Q0XD+OtwZz7CnjFI5yJmLPXhOftvGD3sQROKqIaW/Z6ukUqT63LU6WPkP7pd2IN+BNWwz71Gc5z4Be8x01hSU06qe3o3bLj40Ju23/zxHCJ5QwSAuuGL/MvGCfnJva3aJk0DJlQqtlgm0MspMv8xCpu0EqtbO5PGqUw0o1YkNZi11jbeU6ZDNCGbP3nl/SVOdlTPUWWrSkOqyo06rs4JbupTLtPavIJRRQkIIFde1E1JT8FjIPZmZceXsuELtj613bsLg4PT8aOOcvXLntkuwpUgmAQBe9mI6hLWAV+F3t12jTdN9t4AWdt4fGCWSpFJ5AmPraPNFK2GfE0ILpRBgvkMCLMTgyAIIiNWQj44MOoeHwQTlyQRXPdjm5sbAG13hoj6n5YsWNKmmqFa5nuAROx7jmuHD4bJ7KH9b5AfhcZKfDCeSxem3gxFMABXDU2s2n4yFK4OKkHAPLwKaeIcjH4nid13XJH4XgyuAfHoVkoMWDadfioqRxQFavTBc2adeOgf+hWB6m7pjd195LrmXeGFqePx0aS/uP/NkllS32SWWui2e2Wq/Jilg3S4VpNtfsjCDn7OWTEbZ6twQDq5C5R/fLR5RCT+e1urPWIzctKAGZR8mmkLjf Vp9ftJ/4 P1Wg/CQQ7lXyXNwGjH5xYjDMyNtsE/bZNVwlpoEjW+WPxSerNiZfXjZYl1r+fKRHjTZK/BCi7ftqCzAFfzRZxFE8xK0UssfMqdcT5UxjNtyaYa4jga6re+BebBy349pamtQKyZEFu91I9h5EU4X/lHwyY9ACRyDFakp4H62nQzdHDv7SrIq+EDgAnID312+T7nUYgBzVAMv4RFb/Zi7GaTcNER/8Quo3dZtB/GCrjfk6oXVMPcaXNQeO7J59PldopO4Xi0llBaIHcVxXDqfyrCa/fPIzJ/q0OHXmLVHRsz8tpad5XBylxZY/tmdJsvnaBMxBPNXcxsXa4J8E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000112, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 31, 2023 at 10:44:59AM -0700, Sourav Panda wrote: > +++ b/mm/hugetlb.c > @@ -1790,6 +1790,10 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, > destroy_compound_gigantic_folio(folio, huge_page_order(h)); > free_gigantic_folio(folio, huge_page_order(h)); > } else { > +#ifndef CONFIG_SPARSEMEM_VMEMMAP > + __mod_node_page_state(NODE_DATA(page_to_nid(&folio->page)), > + NR_PAGE_METADATA, -huge_page_order(h)); > +#endif surely, __node_stat_sub_folio(folio, NR_PAGE_METADATA) > @@ -2175,7 +2179,9 @@ static struct folio *alloc_buddy_hugetlb_folio(struct hstate *h, > __count_vm_event(HTLB_BUDDY_PGALLOC_FAIL); > return NULL; > } > - > +#ifndef CONFIG_SPARSEMEM_VMEMMAP > + __mod_node_page_state(NODE_DATA(nid), NR_PAGE_METADATA, huge_page_order(h)); __node_stat_add_folio(folio, NR_PAGE_METADATA) (create the folio first ...) > + __mod_node_page_state(NODE_DATA(page_to_nid(page)), > + NR_PAGE_METADATA, 1); Are you allergic to page_pgdat()? > @@ -1656,6 +1657,8 @@ static void __init alloc_node_mem_map(struct pglist_data *pgdat) > panic("Failed to allocate %ld bytes for node %d memory map\n", > size, pgdat->node_id); > pgdat->node_mem_map = map + offset; > + mod_node_early_perpage_metadata(pgdat->node_id, > + PAGE_ALIGN(size) >> PAGE_SHIFT); I swear I said to use DIV_ROUND_UP(). Yes, I did: https://lore.kernel.org/linux-mm/ZS%2Fm1KRwTLkcJY8y@casper.infradead.org/ Why have you done something different and claimed I said to do it? You've annoyed me now; I shan't review the rest of this.