From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18557C4167D for ; Tue, 31 Oct 2023 16:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6CF8D001A; Tue, 31 Oct 2023 12:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A7918D0012; Tue, 31 Oct 2023 12:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 796318D001A; Tue, 31 Oct 2023 12:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A2558D0012 for ; Tue, 31 Oct 2023 12:43:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 380CA40980 for ; Tue, 31 Oct 2023 16:43:44 +0000 (UTC) X-FDA: 81406327968.03.1ED86BE Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf05.hostedemail.com (Postfix) with ESMTP id 5AFCD10000A for ; Tue, 31 Oct 2023 16:43:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2mWEcCJH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of dmatlack@google.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=dmatlack@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698770621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KUWzNpZFu6ZH+LPCMipXBlnOZ2iMu0xo6DdlSVTTSCM=; b=P1t9zzOCkCv1DDwNZv8SqK5djQx6kIPtXTExk776mxIy5vhMZWkBrUYhD6g29h4YT8tYya HjIIs+a96OBHNtEzlBKBBeoJ0++0euv6RyqRXjsQ3ox9Y6rk2R9jBeMgogo3PHm3K5z1ga ai5pkOGBDjJVZol4p2Qowc7DTyyjLU4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2mWEcCJH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of dmatlack@google.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=dmatlack@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698770621; a=rsa-sha256; cv=none; b=QbA28vlxhQ4peAWF8AGqvKLLAG2aVyBYnUpYjnBrt0frfQy5sDMal1gvWJb/eeu4nCox0c QiYsBhsNh7dRAPNBwFZVnlfokuiQ6a+7/TNm2A5gRgJLjy9VFpPhvZoS9vrE0jyCOzVe37 Eb6BaGGnPG/JyqHbRD2GNBsaF+5nGFQ= Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5b999980689so1719252a12.1 for ; Tue, 31 Oct 2023 09:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698770620; x=1699375420; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KUWzNpZFu6ZH+LPCMipXBlnOZ2iMu0xo6DdlSVTTSCM=; b=2mWEcCJHmHJL9G5oy0Qj2bT6Skc6TGRxgIWKXmq3HGO3y6bA2d44BXskYZYW/YAxE+ PzJvRwJQxNF8gtPJq0CV2c5d6BNlSs59T9nuylW29gPzBtuQODHtAfQZI9tTTxi6G1T9 QLVmv0LT69lVLzE4Y/Pq6DLanYIhBnecSuKQu3SfcmkoftrfwASZ9/MI3Hk9B4gTTsGM L5GzImb0SAvbKxi8nzObXYvDrUzuyXNb9GZXa2titA4ln1+ntNRyfbk5SQ0JH/aQJRHp RgCY3Rg8R20Eb/1HgCUkT8KS1/ePu9sEuTGVIqFH/y7CwsjN5OcNIpvcducHhuZz9FNL WjaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698770620; x=1699375420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KUWzNpZFu6ZH+LPCMipXBlnOZ2iMu0xo6DdlSVTTSCM=; b=eHsrUrqBaousqHBuBu9ybnMFfwNS4v2fiNkDRpT/D1fSsf1Hbv1nhVTpgCbhqVmfA+ jpzvpNqLmYfgEfOM3fgxAGTOHW6fIHEltZRG7ls0KIwBOrrx8n3zVM1wa9pg9hw4o8tx M8kMw0awmKw1irh3CoW34YF4ds1fXojwURum9hIsfeJPdQQm07Kt+nKGZl3pc6hoNAoJ dUgDvvQHCHvc10ZFQgR4Tr9hQoBfXa5roKPNNJI4yaWbbxXrbM1RqxqqFUmPg8UYyIcT t4CqcQc5sAJve5FyFzEY4aiZxZg8zIpGUpF79OciwOOa3zEH386rVmAvXS+R1ySgvuup pQ5A== X-Gm-Message-State: AOJu0YyAePKy8TD4e3zgrimV19CnPntCXgDc6ORP4dgbmnsTAiY5JwYQ peK897hbi9KmiVRP5MxkJZ/SXw== X-Google-Smtp-Source: AGHT+IEij7+ydhlYjhr1xlKLUtNUJw25BFH2l+RQ8zeBA7dBnKRXxZXchV1bLlBIgwVsc3GuzIJ3dQ== X-Received: by 2002:a05:6a20:a10b:b0:15d:7e2a:cc77 with SMTP id q11-20020a056a20a10b00b0015d7e2acc77mr12395968pzk.48.1698770620059; Tue, 31 Oct 2023 09:43:40 -0700 (PDT) Received: from google.com (175.199.125.34.bc.googleusercontent.com. [34.125.199.175]) by smtp.gmail.com with ESMTPSA id fb17-20020a056a002d9100b006b1e8f17b85sm1451493pfb.201.2023.10.31.09.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 09:43:39 -0700 (PDT) Date: Tue, 31 Oct 2023 09:43:32 -0700 From: David Matlack To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Subject: Re: [PATCH v13 13/35] KVM: Introduce per-page memory attributes Message-ID: References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-14-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027182217.3615211-14-seanjc@google.com> X-Rspamd-Queue-Id: 5AFCD10000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: appb569z81wy96b7za94frg3kuj67m8t X-HE-Tag: 1698770621-742759 X-HE-Meta: U2FsdGVkX1/xV33OJ+XrxLsfpwS25fHcDNnHY5UjVU1nBwCUxTC6lIV0OXuTeOlo1MFfLzGa/0rKbFfH5Xpt56sCx4tfT3v34+6GzMc2cyA74z56QtJQCZuOSdNTgPt1NnXUmdAv6LH78usQDwTM/tSJmMY6kbNOusawcwlYOELRvGjvQmPjre2XOsp5KogrBksnrP9n4Ri4/ngo3RKIP44yLU7xVQh+bF/3MYd47GMXOtt2q57zYKsDvp2HTdNeTo5YOafBom6tQkICscDYpuK6f3FRSZoMYX+lJ8bbJXFH1pjRFhIq4Wn+QlhzoIiQm17x5YmXC7V73UL/ratrlERQ9hSLit+jEyGH3Xw/v+hwaRGnj4Kn9MZBiVRcVjfwH/FpiSSXMPDJNTjIjcq8ROID2JXSOKFRhZIUrVe7XSfZThUPl0qi8fRo78J5HsirmtoiRtP8jl2n316D6j4jZN5GHEkCR2QP86UighjkPcN2UJjiwcBa4BGbSzZG/BmTWeI0EhPY8NkYe35Gr89w/JN4MmcHZ2JGSjKBZqTZXzSSzrSItyEu8ms2fdgopsEpqfqAK3cSPQyZ2dDowswrOTfzXw72m7OBppMNYuJeOJ6EMmzUzwAX4P3rITonY1wDgZ9tJJDKO9d266dDmykztWYkIwXxvEsezjZa5qRvny2HNF0N8mmact/Uh25YaUN83evXs4jXnJNjYvLFkoZSHl55qKR6JO3RbNs9awRtzpbps39x9GtlmFy/0bS/o7e8xfHldukf+eFjBb2kuJykfCBrJbGhiWYe+iHSrfIK0l1ckGrjMQLCWEXlr8tSiEOZ9xPIgb+RZKafyCGx1MPU4RB4aIf3resDko8REMwV+C75RX+XRCMfoYW7Ch2Smxa8dpSXmte3IJ7fSeEKfirBpvLtc+xS2qtAx7SyB5x3576q+jZ8MOb1maNlz+S5m1Y9uJz7oQmRfMG+vKOxnqh y/ZjSZYA phBEX38qVqVCCDkfIm8gZ+DR8yb/vES9yqOdYnV1iYKaEzAJunxFr7z9Yske636iChTVVFF2zS8NYLlg5MLUiRVJxt+VcjzrfYB4kTTK5flwOvZiMKoSA07YlUGdKpYGY98UvTirRVz9MBqTdHQp5WBrYKTQE6g1N0fknLp5Uq+8AmKg3K9+98i0w5FmeM0A0HRspDqHAm0ar+OCrH+7Um6Ovf9ub/OzUKFdbU6pU2hZEw3BnMf61+j+YJDStjwzQ85zI1mkBcbiebEC95UnIg1UlDrei70NhTihoAgNgsb3xXSMVTFKdxhW/LVsFE+Znjqc1Cxmeb8EFPVCDHHbQk68zfFn4ubK/xqtyCwIQ4z8xBhvy9ATMu9VMCdWY3kCKzskA9CvafrDpWCJUiB3/M4TacDGVvVrse1GkEPz3n/YO7q0vYvRqQqA1K2e+mEYpP8HKypsXRZPKgmpdJ9cNcpWPvKUP/mPV1tAJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023-10-27 11:21 AM, Sean Christopherson wrote: > From: Chao Peng > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 89c1a991a3b8..df573229651b 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -808,6 +809,9 @@ struct kvm { > > #ifdef CONFIG_HAVE_KVM_PM_NOTIFIER > struct notifier_block pm_notifier; > +#endif > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > + struct xarray mem_attr_array; Please document how access to mem_attr_array is synchronized. If I'm reading the code correctly I think it's... /* Protected by slots_locks (for writes) and RCU (for reads) */