From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB399C4332F for ; Tue, 31 Oct 2023 14:05:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 794666B02FB; Tue, 31 Oct 2023 10:05:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 743FB6B02FC; Tue, 31 Oct 2023 10:05:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E5796B02FD; Tue, 31 Oct 2023 10:05:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F1F16B02FB for ; Tue, 31 Oct 2023 10:05:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 061971401C6 for ; Tue, 31 Oct 2023 14:05:01 +0000 (UTC) X-FDA: 81405928044.01.BD51FC6 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf24.hostedemail.com (Postfix) with ESMTP id 90E151800C0 for ; Tue, 31 Oct 2023 14:04:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QfiwU9XH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3hAlBZQYKCMs9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3hAlBZQYKCMs9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698761093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZsemryN+7v+wOBolNu7Hy0wHrULeaB9eFsfVkGp1/e8=; b=NxAxbQkQEplb73ZBE+U1yJcNwnBPm4Yw6UYw/qJtTG9Bln7VttPJ/l9i7cJlZoq2Gvs/OU 53ZXDXmvxpJsCdHcjsDVGZSodGckZcuQEPOtZ3j72nPXJK1LQt69w860oikHMIaXPD0u9K LlZ8MIaV5lX/gXl8POYRAViD67AbxkE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QfiwU9XH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3hAlBZQYKCMs9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3hAlBZQYKCMs9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698761093; a=rsa-sha256; cv=none; b=L8huox1mtoHr7SO3ecjatqa22zQiX3pt7lyuomqo9BciSOEVFs2RBnRKdxjiZe8fdY/1of Q3TUEicSRbIOLL1q9rb0Vg77bk77lwyGGEgQ5PcW+I299MfWU2T4zlmyU/0FTuvEgbPbWY WcBxPcYYR+C8a5B3pqFmQdTR3F+Q1Gk= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-da04fb79246so5390919276.2 for ; Tue, 31 Oct 2023 07:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698761092; x=1699365892; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ZsemryN+7v+wOBolNu7Hy0wHrULeaB9eFsfVkGp1/e8=; b=QfiwU9XHbrkbxU0Eii+8eCg0mK6bQsmqfUuhxokPVJfs22T4dlxgKUTo5aD+nooCS/ 8OPiqP28oRmb/2lgPZPKKOUZKPcAntgXUyXrqKI7jVGSgiDvs3o3opTA35YN5SU5yelK FEEpViyi94rfesFAxxAKYdkLFUnbmB2D1+y4ojzNPyPlyTUEdKT8Vrjen2uEfbXu/KtN XXuDDrwEGh8OXA28z2gCjkv8lEoq+r4+B4DVwwxmlDoZBWXgB/tb8Zy+ffH3tkgnGvGS YeyVLlz1AqidY3cnH02lLUugFnIqGtSAFPIGBn8Veggv3IQ+LA1o1mrDL0ddKAzQbUxr D5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698761092; x=1699365892; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZsemryN+7v+wOBolNu7Hy0wHrULeaB9eFsfVkGp1/e8=; b=mv8681E7psCRr3UNHuBtDM7c1d7kyiiTW1VnK9Z+UogykMfVspCJgaSxhljwqw9oqC P2bFZVPVg0Vjwsf1gKZQU7oAEYntfA7BvN8md5nd7qaw1ggASdOmhikwpnNco9/3IREb h+55U+qNjNQ/2LBJI9YD9YRVL5RNO1IEVd3xLobqT52jyBOnwHcJceYBjGQPoC0GbNRi clivJ0DZOmK7h4jUTXiCckPowNoiq8bQig2Bc/AcwwHRntGNbzrT4WlWHtB0yub0bk8b 96+//uOWqkuXTJQGYYxyOeWvbZBATRnuLKy7xVnNx10Go3TdW2ot/o54MSP5aXGCB/Lo NmRA== X-Gm-Message-State: AOJu0YyfGfGeRnby+o+vYdQkfdM7QC/ndEXKT0bkToWshOtWYpF58i+V uehbdjyw2iXRPZMTAR5D8ytWfgStri0= X-Google-Smtp-Source: AGHT+IGMRYf422gsAhq04hJnKRMCzmHg+RO6tAl4JuMhPFGeve1lxsPBrReypZbUvK9g95iFN5O303NMZlw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1083:b0:d9a:c3b8:4274 with SMTP id v3-20020a056902108300b00d9ac3b84274mr301710ybu.7.1698761092559; Tue, 31 Oct 2023 07:04:52 -0700 (PDT) Date: Tue, 31 Oct 2023 07:04:51 -0700 In-Reply-To: <2edd908a-9699-4d8e-9063-c655f1fc9712@intel.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-9-seanjc@google.com> <2edd908a-9699-4d8e-9063-c655f1fc9712@intel.com> Message-ID: Subject: Re: [PATCH v13 08/35] KVM: Introduce KVM_SET_USER_MEMORY_REGION2 From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 90E151800C0 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ddserkbrg74bnzx839t4nqwe4iumiobw X-HE-Tag: 1698761093-805960 X-HE-Meta: U2FsdGVkX1/1Wyqi1gqq8AadWryIebIW4ox/XxbKtRCUHYHPRAYHt2CIFjeAahGvM1eoMjt/uTbi6o+bOyadRZMwiALz9bVX1aifg2fSRl9lO8jfY3nRpicBaM9g8ezppmNe29cULu0CFG6JYQWNv99wc9Y64ABpSeOGeg2tCl0KN+0UnaelK4M4mcg5pRrX0dZ5wRFV1t8NhDCqeQVuZNlRSkigVYAn81oG3AdOtpqCr8zFGOFzKdKiQE92OggYrA+BER70i0F6FTOb/3hgTn/d80Oesi5g4eRaf4/WkCCNRCixe7Wa5tU9bOE9AxW6o5u2mSvf/OxWDpLOlF3NZ12eM6TzOLcNpiMk0ABmNJiEJZKxGUUlVfGBH1CNyJcGWGJFiPqsJMbJ9vfAp1lNI7lyliKmNKh+FHexn9zT45j0ONy7o7MgNKUJSvPNbJjdjH7trZxNtliFAJymTBpQ0Vm5xj4XV8ogl/TcZ37xvIOFGx1jz+/cSah2yruxrPbESk8QDmq9fInefBig0IdorH+0a+gpRIxHerMUJnVP246Tw/NYnEsSdmh1GjUM4MYghhLGnAS7d9fPB9puJfg6CSwogmKy8S/YQEDgipKDiPirQ+k08foJKzzgbJIGPyyM66yVmXLaphtmv9z/Imi4ATTKWwffWpA2s8yqOqenFUaEn6cFyhlhqqoNdHD4Gn/Uhea7bWKW7kqxOOJ+xOJIIt49CXIYXzqZwfwW+mXItyTq6/gMmAOfEH+O4IGC/TUgZrXqtOwM2VbhfR8oIiBtRiEM64X4P2NdeExgDHUjPiGSHE9n6VQG1tF6kkyrd65OLCjduya1WGuuhbyqrQhr2z7tbYm3Yx5RHQ5lxsE104/uZ+tHKsYAIAWTT5Ch7YPAT7Pj8EyGDLRFxX65WEsd3/1wienPNLBgqMoJNjeh9cP/Kz25IW+eR6HIP3yrPvTs1Km6WUubR3MWIljsWgN 9im29Dp1 cpzKnAEpl9o+38AArGxrB25O8WMU9+MHaKT9e2NLqdyW32b9zsxLcSIzV22d4reYNCMWW8tYPyxDu4Z61NmfgIyAHhnTSaZO7vF8yBoEOOmVDJIzUzdxQt1J/iQwArwUSKOn5HTK6KDpMiVzb17W3aRYzB5CBuWWe3BXXjDz4MN+McfrTguDvjTaejpI9UBsKBHTGRHMtIPC9cWc2IUiKBE33cMedGaegTzofoNm8MocoLDlWWDYKrYOtsGBP88xxUcOO1nwqGYBlXN+AIFsrp29wNK2mTAqTLlZjOqvJc3B4hoY1R3eFT6aA3nOBqJNko1pCo23eAA5xykVDeOQn6bHmKBJ3fAt7Rpl59g6/Av7Sq0beeMqVYCbD0AdHapmkFpJq+/JSnV0iZmmEZDsOfKHAztHumcrQrpnLd0PQ9Kxsk/lbCe4ArjPct9vkhePBn+4EZhpI9oL9j6wMYuMnDjbpN8J2CJNketz7qXdV9uzCuilqD9zV5EBaA6q/oXdwjh5mBbuF5QDCLLANnAwLmwD+OdER8CibwtKwnaSQWgDzEbT/MhfGG3879GWaYvrtHYCem7WF1+v7DP1vOFRdsruub/hKVxDN/XwSSizCh+4fJIMi95Dcns4rpjfxEDc4vIdX38BFykys/2Tsf3EFM957W5mmK0uyIsDRMFM/7IX32/k+PjIq8eTjNot0LnLblCgMfZ/X72ROYDh1VH2nzX+xrdiV7cUzUANb3x4nyiERSv7WxaVGQ9GyZ3YfVPBYJaUMFVIoozXsbriTwCIyZ8mKtXN9EiGxowlg6iKwUa0IE7jlS4De5bN5Cbp6YLWQmpS3xb6RjTcErHs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 31, 2023, Xiaoyao Li wrote: > On 10/28/2023 2:21 AM, Sean Christopherson wrote: > > Introduce a "version 2" of KVM_SET_USER_MEMORY_REGION so that additional > > information can be supplied without setting userspace up to fail. The > > padding in the new kvm_userspace_memory_region2 structure will be used to > > pass a file descriptor in addition to the userspace_addr, i.e. allow > > userspace to point at a file descriptor and map memory into a guest that > > is NOT mapped into host userspace. > > > > Alternatively, KVM could simply add "struct kvm_userspace_memory_region2" > > without a new ioctl(), but as Paolo pointed out, adding a new ioctl() > > makes detection of bad flags a bit more robust, e.g. if the new fd field > > is guarded only by a flag and not a new ioctl(), then a userspace bug > > (setting a "bad" flag) would generate out-of-bounds access instead of an > > -EINVAL error. > > > > Cc: Jarkko Sakkinen > > Reviewed-by: Paolo Bonzini > > Reviewed-by: Xiaoyao Li > > Signed-off-by: Sean Christopherson > > --- > > Documentation/virt/kvm/api.rst | 21 +++++++++++++++++++ > > arch/x86/kvm/x86.c | 2 +- > > include/linux/kvm_host.h | 4 ++-- > > include/uapi/linux/kvm.h | 13 ++++++++++++ > > virt/kvm/kvm_main.c | 38 +++++++++++++++++++++++++++------- > > 5 files changed, 67 insertions(+), 11 deletions(-) > > > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > > index 21a7578142a1..ace984acc125 100644 > > --- a/Documentation/virt/kvm/api.rst > > +++ b/Documentation/virt/kvm/api.rst > > @@ -6070,6 +6070,27 @@ writes to the CNTVCT_EL0 and CNTPCT_EL0 registers using the SET_ONE_REG > > interface. No error will be returned, but the resulting offset will not be > > applied. > > +4.139 KVM_SET_USER_MEMORY_REGION2 > > +--------------------------------- > > + > > +:Capability: KVM_CAP_USER_MEMORY2 > > +:Architectures: all > > +:Type: vm ioctl > > +:Parameters: struct kvm_userspace_memory_region2 (in) > > +:Returns: 0 on success, -1 on error > > + > > +:: > > + > > + struct kvm_userspace_memory_region2 { > > + __u32 slot; > > + __u32 flags; > > + __u64 guest_phys_addr; > > + __u64 memory_size; /* bytes */ > > + __u64 userspace_addr; /* start of the userspace allocated memory */ > > missing > > __u64 pad[16]; I can't even copy+paste correctly :-(