From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CBE9C4167B for ; Mon, 30 Oct 2023 20:35:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98B4C6B027E; Mon, 30 Oct 2023 16:35:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9626E6B028A; Mon, 30 Oct 2023 16:35:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82A356B028B; Mon, 30 Oct 2023 16:35:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 723656B027E for ; Mon, 30 Oct 2023 16:35:37 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3E4821207A3 for ; Mon, 30 Oct 2023 20:35:37 +0000 (UTC) X-FDA: 81403283514.25.C9A5991 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 3587A40017 for ; Mon, 30 Oct 2023 20:35:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L3FaOxqT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698698135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HQqQywcIq3pleqCdkmZJnvq+aD96AGHUCBNW1Pk+bxA=; b=tUv01eROGTQ1nxO3blF3f6JA1ZfgdDZW5Y8cSiuaraV3ZsqvJd38F1UixRM9JkWdf+K+de A0lkaEWjBDw4AdtC/okMJlcYE8hR0kmSL4yAu1BTE2ChlNlEPY6BHOFkUnGoylzwSarqth obv5NdzKp5aROcJ+DYz3kqZNTomxlIA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L3FaOxqT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698698135; a=rsa-sha256; cv=none; b=ZJLZ9YcaikEbgagEwhm7R33Gc9uEg8l1ITGhYr0ig/gXrcJV9fd2q241TM1blZKm9PnzOD cUkeRWm51D1Gy6m8xNbw1UsPsyFcdjf8rtmojtLY+JHgflcyyq6VW4wfb2Uz1fDk1fY421 33f/6NSORGtE+yJLI43c8GMxcjE4cAY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698698134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HQqQywcIq3pleqCdkmZJnvq+aD96AGHUCBNW1Pk+bxA=; b=L3FaOxqTEzbYGSkp9d7I1W0ir4JQKEliP4TnNsTBcUG93X3mUvmVU6j0vOyYxrX68xymxH pClacKZtHIXxyzh+BRXFyvwUKfd7ybgFFyBJtsrGR85uUPwf/ixXS/kpLt5uWbEpYiLGBd EkWakWXEwS6KOfoKmPdMTIRskrocQ1M= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-Yx7_MuFjPSGuJbnsA77WMQ-1; Mon, 30 Oct 2023 16:35:31 -0400 X-MC-Unique: Yx7_MuFjPSGuJbnsA77WMQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-66ffa15d354so9909986d6.0 for ; Mon, 30 Oct 2023 13:35:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698698131; x=1699302931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HQqQywcIq3pleqCdkmZJnvq+aD96AGHUCBNW1Pk+bxA=; b=Q0ZK7BI6B2A6XLzqv2TLFhlCRx0RI1o8vfj0MebL55NSbdxkehIR5axS3zcZ2w72ve X8cpNwI75LffNwZ9ou7WmInQPfMOfO8FrU5KtNi4w9aUGSNM5jQjhNoFcrjXORuQy5Oa uYbApfS0+Gi3wkDSlwzyEzdB/xW2g7yX36PWDTUfweKeoer5D9PC5+K7bluEbd0Egwvc +YAIII9ZVlBlIo54D3BMFJv3nPlh58YFlj9ZcqKjw741STkOAAYz1Py/bdBDzo45trTX XucRzdKCCQe05mlSLwPfPSpxckwpk3H6J5cj1+ZsY7i+d1+bv8Cf1M6iLNClkj5AFMCS mTKg== X-Gm-Message-State: AOJu0YzIfn5dyN8tg69Z2k+Ni3XBRhpxJ34vZGtbf4kPXnKtwTVBKly/ GGPWEEsx2dzzezutTJ+GsZ7FuZfnv2XdT5l+U79QUC05P2tiVOkfiMhOvqcF3Ix6PuKfcZh07s5 Q90PQAYXVfvY= X-Received: by 2002:a0c:f78c:0:b0:66d:6111:5c5c with SMTP id s12-20020a0cf78c000000b0066d61115c5cmr11465026qvn.3.1698698130987; Mon, 30 Oct 2023 13:35:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoHYJYrlsiTilKNNDCIy4gwl3kNblk99zpaZUZAXSFQUfkN4dW93Dg1VUo6nUBxJv7RxuZhg== X-Received: by 2002:a0c:f78c:0:b0:66d:6111:5c5c with SMTP id s12-20020a0cf78c000000b0066d61115c5cmr11465017qvn.3.1698698130723; Mon, 30 Oct 2023 13:35:30 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id cx15-20020a056214188f00b0066cfadfb796sm2362777qvb.107.2023.10.30.13.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 13:35:30 -0700 (PDT) Date: Mon, 30 Oct 2023 16:35:27 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, david@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Message-ID: References: <20231028003819.652322-1-surenb@google.com> <20231028003819.652322-6-surenb@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 3587A40017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: o4pc396rbik5marz4kjoddra4urqexz5 X-HE-Tag: 1698698135-169808 X-HE-Meta: U2FsdGVkX1/7gt+PIZhkRf0MUNlW8YIvwzot1RtCn+eErJjEzNps4gCtDw8jH6UVMHF1BAkRDHPi3usMrc6Jp/ZadmspDRhi+sU0gemFLEGWkYIgtQP9GEO+Kd9Pq0G81C61DgF8uJCaYsUj/T739hflvpC6kwCHopYUr/f/ccrEJINqJv547V66ybjY1kGyCX/awE2s3I9cNzf4qPq4aweRDa58taovrJm6At61CoFaHJCVbTGCwMyeldSZMaSQfX7oZEe5BHYl6CmdsfHrQKio87wvwvZ/P+kCuBg2kSYNu3pUCHZE/lCmszfXKUz1CIcJ+blHa0R/ULJ6bSrtQBfVqSzImVwzsITDxKgr81xoN5bC4w1SZFHYo4MCZAaMWlZac/qmrDqylpN7ev60s/LT/ZbSwUnQOWhVdGPddBQN0AhH5400IjEzxo2lxnS/ikYai5IQe+7YoOzzmlq/s8U6rfg2UPKJSP58WTvjoEzOoGG2r5Wr/bN4XA1qtu3Z5I5IL+BqUZsCCRuR8F/5bpR7TID/7YVZ8uyx6MKLr9mbEHRPRWyhsiK2uX3hMb0kR72si0b/wJdZOAvSODFZqPMtOgYxRrsoIlb5XTq0hnciclGPmP9HWtvHFoS+650r8THuZNbxuEWFycw3vCPoWwsurC9GISMkukxXnilT19UxLC29yDN9r997roJ+4a8KclXgcxNAApiivAf4wutybgKSZmcy5NRpLHDp471uNQJ0tXRjGyWQsie69XAOmypn1TUW9YmgLgd7xsieWLU765XsvqqZcBwOl7UWMkWoCiQAYztumZ8SkHuHnNh3Bo0PDIjz6c5WdqZeKuz1X8AZ9yK9uXRVLgYm5ftPvPdxgjil9YgAzvBNV4r44wSgVrF/WAhUtv01RkXlgmCEvc2i33T5k0U6Al4Xxy3dFUdtA3MPd6DOv1Lng0yeCV5mhHZeKzamnnl4eBYjSvLed16 E9cqKJuN 1FfDGVhh1U6Etv5xLCsdMBP8NxUPLFLDVLZsKOT8mzasCb+Q/34752UmUX0R0LUawTh6NhTRGj8ZqPKQqwfxyW9X4ZpK+bzQpqXiejFee1y7AL1qGtbwlBkbJz+K50wxG302OmK/OLqg3YRuwMu3xapyMkFoYEKnaaFR6JunCj8XoIUnOBPuD+Zp2zGb0/q7dUPqvTDDWeKVdKqcTNfDoJGpFRfnjTh9RRQXEKsHe3CSKYOzvvBF6ESO+dgyNC0Lv4rbdydYoZStEYjQBCKfvxNArnp/kJ2xlVOON+bcCxIfzO+/eJviBwaz0JltAZAakXMTDWQoJqwuQHfxkEMgA8zm7PkBMu4nMNESb5LjiMfePQSw5mDk8YsTw2JXhbUl6zgqEna7YCC/IoH/qewVzagurwpcIoEnY1YUi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 01:22:02PM -0700, Suren Baghdasaryan wrote: > > > +static int adjust_page_size(void) > > > +{ > > > + page_size = default_huge_page_size(); > > > > This is hacky too, currently page_size is the real page_size backing the > > memory. > > > > To make thp test simple, maybe just add one more test to MOVE a large chunk > > to replace the thp test, which may contain a few thps? It also doesn't > > need to be fault based. > > Sorry, I didn't get your suggestion. Could you please clarify? Which > thp test are you referring to? The new "move-pmd" test. I meant maybe it makes sense to have one separate MOVE test for when one ioctl(MOVE) covers a large range which can cover some thps. Then that will trigger thp paths. Assuming the fault paths are already covered in the generic "move" test. Thanks, -- Peter Xu