From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F8AC4332F for ; Mon, 30 Oct 2023 23:22:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 094BF6B0299; Mon, 30 Oct 2023 19:22:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 044D26B029A; Mon, 30 Oct 2023 19:22:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4F586B029B; Mon, 30 Oct 2023 19:22:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D52216B0299 for ; Mon, 30 Oct 2023 19:22:28 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AB7C680556 for ; Mon, 30 Oct 2023 23:22:28 +0000 (UTC) X-FDA: 81403703976.04.225F80E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 9D3FB120002 for ; Mon, 30 Oct 2023 23:22:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QFHqbbyR; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698708146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vgtwIpOv7aynDs/c0Cteoh8B8jUiQYzWQhTbABw5QcA=; b=N7s2EHhp64XnN+eu9zk/J7wxlbv+RrTC6wJM53Jdy9FdAHnPXnHbVD1nhhSzYV/j9TqmIe gUPxuBBrGWphXKSwFQzk1mc0fYYfGiceIvX9hzV2hFMMWc5HsqAYk0otAr5RIGrCIhsiHF XtLuRWFi3yYIt+fCU1CMd0Z5o0rRbOg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698708146; a=rsa-sha256; cv=none; b=CnZZ6+tfH5eQhBj4ehJwOQqkSPHglZakWYB7WvNHJ2GaVgz7rbip5ZZiF5/J5YAsiDQJ6t c89fswtWbTnOHZrB06s2IjUHuAgAeW8p3mHaZRb4dqvs5uVh4mlzbdot2UlgWCIImbJ8iU J6dmJOf6foopmFMQ8+CauSUgi9rx+ig= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QFHqbbyR; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vgtwIpOv7aynDs/c0Cteoh8B8jUiQYzWQhTbABw5QcA=; b=QFHqbbyRP7IuQ01xPhrltBwja/ wGRj5o0MMuBo1SVwbo3Id+jGqP5JjzAGevnCCM7dqgNQshaYbCYpxvekqm/SuXvTEcDBALcxC2XlU bedNmzolHcFiKC3RW5jIUdr94BkrB60btm8Gr+o1UuYqmj2JUJd1CdVpRTUSh+3prLQ/mCgwgXCYk /0wAuhiN7DSPP1SaQAny8pEQVWWjTG5UlurnS0MerTNx9UZITxxrsZIRYHCX7fR2J+43udgqowujI OzILe30wwaH0NxueJNBfyskdx43rVw9DBn+1EkNKWomkCI3s7V1ro2BooPL0DBV37SQSD7OyuVy8y pmRq6oTg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxbaM-006ren-HB; Mon, 30 Oct 2023 23:22:18 +0000 Date: Mon, 30 Oct 2023 23:22:18 +0000 From: Matthew Wilcox To: Gregory Price Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, naoya.horiguchi@linux.dev, linux-kernel@vger.kernel.org, Gregory Price Subject: Re: [PATCH v2] kpageflags: respect folio head-page flag placement Message-ID: References: <20231030180005.2046-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231030180005.2046-1-gregory.price@memverge.com> X-Rspamd-Queue-Id: 9D3FB120002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sr48go4xsh756fa5idahza33hu4ktdh1 X-HE-Tag: 1698708145-490602 X-HE-Meta: U2FsdGVkX1/uiokaXIbTygo08ewVDN5BOdicHgRartvKrwxXd9bLtW1Hkge8GoezZK7FtvhQbLIqL52qvhYbocURLPH+KcPeSnLYduj87U2qJ48AlP9RjxSTcLXoFArv4xJuadFsX0PhS4sY6v/64VQ7Q1EJvcAIGJm2zXJepQPF2m7UqdgR6ig+TmvR/H+2pyAxo1zTfRcFgJZnr9rjAiq/1i6gjVUC8OycTVq1VXMpcDY9Lmtnyyd0tzc3fI83xik95yG7HMjarLtJfttA/8f+Ge5eEKpNNi/bcgMxwwwyTiQ4xUGvaCcJ8K5BWfB88AaveG0dgcjL11lqk7weoycykBGnCEhh6kjh4+6UBLKXlmE8AdVWxObWOJn90aRalcYL7CZikz5qlYszF/slon91bDakarkDvE2JsK/6jw7Z8fg9jUENUmMirXful6JHCaJxvCyiRdxt9uhF3LanoLLMkkhwGly9xbN499ma8aylY/2uydKFyLnzZGhHF5BS7Xirh100vSQ0/rUg96ptFc26bQIBFhvPKEjyK7CcDftm/d/Mu5Ieno9lCFuB19ukP3eJAdrysYR9AQqj6g4Sp0u8aM6IVQTpTLrKd3wKIDh3iN1uO6n/dePIk7vgPvdTPJbGV34vBQYaj5Ul6krLHpHp8cIHxxhUkXzNnWyWKnajsQel8KCTeSPmOA6psGa4QwECTuC9QYwn+m7IaXrCXWVGuSOcR1OV4lTeorGsPNLo6VfrFS8QcEmYV13OQGpDFhXL72JK1qvOiC1UO8RlFdgxOpshSeN4qbzwiw7sZAWJY4NxEJ20XsDqsP9R1iJu+2RWhyVo3q8c5s4AHEiX6OY3kMpzw2v1B9gZN2paRn360V5So08Vg0Ih4pqaqw5XyH7pTorYjx8qf5nPM4Xi4Bk+0gehtG8v68e01iw/aIBBNlsZT3DYm/tScSEqLq8L9BoscUTgCMVm0d7l8UD u0i14vym elGD0HlWTE3lrewuMtK88lTErzViwPEkC5IJweVxLO4G2VUQr6MiCS17kPFaSdvNzZG+5vjUnsj00YzYDHA25YKql8qlpRfI11TgcxrjHXLX0YxonyOUsYBNIJLZMBcbybMHRnDvNjo1lk0IeTzeZaU5ZZvbxBLeEvwK9+mVP0/2imcSAr9HVSLSUtL+rUhIm3PzS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 02:00:05PM -0400, Gregory Price wrote: > kpageflags reads page-flags directly from the page, even when the > respective flag is only updated on the headpage of a folio. > > Update bitchecks to use PAGEFLAG() interfaces to check folio for the > referenced, dirty, lru, active, and unevictable bits. But uptodate, writeback and reclaim (amongst others) are also defined only on the head page. > u |= kpf_copy_bit(k, KPF_UPTODATE, PG_uptodate); > u |= kpf_copy_bit(k, KPF_WRITEBACK, PG_writeback); > > u |= kpf_copy_bit(k, KPF_RECLAIM, PG_reclaim); > > if (PageSwapCache(page)) > u |= 1 << KPF_SWAPCACHE; > u |= kpf_copy_bit(k, KPF_SWAPBACKED, PG_swapbacked); > > u |= kpf_copy_bit(k, KPF_MLOCKED, PG_mlocked);