From: Matthew Wilcox <willy@infradead.org>
To: Gregory Price <gourry.memverge@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com,
vbabka@suse.cz, naoya.horiguchi@linux.dev,
linux-kernel@vger.kernel.org,
Gregory Price <gregory.price@memverge.com>
Subject: Re: [PATCH v2] kpageflags: respect folio head-page flag placement
Date: Mon, 30 Oct 2023 23:22:18 +0000 [thread overview]
Message-ID: <ZUA6qq6zXuc0fqOE@casper.infradead.org> (raw)
In-Reply-To: <20231030180005.2046-1-gregory.price@memverge.com>
On Mon, Oct 30, 2023 at 02:00:05PM -0400, Gregory Price wrote:
> kpageflags reads page-flags directly from the page, even when the
> respective flag is only updated on the headpage of a folio.
>
> Update bitchecks to use PAGEFLAG() interfaces to check folio for the
> referenced, dirty, lru, active, and unevictable bits.
But uptodate, writeback and reclaim (amongst others) are also defined
only on the head page.
> u |= kpf_copy_bit(k, KPF_UPTODATE, PG_uptodate);
> u |= kpf_copy_bit(k, KPF_WRITEBACK, PG_writeback);
>
> u |= kpf_copy_bit(k, KPF_RECLAIM, PG_reclaim);
>
> if (PageSwapCache(page))
> u |= 1 << KPF_SWAPCACHE;
> u |= kpf_copy_bit(k, KPF_SWAPBACKED, PG_swapbacked);
>
> u |= kpf_copy_bit(k, KPF_MLOCKED, PG_mlocked);
next prev parent reply other threads:[~2023-10-30 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 18:00 Gregory Price
2023-10-30 23:22 ` Matthew Wilcox [this message]
2023-10-30 23:41 ` Gregory Price
2023-10-31 9:13 ` Matthew Wilcox
2023-10-31 4:34 ` Gregory Price
2023-11-07 1:03 ` Kefeng Wang
2023-11-07 15:34 ` Gregory Price
2023-11-08 2:01 ` Kefeng Wang
2023-11-08 23:33 ` Gregory Price
2023-11-09 9:05 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUA6qq6zXuc0fqOE@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gourry.memverge@gmail.com \
--cc=gregory.price@memverge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox