From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA01EC4332F for ; Sat, 11 Nov 2023 12:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFB778D0011; Sat, 11 Nov 2023 07:25:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EABAD8D0003; Sat, 11 Nov 2023 07:25:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D99C28D0011; Sat, 11 Nov 2023 07:25:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CABC38D0003 for ; Sat, 11 Nov 2023 07:25:22 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9262E14079F for ; Sat, 11 Nov 2023 12:25:22 +0000 (UTC) X-FDA: 81445593684.28.83603B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id C743D1C0005 for ; Sat, 11 Nov 2023 12:25:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699705521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ksLADd2+L0w7KgUmqciSTe3hhB/lr0wdn48CE8mr+Z0=; b=OZsqZIrPKm1ZU6+9YWRNjYiReGVYOAZMzfE3KKl9OVjyW1s5rtIcplBR3G+reOR9F8NE6r dP3zBiAnGGy8WoOXyd2hzwz0hvh4+51TG4V/kZxLcaAEMp6Vyaxdz9QfrlZPf6lt4kU8Lw lsY6gTmY4h2Yk6UX+5Tqv/QRqm9DcWM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699705521; a=rsa-sha256; cv=none; b=g13mc2OjJ1yieytzWjc6qxkpTzwmVNh+X+Rx6LzjUHXtsB94g77aPb2iqmPe4wpUNzBROC iz1AYmX/kDsKD5zcDeBLzG3gnK8bTbAwh+Ubw54TvuvKJpqwZjBS9yI970qdAG/sx+QNmE xubsxVfBY6HsaSqPgPglte8q0j7lIo8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BFE9360A47; Sat, 11 Nov 2023 12:25:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08D87C433C7; Sat, 11 Nov 2023 12:25:17 +0000 (UTC) Date: Sat, 11 Nov 2023 12:25:12 +0000 From: Catalin Marinas To: Omkar Wagle Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kmemleak: Remove security and coding style warning Message-ID: References: <20231110191102.2029-1-ov.wagle@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110191102.2029-1-ov.wagle@gmail.com> X-Rspamd-Queue-Id: C743D1C0005 X-Rspam-User: X-Stat-Signature: gyhudto9mquitt3dahfge3dx4totjnyh X-Rspamd-Server: rspam01 X-HE-Tag: 1699705520-849431 X-HE-Meta: U2FsdGVkX19rR7KEnKhzzUu88PgqleG19fBqllB3Q4a4UNxMABFsR0kaQSPJ2dm8A7OwVnyO0fsUng27Aqn/JAF8bRRhdDjvpFBZdltGeHm/TKSPzo6Vnk4Q3v+4hxyb8GbEjvgbL6Vd/9dVWjr3rGM1E2ysWtxfAXE/cLwd29Ssj8BetGCTcSgQDRBzqfvQD6zojYSjiG9QTpn+Pavib71ckwtStVJX47u6O5HNfQJ9o268DHfMy/Y3WbO/hG7jzzkMM/EYdDoejwi7aUFErwFjEMtJ2QvBTQGLSSOQLg5aW46dAnSulG529ajgFCvMlWo4+Cq09vL69n6KgLSrOuSGtHPoBgdjjGZbTEb9AM2wwrA5uEpU1/e6eTc6tS1M+wIGcVvMTbt2NrhdZufQRFguJp0b1o8c7Szhu8Ir4U/Bzy4Rqd6gggH7FqGIMCH3TN+SRhTSn9ZyHMDqOWBnxx3hH7LO9BENPiRNHs5isLKPbLmsHoyrfqTk2vx1msK7jT07NzVPenTzS+9qc2l93ayI11ZrlZ0VIvsIxz1LJmUJ85kRjOsgCynrJFE0Il2yupk64SuHfLjkw+5x0vj4QBb8bWhHellX0D5bYAKzCF+hSGZRbfIrk9muqkEkjym/Hl4s9v6wHYCoXohnOks66X/5NukK/9uFa+uH1L38AIXwxmJZVJr7PLVGn/0+My/Zm1uDidg/yH6wd/G39+yG/jIOjoqYVn5/Ie5e9PcVbJljmIu7lpEKYhFjpWSHJLL2bgiGRw0nP1vWpsHuC0q4JW7FkBofkDs68TflT3cw3RAUwcuz/Bepyij6mSx61hFl5x4E0GaUw+5npYCPtDqI/K8BKWek7ytDNi2YScejnYxaGUfyb5Az7lKWnsnf+0lLuXnZhnmRSAFE+EMBqFCfbzx4gZMUbUINrxy1OkcE+BizSydMRNxhlC+TthCdfM1qawlbtpIPTvMScr9L0ZR B692OLEB 1FuCklXR74tzE7J4ytvZECqihB1sjcj6qtD1B0XtX95lWZoHGJK77TtPNc3Z3C6N8EEWM//ZRFwrJ7cVeMm9+/7PGIwP/B3+/YCcYfqIxWwNNnXPaRhyiKTeiGBe72USsEceNKzHTxBmTYXNhlWT2iwCczF8XoeGKOahJyK+KPdwlZ+bcgQUdWLSpTVWtmNlFtfY7NDvZ/D7CqQl3X4hT19TVKytvMogUxehUt7likzO1ZPULACRhip6QMctdYNk8OwzVkK1IBzZH+SeFYsSyFsjMvEZWI20oNG/00ZRQsuVBMkNyjFEc6fQO9cedI9BvTk3KM9RnkO/KQIr4gFNIffMuVFmHU9iiIoIjXXwufJLtxKSwJEhVYBFDOZWkE4HOhg2a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 10, 2023 at 11:11:02AM -0800, Omkar Wagle wrote: > @@ -368,6 +367,7 @@ static void print_unreferenced(struct seq_file *seq, > > for (i = 0; i < nr_entries; i++) { > void *ptr = (void *)entries[i]; > + > warn_or_seq_printf(seq, " [<%pK>] %pS\n", ptr, ptr); > } > } > @@ -406,10 +406,11 @@ static struct kmemleak_object *__lookup_object(unsigned long ptr, int alias, > unsigned long untagged_ptr = (unsigned long)kasan_reset_tag((void *)ptr); > > while (rb) { > - struct kmemleak_object *object; > + struct kmemleak_object *object = NULL; Seriously, what's this initialisation for? > unsigned long untagged_objp; > > object = rb_entry(rb, struct kmemleak_object, rb_node); The variable gets assigned here. > + > untagged_objp = (unsigned long)kasan_reset_tag((void *)object->pointer); I'm also not a fan of random whitespace updates throughout this file. It makes backporting fixes harder later on. -- Catalin