From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BFE1C4332F for ; Fri, 10 Nov 2023 21:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65DE8D00F9; Fri, 10 Nov 2023 16:50:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A16038D0005; Fri, 10 Nov 2023 16:50:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88FF98D00F9; Fri, 10 Nov 2023 16:50:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 730B08D0005 for ; Fri, 10 Nov 2023 16:50:35 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3EB63A0C26 for ; Fri, 10 Nov 2023 21:50:35 +0000 (UTC) X-FDA: 81443389230.08.CDBFA84 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2042.outbound.protection.outlook.com [40.107.102.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 83FD9160002 for ; Fri, 10 Nov 2023 21:50:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=kaTddcNc; dmarc=pass (policy=none) header.from=memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf08.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.102.42 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699653032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UHulGFI3/RrwcNDLEvmaYyTiRgnj0xRZUknurGQI4jU=; b=Q4yTATrzcDmqEqFRBCjSNXq5Mu4SAHBT0DHzPus1xg3gzH89T9xz/x7Zc5PlfCVEa+Da3A yJ2vJd0lwcPHQY9Jh5Qnv3T20uOl4OlYmhCNCtTuByiABfkekrvgCfjtnRdI+EmK8BflyA IMM8Dsoa+dMZmdY/BCO8QIj/s9HLaVM= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=kaTddcNc; dmarc=pass (policy=none) header.from=memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf08.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.102.42 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1699653032; a=rsa-sha256; cv=pass; b=ntwXVTldO7phlvbpEpDZVXnjWDXgdA84rjyF11h6z9U+wR15OdkOnMDYAn7U9cjXiVUddl gGMGfGlEJZaNYAzHFvnA9yGue4BW58C63xV56AAfZ0nc30aZO3zdWtx4DWJNauDdOpxcXa Tb/MMlTy5wwbhsYT1uJSi8H/W3y0K/o= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BcIV5eOto7CP/XD4hNOLXNUmOCUA/8dBVdQK5QpYGEciek/L2j+2AKD/ouLNOjmwKABMGAIlpP8Xwfu1IRxNpIrU23THZd5BBt/UNmN9fhlKGqTRSLClZRtePvxt8geqbZQnVv/MPxjtbeN1irk2V8vaNXen6m2ViJdxICyl2o+zCJoII0czCJHXNQwHrIshxfb5ijZ4yVibEQWbwHu4ggXVbvRfSFemWK9+GLeILnS7FImk2TFjkz0b1VudTzaef3Yl6YnLsxmHxL+zerc96x0XPbf/IxRXntTVZ93PlsU6UmrWJ2pH++Tbp+vV6xKy56Pji4Z01cv6EKpDFtrbYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UHulGFI3/RrwcNDLEvmaYyTiRgnj0xRZUknurGQI4jU=; b=CrRcZ2xII5EMV7mMs6jQygXNz5suN0n91cwXOEhnSRq6BQo6OB6ffhK4cfCJ5/TVWnXHO89Q+QZiG6QxwDV3aJbiaevTF/r3mPoF8a0Hi/OJIoI8Vgra88wyAnglxZfDz2KE0btfEJaWzAfw+M26sxORbBxDaPKk5Y8tMYNbcobyQYrXgsmvzjtUudzcjUSaDkojd+WyPlJn8n1HCexNv524oN+gmXhIBClnJVDl15Rt/+Mp6fxM46OJ2f48uDCC+o0AMiRJ/V7Rx9NIYTcRPfQb6/JX3wBn0BYTJIGTXVkuGCLbZL3808bimXzGujSwRXm5h2/v9GS2i+xQF1j50g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UHulGFI3/RrwcNDLEvmaYyTiRgnj0xRZUknurGQI4jU=; b=kaTddcNcMkjATFrM04lrohokBM0//hyz0xB1iVY1//bPu4y5Tfnw7K7PfuEQk3o4QkN3WtFF9/jzSh2pPfrMeztxy2r1LnnCqs6yB3Fbfor2nCg2iFAhdxOYg4TVZ2Eihik429iS/dRk296IM0zNiwwGyV7ZZKH9TcjZ6qjboRY= Received: from SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) by SJ0PR17MB4680.namprd17.prod.outlook.com (2603:10b6:a03:375::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.10; Fri, 10 Nov 2023 21:50:27 +0000 Received: from SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::381c:7f11:1028:15f4]) by SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::381c:7f11:1028:15f4%5]) with mapi id 15.20.7002.010; Fri, 10 Nov 2023 21:50:27 +0000 Date: Fri, 10 Nov 2023 16:50:18 -0500 From: Gregory Price To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand Subject: Re: [PATCH v2 2/7] fs/proc/page: use a folio in stable_page_flags() Message-ID: References: <20231110033324.2455523-1-wangkefeng.wang@huawei.com> <20231110033324.2455523-3-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110033324.2455523-3-wangkefeng.wang@huawei.com> X-ClientProxiedBy: SJ0PR05CA0070.namprd05.prod.outlook.com (2603:10b6:a03:332::15) To SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR17MB5512:EE_|SJ0PR17MB4680:EE_ X-MS-Office365-Filtering-Correlation-Id: e89d7538-a76c-4e4c-54e5-08dbe2370c99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bVkdLC1EaTnDhObJ4xJpeu6VTJp9kFoasKwavufE5Jh1dH+TNMWc5D6c3asWxgwqA8yRVtB2rSNtoVKTynlXcANljLB+QujIbTvGV+dnMYDg7JJMEsNwSPjpoj1Y9R+3c1VLWDbXRKP22TiFW1ynmedyaRaHmFfw4nxxOyFrpxtdmC6dgUoyqUmNBsnJEMDMPcp6wEiRcK7ucjyQjz1RlXMRQEqEIkNlS48WiyJr6YHXY4dURdc0finxTiU1tZuFWqdl/zIvc9eJ4DSgMzl6rdLWbBs07jpuWxYN8eF/dR//rWzictF5ASAdRP7vz6aKVCwxl4MWYC3hZSo6LXllC8cP2dxDkU+muDry8xDFrytRxUBCLWUJs0Q6a6uzPmWqiQqaYzZAhhib9OWgsYowXNF0LVCuLEskJ661BZfO2pqGK2MMBmHJQtqC5+/fSxQI8owO+J1wtEK0xNpryT7Mfqcarc13YzxGu24DnCbj288xrBYhDx/oTZRpX4o+sDg2rhhqphouVgroVz1Hxyxcw9/t6l36J1+rVPjB8RgJ4TsgdnFvBVeh1HflmiJG7WEp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR17MB5512.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39840400004)(396003)(346002)(366004)(376002)(136003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(86362001)(83380400001)(8936002)(8676002)(4326008)(6916009)(66476007)(54906003)(66556008)(316002)(4744005)(2906002)(44832011)(66946007)(478600001)(5660300002)(6512007)(6486002)(6666004)(6506007)(26005)(2616005)(38100700002)(41300700001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Hlor/9gS/2GDSfhXKDM0z/i6vLfZF0SUyaObSpUwSt1mKliMMxeDy0txh7hs?= =?us-ascii?Q?h2Lto4zDjlMtt2fs5xMxdItQfKz5N/yAXGuQszPvuCDO/YuJSp7SiASVPtvM?= =?us-ascii?Q?drcKFpPVS4A03Fck29BpG4L/acJ9SwJD4QdU35a8XgLUavsniYPS99Iv9CkN?= =?us-ascii?Q?L6bjb6hJoC0InNWSjpETGjLDH9KRUkutC0imAhGFurpBYRE2vQWbnpdfIvhi?= =?us-ascii?Q?6IoHRECo+WLLNS8AXI/pTzzxC749nWLVTJ2iNCzZ18Da/QnnoWTxVNp0/7g2?= =?us-ascii?Q?F3UHg8683KhWpOqVGmpOWAi9DtuViK3dESxCK3Gzi5T4I3OO/3cWRbXYsYI3?= =?us-ascii?Q?66ODAVsoumeMPuxGtgNYIQ1VtSANVCv9i9vU05VqGMkeUZBxt252Y4AsvAaz?= =?us-ascii?Q?VEHxBwk2yiM9dJbUkM6Y6lsU4jE88RU29JL4EB3HVKSRT1OvIjHbZ3V6rFWd?= =?us-ascii?Q?S5u1f3fltGc/ws059Rvp/0MgJ71WJQKVjuicU1bjS0GqANOYf3aiu4GX4YUB?= =?us-ascii?Q?pa1NQWI4ZneqcvWt5xhEM6HtWlPSgZKTBO4qdt9hSv1mvsgxC40qfah/HUe2?= =?us-ascii?Q?/0UO+UvX8R/LaIDOkXFZrwJGeVp06UFl69rTXYt3eBu70IHBNqpOFr43OjCx?= =?us-ascii?Q?u25TvhYvf5oVvn3bd76oFkVU0fuStHTj70rCdpZhxMMHQtUsMPr7KetyimDv?= =?us-ascii?Q?c+zXFU6MxgxqXsd0/p6kztUWL8RmMgbepsLZEvpPUfK1TiPyfoXOhFXiKz1n?= =?us-ascii?Q?3jcXLvn+4M2gC1LHtUmfh27YRsWaAJlIzcadGVud12OGn+H/dATBNGmTZyHG?= =?us-ascii?Q?/YegIgm3aMVV83+NCURraubjCPmF43MYdcAoujU5l7Hf6HRs01Ol9ml7mWYV?= =?us-ascii?Q?JYSJ8mB+B/J3eL1BdvPXqGukn7W6vMet53GxHXAjhMJxMu+KcHtotghtWXVO?= =?us-ascii?Q?TJQmGkCCjA3mV+KwUzuuTVJzF3hK3aQNoi2bt+Ctu5F7fVLju9naDDfMKvhe?= =?us-ascii?Q?ZDP+fzQ/58VhgKJ3nGOZi4zdHYAlseGEDyJQI/fWXgx4bLt9yyceldIwjjJu?= =?us-ascii?Q?0exQ9WH/H6qagYBpIh4w1nz3Ra6wVrAVTGVV7jjtRB+1y/AQ+/Bq0z2hvzxO?= =?us-ascii?Q?K7/HD03hEhZjf2y+tQ0x1PfVhO2i/LsHOULEqQtm6TMyfVQHKvEz8juDoI45?= =?us-ascii?Q?HWXyjKLmmNxicfli7bcLzUoWQ1wyKoshuJNOgZAvDKJMeZu52RVURwF10hWO?= =?us-ascii?Q?/RLnYD+uJ+zQlS+YjwJwFctRl78DzuWB4+wb6+E0evK/PyjLoloqMs8jc5DP?= =?us-ascii?Q?nWrKdQ+txzzizyGBl9WwjQ1JONstIYps0hWXnW26acOePMfmpi/hZiFCwfex?= =?us-ascii?Q?uzbdV2WudX1xDbI3haEYQ8Y+YAxjqFS0ajmkYD0nZ7XnrdD3+yr5+ERrBxIL?= =?us-ascii?Q?g/ZcwjCJ1toJo8yYIAteYQlQTgfJ5/0zmm/73kvfmsR1QuEacUGyMqDNN4MW?= =?us-ascii?Q?sktK/NNZZTlZkls2TjEKeY0JUgxUQRHiiSUOA6jO7jbMeeJGMbzEY90/dAwV?= =?us-ascii?Q?dX46zO1ML7lzz5DBaE/FSOqykWqdm3LsmJplUmaM2viJKszmlfnA5QKJoCUn?= =?us-ascii?Q?+w=3D=3D?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: e89d7538-a76c-4e4c-54e5-08dbe2370c99 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2023 21:50:26.7089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fo1xkT23uNAHN4rcYvvvkiTbRhtuBXICjJjTrxd78ALLLu5ae+9HzlSyL4Q1AtRL/JD1+tTbVBJMEveSlD1+3xyj47fbyp2QaLOn2ySb1vE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB4680 X-Rspam-User: X-Stat-Signature: zgp3kbj8b9fjp5r9d8snnown71uhncus X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 83FD9160002 X-HE-Tag: 1699653032-265157 X-HE-Meta: U2FsdGVkX1/F/l8RVgpc3pYRWV2jKDo17+XTNYnoOKaZfNDa/k8qzwkMnM+PvB/FT/9tuH5BVf30NvmKiLZ2iqXKDCo4noUwNsi3bWTKoDN9byUPem8KiIXgex1JXn6LkXaAFzijci3eqGJc0SOdHLNEbXHGXOnggorTtQq/bgvfh8FXU1zwtAfAyGWRtrO8jEt9l8xoy9pCXJz3Ls3F5HBZh/cAH86FB6AJPnC9vtGhqOuK6ttPBd5Cjwuz8qDhxLUuVIrVhAnehypM3jzVEb5PwfEJqA39EuKvhxa88lAqYMM+pmTFfY8VWO1+qQDiQMVmMQh+jB0f1AN78hUlA207ZQXql4mUfCTPwmuWwiOjl5TSPzV6OMPixHm4RKTcxstYL6IbOvkKcDYtiOfcuLqkpTobUl4LnNJnb7RqCx3BXtOXEEXb5MpjwJxnF8tohgbozyBuqzd/j2JjhMqhQ/U+cTd2c/eq9BKBjklXaIHzGKyeYJgMWdwSjkwXHgGmq67qCbDcE2tcjlNyTA4xmRO11Cr/EJPfGBIB2/kwo26lIR0TkNkwbVUpeE0fPemhi20gVFfH/yPCmdZJQ4KGRrsm+PwfE9u4vrWEkpu2S24hMeFfXmM0hcC0NTCRs4I9jO7yQrbxkZJdWiwHAp4NX5CcqDycxPiAxtLF5yeuWh/zr9HnFJmCt8fzwD4JozBLhA6ug3cCSiNBBhfo8unLXEJHlVhfWYAOO9karBnVcreOeLlYpH+Uk7aDBRePwOxBdelxNGfNWUfTDPrP2EiTCWPLyZH4JQHDH+bIBtpwzQ1uvlPqY2puIcEAAojQp/vKeRYqUqde+GsLAFaBf0xxYRa43uu3J6kFcUajYobHQKQMXLWuDENCyPK1OWgWuD3/UFoa+1D6LY6toc8Tl7+w6MqwTzMhNDzD0wHzOOJkEGs86i9LHnFVgvfJgLHzx/vB7YuQnAs3mweRfeUtnjV kZS36rAH BN7sEUo+DlZk58f9cYGsdQqhNdpJAEH0emBsqugCuz571AjrjNe6VnlbBHSlK9wR+0YN9w0smWCzj5SNTLjxg3PXlVkWAjictxOo/uE9MhMo2Xno+iQdlgaRRqjDhG1ZpTd2fw5ElzWCvXdFcHBNcJ0AbYcP7/Bx1RhFY1ht1U3qTmrFo7eaUW0YEGPW/zJs2279rsEfnZGENLbqwx8YDwn8AAbLxE8B6tD89eaARplOxAla2/bDIABQo+nlCe1H7aaIa/QQEso9w326mmB/rWFpjr+e45MbxfVUP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 10, 2023 at 11:33:19AM +0800, Kefeng Wang wrote: > Replace nine compound_head() calls with one page_folio(). > Sorry to echo Matthew, but this commit message is extremely insufficient and just outright wrong. Single pass through, here's the real change list: 1) changes PageFLAG() calls to folio_test_FLAG calls 2) changes compound_head() flag checks to folio_test_FLAG checks 3) change page count to folio ref count -- without even looking... is this even correct? Need more explanation here. Is page count === folio ref count? So there are really 3 changes in this patch set that should be broken out separately, even if they all depend on folio flags, because they need separate explanation and validation for correctness. > Signed-off-by: Kefeng Wang > --- > fs/proc/page.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >